[monitoring-plugins] utils.pm: use FindBin instead of awk to find the ...
Jan Wagner
git at monitoring-plugins.org
Thu Feb 27 21:00:08 CET 2014
Module: monitoring-plugins
Branch: master
Commit: 9408c975fe199c4ef4d662dee05f4f684167b731
Author: Evgeni Golov <evgeni at golov.de>
Committer: Jan Wagner <waja at cyconet.org>
Date: Wed Feb 26 08:07:10 2014 +0100
URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=9408c97
utils.pm: use FindBin instead of awk to find the path to
'use lib utils.pm' is not valid Perl syntax:
Bareword "utils" not allowed while "strict subs" in use at plugins-scripts/check_ircd.pl line 52.
Bareword "pm" not allowed while "strict subs" in use at plugins-scripts/check_ircd.pl line 52.
This makes it impossible to use the plugins directly from the git tree,
e.g. while hacking on them.
Using FindBin::Bin as the library path allows that, while preserving
the original behaviour of adding the libexec path when the plugin is
properly installed.
---
plugins-scripts/check_breeze.pl | 3 ++-
plugins-scripts/check_disk_smb.pl | 3 ++-
plugins-scripts/check_flexlm.pl | 3 ++-
plugins-scripts/check_ifoperstatus.pl | 3 ++-
plugins-scripts/check_ifstatus.pl | 3 ++-
plugins-scripts/check_ircd.pl | 3 ++-
plugins-scripts/check_mailq.pl | 3 ++-
plugins-scripts/check_netdns.pl | 3 ++-
plugins-scripts/check_rpc.pl | 3 ++-
plugins-scripts/check_wave.pl | 3 ++-
10 files changed, 20 insertions(+), 10 deletions(-)
diff --git a/plugins-scripts/check_breeze.pl b/plugins-scripts/check_breeze.pl
index a4e8542..5ff4fcf 100755
--- a/plugins-scripts/check_breeze.pl
+++ b/plugins-scripts/check_breeze.pl
@@ -4,7 +4,8 @@
use strict;
use Getopt::Long;
use vars qw($opt_V $opt_h $opt_w $opt_c $opt_H $opt_C $PROGNAME);
-use lib utils.pm ;
+use FindBin;
+use lib "$FindBin::Bin";
use utils qw(%ERRORS &print_revision &support &usage);
$PROGNAME = "check_breeze";
diff --git a/plugins-scripts/check_disk_smb.pl b/plugins-scripts/check_disk_smb.pl
index 8b6cd2e..b0a6114 100755
--- a/plugins-scripts/check_disk_smb.pl
+++ b/plugins-scripts/check_disk_smb.pl
@@ -24,7 +24,8 @@ use strict;
use Getopt::Long;
use vars qw($opt_P $opt_V $opt_h $opt_H $opt_s $opt_W $opt_u $opt_p $opt_w $opt_c $opt_a $verbose);
use vars qw($PROGNAME);
-use lib utils.pm ;
+use FindBin;
+use lib "$FindBin::Bin";
use utils qw($TIMEOUT %ERRORS &print_revision &support &usage);
sub print_help ();
diff --git a/plugins-scripts/check_flexlm.pl b/plugins-scripts/check_flexlm.pl
index 574c1cc..a0b007f 100755
--- a/plugins-scripts/check_flexlm.pl
+++ b/plugins-scripts/check_flexlm.pl
@@ -35,7 +35,8 @@
use strict;
use Getopt::Long;
use vars qw($opt_V $opt_h $opt_F $opt_t $verbose $PROGNAME);
-use lib utils.pm;
+use FindBin;
+use lib "$FindBin::Bin";
use utils qw(%ERRORS &print_revision &support &usage);
$PROGNAME="check_flexlm";
diff --git a/plugins-scripts/check_ifoperstatus.pl b/plugins-scripts/check_ifoperstatus.pl
index a431cf3..26fae76 100755
--- a/plugins-scripts/check_ifoperstatus.pl
+++ b/plugins-scripts/check_ifoperstatus.pl
@@ -35,7 +35,8 @@
use POSIX;
use strict;
-use lib utils.pm ;
+use FindBin;
+use lib "$FindBin::Bin";
use utils qw($TIMEOUT %ERRORS &print_revision &support);
use Net::SNMP;
diff --git a/plugins-scripts/check_ifstatus.pl b/plugins-scripts/check_ifstatus.pl
index b8faada..588e5df 100755
--- a/plugins-scripts/check_ifstatus.pl
+++ b/plugins-scripts/check_ifstatus.pl
@@ -32,7 +32,8 @@
use POSIX;
use strict;
-use lib utils.pm ;
+use FindBin;
+use lib "$FindBin::Bin";
use utils qw($TIMEOUT %ERRORS &print_revision &support);
use Net::SNMP;
diff --git a/plugins-scripts/check_ircd.pl b/plugins-scripts/check_ircd.pl
index 7612a0e..e45e9fc 100755
--- a/plugins-scripts/check_ircd.pl
+++ b/plugins-scripts/check_ircd.pl
@@ -49,7 +49,8 @@ use strict;
use Getopt::Long;
use vars qw($opt_V $opt_h $opt_t $opt_p $opt_H $opt_w $opt_c $verbose);
use vars qw($PROGNAME);
-use lib utils.pm;
+use FindBin;
+use lib "$FindBin::Bin";
use utils qw($TIMEOUT %ERRORS &print_revision &support &usage);
# ----------------------------------------------------[ Function Prototypes ]--
diff --git a/plugins-scripts/check_mailq.pl b/plugins-scripts/check_mailq.pl
index 8293e9c..a7de87b 100755
--- a/plugins-scripts/check_mailq.pl
+++ b/plugins-scripts/check_mailq.pl
@@ -31,7 +31,8 @@ use Getopt::Long;
use vars qw($opt_V $opt_h $opt_v $verbose $PROGNAME $opt_w $opt_c $opt_t
$opt_M $mailq $status $state $msg $msg_q $msg_p $opt_W $opt_C $mailq @lines
%srcdomains %dstdomains);
-use lib utils.pm;
+use FindBin;
+use lib "$FindBin::Bin";
use utils qw(%ERRORS &print_revision &support &usage );
diff --git a/plugins-scripts/check_netdns.pl b/plugins-scripts/check_netdns.pl
index ecdbdb1..5b24642 100755
--- a/plugins-scripts/check_netdns.pl
+++ b/plugins-scripts/check_netdns.pl
@@ -27,7 +27,8 @@
use Getopt::Long;
use Net::DNS;
-use lib utils.pm;
+use FindBin;
+use lib "$FindBin::Bin";
use utils ;
my $PROGNAME = "check_netdns";
diff --git a/plugins-scripts/check_rpc.pl b/plugins-scripts/check_rpc.pl
index 474067e..3a6f717 100755
--- a/plugins-scripts/check_rpc.pl
+++ b/plugins-scripts/check_rpc.pl
@@ -20,7 +20,8 @@
#
use strict;
-use lib utils.pm;
+use FindBin;
+use lib "$FindBin::Bin";
use utils qw($TIMEOUT %ERRORS &print_revision &support);
use vars qw($PROGNAME);
my ($verbose, at proto,%prognum,$host,$response,$prognum,$port,$cmd,$progver,$state);
diff --git a/plugins-scripts/check_wave.pl b/plugins-scripts/check_wave.pl
index 2671112..b8ec3f0 100755
--- a/plugins-scripts/check_wave.pl
+++ b/plugins-scripts/check_wave.pl
@@ -3,7 +3,8 @@
use strict;
-use lib utils.pm;
+use FindBin;
+use lib "$FindBin::Bin";
use utils qw($TIMEOUT %ERRORS &print_revision &support);
use vars qw($PROGNAME);
use Getopt::Long;
More information about the Commits
mailing list