[monitoring-plugins] make snmp tests more reliable
Sven Nierlein
git at monitoring-plugins.org
Mon Mar 13 11:50:12 CET 2017
Module: monitoring-plugins
Branch: master
Commit: b3dee5c4bf9909c44a43dea0d27475cdbf79f243
Author: Sven Nierlein <sven at nierlein.de>
Date: Fri Mar 10 19:37:37 2017 +0100
URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=b3dee5c
make snmp tests more reliable
snmp tests fail if the snmp daemon runs systemd, then the process with 1 has arguments. Convert
the test into a regex which works for sysv and systemd.
Signed-off-by: Sven Nierlein <sven at nierlein.de>
---
plugins/t/check_snmp.t | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/plugins/t/check_snmp.t b/plugins/t/check_snmp.t
index eff46ea..9a6cd2b 100644
--- a/plugins/t/check_snmp.t
+++ b/plugins/t/check_snmp.t
@@ -154,9 +154,9 @@ SKIP: {
cmp_ok( $res->return_code, '==', 0, "Timetick used as a string");
like($res->output, '/^SNMP OK - Timeticks:\s\(\d+\)\s+(?:\d+ days?,\s+)?\d+:\d+:\d+\.\d+\s.*$/', "Timetick used as a string, result printed rather than parsed");
- $res = NPTest->testCmd( "./check_snmp -H $host_snmp -C $snmp_community -o HOST-RESOURCES-MIB::hrSWRunParameters.1");
- cmp_ok( $res->return_code, '==', 0, "Timetick used as a string");
- is( $res->output, 'SNMP OK - "" | ', "snmp response without datatype" );
+ $res = NPTest->testCmd( "./check_snmp -H $host_snmp -C $snmp_community -o HOST-RESOURCES-MIB::hrSWRunName.1");
+ cmp_ok( $res->return_code, '==', 0, "snmp response without datatype");
+ like( $res->output, '/^SNMP OK - "(systemd|init)" \| $/', "snmp response without datatype" );
}
SKIP: {
More information about the Commits
mailing list