[monitoring-plugins] check_icmp: move opts string into a variable

Jacob Hansen git at monitoring-plugins.org
Tue Feb 19 15:50:17 CET 2019


 Module: monitoring-plugins
 Branch: master
 Commit: 7a660b3f018e0903e098cbd2e766a9af18f6723f
 Author: Jacob Hansen <jhansen at op5.com>
   Date: Mon Dec 10 13:43:09 2018 +0000
    URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=7a660b3

check_icmp: move opts string into a variable

This commit moves the opts string into a variable as it is now used
twice.

Signed-off-by: Jacob Hansen <jhansen at op5.com>

---

 plugins-root/check_icmp.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/plugins-root/check_icmp.c b/plugins-root/check_icmp.c
index 1a2a177..6a883a8 100644
--- a/plugins-root/check_icmp.c
+++ b/plugins-root/check_icmp.c
@@ -410,6 +410,7 @@ main(int argc, char **argv)
 #ifdef SO_TIMESTAMP
 	int on = 1;
 #endif
+	char * opts_str = "vhVw:c:n:p:t:H:s:i:b:I:l:m:64";
 
 	setlocale (LC_ALL, "");
 	bindtextdomain (PACKAGE, LOCALEDIR);
@@ -462,7 +463,7 @@ main(int argc, char **argv)
 
 	/* Parse protocol arguments first */
 	for(i = 1; i < argc; i++) {
-		while((arg = getopt(argc, argv, "vhVw:c:n:p:t:H:s:i:b:I:l:m:64")) != EOF) {
+		while((arg = getopt(argc, argv, opts_str)) != EOF) {
 			unsigned short size;
 			switch(arg) {
 			case '4':
@@ -484,7 +485,7 @@ main(int argc, char **argv)
 
 	/* parse the arguments */
 	for(i = 1; i < argc; i++) {
-		while((arg = getopt(argc, argv, "vhVw:c:n:p:t:H:s:i:b:I:l:m:64")) != EOF) {
+		while((arg = getopt(argc, argv, opts_str)) != EOF) {
 			unsigned short size;
 			switch(arg) {
 			case 'v':



More information about the Commits mailing list