[monitoring-plugins] fix fping test

Sven Nierlein git at monitoring-plugins.org
Fri Apr 30 10:00:13 CEST 2021


 Module: monitoring-plugins
 Branch: feature_github_actions
 Commit: 444a3579b2168eda949943a060bddff9ec95fd99
 Author: Sven Nierlein <sven at nierlein.de>
   Date: Mon Apr 12 17:21:47 2021 +0200
    URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=444a357

fix fping test

in case of dns errors, fping returns an unknown and thats ok.

---

 plugins/t/check_fping.t | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/plugins/t/check_fping.t b/plugins/t/check_fping.t
index 342b0a7..03a6110 100644
--- a/plugins/t/check_fping.t
+++ b/plugins/t/check_fping.t
@@ -12,9 +12,6 @@ use vars qw($tests);
 
 BEGIN {$tests = 4; plan tests => $tests}
 
-my $successOutput = '/^FPING OK - /';
-my $failureOutput = '/^FPING CRITICAL - /';
-
 my $host_responsive    = getTestParameter("NP_HOST_RESPONSIVE", "The hostname of system responsive to network requests", "localhost");
 my $host_nonresponsive = getTestParameter("NP_HOST_NONRESPONSIVE", "The hostname of system not responsive to network requests", "10.0.0.1");
 my $hostname_invalid   = getTestParameter("NP_HOSTNAME_INVALID", "An invalid (not known to DNS) hostname", "nosuchhost");
@@ -29,9 +26,9 @@ if( ! -x "./check_fping") {
 elsif ( $> != 0 && (!$fping || ! -u $fping)) {
   $t += skipMsg( "./check_fping", $tests );
 } else {
-  $t += checkCmd( "./check_fping $host_responsive",    0,       $successOutput );
-  $t += checkCmd( "./check_fping $host_nonresponsive", [ 1, 2 ] );
-  $t += checkCmd( "./check_fping $hostname_invalid",   [ 1, 2 ] );
+  $t += checkCmd( "./check_fping $host_responsive",    0,  '/^FPING OK - /' );
+  $t += checkCmd( "./check_fping $host_nonresponsive", 2,  '/^FPING CRITICAL - /' );
+  $t += checkCmd( "./check_fping $hostname_invalid",   3,  '/^FPING UNKNOWN - /' );
 }
 
 exit(0) if defined($Test::Harness::VERSION);



More information about the Commits mailing list