[Nagiosplug-devel] [nagios-plugins] check_ntp_peers peer count check is inversed (#1204)

[Jochen Bern]

On 17.10.2013 22:05, Brady Catherman wrote:
> That seems backwards from what I would expect. Ideally the logic
> should be reversed. I don't care if I have "more than" 5 peers.
> I care if I have less.

Then you should ask for that in the limit you pass with "-n".
check_ntp_peer implements the current syntax spec, which says that a
bare number (x) shall be interpreted as "alert if value is *outside* the
range from 0 to x".

> $ /usr/lib64/nagios/plugins/check_ntp_peer -H 127.0.0.1 -n 5
> NTP OK: Offset -0.000428 secs, truechimers=3|offset=-0.000428s;60.000000;120.000000; truechimers=3;0;5;0
> $ /usr/lib64/nagios/plugins/check_ntp_peer -H 127.0.0.1 -n @5
> NTP CRITICAL: Offset -0.000428 secs, truechimers=3|offset=-0.000428s;60.000000;120.000000; truechimers=3;0;5;0
> $ /usr/lib64/nagios/plugins/check_ntp_peer -H 127.0.0.1 -n 5:99
> NTP CRITICAL: Offset -0.000428 secs, truechimers=3|offset=-0.000428s;60.000000;120.000000; truechimers=3;0;99;0

https://www.nagios-plugins.org/doc/guidelines.html#THRESHOLDFORMAT

Regards,
								J. Bern
-- 
*NEU* - NEC IT-Infrastruktur-Produkte im <http://www.linworks-shop.de/>:
Server--Storage--Virtualisierung--Management SW--Passion for Performance
Jochen Bern, Systemingenieur --- LINworks GmbH <http://www.LINworks.de/>
Postfach 100121, 64201 Darmstadt | Robert-Koch-Str. 9, 64331 Weiterstadt
PGP (1024D/4096g) FP = D18B 41B1 16C0 11BA 7F8C DCF7 E1D5 FAF4 444E 1C27
Tel. +49 6151 9067-231, Zentr. -0, Fax -299 - Amtsg. Darmstadt HRB 85202
Unternehmenssitz Weiterstadt, Geschäftsführer Metin Dogan, Oliver Michel