Update check_icmp to use op5 version (#1238)
Holger Weiß
notifications at github.com
Wed Feb 19 15:39:04 CET 2014
> How about you have a look at ours and see if there's something you
> definitiely do not want and vice versa?
Sounds like a plan. Basically, I think we want everything that looks like
it makes the world a better place :-)
We obviously don't want to loose previous fixes of ours; `cd plugins-root;
perl t/check_icmp.t` shouldn't break; and for extra happiness, new stuff
should come with new test cases where it makes sense.
I went through your commit messages (and some of the commit diffs) and they
all look good to me (except for the obvious contact information changes you
mentioned). I didn't look through the initial diff yet ...
--
Reply to this email on GitHub:
https://github.com/monitoring-plugins/monitoring-plugins/issues/1238#issuecomment-35504658
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.monitoring-plugins.org/archive/devel/attachments/20140219/e9a32551/attachment.html>
More information about the Devel
mailing list