use FindBin instead of awk to find the path to utils.pm (#1241)

Evgeni Golov notifications at github.com
Wed Feb 26 08:22:19 CET 2014


'use lib utils.pm' is not valid Perl syntax:

    Bareword "utils" not allowed while "strict subs" in use at plugins-scripts/check_ircd.pl line 52.
    Bareword "pm" not allowed while "strict subs" in use at plugins-scripts/check_ircd.pl line 52.

This makes it impossible to use the plugins directly from the git tree, e.g.
while hacking on them.

Using `FindBin::Bin` as the library path allows that, while preserving the
original behaviour of adding the `libexec` path when the plugin is properly
installed.
You can merge this Pull Request by running:

  git pull https://github.com/evgeni/monitoring-plugins findbin

Or you can view, comment on it, or merge it online at:

  https://github.com/monitoring-plugins/monitoring-plugins/pull/1241

-- Commit Summary --

  * use FindBin instead of awk to find the path to utils.pm

-- File Changes --

    M plugins-scripts/check_breeze.pl (3)
    M plugins-scripts/check_disk_smb.pl (3)
    M plugins-scripts/check_flexlm.pl (3)
    M plugins-scripts/check_ifoperstatus.pl (3)
    M plugins-scripts/check_ifstatus.pl (3)
    M plugins-scripts/check_ircd.pl (3)
    M plugins-scripts/check_mailq.pl (3)
    M plugins-scripts/check_netdns.pl (3)
    M plugins-scripts/check_rpc.pl (3)
    M plugins-scripts/check_wave.pl (3)

-- Patch Links --

https://github.com/monitoring-plugins/monitoring-plugins/pull/1241.patch
https://github.com/monitoring-plugins/monitoring-plugins/pull/1241.diff

-- 
Reply to this email on GitHub:
https://github.com/monitoring-plugins/monitoring-plugins/pull/1241
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.monitoring-plugins.org/archive/devel/attachments/20140225/b2e9d3a3/attachment.html>


More information about the Devel mailing list