summaryrefslogtreecommitdiffstats
path: root/lib/Monitoring
AgeCommit message (Collapse)AuthorFilesLines
2018-03-05Remove "experimental" tag on "Message Methods"Tom Ryder1-4/+1
From a maintainer, Sven Nierlein: > I'd say we can remove the "experimental" tag there. It had been there > for years now and i see no reason why we would change them. Partly resolves #14.
2017-12-16Remove "scalar" call entirelyTom Ryder1-1/+1
Context with the lhs of the == operator forces this into scalar context anyway, making this call redundant.
2017-12-16Pass params validation by ref not copyTom Ryder1-1/+1
Since Params::Validate::validate() doesn't seem to actually mess with this specification, may as well pass a reference rather than bother copying the whole thing.
2017-12-16Remove unneeded params around "scalar" callTom Ryder1-1/+1
Operator precedence allows leaving these out.
2017-12-16Refactor positional arg parsing for Getopt::arg()Tom Ryder1-8/+2
Define the expected order of parameters by key in an array, and then apply hash slices to validate and assign the arguments including their required flags in one swoop, again hinging on the parameter definitions established in c1046ba.
2017-12-16Change arg() param type detect to key exists checkTom Ryder1-1/+1
Use the parameter label definitions from commit c1046ba to simplify the block of code that checks whether the first argument passed to arg() is one of the known param keys, rather than using a regular expression with alternating expression. This is more compact, may be marginally faster, and will make adding new parameters to this method more straightforward in future, avoiding the situation corrected in commit 4aa2aee.
2017-12-16Move Getopt param/reqd defs into dedicated hashTom Ryder1-7/+10
This shift and its comment makes what the values of the hashref passed to the validate() methods mean clearer, and also allows the use of the keys as a means of determining whether arg() was passed its definition in the array or hash format in a separate commit.
2017-11-15Add missing `label` key to named Getopts argsTom Ryder1-1/+1
If the `label` key is given as a named argument for argument specification, if it turns out to be the first element returned in the argument list subject to hash randomization, then this test for named arguments fails due to the omission of the label from this alternating group in the pattern. When this happens, the code for an unnamed list of items was run instead, leading to a very confusing area happening randomly: 8 parameters were passed to Monitoring::Plugin::Getopt::arg but 2 - 5 were expected at PERL/lib/perl5/Monitoring/Plugin/Getopt.pm line 397. Monitoring::Plugin::Getopt::arg(undef, "label", "HOSTNAME", "required", 1, "help", "Hostname of device to check", "spec", ...) called at PERL/lib/perl5/Monitoring/Plugin.pm line 161 Monitoring::Plugin::add_arg(Monitoring::Plugin=HASH(0x1f90fd8), "label", "HOSTNAME", "required", 1, "help", "Hostname of device to check", "spec", ...) called at libexec/check_example line 144 If you specified all five keys for your argument, then this happens (roughly) one-fifth of the time.
2016-11-19Allow negation of command line arguments using '--no'-prefixManfred Stock1-4/+8
Getopt::Long supports negatable boolean options by appending an '!' to the option specification, so this allows to use this functionality with Monitoring::Plugin::Getopt as well.
2016-06-22use case insensitive regexSven Nierlein1-1/+1
2016-06-22Merge pull request #12 from pdugas/masterSven Nierlein1-1/+1
Fix plugin-name processing in ALRM handler.
2016-06-03fix typo in perl pod (fixes rt #114873)Sven Nierlein1-4/+4
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2016-04-20Update Getopt.pmPaul Dugas1-1/+1
Allow hypen or underscore in plugin name.
2016-04-20Update Getopt.pmPaul Dugas1-1/+1
Wrong case in ALRM regex.
2016-04-02make regular expression 5.8 compatibleSven Nierlein1-1/+1
\R was introduced in 5.10 too
2016-04-02make regular expression 5.8 compatibleSven Nierlein1-1/+1
2016-04-02Fixed regex in plugin_exit() that handles hyphen for LONGOUTPUT.Paul Dugas1-1/+1
Added tests.
2016-03-31Support LONGTEXT outputPaul Dugas1-1/+4
Pass `TEXT OUTPUT\nLONGTEXT1\nLONGTEXT2` to as the second parameter to `plugin_exit()` to add LONGOUTPUT lines. If the parameter is has a leading newline (i.e. `\nLONGTEXT1\nLONGTEXT2`), skip emitting the hyphen (dash).
2015-12-03output empty values as "U"daku36491-1/+8
output empty performance data value as value "U" to "indicate that the actual value couldn't be determined" (defined in https://nagios-plugins.org/doc/guidelines.html#AEN200) and do valid output
2015-10-02add description for getter / setter methods (#107370)Sven Nierlein1-0/+26
Signed-off-by: Sven Nierlein <sven@nierlein.de> Original-Author: Christoph Biedl <debian.axhn@manchmal.in-ulm.de>
2015-04-11released 0.39v0.39Sven Nierlein2-2/+2
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2015-04-11fix "Redundant argument in sprintf" in perl 5.21 (RT #103214)Sven Nierlein1-7/+9
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2014-12-28Merge pull request #2 from evgeni/getopt_colon_specSven Nierlein1-4/+14
GetOpt::Long optional arguments using a colon instead of an equal sign
2014-12-28release 0.38v0.38Sven Nierlein2-2/+2
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2014-12-08fix link to documentationSven Nierlein1-1/+1
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2014-12-08correct getopt helpSven Nierlein1-2/+2
its not true that the options are available via the main Monitoring::Plugin object. Instead you have to fetch them from the opts object. Signed-off-by: Sven Nierlein <sven@nierlein.de>
2014-10-03format optional arguments in square braketsEvgeni Golov1-3/+13
2014-10-03GetOpt::Long optional arguments using a colon instead of an equal signEvgeni Golov1-2/+2
Instead of writing `foo|f=s` you can also write `foo|f:s` for a GetOpt::Long option spec [1], thus making the argument optional. The current implementation of `_spec_to_help` will wrongly render this as two long options: --dirport, --d:9030 directory port instead of a short and a long one: -d, --dirport=INTEGER directory port This commit fixes the the parsing of the spec, detection of the type and adds tests for a few common cases this could be used in. [1] http://perldoc.perl.org/Getopt/Long.html#Summary-of-Option-Specifications
2014-01-20keep the old name in copyright for more transparencyv0.37Sven Nierlein8-21/+36
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2014-01-20renamed module into Monitoring::PluginSven Nierlein8-0/+2871
since the complete monitoring team has been renamed, we also rename this module. Signed-off-by: Sven Nierlein <sven@nierlein.de>