From bacb16365718f55bbb09f9d990011e3829691f16 Mon Sep 17 00:00:00 2001 From: Thomas Guyot-Sionnest Date: Thu, 28 Jun 2012 22:49:41 -0400 Subject: Add new test - match on "die" error message 1. Add new test "class" where expected data is the error string caught 2. Add new test exposing a bug where default file used is not shown, ex: Invalid section 'bad_section' in config file '' --- t/Nagios-Plugin-Getopt-03.t | 3 ++- t/npg03/expected/15_badsection_catch | 1 + t/npg03/input/15_badsection_catch | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 t/npg03/expected/15_badsection_catch create mode 100644 t/npg03/input/15_badsection_catch diff --git a/t/Nagios-Plugin-Getopt-03.t b/t/Nagios-Plugin-Getopt-03.t index 11443c8..560b782 100644 --- a/t/Nagios-Plugin-Getopt-03.t +++ b/t/Nagios-Plugin-Getopt-03.t @@ -96,7 +96,8 @@ for my $infile (glob File::Spec->catfile($tdir, 'input', $glob)) { eval { $ng->getopts }; if ($@) { chomp $@; - ok($infile =~ m/_dies?$/, "$infile ($@)"); + ok($infile =~ m/_(dies?|catch)$/, "$infile ($@)"); + is($@, $EXPECTED{$infile}, $infile) if ($infile =~ m/_catch$/); } else { is($plugin . ' ' . $ng->_cmdline, $EXPECTED{$infile}, $infile); diff --git a/t/npg03/expected/15_badsection_catch b/t/npg03/expected/15_badsection_catch new file mode 100644 index 0000000..7505c2b --- /dev/null +++ b/t/npg03/expected/15_badsection_catch @@ -0,0 +1 @@ +Invalid section 'bad_section' in config file 't/npg03/plugins.ini' diff --git a/t/npg03/input/15_badsection_catch b/t/npg03/input/15_badsection_catch new file mode 100644 index 0000000..bcc026a --- /dev/null +++ b/t/npg03/input/15_badsection_catch @@ -0,0 +1 @@ +check_no_section_default_file --extra-opts=bad_section -- cgit v1.2.3-74-g34f1