summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJan Wagner <waja@cyconet.org>2013-09-30 15:55:22 (GMT)
committerJan Wagner <waja@cyconet.org>2014-07-20 21:52:25 (GMT)
commit69b719aa2e3bd8dfd643d7cbe60e6e165d5279ea (patch)
tree8428904d65cc748620318cbfac5e3063b4ddfbb4
parent71063655e558224d692950ac9abaa39e0b7c6585 (diff)
downloadmonitoring-plugins-69b719aa2e3bd8dfd643d7cbe60e6e165d5279ea.tar.gz
check_ifstatus: perfdata bug
The perfdata output violates the current Nagios Plugin Development Guidelines (http://nagiosplug.sourceforge.net/developer-guidelines.html#AEN202 : "space separated list of label/value pairs"). Thus the Addon PNP did not read the perdata correctly. The patch replaces the commas with spaces in the perfdata output. Many thanks to Patric Wust. --- Closes #1169 and #721.
-rw-r--r--THANKS.in1
-rwxr-xr-xplugins-scripts/check_ifstatus.pl2
2 files changed, 2 insertions, 1 deletions
diff --git a/THANKS.in b/THANKS.in
index 883387e..43ba182 100644
--- a/THANKS.in
+++ b/THANKS.in
@@ -323,3 +323,4 @@ Eric J. Mislivec
323Jean-Claude Computing 323Jean-Claude Computing
324Andy Brist 324Andy Brist
325Mikael Falkvidd 325Mikael Falkvidd
326Patric Wust
diff --git a/plugins-scripts/check_ifstatus.pl b/plugins-scripts/check_ifstatus.pl
index fb17d98..709ad17 100755
--- a/plugins-scripts/check_ifstatus.pl
+++ b/plugins-scripts/check_ifstatus.pl
@@ -221,7 +221,7 @@ foreach $key (keys %ifStatus) {
221 $ifexclude, 221 $ifexclude,
222 $ifunused); 222 $ifunused);
223 } 223 }
224my $perfdata = sprintf("up=%d,down=%d,dormant=%d,excluded=%d,unused=%d",$ifup,$ifdown,$ifdormant,$ifexclude,$ifunused); 224my $perfdata = sprintf("up=%d down=%d dormant=%d excluded=%d unused=%d",$ifup,$ifdown,$ifdormant,$ifexclude,$ifunused);
225print ("$state: $answer |$perfdata\n"); 225print ("$state: $answer |$perfdata\n");
226exit $ERRORS{$state}; 226exit $ERRORS{$state};
227 227