diff options
author | Holger Weiss <holger@zedat.fu-berlin.de> | 2012-06-24 15:51:56 +0200 |
---|---|---|
committer | Holger Weiss <holger@zedat.fu-berlin.de> | 2012-06-24 15:51:56 +0200 |
commit | 991054fa6e3d8b3288679ebfe6d84bcfe3ca5d20 (patch) | |
tree | 3747a14f1f4af6f21afaa4a15dde02d676d7b3b3 | |
parent | d61a3056c598bf030e699a094671727f841eca8c (diff) | |
download | monitoring-plugins-991054fa6e3d8b3288679ebfe6d84bcfe3ca5d20.tar.gz |
check_ping: Ignore ping(1)'s exit status
Don't return a WARNING state if the number of lost packets is greater
than zero but below the specified warning threshold. This happened
because the check_ping plugin used the exit status of the ping(1)
utility. (#3535140 - Tobias Brox)
-rw-r--r-- | THANKS.in | 1 | ||||
-rw-r--r-- | plugins/check_ping.c | 4 |
2 files changed, 2 insertions, 3 deletions
@@ -275,3 +275,4 @@ Marc Remy | |||
275 | Matej Vela | 275 | Matej Vela |
276 | Jason Ellison | 276 | Jason Ellison |
277 | Charles-Henri Larose | 277 | Charles-Henri Larose |
278 | Tobias Brox | ||
diff --git a/plugins/check_ping.c b/plugins/check_ping.c index 1367e903..bfdee492 100644 --- a/plugins/check_ping.c +++ b/plugins/check_ping.c | |||
@@ -500,9 +500,7 @@ run_ping (const char *cmd, const char *addr) | |||
500 | (void) fclose (child_stderr); | 500 | (void) fclose (child_stderr); |
501 | 501 | ||
502 | 502 | ||
503 | /* close the pipe - WARNING if status is set */ | 503 | spclose (child_process); |
504 | if (spclose (child_process)) | ||
505 | result = max_state (result, STATE_WARNING); | ||
506 | 504 | ||
507 | if (warn_text == NULL) | 505 | if (warn_text == NULL) |
508 | warn_text = strdup(""); | 506 | warn_text = strdup(""); |