diff options
author | Holger Weiss <hweiss@users.sourceforge.net> | 2009-04-21 22:28:53 (GMT) |
---|---|---|
committer | Holger Weiss <hweiss@users.sourceforge.net> | 2009-04-21 22:47:29 (GMT) |
commit | 92bb86c484c3d52c5ffdfa790f7a5acf68edcc36 (patch) | |
tree | e2195501bf3b67b373c9c3ddd0a5f0330d0209ed /lib/utils_base.h | |
parent | 05a980ba4bd3de0540771000955bd3235ad17acd (diff) | |
download | monitoring-plugins-92bb86c484c3d52c5ffdfa790f7a5acf68edcc36.tar.gz |
Make C plugin output format configurable
*** THIS COMMIT WILL BE MODIFIED IN THE FUTURE! ***
The development guidelines¹ currently state that the plugin output
should be in the format "SERVICE STATUS: Information text".
However, when a plugin is called via Nagios in order to perform a
service check, adding SERVICE and STATUS to the output is redundant.
And when a plugin is called on the command line for testing, there is no
use in printing out the SERVICE string, either. However, for debugging,
it does make sense to print out the STATUS so that the user won't have
to check and interpret the exit code manually. But it should suffice to
print such debug output only when called with "--verbose", not in
production.
Space for plugin output is sometimes scarce, so that we should try to
keep the output "short and to the point" (as the guide states) and not
waste space with redundant information. Therefore, we decided² to make
the ("normal" and "verbose") plugin output configurable at compile time.
¹ http://nagiosplug.sf.net/developer-guidelines.html
² http://thread.gmane.org/gmane.network.nagios.plugins.devel/5155
Diffstat (limited to 'lib/utils_base.h')
-rw-r--r-- | lib/utils_base.h | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/lib/utils_base.h b/lib/utils_base.h index bda7659..b6e8128 100644 --- a/lib/utils_base.h +++ b/lib/utils_base.h | |||
@@ -37,6 +37,23 @@ int get_status(double, thresholds *); | |||
37 | 37 | ||
38 | char *np_escaped_string (const char *); | 38 | char *np_escaped_string (const char *); |
39 | 39 | ||
40 | void np_set_output(const char *, const char *, int, int); | ||
41 | int np_adjust_verbosity(int); | ||
42 | void np_debug(int, const char *, ...) | ||
43 | __attribute__((format(printf, 2, 3))); | ||
44 | void np_verbose(const char *, ...) | ||
45 | __attribute__((format(printf, 1, 2))); | ||
46 | void np_die(int, const char *, ...) | ||
47 | __attribute__((noreturn, format(printf, 2, 3))); | ||
48 | |||
49 | #define np_verbatim(s) np_verbose("%s", s) | ||
50 | #define np_increase_verbosity(i) np_adjust_verbosity(i) | ||
51 | #define np_decrease_verbosity(i) np_adjust_verbosity(-i) | ||
52 | #define np_get_verbosity() np_adjust_verbosity(0) | ||
53 | #define np_set_verbosity(v) np_set_output(NULL, NULL, v, 0) | ||
54 | #define np_set_mynames(p, s) np_set_output(p, s, -2, 0) | ||
55 | |||
56 | /* TODO: die() can be removed as soon as all plugins use np_die() instead. */ | ||
40 | void die (int, const char *, ...) __attribute__((noreturn,format(printf, 2, 3))); | 57 | void die (int, const char *, ...) __attribute__((noreturn,format(printf, 2, 3))); |
41 | 58 | ||
42 | /* Return codes for _set_thresholds */ | 59 | /* Return codes for _set_thresholds */ |
@@ -50,4 +67,6 @@ int np_check_if_root(void); | |||
50 | * code from the above function, in case it's helpful for testing */ | 67 | * code from the above function, in case it's helpful for testing */ |
51 | int np_warn_if_not_root(void); | 68 | int np_warn_if_not_root(void); |
52 | 69 | ||
70 | const char *state_text(int); | ||
71 | |||
53 | #endif /* _UTILS_BASE_ */ | 72 | #endif /* _UTILS_BASE_ */ |