summaryrefslogtreecommitdiffstats
path: root/plugins
diff options
context:
space:
mode:
authorIustin Pop <iustin@debian.org>2019-01-18 22:52:54 +0100
committerJan Wagner <waja@cyconet.org>2019-01-20 15:03:57 +0100
commiteeb41ef1e7f687585aa34be8c655848a4fe647e4 (patch)
treeb40a8e81c7e1448c068b5934c1bdea884878316f /plugins
parent8526d65d47195d76d78f0132115dd22ebe8ff557 (diff)
downloadmonitoring-plugins-eeb41ef1e7f687585aa34be8c655848a4fe647e4.tar.gz
Simply initializes n before it is used
When SSL is enabled, n is assigned the size of the server's second EHLO response (I think in bytes), which will usually be significantly higher than the command passed. As such, no commands are executed and no responses are checked, which - silently - defeats the desired checks and results in a success value.
Diffstat (limited to 'plugins')
-rw-r--r--plugins/check_smtp.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/plugins/check_smtp.c b/plugins/check_smtp.c
index 0fcf4c68..d37c57c8 100644
--- a/plugins/check_smtp.c
+++ b/plugins/check_smtp.c
@@ -293,6 +293,7 @@ main (int argc, char **argv)
293 printf("%s", buffer); 293 printf("%s", buffer);
294 } 294 }
295 295
296 n = 0;
296 while (n < ncommands) { 297 while (n < ncommands) {
297 xasprintf (&cmd_str, "%s%s", commands[n], "\r\n"); 298 xasprintf (&cmd_str, "%s%s", commands[n], "\r\n");
298 my_send(cmd_str, strlen(cmd_str)); 299 my_send(cmd_str, strlen(cmd_str));