diff options
-rw-r--r-- | plugins/check_apt.c | 40 |
1 files changed, 20 insertions, 20 deletions
diff --git a/plugins/check_apt.c b/plugins/check_apt.c index af3563a..312909b 100644 --- a/plugins/check_apt.c +++ b/plugins/check_apt.c | |||
@@ -76,9 +76,9 @@ int cmpstringp(const void *p1, const void *p2); | |||
76 | 76 | ||
77 | /* configuration variables */ | 77 | /* configuration variables */ |
78 | static int verbose = 0; /* -v */ | 78 | static int verbose = 0; /* -v */ |
79 | static int list = 0; /* list packages available for upgrade */ | 79 | static bool list = false; /* list packages available for upgrade */ |
80 | static int do_update = 0; /* whether to call apt-get update */ | 80 | static bool do_update = false; /* whether to call apt-get update */ |
81 | static int only_critical = 0; /* whether to warn about non-critical updates */ | 81 | static bool only_critical = false; /* whether to warn about non-critical updates */ |
82 | static upgrade_type upgrade = UPGRADE; /* which type of upgrade to do */ | 82 | static upgrade_type upgrade = UPGRADE; /* which type of upgrade to do */ |
83 | static char *upgrade_opts = NULL; /* options to override defaults for upgrade */ | 83 | static char *upgrade_opts = NULL; /* options to override defaults for upgrade */ |
84 | static char *update_opts = NULL; /* options to override defaults for update */ | 84 | static char *update_opts = NULL; /* options to override defaults for update */ |
@@ -119,7 +119,7 @@ int main (int argc, char **argv) { | |||
119 | 119 | ||
120 | if(sec_count > 0){ | 120 | if(sec_count > 0){ |
121 | result = max_state(result, STATE_CRITICAL); | 121 | result = max_state(result, STATE_CRITICAL); |
122 | } else if(packages_available >= packages_warning && only_critical == 0){ | 122 | } else if(packages_available >= packages_warning && only_critical == false){ |
123 | result = max_state(result, STATE_WARNING); | 123 | result = max_state(result, STATE_WARNING); |
124 | } else if(result > STATE_UNKNOWN){ | 124 | } else if(result > STATE_UNKNOWN){ |
125 | result = STATE_UNKNOWN; | 125 | result = STATE_UNKNOWN; |
@@ -144,7 +144,7 @@ int main (int argc, char **argv) { | |||
144 | 144 | ||
145 | for(i = 0; i < sec_count; i++) | 145 | for(i = 0; i < sec_count; i++) |
146 | printf("%s (security)\n", secpackages_list[i]); | 146 | printf("%s (security)\n", secpackages_list[i]); |
147 | if (only_critical == 0) { | 147 | if (only_critical == false) { |
148 | for(i = 0; i < packages_available - sec_count; i++) | 148 | for(i = 0; i < packages_available - sec_count; i++) |
149 | printf("%s\n", packages_list[i]); | 149 | printf("%s\n", packages_list[i]); |
150 | } | 150 | } |
@@ -166,7 +166,7 @@ int process_arguments (int argc, char **argv) { | |||
166 | {"upgrade", optional_argument, 0, 'U'}, | 166 | {"upgrade", optional_argument, 0, 'U'}, |
167 | {"no-upgrade", no_argument, 0, 'n'}, | 167 | {"no-upgrade", no_argument, 0, 'n'}, |
168 | {"dist-upgrade", optional_argument, 0, 'd'}, | 168 | {"dist-upgrade", optional_argument, 0, 'd'}, |
169 | {"list", no_argument, 0, 'l'}, | 169 | {"list", no_argument, false, 'l'}, |
170 | {"include", required_argument, 0, 'i'}, | 170 | {"include", required_argument, 0, 'i'}, |
171 | {"exclude", required_argument, 0, 'e'}, | 171 | {"exclude", required_argument, 0, 'e'}, |
172 | {"critical", required_argument, 0, 'c'}, | 172 | {"critical", required_argument, 0, 'c'}, |
@@ -212,14 +212,14 @@ int process_arguments (int argc, char **argv) { | |||
212 | upgrade=NO_UPGRADE; | 212 | upgrade=NO_UPGRADE; |
213 | break; | 213 | break; |
214 | case 'u': | 214 | case 'u': |
215 | do_update=1; | 215 | do_update=true; |
216 | if(optarg!=NULL){ | 216 | if(optarg!=NULL){ |
217 | update_opts=strdup(optarg); | 217 | update_opts=strdup(optarg); |
218 | if(update_opts==NULL) die(STATE_UNKNOWN, "strdup failed"); | 218 | if(update_opts==NULL) die(STATE_UNKNOWN, "strdup failed"); |
219 | } | 219 | } |
220 | break; | 220 | break; |
221 | case 'l': | 221 | case 'l': |
222 | list=1; | 222 | list=true; |
223 | break; | 223 | break; |
224 | case 'i': | 224 | case 'i': |
225 | do_include=add_to_regexp(do_include, optarg); | 225 | do_include=add_to_regexp(do_include, optarg); |
@@ -231,7 +231,7 @@ int process_arguments (int argc, char **argv) { | |||
231 | do_critical=add_to_regexp(do_critical, optarg); | 231 | do_critical=add_to_regexp(do_critical, optarg); |
232 | break; | 232 | break; |
233 | case 'o': | 233 | case 'o': |
234 | only_critical=1; | 234 | only_critical=true; |
235 | break; | 235 | break; |
236 | case INPUT_FILE_OPT: | 236 | case INPUT_FILE_OPT: |
237 | input_filename = optarg; | 237 | input_filename = optarg; |
@@ -371,7 +371,7 @@ int run_update(void){ | |||
371 | struct output chld_out, chld_err; | 371 | struct output chld_out, chld_err; |
372 | char *cmdline; | 372 | char *cmdline; |
373 | 373 | ||
374 | /* run the upgrade */ | 374 | /* run the update */ |
375 | cmdline = construct_cmdline(NO_UPGRADE, update_opts); | 375 | cmdline = construct_cmdline(NO_UPGRADE, update_opts); |
376 | result = np_runcmd(cmdline, &chld_out, &chld_err, 0); | 376 | result = np_runcmd(cmdline, &chld_out, &chld_err, 0); |
377 | /* apt-get update changes exit status if it can't fetch packages. | 377 | /* apt-get update changes exit status if it can't fetch packages. |
@@ -501,16 +501,6 @@ print_help (void) | |||
501 | 501 | ||
502 | printf(UT_PLUG_TIMEOUT, timeout_interval); | 502 | printf(UT_PLUG_TIMEOUT, timeout_interval); |
503 | 503 | ||
504 | printf (" %s\n", "-U, --upgrade=OPTS"); | ||
505 | printf (" %s\n", _("[Default] Perform an upgrade. If an optional OPTS argument is provided,")); | ||
506 | printf (" %s\n", _("apt-get will be run with these command line options instead of the")); | ||
507 | printf (" %s", _("default ")); | ||
508 | printf ("(%s).\n", UPGRADE_DEFAULT_OPTS); | ||
509 | printf (" %s\n", _("Note that you may be required to have root privileges if you do not use")); | ||
510 | printf (" %s\n", _("the default options.")); | ||
511 | printf (" %s\n", "-d, --dist-upgrade=OPTS"); | ||
512 | printf (" %s\n", _("Perform a dist-upgrade instead of normal upgrade. Like with -U OPTS")); | ||
513 | printf (" %s\n", _("can be provided to override the default options.")); | ||
514 | printf (" %s\n", "-n, --no-upgrade"); | 504 | printf (" %s\n", "-n, --no-upgrade"); |
515 | printf (" %s\n", _("Do not run the upgrade. Probably not useful (without -u at least).")); | 505 | printf (" %s\n", _("Do not run the upgrade. Probably not useful (without -u at least).")); |
516 | printf (" %s\n", "-l, --list"); | 506 | printf (" %s\n", "-l, --list"); |
@@ -547,6 +537,16 @@ print_help (void) | |||
547 | printf (" %s\n", _("the default options. Note: you may also need to adjust the global")); | 537 | printf (" %s\n", _("the default options. Note: you may also need to adjust the global")); |
548 | printf (" %s\n", _("timeout (with -t) to prevent the plugin from timing out if apt-get")); | 538 | printf (" %s\n", _("timeout (with -t) to prevent the plugin from timing out if apt-get")); |
549 | printf (" %s\n", _("upgrade is expected to take longer than the default timeout.")); | 539 | printf (" %s\n", _("upgrade is expected to take longer than the default timeout.")); |
540 | printf (" %s\n", "-U, --upgrade=OPTS"); | ||
541 | printf (" %s\n", _("Perform an upgrade. If an optional OPTS argument is provided,")); | ||
542 | printf (" %s\n", _("apt-get will be run with these command line options instead of the")); | ||
543 | printf (" %s", _("default ")); | ||
544 | printf ("(%s).\n", UPGRADE_DEFAULT_OPTS); | ||
545 | printf (" %s\n", _("Note that you may be required to have root privileges if you do not use")); | ||
546 | printf (" %s\n", _("the default options, which will only run a simulation and NOT perform the upgrade")); | ||
547 | printf (" %s\n", "-d, --dist-upgrade=OPTS"); | ||
548 | printf (" %s\n", _("Perform a dist-upgrade instead of normal upgrade. Like with -U OPTS")); | ||
549 | printf (" %s\n", _("can be provided to override the default options.")); | ||
550 | 550 | ||
551 | printf(UT_SUPPORT); | 551 | printf(UT_SUPPORT); |
552 | } | 552 | } |