diff options
48 files changed, 738 insertions, 825 deletions
diff --git a/.travis.yml b/.travis.yml index 6af1fee..dcf13d5 100644 --- a/.travis.yml +++ b/.travis.yml | |||
@@ -1,22 +1,40 @@ | |||
1 | sudo: required | ||
2 | dist: trusty | ||
1 | language: c | 3 | language: c |
2 | 4 | ||
3 | before_install: | 5 | before_install: |
4 | - sudo add-apt-repository -y ppa:waja/precise-backports | 6 | # Trusty related fixed |
7 | # multiverse is no on trusty activated (https://github.com/travis-ci/travis-ci/issues/4979) | ||
8 | - sudo add-apt-repository "deb http://archive.ubuntu.com/ubuntu/ trusty multiverse" && sudo add-apt-repository "deb http://archive.ubuntu.com/ubuntu/ trusty-updates multiverse" | ||
9 | # /etc/hosts has IPv6 hosts (https://github.com/travis-ci/travis-ci/issues/4978) | ||
10 | - sudo [ $(ip addr show | grep "inet6 ::1" | wc -l) -lt "1" ] && sudo sed -i '/^::1/d' /etc/hosts | ||
11 | # Trusty has running ntpd on localhost, but we don't like that for our tests | ||
12 | - sudo killall -9 ntpd | ||
13 | # Trusty has no swap, lets create some | ||
14 | - sudo fallocate -l 20M /swapfile; sudo chmod 600 /swapfile; sudo mkswap /swapfile; sudo swapon /swapfile | ||
15 | - sudo add-apt-repository -y ppa:waja/trusty-backports | ||
5 | - sudo apt-get update -qq | 16 | - sudo apt-get update -qq |
6 | - sudo apt-get purge -qq gawk | 17 | - sudo apt-get purge -qq gawk |
7 | # ensure we have a test database in place for tests | 18 | # http://docs.travis-ci.com/user/trusty-ci-environment/ indicates, no MySQL on Trusty (yet) |
8 | - mysql -e "create database IF NOT EXISTS test;" -uroot | 19 | # # ensure we have a test database in place for tests |
20 | # - mysql -e "create database IF NOT EXISTS test;" -uroot | ||
9 | 21 | ||
10 | install: | 22 | install: |
11 | - sudo apt-get install -qq --no-install-recommends perl autotools-dev libdbi-dev libldap2-dev libpq-dev libmysqlclient-dev libfreeradius-client-dev libkrb5-dev libnet-snmp-perl procps | 23 | - sudo apt-get install -qq --no-install-recommends perl autotools-dev libdbi-dev libldap2-dev libpq-dev libmysqlclient-dev libradcli-dev libkrb5-dev libnet-snmp-perl procps |
12 | - sudo apt-get install -qq --no-install-recommends libdbi0-dev libdbd-sqlite3 libssl-dev dnsutils snmp-mibs-downloader libsnmp-perl snmpd | 24 | - sudo apt-get install -qq --no-install-recommends libdbi0-dev libdbd-sqlite3 libssl-dev dnsutils snmp-mibs-downloader libsnmp-perl snmpd |
13 | - sudo apt-get install -qq --no-install-recommends fping snmp netcat smbclient fping pure-ftpd apache2 postfix libhttp-daemon-ssl-perl | 25 | - sudo apt-get install -qq --no-install-recommends fping snmp netcat smbclient fping pure-ftpd apache2 postfix libhttp-daemon-ssl-perl |
14 | - sudo apt-get install -qq --no-install-recommends libdbd-sybase-perl libnet-dns-perl | 26 | - sudo apt-get install -qq --no-install-recommends libdbd-sybase-perl libnet-dns-perl |
15 | - sudo apt-get install -qq --no-install-recommends slapd ldap-utils | 27 | - sudo apt-get install -qq --no-install-recommends slapd ldap-utils |
16 | - sudo apt-get install -qq --no-install-recommends autoconf automake | 28 | - sudo apt-get install -qq --no-install-recommends autoconf automake |
17 | - sudo apt-get install -qq --no-install-recommends faketime | 29 | - sudo apt-get install -qq --no-install-recommends faketime |
30 | # Trusty related dependencies (not yet provided) | ||
31 | - sudo apt-get install -qq --no-install-recommends mariadb-client mariadb-server | ||
18 | 32 | ||
19 | before_script: | 33 | before_script: |
34 | # ensure we have a test database in place for tests | ||
35 | - mysql -e "create database IF NOT EXISTS test;" -uroot | ||
36 | # Detect LDAP configuration (seems volatile on trusty env) | ||
37 | - sed -e 's/cn=admin,dc=nodomain/'$(sudo /usr/sbin/slapcat|grep ^dn:|grep cn=|awk '{print $2}')'/' -i plugins/t/NPTest.cache.travis | ||
20 | - tools/setup | 38 | - tools/setup |
21 | - ./configure --enable-libtap | 39 | - ./configure --enable-libtap |
22 | - make | 40 | - make |
@@ -21,3 +21,4 @@ Ton Voon | |||
21 | Jan Wagner | 21 | Jan Wagner |
22 | Holger Weiss | 22 | Holger Weiss |
23 | Michael Wirtgen | 23 | Michael Wirtgen |
24 | Oliver Skibbe | ||
@@ -6,21 +6,39 @@ This file documents the major additions and syntax changes between releases. | |||
6 | thresholds | 6 | thresholds |
7 | New check_snmp "-N" option to specify SNMPv3 context name | 7 | New check_snmp "-N" option to specify SNMPv3 context name |
8 | New check_nt "-l" parameters: seconds|minutes|hours|days | 8 | New check_nt "-l" parameters: seconds|minutes|hours|days |
9 | Make sure check_disk won't hang on hanging (network) file systems | ||
10 | New check_mailq -s option which tells the plugin to use sudo(8) | 9 | New check_mailq -s option which tells the plugin to use sudo(8) |
11 | New -W/-C option for check_ldap to check number of entries (Gerhard Lausser) | 10 | New -W/-C option for check_ldap to check number of entries (Gerhard Lausser) |
11 | The check_http -S/--ssl option now accepts the arguments "1.1" and "1.2" | ||
12 | to force TLSv1.1 and TLSv1.2 connections, respectively | ||
13 | The check_http -S/--ssl option now allows for specifying the desired | ||
14 | protocol with a "+" suffix to also accept newer versions | ||
15 | check_users: add support for range thresholds (John C. Frickson) | ||
16 | check_snmp: add ipv6 support (abrist) | ||
17 | check_http: report certificate expire date in UTC (pirtoo / ylfingr) | ||
18 | check_radius now supports the radcli library | ||
12 | 19 | ||
13 | FIXES | 20 | FIXES |
14 | Let check_real terminate lines with CRLF when talking to the server, as | 21 | Let check_real terminate lines with CRLF when talking to the server, as |
15 | mandated by 2326 | 22 | mandated by 2326 |
16 | Fix check_procs on HP-UX | 23 | Fix check_procs on HP-UX |
24 | check_smtp's -e/--expect option can now be combined with -S/--starttls | ||
25 | Fix incorrect performance data thresholds emitted by check_ups | ||
26 | check_http: fix host header port handling (odenbach) | ||
17 | 27 | ||
18 | WARNINGS | 28 | WARNINGS |
19 | The format of the performance data emitted by check_mrtgtraf has been | 29 | The format of the performance data emitted by check_mrtgtraf has been |
20 | changed to comply with the development guidelines | 30 | changed to comply with the development guidelines |
21 | check_ssh not returns CRITICAL for protocal/version errors | 31 | check_ssh now returns CRITICAL for protocol/version errors |
22 | If a plugin is invoked with -h/--help or -V/--version, the exit status | 32 | If a plugin is invoked with -h/--help or -V/--version, the exit status |
23 | is now UNKNOWN | 33 | is now UNKNOWN |
34 | The superseded check_ntp.pl was removed, please use check_ntp_peer or | ||
35 | check_ntp_time instead | ||
36 | |||
37 | 2.1.2 16th October 2015 | ||
38 | FIXES | ||
39 | Fix incorrect performance data thresholds emitted by check_ups | ||
40 | Fix check_dhcp's option parsing to not crash with certain arguments | ||
41 | Fix check_snmp using correct timeout | ||
24 | 42 | ||
25 | 2.1.1 2nd December 2014 | 43 | 2.1.1 2nd December 2014 |
26 | FIXES | 44 | FIXES |
@@ -29,6 +47,7 @@ This file documents the major additions and syntax changes between releases. | |||
29 | Fix check_apt's handling of invalid regular expressions | 47 | Fix check_apt's handling of invalid regular expressions |
30 | Fix check_real's server response processing | 48 | Fix check_real's server response processing |
31 | Fix backslash escaping in check_tcp's --help output | 49 | Fix backslash escaping in check_tcp's --help output |
50 | Fix check_procs's unclosed filehandle in pst3 on Solaris | ||
32 | 51 | ||
33 | 2.1 15th October 2014 | 52 | 2.1 15th October 2014 |
34 | ENHANCEMENTS | 53 | ENHANCEMENTS |
diff --git a/NP-VERSION-GEN b/NP-VERSION-GEN index 12efad7..dd82bf1 100755 --- a/NP-VERSION-GEN +++ b/NP-VERSION-GEN | |||
@@ -6,7 +6,7 @@ | |||
6 | SRC_ROOT=`dirname $0` | 6 | SRC_ROOT=`dirname $0` |
7 | 7 | ||
8 | NPVF=NP-VERSION-FILE | 8 | NPVF=NP-VERSION-FILE |
9 | DEF_VER=2.1.1.git | 9 | DEF_VER=2.1.2.git |
10 | 10 | ||
11 | LF=' | 11 | LF=' |
12 | ' | 12 | ' |
diff --git a/REQUIREMENTS b/REQUIREMENTS index 303fd62..ac7b593 100644 --- a/REQUIREMENTS +++ b/REQUIREMENTS | |||
@@ -50,16 +50,18 @@ check_dbi: | |||
50 | http://libdbi.sourceforge.net/ | 50 | http://libdbi.sourceforge.net/ |
51 | 51 | ||
52 | check_radius: | 52 | check_radius: |
53 | - Requires the FreeRADIUS Client library available from: | 53 | - Requires the radcli library available from: |
54 | http://radcli.github.io/radcli/ | ||
55 | - As an alternative, the FreeRADIUS Client library may be used: | ||
54 | http://freeradius.org/freeradius-client/ | 56 | http://freeradius.org/freeradius-client/ |
55 | - As an alternative, the radiusclient-ng library may be used: | 57 | - As another alternative, the radiusclient-ng library may be used: |
56 | http://sourceforge.net/projects/radiusclient-ng.berlios/ | 58 | http://sourceforge.net/projects/radiusclient-ng.berlios/ |
57 | - This plugin also works with the original radiusclient library from | 59 | - This plugin also works with the original radiusclient library from |
58 | ftp://ftp.cityline.net/pub/radiusclient/ | 60 | ftp://ftp.cityline.net/pub/radiusclient/ |
59 | RPM (rpmfind): radiusclient 0.3.2, radiusclient-devel-0.3.2 | 61 | RPM (rpmfind): radiusclient 0.3.2, radiusclient-devel-0.3.2 |
60 | However, you probably want to use the FreeRADIUS Client library, as | 62 | However, you probably want to use either radcli or the FreeRADIUS |
61 | both radiusclient and radiusclient-ng are unmaintained and have known | 63 | Client library, as both radiusclient and radiusclient-ng are |
62 | issues. | 64 | unmaintained and have known issues. |
63 | 65 | ||
64 | check_snmp: | 66 | check_snmp: |
65 | - Requires the NET-SNMP package available from | 67 | - Requires the NET-SNMP package available from |
@@ -336,3 +336,8 @@ Nick Peelman | |||
336 | Sebastian Herbszt | 336 | Sebastian Herbszt |
337 | Christopher Schultz | 337 | Christopher Schultz |
338 | Matthias Hähnel | 338 | Matthias Hähnel |
339 | Roberto Greiner | ||
340 | Peter (pirtoo) | ||
341 | ylfingr | ||
342 | Christian Kujau | ||
343 | Christopher Odenbach | ||
diff --git a/configure.ac b/configure.ac index ce1728e..367e82a 100644 --- a/configure.ac +++ b/configure.ac | |||
@@ -1,6 +1,6 @@ | |||
1 | dnl Process this file with autoconf to produce a configure script. | 1 | dnl Process this file with autoconf to produce a configure script. |
2 | AC_PREREQ(2.59) | 2 | AC_PREREQ(2.59) |
3 | AC_INIT(monitoring-plugins,2.1.1) | 3 | AC_INIT(monitoring-plugins,2.1.2) |
4 | AC_CONFIG_SRCDIR(NPTest.pm) | 4 | AC_CONFIG_SRCDIR(NPTest.pm) |
5 | AC_CONFIG_FILES([gl/Makefile]) | 5 | AC_CONFIG_FILES([gl/Makefile]) |
6 | AC_CONFIG_AUX_DIR(build-aux) | 6 | AC_CONFIG_AUX_DIR(build-aux) |
@@ -156,12 +156,6 @@ AC_CHECK_LIB(socket,socket,SOCKETLIBS="$SOCKETLIBS -lsocket") | |||
156 | AC_CHECK_LIB(resolv,main,SOCKETLIBS="$SOCKETLIBS -lresolv") | 156 | AC_CHECK_LIB(resolv,main,SOCKETLIBS="$SOCKETLIBS -lresolv") |
157 | AC_SUBST(SOCKETLIBS) | 157 | AC_SUBST(SOCKETLIBS) |
158 | 158 | ||
159 | dnl Check for POSIX thread libraries | ||
160 | AC_CHECK_HEADERS(pthread.h) | ||
161 | AC_CHECK_LIB(pthread,pthread_create,THREADLIBS="-lpthread", | ||
162 | AC_CHECK_LIB(pthread,pthread_create,THREADLIBS="-lpthread -lrt",-lrt)) | ||
163 | AC_SUBST(THREADLIBS) | ||
164 | |||
165 | dnl | 159 | dnl |
166 | dnl check for math-related functions needing -lm | 160 | dnl check for math-related functions needing -lm |
167 | AC_CHECK_HEADERS(math.h) | 161 | AC_CHECK_HEADERS(math.h) |
@@ -279,26 +273,33 @@ AC_ARG_WITH([radius], [AS_HELP_STRING([--without-radius], [Skips the radius plug | |||
279 | dnl Check for radius libraries | 273 | dnl Check for radius libraries |
280 | AS_IF([test "x$with_radius" != "xno"], [ | 274 | AS_IF([test "x$with_radius" != "xno"], [ |
281 | _SAVEDLIBS="$LIBS" | 275 | _SAVEDLIBS="$LIBS" |
282 | AC_CHECK_LIB(freeradius-client,rc_read_config) | 276 | AC_CHECK_LIB(radcli,rc_read_config) |
283 | if test "$ac_cv_lib_freeradius_client_rc_read_config" = "yes"; then | 277 | if test "$ac_cv_lib_radcli_rc_read_config" = "yes"; then |
284 | EXTRAS="$EXTRAS check_radius\$(EXEEXT)" | 278 | EXTRAS="$EXTRAS check_radius\$(EXEEXT)" |
285 | RADIUSLIBS="-lfreeradius-client" | 279 | RADIUSLIBS="-lradcli" |
286 | AC_SUBST(RADIUSLIBS) | 280 | AC_SUBST(RADIUSLIBS) |
287 | else | 281 | else |
288 | AC_CHECK_LIB(radiusclient-ng,rc_read_config) | 282 | AC_CHECK_LIB(freeradius-client,rc_read_config) |
289 | if test "$ac_cv_lib_radiusclient_ng_rc_read_config" = "yes"; then | 283 | if test "$ac_cv_lib_freeradius_client_rc_read_config" = "yes"; then |
290 | EXTRAS="$EXTRAS check_radius\$(EXEEXT)" | 284 | EXTRAS="$EXTRAS check_radius\$(EXEEXT)" |
291 | RADIUSLIBS="-lradiusclient-ng" | 285 | RADIUSLIBS="-lfreeradius-client" |
292 | AC_SUBST(RADIUSLIBS) | 286 | AC_SUBST(RADIUSLIBS) |
293 | else | 287 | else |
294 | AC_CHECK_LIB(radiusclient,rc_read_config) | 288 | AC_CHECK_LIB(radiusclient-ng,rc_read_config) |
295 | if test "$ac_cv_lib_radiusclient_rc_read_config" = "yes"; then | 289 | if test "$ac_cv_lib_radiusclient_ng_rc_read_config" = "yes"; then |
296 | EXTRAS="$EXTRAS check_radius\$(EXEEXT)" | 290 | EXTRAS="$EXTRAS check_radius\$(EXEEXT)" |
297 | RADIUSLIBS="-lradiusclient" | 291 | RADIUSLIBS="-lradiusclient-ng" |
298 | AC_SUBST(RADIUSLIBS) | 292 | AC_SUBST(RADIUSLIBS) |
299 | else | 293 | else |
300 | AC_MSG_WARN([Skipping radius plugin]) | 294 | AC_CHECK_LIB(radiusclient,rc_read_config) |
301 | AC_MSG_WARN([install radius libs to compile this plugin (see REQUIREMENTS).]) | 295 | if test "$ac_cv_lib_radiusclient_rc_read_config" = "yes"; then |
296 | EXTRAS="$EXTRAS check_radius\$(EXEEXT)" | ||
297 | RADIUSLIBS="-lradiusclient" | ||
298 | AC_SUBST(RADIUSLIBS) | ||
299 | else | ||
300 | AC_MSG_WARN([Skipping radius plugin]) | ||
301 | AC_MSG_WARN([install radius libs to compile this plugin (see REQUIREMENTS).]) | ||
302 | fi | ||
302 | fi | 303 | fi |
303 | fi | 304 | fi |
304 | fi | 305 | fi |
@@ -499,15 +500,15 @@ if ! test x"$with_openssl" = x"no"; then | |||
499 | dnl Check for crypto lib | 500 | dnl Check for crypto lib |
500 | _SAVEDLIBS="$LIBS" | 501 | _SAVEDLIBS="$LIBS" |
501 | LIBS="-L${with_openssl}/lib" | 502 | LIBS="-L${with_openssl}/lib" |
502 | AC_CHECK_LIB(crypto,CRYPTO_lock) | 503 | AC_CHECK_LIB(crypto,CRYPTO_new_ex_data) |
503 | if test "$ac_cv_lib_crypto_CRYPTO_lock" = "yes"; then | 504 | if test "$ac_cv_lib_crypto_CRYPTO_new_ex_data" = "yes"; then |
504 | dnl Check for SSL lib | 505 | dnl Check for SSL lib |
505 | AC_CHECK_LIB(ssl,main, SSLLIBS="-lssl -lcrypto",,-lcrypto) | 506 | AC_CHECK_LIB(ssl,main, SSLLIBS="-lssl -lcrypto",,-lcrypto) |
506 | fi | 507 | fi |
507 | LIBS="$_SAVEDLIBS" | 508 | LIBS="$_SAVEDLIBS" |
508 | 509 | ||
509 | dnl test headers and libs to decide whether check_http should use SSL | 510 | dnl test headers and libs to decide whether check_http should use SSL |
510 | if test "$ac_cv_lib_crypto_CRYPTO_lock" = "yes"; then | 511 | if test "$ac_cv_lib_crypto_CRYPTO_new_ex_data" = "yes"; then |
511 | if test "$ac_cv_lib_ssl_main" = "yes"; then | 512 | if test "$ac_cv_lib_ssl_main" = "yes"; then |
512 | if test "$FOUNDINCLUDE" = "yes"; then | 513 | if test "$FOUNDINCLUDE" = "yes"; then |
513 | FOUNDOPENSSL="yes" | 514 | FOUNDOPENSSL="yes" |
diff --git a/doc/developer-guidelines.sgml b/doc/developer-guidelines.sgml index 228d3fa..6f31f36 100644 --- a/doc/developer-guidelines.sgml +++ b/doc/developer-guidelines.sgml | |||
@@ -200,9 +200,8 @@ | |||
200 | operation. Higher-level errors (such as name resolution errors, | 200 | operation. Higher-level errors (such as name resolution errors, |
201 | socket timeouts, etc) are outside of the control of plugins and should | 201 | socket timeouts, etc) are outside of the control of plugins and should |
202 | generally NOT be reported as UNKNOWN states. | 202 | generally NOT be reported as UNKNOWN states. |
203 | </para> | 203 | </para><para>The --help or --version output should also result in Unknown state. |
204 | <para>The --help or --version output should also result in Unknown state.</para> | 204 | </para></entry> |
205 | </entry> | ||
206 | </row> | 205 | </row> |
207 | </tbody> | 206 | </tbody> |
208 | </tgroup> | 207 | </tgroup> |
@@ -613,7 +612,7 @@ | |||
613 | The user should be allowed to specify -v multiple times to increase | 612 | The user should be allowed to specify -v multiple times to increase |
614 | the verbosity level, as described in <xref linkend="verboselevels">.</para> | 613 | the verbosity level, as described in <xref linkend="verboselevels">.</para> |
615 | 614 | ||
616 | The exit code for version information or help should be UNKNOWN | 615 | <para>The exit code for version information or help should be UNKNOWN |
617 | (3).</para> | 616 | (3).</para> |
618 | </section> | 617 | </section> |
619 | 618 | ||
diff --git a/gl/Makefile.am b/gl/Makefile.am index 54abb4c..15135c8 100644 --- a/gl/Makefile.am +++ b/gl/Makefile.am | |||
@@ -21,7 +21,7 @@ | |||
21 | # the same distribution terms as the rest of that program. | 21 | # the same distribution terms as the rest of that program. |
22 | # | 22 | # |
23 | # Generated by gnulib-tool. | 23 | # Generated by gnulib-tool. |
24 | # Reproduce by: gnulib-tool --import --dir=. --lib=libgnu --source-base=gl --m4-base=gl/m4 --doc-base=doc --tests-base=tests --aux-dir=build-aux --no-conditional-dependencies --no-libtool --macro-prefix=gl --no-vc-files base64 crypto/sha1 dirname environ floorf fsusage getaddrinfo gethostname getloadavg getopt-gnu gettext idpriv-droptemp mountlist regex setenv strcase strsep timegm unsetenv vasprintf vsnprintf | 24 | # Reproduce by: gnulib-tool --import --dir=. --lib=libgnu --source-base=gl --m4-base=gl/m4 --doc-base=doc --tests-base=tests --aux-dir=build-aux --no-conditional-dependencies --no-libtool --macro-prefix=gl --no-vc-files base64 crypto/sha1 dirname environ floorf fsusage getaddrinfo gethostname getloadavg getopt-gnu gettext idpriv-droptemp mountlist regex setenv strcase strcasestr strsep timegm unsetenv vasprintf vsnprintf |
25 | 25 | ||
26 | AUTOMAKE_OPTIONS = 1.9.6 gnits subdir-objects | 26 | AUTOMAKE_OPTIONS = 1.9.6 gnits subdir-objects |
27 | 27 | ||
@@ -1553,6 +1553,15 @@ EXTRA_libgnu_a_SOURCES += strcasecmp.c strncasecmp.c | |||
1553 | 1553 | ||
1554 | ## end gnulib module strcase | 1554 | ## end gnulib module strcase |
1555 | 1555 | ||
1556 | ## begin gnulib module strcasestr-simple | ||
1557 | |||
1558 | |||
1559 | EXTRA_DIST += str-two-way.h strcasestr.c | ||
1560 | |||
1561 | EXTRA_libgnu_a_SOURCES += strcasestr.c | ||
1562 | |||
1563 | ## end gnulib module strcasestr-simple | ||
1564 | |||
1556 | ## begin gnulib module streq | 1565 | ## begin gnulib module streq |
1557 | 1566 | ||
1558 | 1567 | ||
diff --git a/gl/m4/gnulib-cache.m4 b/gl/m4/gnulib-cache.m4 index d6fca2a..90ad4aa 100644 --- a/gl/m4/gnulib-cache.m4 +++ b/gl/m4/gnulib-cache.m4 | |||
@@ -27,7 +27,7 @@ | |||
27 | 27 | ||
28 | 28 | ||
29 | # Specification in the form of a command-line invocation: | 29 | # Specification in the form of a command-line invocation: |
30 | # gnulib-tool --import --dir=. --lib=libgnu --source-base=gl --m4-base=gl/m4 --doc-base=doc --tests-base=tests --aux-dir=build-aux --no-conditional-dependencies --no-libtool --macro-prefix=gl --no-vc-files base64 crypto/sha1 dirname environ floorf fsusage getaddrinfo gethostname getloadavg getopt-gnu gettext idpriv-droptemp mountlist regex setenv strcase strsep timegm unsetenv vasprintf vsnprintf | 30 | # gnulib-tool --import --dir=. --lib=libgnu --source-base=gl --m4-base=gl/m4 --doc-base=doc --tests-base=tests --aux-dir=build-aux --no-conditional-dependencies --no-libtool --macro-prefix=gl --no-vc-files base64 crypto/sha1 dirname environ floorf fsusage getaddrinfo gethostname getloadavg getopt-gnu gettext idpriv-droptemp mountlist regex setenv strcase strcasestr strsep timegm unsetenv vasprintf vsnprintf |
31 | 31 | ||
32 | # Specification in the form of a few gnulib-tool.m4 macro invocations: | 32 | # Specification in the form of a few gnulib-tool.m4 macro invocations: |
33 | gl_LOCAL_DIR([]) | 33 | gl_LOCAL_DIR([]) |
@@ -48,6 +48,7 @@ gl_MODULES([ | |||
48 | regex | 48 | regex |
49 | setenv | 49 | setenv |
50 | strcase | 50 | strcase |
51 | strcasestr | ||
51 | strsep | 52 | strsep |
52 | timegm | 53 | timegm |
53 | unsetenv | 54 | unsetenv |
diff --git a/gl/m4/gnulib-comp.m4 b/gl/m4/gnulib-comp.m4 index 67a8156..9a4f502 100644 --- a/gl/m4/gnulib-comp.m4 +++ b/gl/m4/gnulib-comp.m4 | |||
@@ -121,6 +121,8 @@ AC_DEFUN([gl_EARLY], | |||
121 | # Code from module stdio: | 121 | # Code from module stdio: |
122 | # Code from module stdlib: | 122 | # Code from module stdlib: |
123 | # Code from module strcase: | 123 | # Code from module strcase: |
124 | # Code from module strcasestr: | ||
125 | # Code from module strcasestr-simple: | ||
124 | # Code from module streq: | 126 | # Code from module streq: |
125 | # Code from module strerror: | 127 | # Code from module strerror: |
126 | # Code from module strerror-override: | 128 | # Code from module strerror-override: |
@@ -390,6 +392,17 @@ AC_DEFUN([gl_INIT], | |||
390 | AC_LIBOBJ([strncasecmp]) | 392 | AC_LIBOBJ([strncasecmp]) |
391 | gl_PREREQ_STRNCASECMP | 393 | gl_PREREQ_STRNCASECMP |
392 | fi | 394 | fi |
395 | gl_FUNC_STRCASESTR | ||
396 | if test $HAVE_STRCASESTR = 0 || test $REPLACE_STRCASESTR = 1; then | ||
397 | AC_LIBOBJ([strcasestr]) | ||
398 | gl_PREREQ_STRCASESTR | ||
399 | fi | ||
400 | gl_FUNC_STRCASESTR_SIMPLE | ||
401 | if test $HAVE_STRCASESTR = 0 || test $REPLACE_STRCASESTR = 1; then | ||
402 | AC_LIBOBJ([strcasestr]) | ||
403 | gl_PREREQ_STRCASESTR | ||
404 | fi | ||
405 | gl_STRING_MODULE_INDICATOR([strcasestr]) | ||
393 | gl_FUNC_STRERROR | 406 | gl_FUNC_STRERROR |
394 | if test $REPLACE_STRERROR = 1; then | 407 | if test $REPLACE_STRERROR = 1; then |
395 | AC_LIBOBJ([strerror]) | 408 | AC_LIBOBJ([strerror]) |
@@ -723,6 +736,7 @@ AC_DEFUN([gl_FILE_LIST], [ | |||
723 | lib/stdlib.in.h | 736 | lib/stdlib.in.h |
724 | lib/str-two-way.h | 737 | lib/str-two-way.h |
725 | lib/strcasecmp.c | 738 | lib/strcasecmp.c |
739 | lib/strcasestr.c | ||
726 | lib/streq.h | 740 | lib/streq.h |
727 | lib/strerror-override.c | 741 | lib/strerror-override.c |
728 | lib/strerror-override.h | 742 | lib/strerror-override.h |
@@ -866,6 +880,7 @@ AC_DEFUN([gl_FILE_LIST], [ | |||
866 | m4/stdio_h.m4 | 880 | m4/stdio_h.m4 |
867 | m4/stdlib_h.m4 | 881 | m4/stdlib_h.m4 |
868 | m4/strcase.m4 | 882 | m4/strcase.m4 |
883 | m4/strcasestr.m4 | ||
869 | m4/strerror.m4 | 884 | m4/strerror.m4 |
870 | m4/string_h.m4 | 885 | m4/string_h.m4 |
871 | m4/strings_h.m4 | 886 | m4/strings_h.m4 |
diff --git a/gl/m4/strcasestr.m4 b/gl/m4/strcasestr.m4 new file mode 100644 index 0000000..8681a6a --- /dev/null +++ b/gl/m4/strcasestr.m4 | |||
@@ -0,0 +1,142 @@ | |||
1 | # strcasestr.m4 serial 21 | ||
2 | dnl Copyright (C) 2005, 2007-2013 Free Software Foundation, Inc. | ||
3 | dnl This file is free software; the Free Software Foundation | ||
4 | dnl gives unlimited permission to copy and/or distribute it, | ||
5 | dnl with or without modifications, as long as this notice is preserved. | ||
6 | |||
7 | dnl Check that strcasestr is present and works. | ||
8 | AC_DEFUN([gl_FUNC_STRCASESTR_SIMPLE], | ||
9 | [ | ||
10 | AC_REQUIRE([gl_HEADER_STRING_H_DEFAULTS]) | ||
11 | |||
12 | dnl Persuade glibc <string.h> to declare strcasestr(). | ||
13 | AC_REQUIRE([AC_USE_SYSTEM_EXTENSIONS]) | ||
14 | |||
15 | AC_REQUIRE([gl_FUNC_MEMCHR]) | ||
16 | AC_CHECK_FUNCS([strcasestr]) | ||
17 | if test $ac_cv_func_strcasestr = no; then | ||
18 | HAVE_STRCASESTR=0 | ||
19 | else | ||
20 | if test "$gl_cv_func_memchr_works" != yes; then | ||
21 | REPLACE_STRCASESTR=1 | ||
22 | else | ||
23 | dnl Detect http://sourceware.org/bugzilla/show_bug.cgi?id=12092. | ||
24 | AC_CACHE_CHECK([whether strcasestr works], | ||
25 | [gl_cv_func_strcasestr_works_always], | ||
26 | [AC_RUN_IFELSE([AC_LANG_PROGRAM([[ | ||
27 | #include <string.h> /* for strcasestr */ | ||
28 | #define P "_EF_BF_BD" | ||
29 | #define HAYSTACK "F_BD_CE_BD" P P P P "_C3_88_20" P P P "_C3_A7_20" P | ||
30 | #define NEEDLE P P P P P | ||
31 | ]], [[return !!strcasestr (HAYSTACK, NEEDLE); | ||
32 | ]])], | ||
33 | [gl_cv_func_strcasestr_works_always=yes], | ||
34 | [gl_cv_func_strcasestr_works_always=no], | ||
35 | [dnl glibc 2.12 and cygwin 1.7.7 have a known bug. uClibc is not | ||
36 | dnl affected, since it uses different source code for strcasestr | ||
37 | dnl than glibc. | ||
38 | dnl Assume that it works on all other platforms, even if it is not | ||
39 | dnl linear. | ||
40 | AC_EGREP_CPP([Lucky user], | ||
41 | [ | ||
42 | #ifdef __GNU_LIBRARY__ | ||
43 | #include <features.h> | ||
44 | #if ((__GLIBC__ == 2 && __GLIBC_MINOR__ > 12) || (__GLIBC__ > 2)) \ | ||
45 | || defined __UCLIBC__ | ||
46 | Lucky user | ||
47 | #endif | ||
48 | #elif defined __CYGWIN__ | ||
49 | #include <cygwin/version.h> | ||
50 | #if CYGWIN_VERSION_DLL_COMBINED > CYGWIN_VERSION_DLL_MAKE_COMBINED (1007, 7) | ||
51 | Lucky user | ||
52 | #endif | ||
53 | #else | ||
54 | Lucky user | ||
55 | #endif | ||
56 | ], | ||
57 | [gl_cv_func_strcasestr_works_always="guessing yes"], | ||
58 | [gl_cv_func_strcasestr_works_always="guessing no"]) | ||
59 | ]) | ||
60 | ]) | ||
61 | case "$gl_cv_func_strcasestr_works_always" in | ||
62 | *yes) ;; | ||
63 | *) | ||
64 | REPLACE_STRCASESTR=1 | ||
65 | ;; | ||
66 | esac | ||
67 | fi | ||
68 | fi | ||
69 | ]) # gl_FUNC_STRCASESTR_SIMPLE | ||
70 | |||
71 | dnl Additionally, check that strcasestr is efficient. | ||
72 | AC_DEFUN([gl_FUNC_STRCASESTR], | ||
73 | [ | ||
74 | AC_REQUIRE([gl_FUNC_STRCASESTR_SIMPLE]) | ||
75 | if test $HAVE_STRCASESTR = 1 && test $REPLACE_STRCASESTR = 0; then | ||
76 | AC_CACHE_CHECK([whether strcasestr works in linear time], | ||
77 | [gl_cv_func_strcasestr_linear], | ||
78 | [AC_RUN_IFELSE([AC_LANG_PROGRAM([[ | ||
79 | #include <signal.h> /* for signal */ | ||
80 | #include <string.h> /* for strcasestr */ | ||
81 | #include <stdlib.h> /* for malloc */ | ||
82 | #include <unistd.h> /* for alarm */ | ||
83 | static void quit (int sig) { exit (sig + 128); } | ||
84 | ]], [[ | ||
85 | int result = 0; | ||
86 | size_t m = 1000000; | ||
87 | char *haystack = (char *) malloc (2 * m + 2); | ||
88 | char *needle = (char *) malloc (m + 2); | ||
89 | /* Failure to compile this test due to missing alarm is okay, | ||
90 | since all such platforms (mingw) also lack strcasestr. */ | ||
91 | signal (SIGALRM, quit); | ||
92 | alarm (5); | ||
93 | /* Check for quadratic performance. */ | ||
94 | if (haystack && needle) | ||
95 | { | ||
96 | memset (haystack, 'A', 2 * m); | ||
97 | haystack[2 * m] = 'B'; | ||
98 | haystack[2 * m + 1] = 0; | ||
99 | memset (needle, 'A', m); | ||
100 | needle[m] = 'B'; | ||
101 | needle[m + 1] = 0; | ||
102 | if (!strcasestr (haystack, needle)) | ||
103 | result |= 1; | ||
104 | } | ||
105 | return result; | ||
106 | ]])], | ||
107 | [gl_cv_func_strcasestr_linear=yes], [gl_cv_func_strcasestr_linear=no], | ||
108 | [dnl Only glibc > 2.12 and cygwin > 1.7.7 are known to have a | ||
109 | dnl strcasestr that works in linear time. | ||
110 | AC_EGREP_CPP([Lucky user], | ||
111 | [ | ||
112 | #include <features.h> | ||
113 | #ifdef __GNU_LIBRARY__ | ||
114 | #if ((__GLIBC__ == 2 && __GLIBC_MINOR__ > 12) || (__GLIBC__ > 2)) \ | ||
115 | && !defined __UCLIBC__ | ||
116 | Lucky user | ||
117 | #endif | ||
118 | #endif | ||
119 | #ifdef __CYGWIN__ | ||
120 | #include <cygwin/version.h> | ||
121 | #if CYGWIN_VERSION_DLL_COMBINED > CYGWIN_VERSION_DLL_MAKE_COMBINED (1007, 7) | ||
122 | Lucky user | ||
123 | #endif | ||
124 | #endif | ||
125 | ], | ||
126 | [gl_cv_func_strcasestr_linear="guessing yes"], | ||
127 | [gl_cv_func_strcasestr_linear="guessing no"]) | ||
128 | ]) | ||
129 | ]) | ||
130 | case "$gl_cv_func_strcasestr_linear" in | ||
131 | *yes) ;; | ||
132 | *) | ||
133 | REPLACE_STRCASESTR=1 | ||
134 | ;; | ||
135 | esac | ||
136 | fi | ||
137 | ]) # gl_FUNC_STRCASESTR | ||
138 | |||
139 | # Prerequisites of lib/strcasestr.c. | ||
140 | AC_DEFUN([gl_PREREQ_STRCASESTR], [ | ||
141 | : | ||
142 | ]) | ||
diff --git a/gl/strcasestr.c b/gl/strcasestr.c new file mode 100644 index 0000000..53474a4 --- /dev/null +++ b/gl/strcasestr.c | |||
@@ -0,0 +1,82 @@ | |||
1 | /* Case-insensitive searching in a string. | ||
2 | Copyright (C) 2005-2013 Free Software Foundation, Inc. | ||
3 | Written by Bruno Haible <bruno@clisp.org>, 2005. | ||
4 | |||
5 | This program is free software; you can redistribute it and/or modify | ||
6 | it under the terms of the GNU General Public License as published by | ||
7 | the Free Software Foundation; either version 3, or (at your option) | ||
8 | any later version. | ||
9 | |||
10 | This program is distributed in the hope that it will be useful, | ||
11 | but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
12 | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
13 | GNU General Public License for more details. | ||
14 | |||
15 | You should have received a copy of the GNU General Public License | ||
16 | along with this program; if not, see <http://www.gnu.org/licenses/>. */ | ||
17 | |||
18 | #include <config.h> | ||
19 | |||
20 | /* Specification. */ | ||
21 | #include <string.h> | ||
22 | |||
23 | #include <ctype.h> | ||
24 | #include <stdbool.h> | ||
25 | #include <strings.h> | ||
26 | |||
27 | #define TOLOWER(Ch) (isupper (Ch) ? tolower (Ch) : (Ch)) | ||
28 | |||
29 | /* Two-Way algorithm. */ | ||
30 | #define RETURN_TYPE char * | ||
31 | #define AVAILABLE(h, h_l, j, n_l) \ | ||
32 | (!memchr ((h) + (h_l), '\0', (j) + (n_l) - (h_l)) \ | ||
33 | && ((h_l) = (j) + (n_l))) | ||
34 | #define CANON_ELEMENT(c) TOLOWER (c) | ||
35 | #define CMP_FUNC(p1, p2, l) \ | ||
36 | strncasecmp ((const char *) (p1), (const char *) (p2), l) | ||
37 | #include "str-two-way.h" | ||
38 | |||
39 | /* Find the first occurrence of NEEDLE in HAYSTACK, using | ||
40 | case-insensitive comparison. This function gives unspecified | ||
41 | results in multibyte locales. */ | ||
42 | char * | ||
43 | strcasestr (const char *haystack_start, const char *needle_start) | ||
44 | { | ||
45 | const char *haystack = haystack_start; | ||
46 | const char *needle = needle_start; | ||
47 | size_t needle_len; /* Length of NEEDLE. */ | ||
48 | size_t haystack_len; /* Known minimum length of HAYSTACK. */ | ||
49 | bool ok = true; /* True if NEEDLE is prefix of HAYSTACK. */ | ||
50 | |||
51 | /* Determine length of NEEDLE, and in the process, make sure | ||
52 | HAYSTACK is at least as long (no point processing all of a long | ||
53 | NEEDLE if HAYSTACK is too short). */ | ||
54 | while (*haystack && *needle) | ||
55 | { | ||
56 | ok &= (TOLOWER ((unsigned char) *haystack) | ||
57 | == TOLOWER ((unsigned char) *needle)); | ||
58 | haystack++; | ||
59 | needle++; | ||
60 | } | ||
61 | if (*needle) | ||
62 | return NULL; | ||
63 | if (ok) | ||
64 | return (char *) haystack_start; | ||
65 | needle_len = needle - needle_start; | ||
66 | haystack = haystack_start + 1; | ||
67 | haystack_len = needle_len - 1; | ||
68 | |||
69 | /* Perform the search. Abstract memory is considered to be an array | ||
70 | of 'unsigned char' values, not an array of 'char' values. See | ||
71 | ISO C 99 section 6.2.6.1. */ | ||
72 | if (needle_len < LONG_NEEDLE_THRESHOLD) | ||
73 | return two_way_short_needle ((const unsigned char *) haystack, | ||
74 | haystack_len, | ||
75 | (const unsigned char *) needle_start, | ||
76 | needle_len); | ||
77 | return two_way_long_needle ((const unsigned char *) haystack, haystack_len, | ||
78 | (const unsigned char *) needle_start, | ||
79 | needle_len); | ||
80 | } | ||
81 | |||
82 | #undef LONG_NEEDLE_THRESHOLD | ||
diff --git a/plugins-root/check_dhcp.c b/plugins-root/check_dhcp.c index 3723e61..88b7ca1 100644 --- a/plugins-root/check_dhcp.c +++ b/plugins-root/check_dhcp.c | |||
@@ -229,7 +229,7 @@ struct in_addr requested_address; | |||
229 | 229 | ||
230 | int process_arguments(int, char **); | 230 | int process_arguments(int, char **); |
231 | int call_getopt(int, char **); | 231 | int call_getopt(int, char **); |
232 | int validate_arguments(void); | 232 | int validate_arguments(int, int); |
233 | void print_usage(void); | 233 | void print_usage(void); |
234 | void print_help(void); | 234 | void print_help(void); |
235 | 235 | ||
@@ -463,10 +463,9 @@ int send_dhcp_discover(int sock){ | |||
463 | discover_packet.hlen=ETHERNET_HARDWARE_ADDRESS_LENGTH; | 463 | discover_packet.hlen=ETHERNET_HARDWARE_ADDRESS_LENGTH; |
464 | 464 | ||
465 | /* | 465 | /* |
466 | * transaction ID is supposed to be random. We won't use the address so | 466 | * transaction ID is supposed to be random. |
467 | * we don't care about high entropy here. time(2) is good enough. | ||
468 | */ | 467 | */ |
469 | srand(time(NULL)); | 468 | srand(time(NULL)^getpid()); |
470 | packet_xid=random(); | 469 | packet_xid=random(); |
471 | discover_packet.xid=htonl(packet_xid); | 470 | discover_packet.xid=htonl(packet_xid); |
472 | 471 | ||
@@ -692,17 +691,11 @@ int receive_dhcp_packet(void *buffer, int buffer_size, int sock, int timeout, st | |||
692 | } | 691 | } |
693 | 692 | ||
694 | else{ | 693 | else{ |
695 | |||
696 | /* why do we need to peek first? i don't know, its a hack. without it, the source address of the first packet received was | ||
697 | not being interpreted correctly. sigh... */ | ||
698 | bzero(&source_address,sizeof(source_address)); | 694 | bzero(&source_address,sizeof(source_address)); |
699 | address_size=sizeof(source_address); | 695 | address_size=sizeof(source_address); |
700 | recv_result=recvfrom(sock,(char *)buffer,buffer_size,MSG_PEEK,(struct sockaddr *)&source_address,&address_size); | 696 | recv_result=recvfrom(sock,(char *)buffer,buffer_size,MSG_PEEK,(struct sockaddr *)&source_address,&address_size); |
701 | if(verbose) | 697 | if(verbose) |
702 | printf("recv_result_1: %d\n",recv_result); | 698 | printf("recv_result: %d\n",recv_result); |
703 | recv_result=recvfrom(sock,(char *)buffer,buffer_size,0,(struct sockaddr *)&source_address,&address_size); | ||
704 | if(verbose) | ||
705 | printf("recv_result_2: %d\n",recv_result); | ||
706 | 699 | ||
707 | if(recv_result==-1){ | 700 | if(recv_result==-1){ |
708 | if(verbose){ | 701 | if(verbose){ |
@@ -1059,29 +1052,19 @@ int get_results(void){ | |||
1059 | 1052 | ||
1060 | /* process command-line arguments */ | 1053 | /* process command-line arguments */ |
1061 | int process_arguments(int argc, char **argv){ | 1054 | int process_arguments(int argc, char **argv){ |
1062 | int c; | 1055 | int arg_index; |
1063 | 1056 | ||
1064 | if(argc<1) | 1057 | if(argc<1) |
1065 | return ERROR; | 1058 | return ERROR; |
1066 | 1059 | ||
1067 | c=0; | 1060 | arg_index = call_getopt(argc,argv); |
1068 | while((c+=(call_getopt(argc-c,&argv[c])))<argc){ | 1061 | return validate_arguments(argc,arg_index); |
1069 | |||
1070 | /* | ||
1071 | if(is_option(argv[c])) | ||
1072 | continue; | ||
1073 | */ | ||
1074 | } | ||
1075 | |||
1076 | return validate_arguments(); | ||
1077 | } | 1062 | } |
1078 | 1063 | ||
1079 | 1064 | ||
1080 | 1065 | ||
1081 | int call_getopt(int argc, char **argv){ | 1066 | int call_getopt(int argc, char **argv){ |
1082 | int c=0; | 1067 | extern int optind; |
1083 | int i=0; | ||
1084 | |||
1085 | int option_index = 0; | 1068 | int option_index = 0; |
1086 | static struct option long_options[] = | 1069 | static struct option long_options[] = |
1087 | { | 1070 | { |
@@ -1098,25 +1081,14 @@ int call_getopt(int argc, char **argv){ | |||
1098 | }; | 1081 | }; |
1099 | 1082 | ||
1100 | while(1){ | 1083 | while(1){ |
1101 | c=getopt_long(argc,argv,"+hVvt:s:r:t:i:m:u",long_options,&option_index); | 1084 | int c=0; |
1102 | 1085 | ||
1103 | i++; | 1086 | c=getopt_long(argc,argv,"+hVvt:s:r:t:i:m:u",long_options,&option_index); |
1104 | 1087 | ||
1105 | if(c==-1||c==EOF||c==1) | 1088 | if(c==-1||c==EOF||c==1) |
1106 | break; | 1089 | break; |
1107 | 1090 | ||
1108 | switch(c){ | 1091 | switch(c){ |
1109 | case 'w': | ||
1110 | case 'r': | ||
1111 | case 't': | ||
1112 | case 'i': | ||
1113 | i++; | ||
1114 | break; | ||
1115 | default: | ||
1116 | break; | ||
1117 | } | ||
1118 | |||
1119 | switch(c){ | ||
1120 | 1092 | ||
1121 | case 's': /* DHCP server address */ | 1093 | case 's': /* DHCP server address */ |
1122 | resolve_host(optarg,&dhcp_ip); | 1094 | resolve_host(optarg,&dhcp_ip); |
@@ -1181,12 +1153,14 @@ int call_getopt(int argc, char **argv){ | |||
1181 | break; | 1153 | break; |
1182 | } | 1154 | } |
1183 | } | 1155 | } |
1184 | 1156 | return optind; | |
1185 | return i; | ||
1186 | } | 1157 | } |
1187 | 1158 | ||
1188 | 1159 | ||
1189 | int validate_arguments(void){ | 1160 | int validate_arguments(int argc, int arg_index){ |
1161 | |||
1162 | if(argc-optind > 0) | ||
1163 | usage(_("Got unexpected non-option argument")); | ||
1190 | 1164 | ||
1191 | return OK; | 1165 | return OK; |
1192 | } | 1166 | } |
diff --git a/plugins-root/pst3.c b/plugins-root/pst3.c index ee9d108..c3589f0 100644 --- a/plugins-root/pst3.c +++ b/plugins-root/pst3.c | |||
@@ -139,8 +139,10 @@ try_again: | |||
139 | if((ps_fd = open(ps_name, O_RDONLY)) == -1) | 139 | if((ps_fd = open(ps_name, O_RDONLY)) == -1) |
140 | continue; | 140 | continue; |
141 | 141 | ||
142 | if((as_fd = open(as_name, O_RDONLY)) == -1) | 142 | if((as_fd = open(as_name, O_RDONLY)) == -1) { |
143 | close(ps_fd); | ||
143 | continue; | 144 | continue; |
145 | } | ||
144 | 146 | ||
145 | if(read(ps_fd, &psinfo, sizeof(psinfo)) != sizeof(psinfo)) { | 147 | if(read(ps_fd, &psinfo, sizeof(psinfo)) != sizeof(psinfo)) { |
146 | int err = errno; | 148 | int err = errno; |
diff --git a/plugins-scripts/Makefile.am b/plugins-scripts/Makefile.am index 6970324..ea65aed 100644 --- a/plugins-scripts/Makefile.am +++ b/plugins-scripts/Makefile.am | |||
@@ -36,7 +36,8 @@ TESTS = @SCRIPT_TEST@ | |||
36 | test: | 36 | test: |
37 | perl -I $(top_builddir) -I $(top_srcdir) ../test.pl | 37 | perl -I $(top_builddir) -I $(top_srcdir) ../test.pl |
38 | perl -I $(top_builddir) -I $(top_srcdir) ../test.pl t/utils.t # utils.t is excluded from above, so manually ask to test | 38 | perl -I $(top_builddir) -I $(top_srcdir) ../test.pl t/utils.t # utils.t is excluded from above, so manually ask to test |
39 | for PLSCRIPTS in *.pl; do perl -wc $$PLSCRIPTS || exit 1; done | 39 | for SCRIPT in *.pl; do perl -wc $$SCRIPT || exit 1; done |
40 | set -e; for SCRIPT in *.sh; do sh -n $$SCRIPT || exit 1; done | ||
40 | 41 | ||
41 | test-debug: | 42 | test-debug: |
42 | NPTEST_DEBUG=1 HARNESS_VERBOSE=1 perl -I $(top_builddir) -I $(top_srcdir) ../test.pl | 43 | NPTEST_DEBUG=1 HARNESS_VERBOSE=1 perl -I $(top_builddir) -I $(top_srcdir) ../test.pl |
diff --git a/plugins-scripts/check_ifoperstatus.pl b/plugins-scripts/check_ifoperstatus.pl index 3eed4bc..9ede163 100755 --- a/plugins-scripts/check_ifoperstatus.pl +++ b/plugins-scripts/check_ifoperstatus.pl | |||
@@ -325,7 +325,7 @@ sub print_help() { | |||
325 | printf " (Implies the use of -I)\n"; | 325 | printf " (Implies the use of -I)\n"; |
326 | printf " -w (--warn =i|w|c) ignore|warn|crit if the interface is dormant (default critical)\n"; | 326 | printf " -w (--warn =i|w|c) ignore|warn|crit if the interface is dormant (default critical)\n"; |
327 | printf " -D (--admin-down =i|w|c) same for administratively down interfaces (default warning)\n"; | 327 | printf " -D (--admin-down =i|w|c) same for administratively down interfaces (default warning)\n"; |
328 | printf " -M (--maxmsgsize) Max message size - usefull only for v1 or v2c\n"; | 328 | printf " -M (--maxmsgsize) Max message size - useful only for v1 or v2c\n"; |
329 | printf " -t (--timeout) seconds before the plugin times out (default=$TIMEOUT)\n"; | 329 | printf " -t (--timeout) seconds before the plugin times out (default=$TIMEOUT)\n"; |
330 | printf " -V (--version) Plugin version\n"; | 330 | printf " -V (--version) Plugin version\n"; |
331 | printf " -h (--help) usage help \n\n"; | 331 | printf " -h (--help) usage help \n\n"; |
diff --git a/plugins-scripts/check_ifstatus.pl b/plugins-scripts/check_ifstatus.pl index 9f2f7c3..32984e5 100755 --- a/plugins-scripts/check_ifstatus.pl +++ b/plugins-scripts/check_ifstatus.pl | |||
@@ -280,7 +280,7 @@ sub print_help() { | |||
280 | printf " in hex with 0x prefix generated by using \"snmpkey\" utility\n"; | 280 | printf " in hex with 0x prefix generated by using \"snmpkey\" utility\n"; |
281 | printf " privacy password and authEngineID\n"; | 281 | printf " privacy password and authEngineID\n"; |
282 | printf " -P (--privproto) privacy protocol (DES or AES; default: DES)\n"; | 282 | printf " -P (--privproto) privacy protocol (DES or AES; default: DES)\n"; |
283 | printf " -M (--maxmsgsize) Max message size - usefull only for v1 or v2c\n"; | 283 | printf " -M (--maxmsgsize) Max message size - useful only for v1 or v2c\n"; |
284 | printf " -t (--timeout) seconds before the plugin times out (default=$TIMEOUT)\n"; | 284 | printf " -t (--timeout) seconds before the plugin times out (default=$TIMEOUT)\n"; |
285 | printf " -V (--version) Plugin version\n"; | 285 | printf " -V (--version) Plugin version\n"; |
286 | printf " -h (--help) usage help \n\n"; | 286 | printf " -h (--help) usage help \n\n"; |
diff --git a/plugins-scripts/check_ntp.pl b/plugins-scripts/check_ntp.pl deleted file mode 100755 index f400001..0000000 --- a/plugins-scripts/check_ntp.pl +++ /dev/null | |||
@@ -1,472 +0,0 @@ | |||
1 | #!@PERL@ -w | ||
2 | # | ||
3 | # (c)1999 Ian Cass, Knowledge Matters Ltd. | ||
4 | # Read the GNU copyright stuff for all the legalese | ||
5 | # | ||
6 | # Check NTP time servers plugin. This plugin requires the ntpdate utility to | ||
7 | # be installed on the system, however since it's part of the ntp suite, you | ||
8 | # should already have it installed. | ||
9 | # | ||
10 | # | ||
11 | # Nothing clever done in this program - its a very simple bare basics hack to | ||
12 | # get the job done. | ||
13 | # | ||
14 | # Things to do... | ||
15 | # check @words[9] for time differences greater than +/- x secs & return a | ||
16 | # warning. | ||
17 | # | ||
18 | # (c) 1999 Mark Jewiss, Knowledge Matters Limited | ||
19 | # 22-9-1999, 12:45 | ||
20 | # | ||
21 | # Modified script to accept 2 parameters or set defaults. | ||
22 | # Now issues warning or critical alert is time difference is greater than the | ||
23 | # time passed. | ||
24 | # | ||
25 | # These changes have not been tested completely due to the unavailability of a | ||
26 | # server with the incorrect time. | ||
27 | # | ||
28 | # (c) 1999 Bo Kersey, VirCIO - Managed Server Solutions <bo@vircio.com> | ||
29 | # 22-10-99, 12:17 | ||
30 | # | ||
31 | # Modified the script to give useage if no parameters are input. | ||
32 | # | ||
33 | # Modified the script to check for negative as well as positive | ||
34 | # time differences. | ||
35 | # | ||
36 | # Modified the script to work with ntpdate 3-5.93e Wed Apr 14 20:23:03 EDT 1999 | ||
37 | # | ||
38 | # Modified the script to work with ntpdate's that return adjust or offset... | ||
39 | # | ||
40 | # | ||
41 | # Script modified 2000 June 01 by William Pietri <william@bianca.com> | ||
42 | # | ||
43 | # Modified script to handle weird cases: | ||
44 | # o NTP server doesn't respond (e.g., has died) | ||
45 | # o Server has correct time but isn't suitable synchronization | ||
46 | # source. This happens while starting up and if contact | ||
47 | # with master has been lost. | ||
48 | # | ||
49 | # Modifed to run under Embedded Perl (sghosh@users.sf.net) | ||
50 | # - combined logic some blocks together.. | ||
51 | # | ||
52 | # Added ntpdate check for stratum 16 desynch peer (James Fidell) Feb 03, 2003 | ||
53 | # | ||
54 | # ntpdate - offset is in seconds | ||
55 | # changed ntpdc to ntpq - jitter/dispersion is in milliseconds | ||
56 | # | ||
57 | # Patch for for regex for stratum1 refid. | ||
58 | |||
59 | require 5.004; | ||
60 | use POSIX; | ||
61 | use strict; | ||
62 | use Getopt::Long; | ||
63 | use vars qw($opt_V $opt_h $opt_H $opt_t $opt_w $opt_c $opt_O $opt_j $opt_k $verbose $PROGNAME $def_jitter $ipv4 $ipv6); | ||
64 | use FindBin; | ||
65 | use lib "$FindBin::Bin"; | ||
66 | use utils qw($TIMEOUT %ERRORS &print_revision &support); | ||
67 | |||
68 | $PROGNAME="check_ntp"; | ||
69 | |||
70 | sub print_help (); | ||
71 | sub print_usage (); | ||
72 | |||
73 | $ENV{'PATH'}='@TRUSTED_PATH@'; | ||
74 | $ENV{'BASH_ENV'}=''; | ||
75 | $ENV{'ENV'}=''; | ||
76 | |||
77 | # defaults in sec | ||
78 | my $DEFAULT_OFFSET_WARN = 60; # 1 minute | ||
79 | my $DEFAULT_OFFSET_CRIT = 120; # 2 minutes | ||
80 | # default in millisec | ||
81 | my $DEFAULT_JITTER_WARN = 5000; # 5 sec | ||
82 | my $DEFAULT_JITTER_CRIT = 10000; # 10 sec | ||
83 | |||
84 | Getopt::Long::Configure('bundling'); | ||
85 | GetOptions | ||
86 | ("V" => \$opt_V, "version" => \$opt_V, | ||
87 | "h" => \$opt_h, "help" => \$opt_h, | ||
88 | "v" => \$verbose, "verbose" => \$verbose, | ||
89 | "4" => \$ipv4, "use-ipv4" => \$ipv4, | ||
90 | "6" => \$ipv6, "use-ipv6" => \$ipv6, | ||
91 | "w=f" => \$opt_w, "warning=f" => \$opt_w, # offset|adjust warning if above this number | ||
92 | "c=f" => \$opt_c, "critical=f" => \$opt_c, # offset|adjust critical if above this number | ||
93 | "O" => \$opt_O, "zero-offset" => \$opt_O, # zero-offset bad | ||
94 | "j=s" => \$opt_j, "jwarn=i" => \$opt_j, # jitter warning if above this number | ||
95 | "k=s" => \$opt_k, "jcrit=i" => \$opt_k, # jitter critical if above this number | ||
96 | "t=s" => \$opt_t, "timeout=i" => \$opt_t, | ||
97 | "H=s" => \$opt_H, "hostname=s" => \$opt_H); | ||
98 | |||
99 | if ($opt_V) { | ||
100 | print_revision($PROGNAME,'@NP_VERSION@'); | ||
101 | exit $ERRORS{'UNKNOWN'}; | ||
102 | } | ||
103 | |||
104 | if ($opt_h) { | ||
105 | print_help(); | ||
106 | exit $ERRORS{'UNKNOWN'}; | ||
107 | } | ||
108 | |||
109 | # jitter test params specified | ||
110 | if (defined $opt_j || defined $opt_k ) { | ||
111 | $def_jitter = 1; | ||
112 | } | ||
113 | |||
114 | $opt_H = shift unless ($opt_H); | ||
115 | my $host = $1 if ($opt_H && $opt_H =~ m/^([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+|[a-zA-Z][-a-zA-Z0-9]+(\.[a-zA-Z][-a-zA-Z0-9]+)*)$/); | ||
116 | unless ($host) { | ||
117 | print "No target host specified\n"; | ||
118 | print_usage(); | ||
119 | exit $ERRORS{'UNKNOWN'}; | ||
120 | } | ||
121 | |||
122 | my ($timeout, $owarn, $ocrit, $jwarn, $jcrit); | ||
123 | |||
124 | $timeout = $TIMEOUT; | ||
125 | ($opt_t) && ($opt_t =~ /^([0-9]+)$/) && ($timeout = $1); | ||
126 | |||
127 | $owarn = $DEFAULT_OFFSET_WARN; | ||
128 | ($opt_w) && ($opt_w =~ /^([0-9.]+)$/) && ($owarn = $1); | ||
129 | |||
130 | $ocrit = $DEFAULT_OFFSET_CRIT; | ||
131 | ($opt_c) && ($opt_c =~ /^([0-9.]+)$/) && ($ocrit = $1); | ||
132 | |||
133 | $jwarn = $DEFAULT_JITTER_WARN; | ||
134 | ($opt_j) && ($opt_j =~ /^([0-9]+)$/) && ($jwarn = $1); | ||
135 | |||
136 | $jcrit = $DEFAULT_JITTER_CRIT; | ||
137 | ($opt_k) && ($opt_k =~ /^([0-9]+)$/) && ($jcrit = $1); | ||
138 | |||
139 | if ($ocrit < $owarn ) { | ||
140 | print "Critical offset should be larger than warning offset\n"; | ||
141 | print_usage(); | ||
142 | exit $ERRORS{"UNKNOWN"}; | ||
143 | } | ||
144 | |||
145 | if ($def_jitter) { | ||
146 | if ($opt_k < $opt_j) { | ||
147 | print "Critical jitter should be larger than warning jitter\n"; | ||
148 | print_usage(); | ||
149 | exit $ERRORS{'UNKNOWN'}; | ||
150 | } | ||
151 | } | ||
152 | |||
153 | |||
154 | my $stratum = -1; | ||
155 | my $ignoreret = 0; | ||
156 | my $answer = undef; | ||
157 | my $offset = undef; | ||
158 | my $jitter = undef; | ||
159 | my $syspeer = undef; | ||
160 | my $candidate = 0; | ||
161 | my @candidates; | ||
162 | my $msg; # first line of output to print if format is invalid | ||
163 | |||
164 | my $state = $ERRORS{'UNKNOWN'}; | ||
165 | my $ntpdate_error = $ERRORS{'UNKNOWN'}; | ||
166 | my $jitter_error = $ERRORS{'UNKNOWN'}; | ||
167 | |||
168 | # some systems don't have a proper ntpq (migrated from ntpdc) | ||
169 | my $have_ntpq = undef; | ||
170 | if ($utils::PATH_TO_NTPQ && -x $utils::PATH_TO_NTPQ ) { | ||
171 | $have_ntpq = 1; | ||
172 | }else{ | ||
173 | $have_ntpq = 0; | ||
174 | } | ||
175 | |||
176 | # Just in case of problems, let's not hang Nagios | ||
177 | $SIG{'ALRM'} = sub { | ||
178 | print ("ERROR: No response from ntp server (alarm)\n"); | ||
179 | exit $ERRORS{"UNKNOWN"}; | ||
180 | }; | ||
181 | alarm($timeout); | ||
182 | |||
183 | # Determine protocol to be used for ntpdate and ntpq | ||
184 | my $ntpdate = $utils::PATH_TO_NTPDATE; | ||
185 | my $ntpq = $utils::PATH_TO_NTPQ; | ||
186 | if ($ipv4) { | ||
187 | $ntpdate .= " -4"; | ||
188 | $ntpq .= " -4"; | ||
189 | } | ||
190 | elsif ($ipv6) { | ||
191 | $ntpdate .= " -6"; | ||
192 | $ntpq .= " -6"; | ||
193 | } | ||
194 | # else don't use any flags | ||
195 | |||
196 | ### | ||
197 | ### | ||
198 | ### First, check ntpdate | ||
199 | ### | ||
200 | ### | ||
201 | |||
202 | if (!open (NTPDATE, $ntpdate . " -q $host 2>&1 |")) { | ||
203 | print "Could not open $ntpdate: $!\n"; | ||
204 | exit $ERRORS{"UNKNOWN"}; | ||
205 | } | ||
206 | |||
207 | my $out; | ||
208 | while (<NTPDATE>) { | ||
209 | #print if ($verbose); # noop | ||
210 | $msg = $_ unless ($msg); | ||
211 | $out .= "$_ "; | ||
212 | |||
213 | if (/stratum\s(\d+)/) { | ||
214 | $stratum = $1; | ||
215 | } | ||
216 | |||
217 | if (/(offset|adjust)\s+([-.\d]+)/i) { | ||
218 | $offset = $2; | ||
219 | |||
220 | # An offset of 0.000000 with an error is probably bogus. Actually, | ||
221 | # it's probably always bogus, but let's be paranoid here. | ||
222 | # Has been reported that 0.0000 happens in a production environment | ||
223 | # on Solaris 8 so this check should be taken out - SF tracker 1150777 | ||
224 | if (defined $opt_O ) { | ||
225 | if ($offset == 0) { undef $offset;} | ||
226 | } | ||
227 | |||
228 | $ntpdate_error = defined ($offset) ? $ERRORS{"OK"} : $ERRORS{"CRITICAL"}; | ||
229 | print "ntperr = $ntpdate_error \n" if $verbose; | ||
230 | |||
231 | } | ||
232 | |||
233 | if (/no server suitable for synchronization found/) { | ||
234 | if ($stratum == 16) { | ||
235 | $ntpdate_error = $ERRORS{"WARNING"}; | ||
236 | $msg = "Desynchronized peer server found"; | ||
237 | $ignoreret=1; | ||
238 | } | ||
239 | else { | ||
240 | $ntpdate_error = $ERRORS{"CRITICAL"}; | ||
241 | $msg = "No suitable peer server found - "; | ||
242 | } | ||
243 | } | ||
244 | |||
245 | } | ||
246 | $out =~ s/\n//g; | ||
247 | close (NTPDATE) || | ||
248 | die $! ? "$out - Error closing $ntpdate pipe: $!" | ||
249 | : "$out - Exit status: $? from $ntpdate\n"; | ||
250 | |||
251 | # declare an error if we also get a non-zero return code from ntpdate | ||
252 | # unless already set to critical | ||
253 | if ( $? && !$ignoreret ) { | ||
254 | print "stderr = $? : $! \n" if $verbose; | ||
255 | $ntpdate_error = $ntpdate_error == $ERRORS{"CRITICAL"} ? $ERRORS{"CRITICAL"} : $ERRORS{"UNKNOWN"} ; | ||
256 | print "ntperr = $ntpdate_error : $!\n" if $verbose; | ||
257 | } | ||
258 | |||
259 | ### | ||
260 | ### | ||
261 | ### Then scan xntpq/ntpq if it exists | ||
262 | ### and look in the 11th column for jitter | ||
263 | ### | ||
264 | # Field 1: Tally Code ( Space, 'x','.','-','+','#','*','o') | ||
265 | # Only match for '*' which implies sys.peer | ||
266 | # or 'o' which implies pps.peer | ||
267 | # If both exist, the last one is picked. | ||
268 | # Field 2: address of the remote peer | ||
269 | # Field 3: Refid of the clock (0.0.0.0 if unknown, WWWV/PPS/GPS/ACTS/USNO/PCS/... if Stratum1) | ||
270 | # Field 4: stratum (0-15) | ||
271 | # Field 5: Type of the peer: local (l), unicast (u), multicast (m) | ||
272 | # broadcast (b); not sure about multicast/broadcast | ||
273 | # Field 6: last packet receive (in seconds) | ||
274 | # Field 7: polling interval | ||
275 | # Field 8: reachability resgister (octal) | ||
276 | # Field 9: delay | ||
277 | # Field 10: offset | ||
278 | # Field 11: dispersion/jitter | ||
279 | # | ||
280 | # According to bug 773588 Some solaris xntpd implementations seemto match on | ||
281 | # "#" even though the docs say it exceeds maximum distance. Providing patch | ||
282 | # here which will generate a warining. | ||
283 | |||
284 | if ($have_ntpq) { | ||
285 | |||
286 | if ( open(NTPQ, $ntpq . " -np $host 2>&1 |") ) { | ||
287 | while (<NTPQ>) { | ||
288 | print $_ if ($verbose); | ||
289 | if ( /timed out/ ){ | ||
290 | $have_ntpq = 0 ; | ||
291 | last ; | ||
292 | } | ||
293 | # number of candidates on <host> for sys.peer | ||
294 | if (/^(\*|\+|\#|o])/) { | ||
295 | ++$candidate; | ||
296 | push (@candidates, $_); | ||
297 | print "Candidate count= $candidate\n" if ($verbose); | ||
298 | } | ||
299 | |||
300 | # match sys.peer or pps.peer | ||
301 | if (/^(\*|o)(\S+)\s+(\S+)\s+(\S+)\s+(\S+)\s+(\S+)\s+(\S+)\s+(\S+)\s+(\S+)\s+(\S+)\s+(\S+)/) { | ||
302 | $syspeer = $2; | ||
303 | $stratum = $4; | ||
304 | $jitter = $11; | ||
305 | print "match $_ \n" if $verbose; | ||
306 | if ($jitter > $jcrit) { | ||
307 | print "Jitter_crit = $11 :$jcrit\n" if ($verbose); | ||
308 | $jitter_error = $ERRORS{'CRITICAL'}; | ||
309 | } elsif ($jitter > $jwarn ) { | ||
310 | print "Jitter_warn = $11 :$jwarn\n" if ($verbose); | ||
311 | $jitter_error = $ERRORS{'WARNING'}; | ||
312 | } else { | ||
313 | $jitter_error = $ERRORS{'OK'}; | ||
314 | } | ||
315 | } else { | ||
316 | print "No match!\n" if $verbose; | ||
317 | $jitter = '(not parsed)'; | ||
318 | } | ||
319 | |||
320 | } | ||
321 | close NTPQ || | ||
322 | die $! ? "Error closing $ntpq pipe: $!" | ||
323 | : "Exit status: $? from $ntpq\n"; | ||
324 | |||
325 | # if we did not match sys.peer or pps.peer but matched # candidates only | ||
326 | # generate a warning | ||
327 | # based on bug id 773588 | ||
328 | unless (defined $syspeer) { | ||
329 | if ($#candidates >=0) { | ||
330 | foreach my $c (@candidates) { | ||
331 | $c =~ /^(#)([-0-9.\s]+)\s+([-0-9A-Za-z_().]+)\s+([-0-9.]+)\s+([lumb-]+)\s+([-0-9m.]+)\s+([-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)/; | ||
332 | $syspeer = $2; | ||
333 | $stratum = $4; | ||
334 | $jitter = $11; | ||
335 | print "candidate match $c \n" if $verbose; | ||
336 | if ($jitter > $jcrit) { | ||
337 | print "Candidate match - Jitter_crit = $11 :$jcrit\n" if ($verbose); | ||
338 | $jitter_error = $ERRORS{'CRITICAL'}; | ||
339 | }elsif ($jitter > $jwarn ) { | ||
340 | print "Candidate match - Jitter_warn = $11 :$jwarn \n" if ($verbose); | ||
341 | $jitter_error = $ERRORS{'WARNING'}; | ||
342 | } else { | ||
343 | $jitter_error = $ERRORS{'WARNING'}; | ||
344 | } | ||
345 | } | ||
346 | |||
347 | } | ||
348 | } | ||
349 | } | ||
350 | } | ||
351 | |||
352 | |||
353 | if ($ntpdate_error != $ERRORS{'OK'}) { | ||
354 | $state = $ntpdate_error; | ||
355 | if ($ntpdate_error == $ERRORS{'WARNING'} ) { | ||
356 | $answer = $msg; | ||
357 | } | ||
358 | else { | ||
359 | $answer = $msg . "Server for ntp probably down"; | ||
360 | } | ||
361 | |||
362 | if (defined($offset) && abs($offset) > $ocrit) { | ||
363 | $state = $ERRORS{'CRITICAL'}; | ||
364 | $answer = "Server Error and offset $offset sec > +/- $ocrit sec"; | ||
365 | } elsif (defined($offset) && abs($offset) > $owarn) { | ||
366 | $answer = "Server error and offset $offset sec > +/- $owarn sec"; | ||
367 | } elsif (defined($jitter) && abs($jitter) > $jcrit) { | ||
368 | $answer = "Server error and jitter $jitter msec > +/- $jcrit msec"; | ||
369 | } elsif (defined($jitter) && abs($jitter) > $jwarn) { | ||
370 | $answer = "Server error and jitter $jitter msec > +/- $jwarn msec"; | ||
371 | } | ||
372 | |||
373 | } elsif ($have_ntpq && $jitter_error != $ERRORS{'OK'}) { | ||
374 | $state = $jitter_error; | ||
375 | $answer = "Jitter $jitter too high"; | ||
376 | if (defined($offset) && abs($offset) > $ocrit) { | ||
377 | $state = $ERRORS{'CRITICAL'}; | ||
378 | $answer = "Jitter error and offset $offset sec > +/- $ocrit sec"; | ||
379 | } elsif (defined($offset) && abs($offset) > $owarn) { | ||
380 | $answer = "Jitter error and offset $offset sec > +/- $owarn sec"; | ||
381 | } elsif (defined($jitter) && abs($jitter) > $jcrit) { | ||
382 | $answer = "Jitter error and jitter $jitter msec > +/- $jcrit msec"; | ||
383 | } elsif (defined($jitter) && abs($jitter) > $jwarn) { | ||
384 | $answer = "Jitter error and jitter $jitter msec > +/- $jwarn msec"; | ||
385 | } | ||
386 | |||
387 | } elsif( !$have_ntpq ) { # no errors from ntpdate and no ntpq or ntpq timed out | ||
388 | if (abs($offset) > $ocrit) { | ||
389 | $state = $ERRORS{'CRITICAL'}; | ||
390 | $answer = "Offset $offset sec > +/- $ocrit sec"; | ||
391 | } elsif (abs($offset) > $owarn) { | ||
392 | $state = $ERRORS{'WARNING'}; | ||
393 | $answer = "Offset $offset sec > +/- $owarn sec"; | ||
394 | } elsif (( abs($offset) > $owarn) && $def_jitter ) { | ||
395 | $state = $ERRORS{'WARNING'}; | ||
396 | $answer = "Offset $offset sec > +/- $owarn sec, ntpq timed out"; | ||
397 | } elsif ( $def_jitter ) { | ||
398 | $state = $ERRORS{'WARNING'}; | ||
399 | $answer = "Offset $offset secs, ntpq timed out"; | ||
400 | } else{ | ||
401 | $state = $ERRORS{'OK'}; | ||
402 | $answer = "Offset $offset secs"; | ||
403 | } | ||
404 | |||
405 | |||
406 | |||
407 | } else { # no errors from ntpdate or ntpq | ||
408 | if (abs($offset) > $ocrit) { | ||
409 | $state = $ERRORS{'CRITICAL'}; | ||
410 | $answer = "Offset $offset sec > +/- $ocrit sec, jitter $jitter msec"; | ||
411 | } elsif (abs($jitter) > $jcrit ) { | ||
412 | $state = $ERRORS{'CRITICAL'}; | ||
413 | $answer = "Jitter $jitter msec> +/- $jcrit msec, offset $offset sec"; | ||
414 | } elsif (abs($offset) > $owarn) { | ||
415 | $state = $ERRORS{'WARNING'}; | ||
416 | $answer = "Offset $offset sec > +/- $owarn sec, jitter $jitter msec"; | ||
417 | } elsif (abs($jitter) > $jwarn ) { | ||
418 | $state = $ERRORS{'WARNING'}; | ||
419 | $answer = "Jitter $jitter msec> +/- $jwarn msec, offset $offset sec"; | ||
420 | |||
421 | } else { | ||
422 | $state = $ERRORS{'OK'}; | ||
423 | $answer = "Offset $offset secs, jitter $jitter msec, peer is stratum $stratum"; | ||
424 | } | ||
425 | |||
426 | } | ||
427 | |||
428 | foreach my $key (keys %ERRORS) { | ||
429 | if ($state==$ERRORS{$key}) { | ||
430 | # print ("NTP $key: $answer"); | ||
431 | print ("NTP $key: $answer|offset=$offset, jitter=" . $jitter/1000 . ",peer_stratum=$stratum\n"); | ||
432 | last; | ||
433 | } | ||
434 | } | ||
435 | exit $state; | ||
436 | |||
437 | |||
438 | #### | ||
439 | #### subs | ||
440 | |||
441 | sub print_usage () { | ||
442 | print "Usage: $PROGNAME -H <host> [-46] [-O] [-w <warn>] [-c <crit>] [-j <warn>] [-k <crit>] [-v verbose]\n"; | ||
443 | } | ||
444 | |||
445 | sub print_help () { | ||
446 | print_revision($PROGNAME,'@NP_VERSION@'); | ||
447 | print "Copyright (c) 2003 Bo Kersey/Karl DeBisschop\n"; | ||
448 | print "\n"; | ||
449 | print_usage(); | ||
450 | print " | ||
451 | Checks the local timestamp offset versus <host> with ntpdate | ||
452 | Checks the jitter/dispersion of clock signal between <host> and its sys.peer with ntpq\n | ||
453 | -O (--zero-offset) | ||
454 | A zero offset on \"ntpdate\" will generate a CRITICAL.\n | ||
455 | -w (--warning) | ||
456 | Clock offset in seconds at which a warning message will be generated.\n Defaults to $DEFAULT_OFFSET_WARN. | ||
457 | -c (--critical) | ||
458 | Clock offset in seconds at which a critical message will be generated.\n Defaults to $DEFAULT_OFFSET_CRIT. | ||
459 | -j (--jwarn) | ||
460 | Clock jitter in milliseconds at which a warning message will be generated.\n Defaults to $DEFAULT_JITTER_WARN. | ||
461 | -k (--jcrit) | ||
462 | Clock jitter in milliseconds at which a critical message will be generated.\n Defaults to $DEFAULT_JITTER_CRIT. | ||
463 | |||
464 | If jitter/dispersion is specified with -j or -k and ntpq times out, then a | ||
465 | warning is returned.\n | ||
466 | -4 (--use-ipv4) | ||
467 | Use IPv4 connection | ||
468 | -6 (--use-ipv6) | ||
469 | Use IPv6 connection | ||
470 | \n"; | ||
471 | support(); | ||
472 | } | ||
diff --git a/plugins/Makefile.am b/plugins/Makefile.am index 41906c5..0ddf9bd 100644 --- a/plugins/Makefile.am +++ b/plugins/Makefile.am | |||
@@ -71,7 +71,7 @@ check_apt_LDADD = $(BASEOBJS) | |||
71 | check_cluster_LDADD = $(BASEOBJS) | 71 | check_cluster_LDADD = $(BASEOBJS) |
72 | check_dbi_LDADD = $(NETLIBS) $(DBILIBS) | 72 | check_dbi_LDADD = $(NETLIBS) $(DBILIBS) |
73 | check_dig_LDADD = $(NETLIBS) | 73 | check_dig_LDADD = $(NETLIBS) |
74 | check_disk_LDADD = $(BASEOBJS) $(THREADLIBS) | 74 | check_disk_LDADD = $(BASEOBJS) |
75 | check_dns_LDADD = $(NETLIBS) | 75 | check_dns_LDADD = $(NETLIBS) |
76 | check_dummy_LDADD = $(BASEOBJS) | 76 | check_dummy_LDADD = $(BASEOBJS) |
77 | check_fping_LDADD = $(NETLIBS) | 77 | check_fping_LDADD = $(NETLIBS) |
diff --git a/plugins/check_by_ssh.c b/plugins/check_by_ssh.c index 04bce38..13d8bc3 100644 --- a/plugins/check_by_ssh.c +++ b/plugins/check_by_ssh.c | |||
@@ -100,6 +100,13 @@ main (int argc, char **argv) | |||
100 | 100 | ||
101 | result = cmd_run_array (commargv, &chld_out, &chld_err, 0); | 101 | result = cmd_run_array (commargv, &chld_out, &chld_err, 0); |
102 | 102 | ||
103 | if (verbose) { | ||
104 | for(i = 0; i < chld_out.lines; i++) | ||
105 | printf("stdout: %s\n", chld_out.line[i]); | ||
106 | for(i = 0; i < chld_err.lines; i++) | ||
107 | printf("stderr: %s\n", chld_err.line[i]); | ||
108 | } | ||
109 | |||
103 | if (skip_stdout == -1) /* --skip-stdout specified without argument */ | 110 | if (skip_stdout == -1) /* --skip-stdout specified without argument */ |
104 | skip_stdout = chld_out.lines; | 111 | skip_stdout = chld_out.lines; |
105 | if (skip_stderr == -1) /* --skip-stderr specified without argument */ | 112 | if (skip_stderr == -1) /* --skip-stderr specified without argument */ |
diff --git a/plugins/check_dig.c b/plugins/check_dig.c index db4b20e..da4f0de 100644 --- a/plugins/check_dig.c +++ b/plugins/check_dig.c | |||
@@ -48,7 +48,7 @@ void print_usage (void); | |||
48 | 48 | ||
49 | #define UNDEFINED 0 | 49 | #define UNDEFINED 0 |
50 | #define DEFAULT_PORT 53 | 50 | #define DEFAULT_PORT 53 |
51 | #define DEFAULT_TRIES 3 | 51 | #define DEFAULT_TRIES 2 |
52 | 52 | ||
53 | char *query_address = NULL; | 53 | char *query_address = NULL; |
54 | char *record_type = "A"; | 54 | char *record_type = "A"; |
@@ -94,7 +94,7 @@ main (int argc, char **argv) | |||
94 | timeout_interval_dig = timeout_interval / number_tries + number_tries; | 94 | timeout_interval_dig = timeout_interval / number_tries + number_tries; |
95 | 95 | ||
96 | /* get the command to run */ | 96 | /* get the command to run */ |
97 | xasprintf (&command_line, "%s %s %s -p %d @%s %s %s +tries=%d +time=%d", | 97 | xasprintf (&command_line, "%s %s %s -p %d @%s %s %s +retry=%d +time=%d", |
98 | PATH_TO_DIG, dig_args, query_transport, server_port, dns_server, query_address, record_type, number_tries, timeout_interval_dig); | 98 | PATH_TO_DIG, dig_args, query_transport, server_port, dns_server, query_address, record_type, number_tries, timeout_interval_dig); |
99 | 99 | ||
100 | alarm (timeout_interval); | 100 | alarm (timeout_interval); |
@@ -125,7 +125,7 @@ main (int argc, char **argv) | |||
125 | if (verbose) | 125 | if (verbose) |
126 | printf ("%s\n", chld_out.line[i]); | 126 | printf ("%s\n", chld_out.line[i]); |
127 | 127 | ||
128 | if (strstr (chld_out.line[i], (expected_address == NULL ? query_address : expected_address)) != NULL) { | 128 | if (strcasestr (chld_out.line[i], (expected_address == NULL ? query_address : expected_address)) != NULL) { |
129 | msg = chld_out.line[i]; | 129 | msg = chld_out.line[i]; |
130 | result = STATE_OK; | 130 | result = STATE_OK; |
131 | 131 | ||
diff --git a/plugins/check_disk.c b/plugins/check_disk.c index 9693bad..4b5ba5f 100644 --- a/plugins/check_disk.c +++ b/plugins/check_disk.c | |||
@@ -51,9 +51,6 @@ const char *email = "devel@monitoring-plugins.org"; | |||
51 | # include <limits.h> | 51 | # include <limits.h> |
52 | #endif | 52 | #endif |
53 | #include "regex.h" | 53 | #include "regex.h" |
54 | #if HAVE_PTHREAD_H | ||
55 | # include <pthread.h> | ||
56 | #endif | ||
57 | 54 | ||
58 | #ifdef __CYGWIN__ | 55 | #ifdef __CYGWIN__ |
59 | # include <windows.h> | 56 | # include <windows.h> |
@@ -61,9 +58,6 @@ const char *email = "devel@monitoring-plugins.org"; | |||
61 | # define ERROR -1 | 58 | # define ERROR -1 |
62 | #endif | 59 | #endif |
63 | 60 | ||
64 | /* If nonzero, show inode information. */ | ||
65 | static int inode_format = 1; | ||
66 | |||
67 | /* If nonzero, show even filesystems with zero size or | 61 | /* If nonzero, show even filesystems with zero size or |
68 | uninteresting types. */ | 62 | uninteresting types. */ |
69 | static int show_all_fs = 1; | 63 | static int show_all_fs = 1; |
@@ -133,7 +127,6 @@ void print_help (void); | |||
133 | void print_usage (void); | 127 | void print_usage (void); |
134 | double calculate_percent(uintmax_t, uintmax_t); | 128 | double calculate_percent(uintmax_t, uintmax_t); |
135 | void stat_path (struct parameter_list *p); | 129 | void stat_path (struct parameter_list *p); |
136 | void *do_stat_path (void *p); | ||
137 | void get_stats (struct parameter_list *p, struct fs_usage *fsp); | 130 | void get_stats (struct parameter_list *p, struct fs_usage *fsp); |
138 | void get_path_stats (struct parameter_list *p, struct fs_usage *fsp); | 131 | void get_path_stats (struct parameter_list *p, struct fs_usage *fsp); |
139 | 132 | ||
@@ -172,6 +165,7 @@ main (int argc, char **argv) | |||
172 | int result = STATE_UNKNOWN; | 165 | int result = STATE_UNKNOWN; |
173 | int disk_result = STATE_UNKNOWN; | 166 | int disk_result = STATE_UNKNOWN; |
174 | char *output; | 167 | char *output; |
168 | char *ko_output; | ||
175 | char *details; | 169 | char *details; |
176 | char *perf; | 170 | char *perf; |
177 | char *preamble; | 171 | char *preamble; |
@@ -182,7 +176,7 @@ main (int argc, char **argv) | |||
182 | int temp_result; | 176 | int temp_result; |
183 | 177 | ||
184 | struct mount_entry *me; | 178 | struct mount_entry *me; |
185 | struct fs_usage fsp, tmpfsp; | 179 | struct fs_usage fsp; |
186 | struct parameter_list *temp_list, *path; | 180 | struct parameter_list *temp_list, *path; |
187 | 181 | ||
188 | #ifdef __CYGWIN__ | 182 | #ifdef __CYGWIN__ |
@@ -191,6 +185,7 @@ main (int argc, char **argv) | |||
191 | 185 | ||
192 | preamble = strdup (" - free space:"); | 186 | preamble = strdup (" - free space:"); |
193 | output = strdup (""); | 187 | output = strdup (""); |
188 | ko_output = strdup (""); | ||
194 | details = strdup (""); | 189 | details = strdup (""); |
195 | perf = strdup (""); | 190 | perf = strdup (""); |
196 | stat_buf = malloc(sizeof *stat_buf); | 191 | stat_buf = malloc(sizeof *stat_buf); |
@@ -355,9 +350,6 @@ main (int argc, char **argv) | |||
355 | TRUE, 0, | 350 | TRUE, 0, |
356 | TRUE, path->dtotal_units)); | 351 | TRUE, path->dtotal_units)); |
357 | 352 | ||
358 | if (disk_result==STATE_OK && erronly && !verbose) | ||
359 | continue; | ||
360 | |||
361 | if(disk_result && verbose >= 1) { | 353 | if(disk_result && verbose >= 1) { |
362 | xasprintf(&flag_header, " %s [", state_text (disk_result)); | 354 | xasprintf(&flag_header, " %s [", state_text (disk_result)); |
363 | } else { | 355 | } else { |
@@ -383,15 +375,27 @@ main (int argc, char **argv) | |||
383 | (unsigned long)w_df, (unsigned long)c_df, w_dfp, c_dfp); | 375 | (unsigned long)w_df, (unsigned long)c_df, w_dfp, c_dfp); |
384 | */ | 376 | */ |
385 | 377 | ||
378 | /* OS: #1420 save all not ok paths to different output, but only in case of error only option */ | ||
379 | if (disk_result!=STATE_OK && erronly) { | ||
380 | xasprintf (&ko_output, "%s%s %s %.0f %s (%.0f%%", | ||
381 | ko_output, flag_header, | ||
382 | (!strcmp(me->me_mountdir, "none") || display_mntp) ? me->me_devname : me->me_mountdir, | ||
383 | path->dfree_units, | ||
384 | units, | ||
385 | path->dfree_pct); | ||
386 | } | ||
387 | |||
386 | } | 388 | } |
387 | 389 | ||
390 | /* OS: #1420 only show offending paths if error only option is set, but show all paths if everything is ok */ | ||
391 | output = (erronly && result!=STATE_OK) ? ko_output : output; | ||
388 | } | 392 | } |
389 | 393 | ||
390 | if (verbose >= 2) | 394 | if (verbose >= 2) |
391 | xasprintf (&output, "%s%s", output, details); | 395 | xasprintf (&output, "%s%s", output, details); |
392 | 396 | ||
393 | 397 | ||
394 | printf ("DISK %s%s%s|%s\n", state_text (result), (erronly && result==STATE_OK) ? "" : preamble, output, perf); | 398 | printf ("DISK %s%s%s|%s\n", state_text (result), preamble, output, perf); |
395 | return result; | 399 | return result; |
396 | } | 400 | } |
397 | 401 | ||
@@ -427,9 +431,7 @@ process_arguments (int argc, char **argv) | |||
427 | int c, err; | 431 | int c, err; |
428 | struct parameter_list *se; | 432 | struct parameter_list *se; |
429 | struct parameter_list *temp_list = NULL, *previous = NULL; | 433 | struct parameter_list *temp_list = NULL, *previous = NULL; |
430 | struct parameter_list *temp_path_select_list = NULL; | 434 | struct mount_entry *me; |
431 | struct mount_entry *me, *temp_me; | ||
432 | int result = OK; | ||
433 | regex_t re; | 435 | regex_t re; |
434 | int cflags = REG_NOSUB | REG_EXTENDED; | 436 | int cflags = REG_NOSUB | REG_EXTENDED; |
435 | int default_cflags = cflags; | 437 | int default_cflags = cflags; |
@@ -972,44 +974,6 @@ print_usage (void) | |||
972 | void | 974 | void |
973 | stat_path (struct parameter_list *p) | 975 | stat_path (struct parameter_list *p) |
974 | { | 976 | { |
975 | #ifdef HAVE_PTHREAD_H | ||
976 | pthread_t stat_thread; | ||
977 | int statdone = 0; | ||
978 | int timer = timeout_interval; | ||
979 | struct timespec req, rem; | ||
980 | |||
981 | req.tv_sec = 0; | ||
982 | pthread_create(&stat_thread, NULL, do_stat_path, p); | ||
983 | while (timer-- > 0) { | ||
984 | req.tv_nsec = 10000000; | ||
985 | nanosleep(&req, &rem); | ||
986 | if (pthread_kill(stat_thread, 0)) { | ||
987 | statdone = 1; | ||
988 | break; | ||
989 | } else { | ||
990 | req.tv_nsec = 990000000; | ||
991 | nanosleep(&req, &rem); | ||
992 | } | ||
993 | } | ||
994 | if (statdone == 1) { | ||
995 | pthread_join(stat_thread, NULL); | ||
996 | } else { | ||
997 | pthread_detach(stat_thread); | ||
998 | if (verbose >= 3) | ||
999 | printf("stat did not return within %ds on %s\n", timeout_interval, p->name); | ||
1000 | printf("DISK %s - ", _("CRITICAL")); | ||
1001 | die (STATE_CRITICAL, _("%s %s: %s\n"), p->name, _("hangs"), _("Timeout")); | ||
1002 | } | ||
1003 | #else | ||
1004 | do_stat_path(p); | ||
1005 | #endif | ||
1006 | } | ||
1007 | |||
1008 | void * | ||
1009 | do_stat_path (void *in) | ||
1010 | { | ||
1011 | struct parameter_list *p = in; | ||
1012 | |||
1013 | /* Stat entry to check that dir exists and is accessible */ | 977 | /* Stat entry to check that dir exists and is accessible */ |
1014 | if (verbose >= 3) | 978 | if (verbose >= 3) |
1015 | printf("calling stat on %s\n", p->name); | 979 | printf("calling stat on %s\n", p->name); |
@@ -1019,7 +983,6 @@ do_stat_path (void *in) | |||
1019 | printf("DISK %s - ", _("CRITICAL")); | 983 | printf("DISK %s - ", _("CRITICAL")); |
1020 | die (STATE_CRITICAL, _("%s %s: %s\n"), p->name, _("is not accessible"), strerror(errno)); | 984 | die (STATE_CRITICAL, _("%s %s: %s\n"), p->name, _("is not accessible"), strerror(errno)); |
1021 | } | 985 | } |
1022 | return NULL; | ||
1023 | } | 986 | } |
1024 | 987 | ||
1025 | 988 | ||
diff --git a/plugins/check_dns.c b/plugins/check_dns.c index d6bd2c0..54ce7d1 100644 --- a/plugins/check_dns.c +++ b/plugins/check_dns.c | |||
@@ -81,7 +81,6 @@ main (int argc, char **argv) | |||
81 | double elapsed_time; | 81 | double elapsed_time; |
82 | long microsec; | 82 | long microsec; |
83 | struct timeval tv; | 83 | struct timeval tv; |
84 | int multi_address; | ||
85 | int parse_address = FALSE; /* This flag scans for Address: but only after Name: */ | 84 | int parse_address = FALSE; /* This flag scans for Address: but only after Name: */ |
86 | output chld_out, chld_err; | 85 | output chld_out, chld_err; |
87 | size_t i; | 86 | size_t i; |
@@ -127,7 +126,7 @@ main (int argc, char **argv) | |||
127 | if (verbose) | 126 | if (verbose) |
128 | puts(chld_out.line[i]); | 127 | puts(chld_out.line[i]); |
129 | 128 | ||
130 | if (strstr (chld_out.line[i], ".in-addr.arpa")) { | 129 | if (strcasestr (chld_out.line[i], ".in-addr.arpa")) { |
131 | if ((temp_buffer = strstr (chld_out.line[i], "name = "))) | 130 | if ((temp_buffer = strstr (chld_out.line[i], "name = "))) |
132 | addresses[n_addresses++] = strdup (temp_buffer + 7); | 131 | addresses[n_addresses++] = strdup (temp_buffer + 7); |
133 | else { | 132 | else { |
@@ -249,11 +248,6 @@ main (int argc, char **argv) | |||
249 | elapsed_time = (double)microsec / 1.0e6; | 248 | elapsed_time = (double)microsec / 1.0e6; |
250 | 249 | ||
251 | if (result == STATE_OK) { | 250 | if (result == STATE_OK) { |
252 | if (strchr (address, ',') == NULL) | ||
253 | multi_address = FALSE; | ||
254 | else | ||
255 | multi_address = TRUE; | ||
256 | |||
257 | result = get_status(elapsed_time, time_thresholds); | 251 | result = get_status(elapsed_time, time_thresholds); |
258 | if (result == STATE_OK) { | 252 | if (result == STATE_OK) { |
259 | printf ("DNS %s: ", _("OK")); | 253 | printf ("DNS %s: ", _("OK")); |
diff --git a/plugins/check_http.c b/plugins/check_http.c index 68b470c..e5ef7cc 100644 --- a/plugins/check_http.c +++ b/plugins/check_http.c | |||
@@ -91,10 +91,12 @@ struct timeval tv_temp; | |||
91 | 91 | ||
92 | int specify_port = FALSE; | 92 | int specify_port = FALSE; |
93 | int server_port = HTTP_PORT; | 93 | int server_port = HTTP_PORT; |
94 | int virtual_port = 0; | ||
94 | char server_port_text[6] = ""; | 95 | char server_port_text[6] = ""; |
95 | char server_type[6] = "http"; | 96 | char server_type[6] = "http"; |
96 | char *server_address; | 97 | char *server_address; |
97 | char *host_name; | 98 | char *host_name; |
99 | int host_name_length; | ||
98 | char *server_url; | 100 | char *server_url; |
99 | char *user_agent; | 101 | char *user_agent; |
100 | int server_url_length; | 102 | int server_url_length; |
@@ -343,9 +345,20 @@ process_arguments (int argc, char **argv) | |||
343 | parameters, like -S and -C combinations */ | 345 | parameters, like -S and -C combinations */ |
344 | use_ssl = TRUE; | 346 | use_ssl = TRUE; |
345 | if (c=='S' && optarg != NULL) { | 347 | if (c=='S' && optarg != NULL) { |
346 | ssl_version = atoi(optarg); | 348 | int got_plus = strchr(optarg, '+') != NULL; |
347 | if (ssl_version < 1 || ssl_version > 3) | 349 | |
348 | usage4 (_("Invalid option - Valid values for SSL Version are 1 (TLSv1), 2 (SSLv2) or 3 (SSLv3)")); | 350 | if (!strncmp (optarg, "1.2", 3)) |
351 | ssl_version = got_plus ? MP_TLSv1_2_OR_NEWER : MP_TLSv1_2; | ||
352 | else if (!strncmp (optarg, "1.1", 3)) | ||
353 | ssl_version = got_plus ? MP_TLSv1_1_OR_NEWER : MP_TLSv1_1; | ||
354 | else if (optarg[0] == '1') | ||
355 | ssl_version = got_plus ? MP_TLSv1_OR_NEWER : MP_TLSv1; | ||
356 | else if (optarg[0] == '3') | ||
357 | ssl_version = got_plus ? MP_SSLv3_OR_NEWER : MP_SSLv3; | ||
358 | else if (optarg[0] == '2') | ||
359 | ssl_version = got_plus ? MP_SSLv2_OR_NEWER : MP_SSLv2; | ||
360 | else | ||
361 | usage4 (_("Invalid option - Valid SSL/TLS versions: 2, 3, 1, 1.1, 1.2 (with optional '+' suffix)")); | ||
349 | } | 362 | } |
350 | if (specify_port == FALSE) | 363 | if (specify_port == FALSE) |
351 | server_port = HTTPS_PORT; | 364 | server_port = HTTPS_PORT; |
@@ -380,11 +393,25 @@ process_arguments (int argc, char **argv) | |||
380 | case 'H': /* Host Name (virtual host) */ | 393 | case 'H': /* Host Name (virtual host) */ |
381 | host_name = strdup (optarg); | 394 | host_name = strdup (optarg); |
382 | if (host_name[0] == '[') { | 395 | if (host_name[0] == '[') { |
383 | if ((p = strstr (host_name, "]:")) != NULL) /* [IPv6]:port */ | 396 | if ((p = strstr (host_name, "]:")) != NULL) { /* [IPv6]:port */ |
384 | server_port = atoi (p + 2); | 397 | virtual_port = atoi (p + 2); |
398 | /* cut off the port */ | ||
399 | host_name_length = strlen (host_name) - strlen (p) - 1; | ||
400 | free (host_name); | ||
401 | host_name = strndup (optarg, host_name_length); | ||
402 | if (specify_port == FALSE) | ||
403 | server_port = virtual_port; | ||
404 | } | ||
385 | } else if ((p = strchr (host_name, ':')) != NULL | 405 | } else if ((p = strchr (host_name, ':')) != NULL |
386 | && strchr (++p, ':') == NULL) /* IPv4:port or host:port */ | 406 | && strchr (++p, ':') == NULL) { /* IPv4:port or host:port */ |
387 | server_port = atoi (p); | 407 | virtual_port = atoi (p); |
408 | /* cut off the port */ | ||
409 | host_name_length = strlen (host_name) - strlen (p) - 1; | ||
410 | free (host_name); | ||
411 | host_name = strndup (optarg, host_name_length); | ||
412 | if (specify_port == FALSE) | ||
413 | server_port = virtual_port; | ||
414 | } | ||
388 | break; | 415 | break; |
389 | case 'I': /* Server IP-address */ | 416 | case 'I': /* Server IP-address */ |
390 | server_address = strdup (optarg); | 417 | server_address = strdup (optarg); |
@@ -539,9 +566,12 @@ process_arguments (int argc, char **argv) | |||
539 | if (http_method == NULL) | 566 | if (http_method == NULL) |
540 | http_method = strdup ("GET"); | 567 | http_method = strdup ("GET"); |
541 | 568 | ||
542 | if (client_cert && !client_privkey) | 569 | if (client_cert && !client_privkey) |
543 | usage4 (_("If you use a client certificate you must also specify a private key file")); | 570 | usage4 (_("If you use a client certificate you must also specify a private key file")); |
544 | 571 | ||
572 | if (virtual_port == 0) | ||
573 | virtual_port = server_port; | ||
574 | |||
545 | return TRUE; | 575 | return TRUE; |
546 | } | 576 | } |
547 | 577 | ||
@@ -911,8 +941,8 @@ check_http (void) | |||
911 | elapsed_time_ssl = (double)microsec_ssl / 1.0e6; | 941 | elapsed_time_ssl = (double)microsec_ssl / 1.0e6; |
912 | if (check_cert == TRUE) { | 942 | if (check_cert == TRUE) { |
913 | result = np_net_ssl_check_cert(days_till_exp_warn, days_till_exp_crit); | 943 | result = np_net_ssl_check_cert(days_till_exp_warn, days_till_exp_crit); |
914 | np_net_ssl_cleanup(); | ||
915 | if (sd) close(sd); | 944 | if (sd) close(sd); |
945 | np_net_ssl_cleanup(); | ||
916 | return result; | 946 | return result; |
917 | } | 947 | } |
918 | } | 948 | } |
@@ -947,13 +977,13 @@ check_http (void) | |||
947 | * 14.23). Some server applications/configurations cause trouble if the | 977 | * 14.23). Some server applications/configurations cause trouble if the |
948 | * (default) port is explicitly specified in the "Host:" header line. | 978 | * (default) port is explicitly specified in the "Host:" header line. |
949 | */ | 979 | */ |
950 | if ((use_ssl == FALSE && server_port == HTTP_PORT) || | 980 | if ((use_ssl == FALSE && virtual_port == HTTP_PORT) || |
951 | (use_ssl == TRUE && server_port == HTTPS_PORT) || | 981 | (use_ssl == TRUE && virtual_port == HTTPS_PORT) || |
952 | (server_address != NULL && strcmp(http_method, "CONNECT") == 0 | 982 | (server_address != NULL && strcmp(http_method, "CONNECT") == 0 |
953 | && host_name != NULL && use_ssl == TRUE)) | 983 | && host_name != NULL && use_ssl == TRUE)) |
954 | xasprintf (&buf, "%sHost: %s\r\n", buf, host_name); | 984 | xasprintf (&buf, "%sHost: %s\r\n", buf, host_name); |
955 | else | 985 | else |
956 | xasprintf (&buf, "%sHost: %s:%d\r\n", buf, host_name, server_port); | 986 | xasprintf (&buf, "%sHost: %s:%d\r\n", buf, host_name, virtual_port); |
957 | } | 987 | } |
958 | } | 988 | } |
959 | 989 | ||
@@ -1011,6 +1041,10 @@ check_http (void) | |||
1011 | microsec_firstbyte = deltime (tv_temp); | 1041 | microsec_firstbyte = deltime (tv_temp); |
1012 | elapsed_time_firstbyte = (double)microsec_firstbyte / 1.0e6; | 1042 | elapsed_time_firstbyte = (double)microsec_firstbyte / 1.0e6; |
1013 | } | 1043 | } |
1044 | while (pos = memchr(buffer, '\0', i)) { | ||
1045 | /* replace nul character with a blank */ | ||
1046 | *pos = ' '; | ||
1047 | } | ||
1014 | buffer[i] = '\0'; | 1048 | buffer[i] = '\0'; |
1015 | xasprintf (&full_page_new, "%s%s", full_page, buffer); | 1049 | xasprintf (&full_page_new, "%s%s", full_page, buffer); |
1016 | free (full_page); | 1050 | free (full_page); |
@@ -1052,10 +1086,10 @@ check_http (void) | |||
1052 | die (STATE_CRITICAL, _("HTTP CRITICAL - No data received from host\n")); | 1086 | die (STATE_CRITICAL, _("HTTP CRITICAL - No data received from host\n")); |
1053 | 1087 | ||
1054 | /* close the connection */ | 1088 | /* close the connection */ |
1089 | if (sd) close(sd); | ||
1055 | #ifdef HAVE_SSL | 1090 | #ifdef HAVE_SSL |
1056 | np_net_ssl_cleanup(); | 1091 | np_net_ssl_cleanup(); |
1057 | #endif | 1092 | #endif |
1058 | if (sd) close(sd); | ||
1059 | 1093 | ||
1060 | /* Save check time */ | 1094 | /* Save check time */ |
1061 | microsec = deltime (tv); | 1095 | microsec = deltime (tv); |
@@ -1410,6 +1444,9 @@ redir (char *pos, char *status_line) | |||
1410 | MAX_PORT, server_type, server_address, server_port, server_url, | 1444 | MAX_PORT, server_type, server_address, server_port, server_url, |
1411 | display_html ? "</A>" : ""); | 1445 | display_html ? "</A>" : ""); |
1412 | 1446 | ||
1447 | /* reset virtual port */ | ||
1448 | virtual_port = server_port; | ||
1449 | |||
1413 | if (verbose) | 1450 | if (verbose) |
1414 | printf (_("Redirection to %s://%s:%d%s\n"), server_type, | 1451 | printf (_("Redirection to %s://%s:%d%s\n"), server_type, |
1415 | host_name ? host_name : server_address, server_port, server_url); | 1452 | host_name ? host_name : server_address, server_port, server_url); |
@@ -1442,32 +1479,32 @@ char *perfd_time (double elapsed_time) | |||
1442 | return fperfdata ("time", elapsed_time, "s", | 1479 | return fperfdata ("time", elapsed_time, "s", |
1443 | thlds->warning?TRUE:FALSE, thlds->warning?thlds->warning->end:0, | 1480 | thlds->warning?TRUE:FALSE, thlds->warning?thlds->warning->end:0, |
1444 | thlds->critical?TRUE:FALSE, thlds->critical?thlds->critical->end:0, | 1481 | thlds->critical?TRUE:FALSE, thlds->critical?thlds->critical->end:0, |
1445 | TRUE, 0, FALSE, 0); | 1482 | TRUE, 0, TRUE, socket_timeout); |
1446 | } | 1483 | } |
1447 | 1484 | ||
1448 | char *perfd_time_connect (double elapsed_time_connect) | 1485 | char *perfd_time_connect (double elapsed_time_connect) |
1449 | { | 1486 | { |
1450 | return fperfdata ("time_connect", elapsed_time_connect, "s", FALSE, 0, FALSE, 0, FALSE, 0, FALSE, 0); | 1487 | return fperfdata ("time_connect", elapsed_time_connect, "s", FALSE, 0, FALSE, 0, FALSE, 0, TRUE, socket_timeout); |
1451 | } | 1488 | } |
1452 | 1489 | ||
1453 | char *perfd_time_ssl (double elapsed_time_ssl) | 1490 | char *perfd_time_ssl (double elapsed_time_ssl) |
1454 | { | 1491 | { |
1455 | return fperfdata ("time_ssl", elapsed_time_ssl, "s", FALSE, 0, FALSE, 0, FALSE, 0, FALSE, 0); | 1492 | return fperfdata ("time_ssl", elapsed_time_ssl, "s", FALSE, 0, FALSE, 0, FALSE, 0, TRUE, socket_timeout); |
1456 | } | 1493 | } |
1457 | 1494 | ||
1458 | char *perfd_time_headers (double elapsed_time_headers) | 1495 | char *perfd_time_headers (double elapsed_time_headers) |
1459 | { | 1496 | { |
1460 | return fperfdata ("time_headers", elapsed_time_headers, "s", FALSE, 0, FALSE, 0, FALSE, 0, FALSE, 0); | 1497 | return fperfdata ("time_headers", elapsed_time_headers, "s", FALSE, 0, FALSE, 0, FALSE, 0, TRUE, socket_timeout); |
1461 | } | 1498 | } |
1462 | 1499 | ||
1463 | char *perfd_time_firstbyte (double elapsed_time_firstbyte) | 1500 | char *perfd_time_firstbyte (double elapsed_time_firstbyte) |
1464 | { | 1501 | { |
1465 | return fperfdata ("time_firstbyte", elapsed_time_firstbyte, "s", FALSE, 0, FALSE, 0, FALSE, 0, FALSE, 0); | 1502 | return fperfdata ("time_firstbyte", elapsed_time_firstbyte, "s", FALSE, 0, FALSE, 0, FALSE, 0, TRUE, socket_timeout); |
1466 | } | 1503 | } |
1467 | 1504 | ||
1468 | char *perfd_time_transfer (double elapsed_time_transfer) | 1505 | char *perfd_time_transfer (double elapsed_time_transfer) |
1469 | { | 1506 | { |
1470 | return fperfdata ("time_transfer", elapsed_time_transfer, "s", FALSE, 0, FALSE, 0, FALSE, 0, FALSE, 0); | 1507 | return fperfdata ("time_transfer", elapsed_time_transfer, "s", FALSE, 0, FALSE, 0, FALSE, 0, TRUE, socket_timeout); |
1471 | } | 1508 | } |
1472 | 1509 | ||
1473 | char *perfd_size (int page_len) | 1510 | char *perfd_size (int page_len) |
@@ -1514,9 +1551,10 @@ print_help (void) | |||
1514 | printf (UT_IPv46); | 1551 | printf (UT_IPv46); |
1515 | 1552 | ||
1516 | #ifdef HAVE_SSL | 1553 | #ifdef HAVE_SSL |
1517 | printf (" %s\n", "-S, --ssl=VERSION"); | 1554 | printf (" %s\n", "-S, --ssl=VERSION[+]"); |
1518 | printf (" %s\n", _("Connect via SSL. Port defaults to 443. VERSION is optional, and prevents")); | 1555 | printf (" %s\n", _("Connect via SSL. Port defaults to 443. VERSION is optional, and prevents")); |
1519 | printf (" %s\n", _("auto-negotiation (1 = TLSv1, 2 = SSLv2, 3 = SSLv3).")); | 1556 | printf (" %s\n", _("auto-negotiation (2 = SSLv2, 3 = SSLv3, 1 = TLSv1, 1.1 = TLSv1.1,")); |
1557 | printf (" %s\n", _("1.2 = TLSv1.2). With a '+' suffix, newer versions are also accepted.")); | ||
1520 | printf (" %s\n", "--sni"); | 1558 | printf (" %s\n", "--sni"); |
1521 | printf (" %s\n", _("Enable SSL/TLS hostname extension support (SNI)")); | 1559 | printf (" %s\n", _("Enable SSL/TLS hostname extension support (SNI)")); |
1522 | printf (" %s\n", "-C, --certificate=INTEGER[,INTEGER]"); | 1560 | printf (" %s\n", "-C, --certificate=INTEGER[,INTEGER]"); |
diff --git a/plugins/check_ide_smart.c b/plugins/check_ide_smart.c index 8d540ca..4662131 100644 --- a/plugins/check_ide_smart.c +++ b/plugins/check_ide_smart.c | |||
@@ -166,7 +166,6 @@ enum SmartCommand | |||
166 | 166 | ||
167 | char *get_offline_text (int); | 167 | char *get_offline_text (int); |
168 | int smart_read_values (int, values_t *); | 168 | int smart_read_values (int, values_t *); |
169 | int values_not_passed (values_t *, thresholds_t *); | ||
170 | int nagios (values_t *, thresholds_t *); | 169 | int nagios (values_t *, thresholds_t *); |
171 | void print_value (value_t *, threshold_t *); | 170 | void print_value (value_t *, threshold_t *); |
172 | void print_values (values_t *, thresholds_t *); | 171 | void print_values (values_t *, thresholds_t *); |
@@ -340,31 +339,6 @@ smart_read_values (int fd, values_t * values) | |||
340 | 339 | ||
341 | 340 | ||
342 | int | 341 | int |
343 | values_not_passed (values_t * p, thresholds_t * t) | ||
344 | { | ||
345 | value_t * value = p->values; | ||
346 | threshold_t * threshold = t->thresholds; | ||
347 | int failed = 0; | ||
348 | int passed = 0; | ||
349 | int i; | ||
350 | for (i = 0; i < NR_ATTRIBUTES; i++) { | ||
351 | if (value->id && threshold->id && value->id == threshold->id) { | ||
352 | if (value->value < threshold->threshold) { | ||
353 | ++failed; | ||
354 | } | ||
355 | else { | ||
356 | ++passed; | ||
357 | } | ||
358 | } | ||
359 | ++value; | ||
360 | ++threshold; | ||
361 | } | ||
362 | return (passed ? -failed : 2); | ||
363 | } | ||
364 | |||
365 | |||
366 | |||
367 | int | ||
368 | nagios (values_t * p, thresholds_t * t) | 342 | nagios (values_t * p, thresholds_t * t) |
369 | { | 343 | { |
370 | value_t * value = p->values; | 344 | value_t * value = p->values; |
diff --git a/plugins/check_ldap.c b/plugins/check_ldap.c index e70d6a5..66be4b4 100644 --- a/plugins/check_ldap.c +++ b/plugins/check_ldap.c | |||
@@ -483,7 +483,7 @@ print_help (void) | |||
483 | 483 | ||
484 | printf (" %s\n", "-W [--warn-entries]"); | 484 | printf (" %s\n", "-W [--warn-entries]"); |
485 | printf (" %s\n", _("Number of found entries to result in warning status")); | 485 | printf (" %s\n", _("Number of found entries to result in warning status")); |
486 | printf (" %s\n", "-W [--crit-entries]"); | 486 | printf (" %s\n", "-C [--crit-entries]"); |
487 | printf (" %s\n", _("Number of found entries to result in critical status")); | 487 | printf (" %s\n", _("Number of found entries to result in critical status")); |
488 | 488 | ||
489 | printf (UT_CONN_TIMEOUT, DEFAULT_SOCKET_TIMEOUT); | 489 | printf (UT_CONN_TIMEOUT, DEFAULT_SOCKET_TIMEOUT); |
diff --git a/plugins/check_load.c b/plugins/check_load.c index a96435f..b1cc498 100644 --- a/plugins/check_load.c +++ b/plugins/check_load.c | |||
@@ -160,7 +160,7 @@ main (int argc, char **argv) | |||
160 | sscanf (input_buffer, "%*[^l]load averages: %lf, %lf, %lf", &la1, &la5, &la15); | 160 | sscanf (input_buffer, "%*[^l]load averages: %lf, %lf, %lf", &la1, &la5, &la15); |
161 | } | 161 | } |
162 | else { | 162 | else { |
163 | printf (_("could not parse load from uptime: %s\n"), result, PATH_TO_UPTIME); | 163 | printf (_("could not parse load from uptime %s: %s\n"), PATH_TO_UPTIME, result); |
164 | return STATE_UNKNOWN; | 164 | return STATE_UNKNOWN; |
165 | } | 165 | } |
166 | 166 | ||
diff --git a/plugins/check_ntp.c b/plugins/check_ntp.c index 75efc28..5ac6c65 100644 --- a/plugins/check_ntp.c +++ b/plugins/check_ntp.c | |||
@@ -297,7 +297,7 @@ void setup_request(ntp_message *p){ | |||
297 | * this is done by filtering servers based on stratum, dispersion, and | 297 | * this is done by filtering servers based on stratum, dispersion, and |
298 | * finally round-trip delay. */ | 298 | * finally round-trip delay. */ |
299 | int best_offset_server(const ntp_server_results *slist, int nservers){ | 299 | int best_offset_server(const ntp_server_results *slist, int nservers){ |
300 | int i=0, cserver=0, best_server=-1; | 300 | int cserver=0, best_server=-1; |
301 | 301 | ||
302 | /* for each server */ | 302 | /* for each server */ |
303 | for(cserver=0; cserver<nservers; cserver++){ | 303 | for(cserver=0; cserver<nservers; cserver++){ |
@@ -356,7 +356,7 @@ int best_offset_server(const ntp_server_results *slist, int nservers){ | |||
356 | * we have to do it in a way that our lazy macros don't handle currently :( */ | 356 | * we have to do it in a way that our lazy macros don't handle currently :( */ |
357 | double offset_request(const char *host, int *status){ | 357 | double offset_request(const char *host, int *status){ |
358 | int i=0, j=0, ga_result=0, num_hosts=0, *socklist=NULL, respnum=0; | 358 | int i=0, j=0, ga_result=0, num_hosts=0, *socklist=NULL, respnum=0; |
359 | int servers_completed=0, one_written=0, one_read=0, servers_readable=0, best_index=-1; | 359 | int servers_completed=0, one_read=0, servers_readable=0, best_index=-1; |
360 | time_t now_time=0, start_ts=0; | 360 | time_t now_time=0, start_ts=0; |
361 | ntp_message *req=NULL; | 361 | ntp_message *req=NULL; |
362 | double avg_offset=0.; | 362 | double avg_offset=0.; |
@@ -421,7 +421,6 @@ double offset_request(const char *host, int *status){ | |||
421 | * been touched in the past second or so and is still lacking | 421 | * been touched in the past second or so and is still lacking |
422 | * some responses. for each of these servers, send a new request, | 422 | * some responses. for each of these servers, send a new request, |
423 | * and update the "waiting" timestamp with the current time. */ | 423 | * and update the "waiting" timestamp with the current time. */ |
424 | one_written=0; | ||
425 | now_time=time(NULL); | 424 | now_time=time(NULL); |
426 | 425 | ||
427 | for(i=0; i<num_hosts; i++){ | 426 | for(i=0; i<num_hosts; i++){ |
@@ -431,7 +430,6 @@ double offset_request(const char *host, int *status){ | |||
431 | setup_request(&req[i]); | 430 | setup_request(&req[i]); |
432 | write(socklist[i], &req[i], sizeof(ntp_message)); | 431 | write(socklist[i], &req[i], sizeof(ntp_message)); |
433 | servers[i].waiting=now_time; | 432 | servers[i].waiting=now_time; |
434 | one_written=1; | ||
435 | break; | 433 | break; |
436 | } | 434 | } |
437 | } | 435 | } |
diff --git a/plugins/check_ntp_time.c b/plugins/check_ntp_time.c index 295f86f..391b2df 100644 --- a/plugins/check_ntp_time.c +++ b/plugins/check_ntp_time.c | |||
@@ -244,7 +244,7 @@ void setup_request(ntp_message *p){ | |||
244 | * this is done by filtering servers based on stratum, dispersion, and | 244 | * this is done by filtering servers based on stratum, dispersion, and |
245 | * finally round-trip delay. */ | 245 | * finally round-trip delay. */ |
246 | int best_offset_server(const ntp_server_results *slist, int nservers){ | 246 | int best_offset_server(const ntp_server_results *slist, int nservers){ |
247 | int i=0, cserver=0, best_server=-1; | 247 | int cserver=0, best_server=-1; |
248 | 248 | ||
249 | /* for each server */ | 249 | /* for each server */ |
250 | for(cserver=0; cserver<nservers; cserver++){ | 250 | for(cserver=0; cserver<nservers; cserver++){ |
@@ -303,7 +303,7 @@ int best_offset_server(const ntp_server_results *slist, int nservers){ | |||
303 | * we have to do it in a way that our lazy macros don't handle currently :( */ | 303 | * we have to do it in a way that our lazy macros don't handle currently :( */ |
304 | double offset_request(const char *host, int *status){ | 304 | double offset_request(const char *host, int *status){ |
305 | int i=0, j=0, ga_result=0, num_hosts=0, *socklist=NULL, respnum=0; | 305 | int i=0, j=0, ga_result=0, num_hosts=0, *socklist=NULL, respnum=0; |
306 | int servers_completed=0, one_written=0, one_read=0, servers_readable=0, best_index=-1; | 306 | int servers_completed=0, one_read=0, servers_readable=0, best_index=-1; |
307 | time_t now_time=0, start_ts=0; | 307 | time_t now_time=0, start_ts=0; |
308 | ntp_message *req=NULL; | 308 | ntp_message *req=NULL; |
309 | double avg_offset=0.; | 309 | double avg_offset=0.; |
@@ -368,7 +368,6 @@ double offset_request(const char *host, int *status){ | |||
368 | * been touched in the past second or so and is still lacking | 368 | * been touched in the past second or so and is still lacking |
369 | * some responses. For each of these servers, send a new request, | 369 | * some responses. For each of these servers, send a new request, |
370 | * and update the "waiting" timestamp with the current time. */ | 370 | * and update the "waiting" timestamp with the current time. */ |
371 | one_written=0; | ||
372 | now_time=time(NULL); | 371 | now_time=time(NULL); |
373 | 372 | ||
374 | for(i=0; i<num_hosts; i++){ | 373 | for(i=0; i<num_hosts; i++){ |
@@ -378,7 +377,6 @@ double offset_request(const char *host, int *status){ | |||
378 | setup_request(&req[i]); | 377 | setup_request(&req[i]); |
379 | write(socklist[i], &req[i], sizeof(ntp_message)); | 378 | write(socklist[i], &req[i], sizeof(ntp_message)); |
380 | servers[i].waiting=now_time; | 379 | servers[i].waiting=now_time; |
381 | one_written=1; | ||
382 | break; | 380 | break; |
383 | } | 381 | } |
384 | } | 382 | } |
@@ -635,7 +633,7 @@ void print_help(void){ | |||
635 | printf("%s\n", _("Notes:")); | 633 | printf("%s\n", _("Notes:")); |
636 | printf(" %s\n", _("If you'd rather want to monitor an NTP server, please use")); | 634 | printf(" %s\n", _("If you'd rather want to monitor an NTP server, please use")); |
637 | printf(" %s\n", _("check_ntp_peer.")); | 635 | printf(" %s\n", _("check_ntp_peer.")); |
638 | printf(" %s\n", _("--time-offset is usefull for compensating for servers with known")); | 636 | printf(" %s\n", _("--time-offset is useful for compensating for servers with known")); |
639 | printf(" %s\n", _("and expected clock skew.")); | 637 | printf(" %s\n", _("and expected clock skew.")); |
640 | printf("\n"); | 638 | printf("\n"); |
641 | printf(UT_THRESHOLDS_NOTES); | 639 | printf(UT_THRESHOLDS_NOTES); |
diff --git a/plugins/check_radius.c b/plugins/check_radius.c index 03cbb8b..b3b8c82 100644 --- a/plugins/check_radius.c +++ b/plugins/check_radius.c | |||
@@ -36,7 +36,9 @@ const char *email = "devel@monitoring-plugins.org"; | |||
36 | #include "utils.h" | 36 | #include "utils.h" |
37 | #include "netutils.h" | 37 | #include "netutils.h" |
38 | 38 | ||
39 | #if defined(HAVE_LIBFREERADIUS_CLIENT) | 39 | #if defined(HAVE_LIBRADCLI) |
40 | #include <radcli/radcli.h> | ||
41 | #elif defined(HAVE_LIBFREERADIUS_CLIENT) | ||
40 | #include <freeradius-client.h> | 42 | #include <freeradius-client.h> |
41 | #elif defined(HAVE_LIBRADIUSCLIENT_NG) | 43 | #elif defined(HAVE_LIBRADIUSCLIENT_NG) |
42 | #include <radiusclient-ng.h> | 44 | #include <radiusclient-ng.h> |
@@ -48,22 +50,24 @@ int process_arguments (int, char **); | |||
48 | void print_help (void); | 50 | void print_help (void); |
49 | void print_usage (void); | 51 | void print_usage (void); |
50 | 52 | ||
51 | #if defined(HAVE_LIBFREERADIUS_CLIENT) || defined(HAVE_LIBRADIUSCLIENT_NG) | 53 | #if defined(HAVE_LIBFREERADIUS_CLIENT) || defined(HAVE_LIBRADIUSCLIENT_NG) || defined(HAVE_LIBRADCLI) |
52 | #define my_rc_conf_str(a) rc_conf_str(rch,a) | 54 | #define my_rc_conf_str(a) rc_conf_str(rch,a) |
55 | #if defined(HAVE_LIBRADCLI) | ||
56 | #define my_rc_send_server(a,b) rc_send_server(rch,a,b,AUTH) | ||
57 | #else | ||
53 | #define my_rc_send_server(a,b) rc_send_server(rch,a,b) | 58 | #define my_rc_send_server(a,b) rc_send_server(rch,a,b) |
54 | #ifdef HAVE_LIBFREERADIUS_CLIENT | 59 | #endif |
60 | #if defined(HAVE_LIBFREERADIUS_CLIENT) || defined(HAVE_LIBRADCLI) | ||
55 | #define my_rc_buildreq(a,b,c,d,e,f) rc_buildreq(rch,a,b,c,d,(a)->secret,e,f) | 61 | #define my_rc_buildreq(a,b,c,d,e,f) rc_buildreq(rch,a,b,c,d,(a)->secret,e,f) |
56 | #else | 62 | #else |
57 | #define my_rc_buildreq(a,b,c,d,e,f) rc_buildreq(rch,a,b,c,d,e,f) | 63 | #define my_rc_buildreq(a,b,c,d,e,f) rc_buildreq(rch,a,b,c,d,e,f) |
58 | #endif | 64 | #endif |
59 | #define my_rc_own_ipaddress() rc_own_ipaddress(rch) | ||
60 | #define my_rc_avpair_add(a,b,c,d) rc_avpair_add(rch,a,b,c,-1,d) | 65 | #define my_rc_avpair_add(a,b,c,d) rc_avpair_add(rch,a,b,c,-1,d) |
61 | #define my_rc_read_dictionary(a) rc_read_dictionary(rch, a) | 66 | #define my_rc_read_dictionary(a) rc_read_dictionary(rch, a) |
62 | #else | 67 | #else |
63 | #define my_rc_conf_str(a) rc_conf_str(a) | 68 | #define my_rc_conf_str(a) rc_conf_str(a) |
64 | #define my_rc_send_server(a,b) rc_send_server(a, b) | 69 | #define my_rc_send_server(a,b) rc_send_server(a, b) |
65 | #define my_rc_buildreq(a,b,c,d,e,f) rc_buildreq(a,b,c,d,e,f) | 70 | #define my_rc_buildreq(a,b,c,d,e,f) rc_buildreq(a,b,c,d,e,f) |
66 | #define my_rc_own_ipaddress() rc_own_ipaddress() | ||
67 | #define my_rc_avpair_add(a,b,c,d) rc_avpair_add(a, b, c, d) | 71 | #define my_rc_avpair_add(a,b,c,d) rc_avpair_add(a, b, c, d) |
68 | #define my_rc_read_dictionary(a) rc_read_dictionary(a) | 72 | #define my_rc_read_dictionary(a) rc_read_dictionary(a) |
69 | #endif | 73 | #endif |
@@ -76,7 +80,7 @@ void print_usage (void); | |||
76 | 80 | ||
77 | int my_rc_read_config(char *); | 81 | int my_rc_read_config(char *); |
78 | 82 | ||
79 | #if defined(HAVE_LIBFREERADIUS_CLIENT) || defined(HAVE_LIBRADIUSCLIENT_NG) | 83 | #if defined(HAVE_LIBFREERADIUS_CLIENT) || defined(HAVE_LIBRADIUSCLIENT_NG) || defined(HAVE_LIBRADCLI) |
80 | rc_handle *rch = NULL; | 84 | rc_handle *rch = NULL; |
81 | #endif | 85 | #endif |
82 | 86 | ||
@@ -90,7 +94,6 @@ char *config_file = NULL; | |||
90 | unsigned short port = PW_AUTH_UDP_PORT; | 94 | unsigned short port = PW_AUTH_UDP_PORT; |
91 | int retries = 1; | 95 | int retries = 1; |
92 | int verbose = FALSE; | 96 | int verbose = FALSE; |
93 | ENV *env = NULL; | ||
94 | 97 | ||
95 | /****************************************************************************** | 98 | /****************************************************************************** |
96 | 99 | ||
@@ -150,6 +153,8 @@ Please note that all tags must be lowercase to use the DocBook XML DTD. | |||
150 | int | 153 | int |
151 | main (int argc, char **argv) | 154 | main (int argc, char **argv) |
152 | { | 155 | { |
156 | struct sockaddr_storage ss; | ||
157 | char name[HOST_NAME_MAX]; | ||
153 | char msg[BUFFER_LEN]; | 158 | char msg[BUFFER_LEN]; |
154 | SEND_DATA data; | 159 | SEND_DATA data; |
155 | int result = STATE_UNKNOWN; | 160 | int result = STATE_UNKNOWN; |
@@ -185,15 +190,14 @@ main (int argc, char **argv) | |||
185 | die (STATE_UNKNOWN, _("Invalid NAS-Identifier\n")); | 190 | die (STATE_UNKNOWN, _("Invalid NAS-Identifier\n")); |
186 | } | 191 | } |
187 | 192 | ||
188 | if (nasipaddress != NULL) { | 193 | if (nasipaddress == NULL) { |
189 | if (rc_good_ipaddr (nasipaddress)) | 194 | if (gethostname (name, sizeof(name)) != 0) |
190 | die (STATE_UNKNOWN, _("Invalid NAS-IP-Address\n")); | 195 | die (STATE_UNKNOWN, _("gethostname() failed!\n")); |
191 | if ((client_id = rc_get_ipaddr(nasipaddress)) == 0) | 196 | nasipaddress = name; |
192 | die (STATE_UNKNOWN, _("Invalid NAS-IP-Address\n")); | ||
193 | } else { | ||
194 | if ((client_id = my_rc_own_ipaddress ()) == 0) | ||
195 | die (STATE_UNKNOWN, _("Can't find local IP for NAS-IP-Address\n")); | ||
196 | } | 197 | } |
198 | if (!dns_lookup (nasipaddress, &ss, AF_INET)) /* TODO: Support IPv6. */ | ||
199 | die (STATE_UNKNOWN, _("Invalid NAS-IP-Address\n")); | ||
200 | client_id = ntohl (((struct sockaddr_in *)&ss)->sin_addr.s_addr); | ||
197 | if (my_rc_avpair_add (&(data.send_pairs), PW_NAS_IP_ADDRESS, &client_id, 0) == NULL) | 201 | if (my_rc_avpair_add (&(data.send_pairs), PW_NAS_IP_ADDRESS, &client_id, 0) == NULL) |
198 | die (STATE_UNKNOWN, _("Invalid NAS-IP-Address\n")); | 202 | die (STATE_UNKNOWN, _("Invalid NAS-IP-Address\n")); |
199 | 203 | ||
@@ -399,7 +403,7 @@ print_usage (void) | |||
399 | 403 | ||
400 | int my_rc_read_config(char * a) | 404 | int my_rc_read_config(char * a) |
401 | { | 405 | { |
402 | #if defined(HAVE_LIBFREERADIUS_CLIENT) || defined(HAVE_LIBRADIUSCLIENT_NG) | 406 | #if defined(HAVE_LIBFREERADIUS_CLIENT) || defined(HAVE_LIBRADIUSCLIENT_NG) || defined(HAVE_LIBRADCLI) |
403 | rch = rc_read_config(a); | 407 | rch = rc_read_config(a); |
404 | return (rch == NULL) ? 1 : 0; | 408 | return (rch == NULL) ? 1 : 0; |
405 | #else | 409 | #else |
diff --git a/plugins/check_smtp.c b/plugins/check_smtp.c index 56040ff..587a724 100644 --- a/plugins/check_smtp.c +++ b/plugins/check_smtp.c | |||
@@ -59,10 +59,6 @@ enum { | |||
59 | #define SMTP_STARTTLS "STARTTLS\r\n" | 59 | #define SMTP_STARTTLS "STARTTLS\r\n" |
60 | #define SMTP_AUTH_LOGIN "AUTH LOGIN\r\n" | 60 | #define SMTP_AUTH_LOGIN "AUTH LOGIN\r\n" |
61 | 61 | ||
62 | #ifndef HOST_MAX_BYTES | ||
63 | #define HOST_MAX_BYTES 255 | ||
64 | #endif | ||
65 | |||
66 | #define EHLO_SUPPORTS_STARTTLS 1 | 62 | #define EHLO_SUPPORTS_STARTTLS 1 |
67 | 63 | ||
68 | int process_arguments (int, char **); | 64 | int process_arguments (int, char **); |
@@ -231,7 +227,7 @@ main (int argc, char **argv) | |||
231 | send(sd, SMTP_STARTTLS, strlen(SMTP_STARTTLS), 0); | 227 | send(sd, SMTP_STARTTLS, strlen(SMTP_STARTTLS), 0); |
232 | 228 | ||
233 | recvlines(buffer, MAX_INPUT_BUFFER); /* wait for it */ | 229 | recvlines(buffer, MAX_INPUT_BUFFER); /* wait for it */ |
234 | if (!strstr (buffer, server_expect)) { | 230 | if (!strstr (buffer, SMTP_EXPECT)) { |
235 | printf (_("Server does not support STARTTLS\n")); | 231 | printf (_("Server does not support STARTTLS\n")); |
236 | smtp_quit(); | 232 | smtp_quit(); |
237 | return STATE_UNKNOWN; | 233 | return STATE_UNKNOWN; |
@@ -239,8 +235,8 @@ main (int argc, char **argv) | |||
239 | result = np_net_ssl_init(sd); | 235 | result = np_net_ssl_init(sd); |
240 | if(result != STATE_OK) { | 236 | if(result != STATE_OK) { |
241 | printf (_("CRITICAL - Cannot create SSL context.\n")); | 237 | printf (_("CRITICAL - Cannot create SSL context.\n")); |
242 | np_net_ssl_cleanup(); | ||
243 | close(sd); | 238 | close(sd); |
239 | np_net_ssl_cleanup(); | ||
244 | return STATE_CRITICAL; | 240 | return STATE_CRITICAL; |
245 | } else { | 241 | } else { |
246 | ssl_established = 1; | 242 | ssl_established = 1; |
@@ -276,6 +272,7 @@ main (int argc, char **argv) | |||
276 | # ifdef USE_OPENSSL | 272 | # ifdef USE_OPENSSL |
277 | if ( check_cert ) { | 273 | if ( check_cert ) { |
278 | result = np_net_ssl_check_cert(days_till_exp_warn, days_till_exp_crit); | 274 | result = np_net_ssl_check_cert(days_till_exp_warn, days_till_exp_crit); |
275 | smtp_quit(); | ||
279 | my_close(); | 276 | my_close(); |
280 | return result; | 277 | return result; |
281 | } | 278 | } |
@@ -581,11 +578,6 @@ process_arguments (int argc, char **argv) | |||
581 | usage4 (_("Timeout interval must be a positive integer")); | 578 | usage4 (_("Timeout interval must be a positive integer")); |
582 | } | 579 | } |
583 | break; | 580 | break; |
584 | case 'S': | ||
585 | /* starttls */ | ||
586 | use_ssl = TRUE; | ||
587 | use_ehlo = TRUE; | ||
588 | break; | ||
589 | case 'D': | 581 | case 'D': |
590 | /* Check SSL cert validity */ | 582 | /* Check SSL cert validity */ |
591 | #ifdef USE_OPENSSL | 583 | #ifdef USE_OPENSSL |
@@ -607,9 +599,14 @@ process_arguments (int argc, char **argv) | |||
607 | days_till_exp_warn = atoi (optarg); | 599 | days_till_exp_warn = atoi (optarg); |
608 | } | 600 | } |
609 | check_cert = TRUE; | 601 | check_cert = TRUE; |
602 | ignore_send_quit_failure = TRUE; | ||
610 | #else | 603 | #else |
611 | usage (_("SSL support not available - install OpenSSL and recompile")); | 604 | usage (_("SSL support not available - install OpenSSL and recompile")); |
612 | #endif | 605 | #endif |
606 | case 'S': | ||
607 | /* starttls */ | ||
608 | use_ssl = TRUE; | ||
609 | use_ehlo = TRUE; | ||
613 | break; | 610 | break; |
614 | case '4': | 611 | case '4': |
615 | address_family = AF_INET; | 612 | address_family = AF_INET; |
@@ -763,10 +760,12 @@ recvlines(char *buf, size_t bufsize) | |||
763 | int | 760 | int |
764 | my_close (void) | 761 | my_close (void) |
765 | { | 762 | { |
763 | int result; | ||
764 | result = close(sd); | ||
766 | #ifdef HAVE_SSL | 765 | #ifdef HAVE_SSL |
767 | np_net_ssl_cleanup(); | 766 | np_net_ssl_cleanup(); |
768 | #endif | 767 | #endif |
769 | return close(sd); | 768 | return result; |
770 | } | 769 | } |
771 | 770 | ||
772 | 771 | ||
diff --git a/plugins/check_snmp.c b/plugins/check_snmp.c index 28cc44d..da9638c 100644 --- a/plugins/check_snmp.c +++ b/plugins/check_snmp.c | |||
@@ -41,7 +41,6 @@ const char *email = "devel@monitoring-plugins.org"; | |||
41 | #define DEFAULT_PORT "161" | 41 | #define DEFAULT_PORT "161" |
42 | #define DEFAULT_MIBLIST "ALL" | 42 | #define DEFAULT_MIBLIST "ALL" |
43 | #define DEFAULT_PROTOCOL "1" | 43 | #define DEFAULT_PROTOCOL "1" |
44 | #define DEFAULT_TIMEOUT 1 | ||
45 | #define DEFAULT_RETRIES 5 | 44 | #define DEFAULT_RETRIES 5 |
46 | #define DEFAULT_AUTH_PROTOCOL "MD5" | 45 | #define DEFAULT_AUTH_PROTOCOL "MD5" |
47 | #define DEFAULT_PRIV_PROTOCOL "DES" | 46 | #define DEFAULT_PRIV_PROTOCOL "DES" |
@@ -153,7 +152,7 @@ state_data *previous_state; | |||
153 | double *previous_value; | 152 | double *previous_value; |
154 | size_t previous_size = OID_COUNT_STEP; | 153 | size_t previous_size = OID_COUNT_STEP; |
155 | int perf_labels = 1; | 154 | int perf_labels = 1; |
156 | 155 | char* ip_version = ""; | |
157 | 156 | ||
158 | static char *fix_snmp_range(char *th) | 157 | static char *fix_snmp_range(char *th) |
159 | { | 158 | { |
@@ -227,7 +226,7 @@ main (int argc, char **argv) | |||
227 | outbuff = strdup (""); | 226 | outbuff = strdup (""); |
228 | delimiter = strdup (" = "); | 227 | delimiter = strdup (" = "); |
229 | output_delim = strdup (DEFAULT_OUTPUT_DELIMITER); | 228 | output_delim = strdup (DEFAULT_OUTPUT_DELIMITER); |
230 | timeout_interval = DEFAULT_TIMEOUT; | 229 | timeout_interval = DEFAULT_SOCKET_TIMEOUT; |
231 | retries = DEFAULT_RETRIES; | 230 | retries = DEFAULT_RETRIES; |
232 | 231 | ||
233 | np_init( (char *) progname, argc, argv ); | 232 | np_init( (char *) progname, argc, argv ); |
@@ -681,6 +680,8 @@ process_arguments (int argc, char **argv) | |||
681 | {"offset", required_argument, 0, L_OFFSET}, | 680 | {"offset", required_argument, 0, L_OFFSET}, |
682 | {"invert-search", no_argument, 0, L_INVERT_SEARCH}, | 681 | {"invert-search", no_argument, 0, L_INVERT_SEARCH}, |
683 | {"perf-oids", no_argument, 0, 'O'}, | 682 | {"perf-oids", no_argument, 0, 'O'}, |
683 | {"ipv4", no_argument, 0, '4'}, | ||
684 | {"ipv6", no_argument, 0, '6'}, | ||
684 | {0, 0, 0, 0} | 685 | {0, 0, 0, 0} |
685 | }; | 686 | }; |
686 | 687 | ||
@@ -698,7 +699,7 @@ process_arguments (int argc, char **argv) | |||
698 | } | 699 | } |
699 | 700 | ||
700 | while (1) { | 701 | while (1) { |
701 | c = getopt_long (argc, argv, "nhvVOt:c:w:H:C:o:e:E:d:D:s:t:R:r:l:u:p:m:P:N:L:U:a:x:A:X:", | 702 | c = getopt_long (argc, argv, "nhvVO46t:c:w:H:C:o:e:E:d:D:s:t:R:r:l:u:p:m:P:N:L:U:a:x:A:X:", |
702 | longopts, &option); | 703 | longopts, &option); |
703 | 704 | ||
704 | if (c == -1 || c == EOF) | 705 | if (c == -1 || c == EOF) |
@@ -923,6 +924,13 @@ process_arguments (int argc, char **argv) | |||
923 | case 'O': | 924 | case 'O': |
924 | perf_labels=0; | 925 | perf_labels=0; |
925 | break; | 926 | break; |
927 | case '4': | ||
928 | break; | ||
929 | case '6': | ||
930 | xasprintf(&ip_version, "udp6:"); | ||
931 | if(verbose>2) | ||
932 | printf("IPv6 detected! Will pass \"udp6:\" to snmpget.\n"); | ||
933 | break; | ||
926 | } | 934 | } |
927 | } | 935 | } |
928 | 936 | ||
@@ -1128,6 +1136,7 @@ print_help (void) | |||
1128 | 1136 | ||
1129 | printf (UT_HELP_VRSN); | 1137 | printf (UT_HELP_VRSN); |
1130 | printf (UT_EXTRA_OPTS); | 1138 | printf (UT_EXTRA_OPTS); |
1139 | printf (UT_IPv46); | ||
1131 | 1140 | ||
1132 | printf (UT_HOST_PORT, 'p', DEFAULT_PORT); | 1141 | printf (UT_HOST_PORT, 'p', DEFAULT_PORT); |
1133 | 1142 | ||
@@ -1246,5 +1255,5 @@ print_usage (void) | |||
1246 | printf ("[-C community] [-s string] [-r regex] [-R regexi] [-t timeout] [-e retries]\n"); | 1255 | printf ("[-C community] [-s string] [-r regex] [-R regexi] [-t timeout] [-e retries]\n"); |
1247 | printf ("[-l label] [-u units] [-p port-number] [-d delimiter] [-D output-delimiter]\n"); | 1256 | printf ("[-l label] [-u units] [-p port-number] [-d delimiter] [-D output-delimiter]\n"); |
1248 | printf ("[-m miblist] [-P snmp version] [-N context] [-L seclevel] [-U secname]\n"); | 1257 | printf ("[-m miblist] [-P snmp version] [-N context] [-L seclevel] [-U secname]\n"); |
1249 | printf ("[-a authproto] [-A authpasswd] [-x privproto] [-X privpasswd]\n"); | 1258 | printf ("[-a authproto] [-A authpasswd] [-x privproto] [-X privpasswd] [-4|6]\n"); |
1250 | } | 1259 | } |
diff --git a/plugins/check_tcp.c b/plugins/check_tcp.c index 6dc9aa9..61333bd 100644 --- a/plugins/check_tcp.c +++ b/plugins/check_tcp.c | |||
@@ -247,8 +247,8 @@ main (int argc, char **argv) | |||
247 | } | 247 | } |
248 | } | 248 | } |
249 | if(result != STATE_OK){ | 249 | if(result != STATE_OK){ |
250 | np_net_ssl_cleanup(); | ||
251 | if(sd) close(sd); | 250 | if(sd) close(sd); |
251 | np_net_ssl_cleanup(); | ||
252 | return result; | 252 | return result; |
253 | } | 253 | } |
254 | #endif /* HAVE_SSL */ | 254 | #endif /* HAVE_SSL */ |
@@ -321,10 +321,10 @@ main (int argc, char **argv) | |||
321 | if (server_quit != NULL) { | 321 | if (server_quit != NULL) { |
322 | my_send(server_quit, strlen(server_quit)); | 322 | my_send(server_quit, strlen(server_quit)); |
323 | } | 323 | } |
324 | if (sd) close (sd); | ||
324 | #ifdef HAVE_SSL | 325 | #ifdef HAVE_SSL |
325 | np_net_ssl_cleanup(); | 326 | np_net_ssl_cleanup(); |
326 | #endif | 327 | #endif |
327 | if (sd) close (sd); | ||
328 | 328 | ||
329 | microsec = deltime (tv); | 329 | microsec = deltime (tv); |
330 | elapsed_time = (double)microsec / 1.0e6; | 330 | elapsed_time = (double)microsec / 1.0e6; |
diff --git a/plugins/check_ups.c b/plugins/check_ups.c index dc5a348..e9e56a5 100644 --- a/plugins/check_ups.c +++ b/plugins/check_ups.c | |||
@@ -242,8 +242,8 @@ main (int argc, char **argv) | |||
242 | } | 242 | } |
243 | xasprintf (&data, "%s %s", data, | 243 | xasprintf (&data, "%s %s", data, |
244 | perfdata ("battery", (long)ups_battery_percent, "%", | 244 | perfdata ("battery", (long)ups_battery_percent, "%", |
245 | check_warn, (long)(1000*warning_value), | 245 | check_warn, (long)(warning_value), |
246 | check_crit, (long)(1000*critical_value), | 246 | check_crit, (long)(critical_value), |
247 | TRUE, 0, TRUE, 100)); | 247 | TRUE, 0, TRUE, 100)); |
248 | } else { | 248 | } else { |
249 | xasprintf (&data, "%s %s", data, | 249 | xasprintf (&data, "%s %s", data, |
@@ -271,8 +271,8 @@ main (int argc, char **argv) | |||
271 | } | 271 | } |
272 | xasprintf (&data, "%s %s", data, | 272 | xasprintf (&data, "%s %s", data, |
273 | perfdata ("load", (long)ups_load_percent, "%", | 273 | perfdata ("load", (long)ups_load_percent, "%", |
274 | check_warn, (long)(1000*warning_value), | 274 | check_warn, (long)(warning_value), |
275 | check_crit, (long)(1000*critical_value), | 275 | check_crit, (long)(critical_value), |
276 | TRUE, 0, TRUE, 100)); | 276 | TRUE, 0, TRUE, 100)); |
277 | } else { | 277 | } else { |
278 | xasprintf (&data, "%s %s", data, | 278 | xasprintf (&data, "%s %s", data, |
@@ -308,8 +308,8 @@ main (int argc, char **argv) | |||
308 | } | 308 | } |
309 | xasprintf (&data, "%s %s", data, | 309 | xasprintf (&data, "%s %s", data, |
310 | perfdata ("temp", (long)ups_temperature, tunits, | 310 | perfdata ("temp", (long)ups_temperature, tunits, |
311 | check_warn, (long)(1000*warning_value), | 311 | check_warn, (long)(warning_value), |
312 | check_crit, (long)(1000*critical_value), | 312 | check_crit, (long)(critical_value), |
313 | TRUE, 0, FALSE, 0)); | 313 | TRUE, 0, FALSE, 0)); |
314 | } else { | 314 | } else { |
315 | xasprintf (&data, "%s %s", data, | 315 | xasprintf (&data, "%s %s", data, |
diff --git a/plugins/check_users.c b/plugins/check_users.c index 54415a4..f6f4b36 100644 --- a/plugins/check_users.c +++ b/plugins/check_users.c | |||
@@ -54,15 +54,15 @@ int process_arguments (int, char **); | |||
54 | void print_help (void); | 54 | void print_help (void); |
55 | void print_usage (void); | 55 | void print_usage (void); |
56 | 56 | ||
57 | int wusers = -1; | 57 | char *warning_range = NULL; |
58 | int cusers = -1; | 58 | char *critical_range = NULL; |
59 | thresholds *thlds = NULL; | ||
59 | 60 | ||
60 | int | 61 | int |
61 | main (int argc, char **argv) | 62 | main (int argc, char **argv) |
62 | { | 63 | { |
63 | int users = -1; | 64 | int users = -1; |
64 | int result = STATE_UNKNOWN; | 65 | int result = STATE_UNKNOWN; |
65 | char *perf; | ||
66 | #if HAVE_WTSAPI32_H | 66 | #if HAVE_WTSAPI32_H |
67 | WTS_SESSION_INFO *wtsinfo; | 67 | WTS_SESSION_INFO *wtsinfo; |
68 | DWORD wtscount; | 68 | DWORD wtscount; |
@@ -77,8 +77,6 @@ main (int argc, char **argv) | |||
77 | bindtextdomain (PACKAGE, LOCALEDIR); | 77 | bindtextdomain (PACKAGE, LOCALEDIR); |
78 | textdomain (PACKAGE); | 78 | textdomain (PACKAGE); |
79 | 79 | ||
80 | perf = strdup (""); | ||
81 | |||
82 | /* Parse extra opts if any */ | 80 | /* Parse extra opts if any */ |
83 | argv = np_extra_opts (&argc, argv, progname); | 81 | argv = np_extra_opts (&argc, argv, progname); |
84 | 82 | ||
@@ -160,23 +158,15 @@ main (int argc, char **argv) | |||
160 | #endif | 158 | #endif |
161 | 159 | ||
162 | /* check the user count against warning and critical thresholds */ | 160 | /* check the user count against warning and critical thresholds */ |
163 | if (users > cusers) | 161 | result = get_status((double)users, thlds); |
164 | result = STATE_CRITICAL; | ||
165 | else if (users > wusers) | ||
166 | result = STATE_WARNING; | ||
167 | else if (users >= 0) | ||
168 | result = STATE_OK; | ||
169 | 162 | ||
170 | if (result == STATE_UNKNOWN) | 163 | if (result == STATE_UNKNOWN) |
171 | printf ("%s\n", _("Unable to read output")); | 164 | printf ("%s\n", _("Unable to read output")); |
172 | else { | 165 | else { |
173 | xasprintf (&perf, "%s", perfdata ("users", users, "", | 166 | printf (_("USERS %s - %d users currently logged in |%s\n"), |
174 | TRUE, wusers, | 167 | state_text(result), users, |
175 | TRUE, cusers, | 168 | sperfdata_int("users", users, "", warning_range, |
176 | TRUE, 0, | 169 | critical_range, TRUE, 0, FALSE, 0)); |
177 | FALSE, 0)); | ||
178 | printf (_("USERS %s - %d users currently logged in |%s\n"), state_text (result), | ||
179 | users, perf); | ||
180 | } | 170 | } |
181 | 171 | ||
182 | return result; | 172 | return result; |
@@ -215,33 +205,27 @@ process_arguments (int argc, char **argv) | |||
215 | print_revision (progname, NP_VERSION); | 205 | print_revision (progname, NP_VERSION); |
216 | exit (STATE_UNKNOWN); | 206 | exit (STATE_UNKNOWN); |
217 | case 'c': /* critical */ | 207 | case 'c': /* critical */ |
218 | if (!is_intnonneg (optarg)) | 208 | critical_range = optarg; |
219 | usage4 (_("Critical threshold must be a positive integer")); | ||
220 | else | ||
221 | cusers = atoi (optarg); | ||
222 | break; | 209 | break; |
223 | case 'w': /* warning */ | 210 | case 'w': /* warning */ |
224 | if (!is_intnonneg (optarg)) | 211 | warning_range = optarg; |
225 | usage4 (_("Warning threshold must be a positive integer")); | ||
226 | else | ||
227 | wusers = atoi (optarg); | ||
228 | break; | 212 | break; |
229 | } | 213 | } |
230 | } | 214 | } |
231 | 215 | ||
232 | c = optind; | 216 | c = optind; |
233 | if (wusers == -1 && argc > c) { | 217 | if (warning_range == NULL && argc > c) |
234 | if (is_intnonneg (argv[c]) == FALSE) | 218 | warning_range = argv[c++]; |
235 | usage4 (_("Warning threshold must be a positive integer")); | 219 | if (critical_range == NULL && argc > c) |
236 | else | 220 | critical_range = argv[c++]; |
237 | wusers = atoi (argv[c++]); | 221 | |
238 | } | 222 | /* this will abort in case of invalid ranges */ |
239 | if (cusers == -1 && argc > c) { | 223 | set_thresholds (&thlds, warning_range, critical_range); |
240 | if (is_intnonneg (argv[c]) == FALSE) | 224 | |
241 | usage4 (_("Warning threshold must be a positive integer")); | 225 | if (thlds->warning->end < 0) |
242 | else | 226 | usage4 (_("Warning threshold must be a positive integer")); |
243 | cusers = atoi (argv[c]); | 227 | if (thlds->critical->end < 0) |
244 | } | 228 | usage4 (_("Critical threshold must be a positive integer")); |
245 | 229 | ||
246 | return OK; | 230 | return OK; |
247 | } | 231 | } |
diff --git a/plugins/common.h b/plugins/common.h index 01003b3..8719b50 100644 --- a/plugins/common.h +++ b/plugins/common.h | |||
@@ -161,6 +161,13 @@ | |||
161 | # endif | 161 | # endif |
162 | #endif | 162 | #endif |
163 | 163 | ||
164 | /* openssl 1.1 does not set OPENSSL_NO_SSL2 by default but ships without ssl2 */ | ||
165 | #ifdef OPENSSL_VERSION_NUMBER | ||
166 | # if OPENSSL_VERSION_NUMBER >= 0x10100000 | ||
167 | # define OPENSSL_NO_SSL2 | ||
168 | # endif | ||
169 | #endif | ||
170 | |||
164 | /* | 171 | /* |
165 | * | 172 | * |
166 | * Standard Values | 173 | * Standard Values |
diff --git a/plugins/negate.c b/plugins/negate.c index beaed1e..b320e35 100644 --- a/plugins/negate.c +++ b/plugins/negate.c | |||
@@ -59,8 +59,8 @@ static int state[4] = { | |||
59 | int | 59 | int |
60 | main (int argc, char **argv) | 60 | main (int argc, char **argv) |
61 | { | 61 | { |
62 | int found = 0, result = STATE_UNKNOWN; | 62 | int result = STATE_UNKNOWN; |
63 | char *buf, *sub; | 63 | char *sub; |
64 | char **command_line; | 64 | char **command_line; |
65 | output chld_out, chld_err; | 65 | output chld_out, chld_err; |
66 | int i; | 66 | int i; |
diff --git a/plugins/netutils.c b/plugins/netutils.c index 705aaf0..1bb4f07 100644 --- a/plugins/netutils.c +++ b/plugins/netutils.c | |||
@@ -359,20 +359,21 @@ is_addr (const char *address) | |||
359 | } | 359 | } |
360 | 360 | ||
361 | int | 361 | int |
362 | resolve_host_or_addr (const char *address, int family) | 362 | dns_lookup (const char *in, struct sockaddr_storage *ss, int family) |
363 | { | 363 | { |
364 | struct addrinfo hints; | 364 | struct addrinfo hints; |
365 | struct addrinfo *res; | 365 | struct addrinfo *res; |
366 | int retval; | 366 | int retval; |
367 | 367 | ||
368 | memset (&hints, 0, sizeof (hints)); | 368 | memset (&hints, 0, sizeof(struct addrinfo)); |
369 | hints.ai_family = family; | 369 | hints.ai_family = family; |
370 | retval = getaddrinfo (address, NULL, &hints, &res); | ||
371 | 370 | ||
371 | retval = getaddrinfo (in, NULL, &hints, &res); | ||
372 | if (retval != 0) | 372 | if (retval != 0) |
373 | return FALSE; | 373 | return FALSE; |
374 | else { | 374 | |
375 | freeaddrinfo (res); | 375 | if (ss != NULL) |
376 | return TRUE; | 376 | memcpy (ss, res->ai_addr, res->ai_addrlen); |
377 | } | 377 | freeaddrinfo (res); |
378 | return TRUE; | ||
378 | } | 379 | } |
diff --git a/plugins/netutils.h b/plugins/netutils.h index c6fce90..d7ee0dd 100644 --- a/plugins/netutils.h +++ b/plugins/netutils.h | |||
@@ -45,6 +45,10 @@ | |||
45 | # endif /* UNIX_PATH_MAX */ | 45 | # endif /* UNIX_PATH_MAX */ |
46 | #endif /* HAVE_SYS_UN_H */ | 46 | #endif /* HAVE_SYS_UN_H */ |
47 | 47 | ||
48 | #ifndef HOST_MAX_BYTES | ||
49 | # define HOST_MAX_BYTES 255 | ||
50 | #endif | ||
51 | |||
48 | /* process_request and wrapper macros */ | 52 | /* process_request and wrapper macros */ |
49 | #define process_tcp_request(addr, port, sbuf, rbuf, rsize) \ | 53 | #define process_tcp_request(addr, port, sbuf, rbuf, rsize) \ |
50 | process_request(addr, port, IPPROTO_TCP, sbuf, rbuf, rsize) | 54 | process_request(addr, port, IPPROTO_TCP, sbuf, rbuf, rsize) |
@@ -71,8 +75,9 @@ int send_request (int sd, int proto, const char *send_buffer, char *recv_buffer, | |||
71 | /* "is_*" wrapper macros and functions */ | 75 | /* "is_*" wrapper macros and functions */ |
72 | int is_host (const char *); | 76 | int is_host (const char *); |
73 | int is_addr (const char *); | 77 | int is_addr (const char *); |
74 | int resolve_host_or_addr (const char *, int); | 78 | int dns_lookup (const char *, struct sockaddr_storage *, int); |
75 | void host_or_die(const char *str); | 79 | void host_or_die(const char *str); |
80 | #define resolve_host_or_addr(addr, family) dns_lookup(addr, NULL, family) | ||
76 | #define is_inet_addr(addr) resolve_host_or_addr(addr, AF_INET) | 81 | #define is_inet_addr(addr) resolve_host_or_addr(addr, AF_INET) |
77 | #ifdef USE_IPV6 | 82 | #ifdef USE_IPV6 |
78 | # define is_inet6_addr(addr) resolve_host_or_addr(addr, AF_INET6) | 83 | # define is_inet6_addr(addr) resolve_host_or_addr(addr, AF_INET6) |
@@ -91,6 +96,16 @@ RETSIGTYPE socket_timeout_alarm_handler (int) __attribute__((noreturn)); | |||
91 | 96 | ||
92 | /* SSL-Related functionality */ | 97 | /* SSL-Related functionality */ |
93 | #ifdef HAVE_SSL | 98 | #ifdef HAVE_SSL |
99 | # define MP_SSLv2 1 | ||
100 | # define MP_SSLv3 2 | ||
101 | # define MP_TLSv1 3 | ||
102 | # define MP_TLSv1_1 4 | ||
103 | # define MP_TLSv1_2 5 | ||
104 | # define MP_SSLv2_OR_NEWER 6 | ||
105 | # define MP_SSLv3_OR_NEWER 7 | ||
106 | # define MP_TLSv1_OR_NEWER 8 | ||
107 | # define MP_TLSv1_1_OR_NEWER 9 | ||
108 | # define MP_TLSv1_2_OR_NEWER 10 | ||
94 | /* maybe this could be merged with the above np_net_connect, via some flags */ | 109 | /* maybe this could be merged with the above np_net_connect, via some flags */ |
95 | int np_net_ssl_init(int sd); | 110 | int np_net_ssl_init(int sd); |
96 | int np_net_ssl_init_with_hostname(int sd, char *host_name); | 111 | int np_net_ssl_init_with_hostname(int sd, char *host_name); |
diff --git a/plugins/sslutils.c b/plugins/sslutils.c index c9882c6..b412ef3 100644 --- a/plugins/sslutils.c +++ b/plugins/sslutils.c | |||
@@ -49,28 +49,78 @@ int np_net_ssl_init_with_hostname_and_version(int sd, char *host_name, int versi | |||
49 | 49 | ||
50 | int np_net_ssl_init_with_hostname_version_and_cert(int sd, char *host_name, int version, char *cert, char *privkey) { | 50 | int np_net_ssl_init_with_hostname_version_and_cert(int sd, char *host_name, int version, char *cert, char *privkey) { |
51 | SSL_METHOD *method = NULL; | 51 | SSL_METHOD *method = NULL; |
52 | long options = 0; | ||
52 | 53 | ||
53 | switch (version) { | 54 | switch (version) { |
54 | case 0: /* Deafult to auto negotiation */ | 55 | case MP_SSLv2: /* SSLv2 protocol */ |
55 | method = SSLv23_client_method(); | ||
56 | break; | ||
57 | case 1: /* TLSv1 protocol */ | ||
58 | method = TLSv1_client_method(); | ||
59 | break; | ||
60 | case 2: /* SSLv2 protocol */ | ||
61 | #if defined(USE_GNUTLS) || defined(OPENSSL_NO_SSL2) | 56 | #if defined(USE_GNUTLS) || defined(OPENSSL_NO_SSL2) |
62 | printf(("%s\n", _("CRITICAL - SSL protocol version 2 is not supported by your SSL library."))); | 57 | printf("%s\n", _("UNKNOWN - SSL protocol version 2 is not supported by your SSL library.")); |
63 | return STATE_CRITICAL; | 58 | return STATE_UNKNOWN; |
64 | #else | 59 | #else |
65 | method = SSLv2_client_method(); | 60 | method = SSLv2_client_method(); |
66 | #endif | ||
67 | break; | 61 | break; |
68 | case 3: /* SSLv3 protocol */ | 62 | #endif |
63 | case MP_SSLv3: /* SSLv3 protocol */ | ||
64 | #if defined(OPENSSL_NO_SSL3) | ||
65 | printf("%s\n", _("UNKNOWN - SSL protocol version 3 is not supported by your SSL library.")); | ||
66 | return STATE_UNKNOWN; | ||
67 | #else | ||
69 | method = SSLv3_client_method(); | 68 | method = SSLv3_client_method(); |
70 | break; | 69 | break; |
71 | default: /* Unsupported */ | 70 | #endif |
72 | printf("%s\n", _("CRITICAL - Unsupported SSL protocol version.")); | 71 | case MP_TLSv1: /* TLSv1 protocol */ |
73 | return STATE_CRITICAL; | 72 | #if defined(OPENSSL_NO_TLS1) |
73 | printf("%s\n", _("UNKNOWN - TLS protocol version 1 is not supported by your SSL library.")); | ||
74 | return STATE_UNKNOWN; | ||
75 | #else | ||
76 | method = TLSv1_client_method(); | ||
77 | break; | ||
78 | #endif | ||
79 | case MP_TLSv1_1: /* TLSv1.1 protocol */ | ||
80 | #if !defined(SSL_OP_NO_TLSv1_1) | ||
81 | printf("%s\n", _("UNKNOWN - TLS protocol version 1.1 is not supported by your SSL library.")); | ||
82 | return STATE_UNKNOWN; | ||
83 | #else | ||
84 | method = TLSv1_1_client_method(); | ||
85 | break; | ||
86 | #endif | ||
87 | case MP_TLSv1_2: /* TLSv1.2 protocol */ | ||
88 | #if !defined(SSL_OP_NO_TLSv1_2) | ||
89 | printf("%s\n", _("UNKNOWN - TLS protocol version 1.2 is not supported by your SSL library.")); | ||
90 | return STATE_UNKNOWN; | ||
91 | #else | ||
92 | method = TLSv1_2_client_method(); | ||
93 | break; | ||
94 | #endif | ||
95 | case MP_TLSv1_2_OR_NEWER: | ||
96 | #if !defined(SSL_OP_NO_TLSv1_1) | ||
97 | printf("%s\n", _("UNKNOWN - Disabling TLSv1.1 is not supported by your SSL library.")); | ||
98 | return STATE_UNKNOWN; | ||
99 | #else | ||
100 | options |= SSL_OP_NO_TLSv1_1; | ||
101 | #endif | ||
102 | /* FALLTHROUGH */ | ||
103 | case MP_TLSv1_1_OR_NEWER: | ||
104 | #if !defined(SSL_OP_NO_TLSv1) | ||
105 | printf("%s\n", _("UNKNOWN - Disabling TLSv1 is not supported by your SSL library.")); | ||
106 | return STATE_UNKNOWN; | ||
107 | #else | ||
108 | options |= SSL_OP_NO_TLSv1; | ||
109 | #endif | ||
110 | /* FALLTHROUGH */ | ||
111 | case MP_TLSv1_OR_NEWER: | ||
112 | #if defined(SSL_OP_NO_SSLv3) | ||
113 | options |= SSL_OP_NO_SSLv3; | ||
114 | #endif | ||
115 | /* FALLTHROUGH */ | ||
116 | case MP_SSLv3_OR_NEWER: | ||
117 | #if defined(SSL_OP_NO_SSLv2) | ||
118 | options |= SSL_OP_NO_SSLv2; | ||
119 | #endif | ||
120 | case MP_SSLv2_OR_NEWER: | ||
121 | /* FALLTHROUGH */ | ||
122 | default: /* Default to auto negotiation */ | ||
123 | method = SSLv23_client_method(); | ||
74 | } | 124 | } |
75 | if (!initialized) { | 125 | if (!initialized) { |
76 | /* Initialize SSL context */ | 126 | /* Initialize SSL context */ |
@@ -94,8 +144,9 @@ int np_net_ssl_init_with_hostname_version_and_cert(int sd, char *host_name, int | |||
94 | #endif | 144 | #endif |
95 | } | 145 | } |
96 | #ifdef SSL_OP_NO_TICKET | 146 | #ifdef SSL_OP_NO_TICKET |
97 | SSL_CTX_set_options(c, SSL_OP_NO_TICKET); | 147 | options |= SSL_OP_NO_TICKET; |
98 | #endif | 148 | #endif |
149 | SSL_CTX_set_options(c, options); | ||
99 | SSL_CTX_set_mode(c, SSL_MODE_AUTO_RETRY); | 150 | SSL_CTX_set_mode(c, SSL_MODE_AUTO_RETRY); |
100 | if ((s = SSL_new(c)) != NULL) { | 151 | if ((s = SSL_new(c)) != NULL) { |
101 | #ifdef SSL_set_tlsext_host_name | 152 | #ifdef SSL_set_tlsext_host_name |
@@ -146,6 +197,7 @@ int np_net_ssl_check_cert(int days_till_exp_warn, int days_till_exp_crit){ | |||
146 | X509_NAME *subj=NULL; | 197 | X509_NAME *subj=NULL; |
147 | char timestamp[50] = ""; | 198 | char timestamp[50] = ""; |
148 | char cn[MAX_CN_LENGTH]= ""; | 199 | char cn[MAX_CN_LENGTH]= ""; |
200 | char *tz; | ||
149 | 201 | ||
150 | int cnlen =-1; | 202 | int cnlen =-1; |
151 | int status=STATE_UNKNOWN; | 203 | int status=STATE_UNKNOWN; |
@@ -213,10 +265,18 @@ int np_net_ssl_check_cert(int days_till_exp_warn, int days_till_exp_crit){ | |||
213 | (tm->data[10 + offset] - '0') * 10 + (tm->data[11 + offset] - '0'); | 265 | (tm->data[10 + offset] - '0') * 10 + (tm->data[11 + offset] - '0'); |
214 | stamp.tm_isdst = -1; | 266 | stamp.tm_isdst = -1; |
215 | 267 | ||
216 | time_left = difftime(timegm(&stamp), time(NULL)); | 268 | tm_t = timegm(&stamp); |
269 | time_left = difftime(tm_t, time(NULL)); | ||
217 | days_left = time_left / 86400; | 270 | days_left = time_left / 86400; |
218 | tm_t = mktime (&stamp); | 271 | tz = getenv("TZ"); |
219 | strftime(timestamp, 50, "%c", localtime(&tm_t)); | 272 | setenv("TZ", "GMT", 1); |
273 | tzset(); | ||
274 | strftime(timestamp, 50, "%c %z", localtime(&tm_t)); | ||
275 | if (tz) | ||
276 | setenv("TZ", tz, 1); | ||
277 | else | ||
278 | unsetenv("TZ"); | ||
279 | tzset(); | ||
220 | 280 | ||
221 | if (days_left > 0 && days_left <= days_till_exp_warn) { | 281 | if (days_left > 0 && days_left <= days_till_exp_warn) { |
222 | printf (_("%s - Certificate '%s' expires in %d day(s) (%s).\n"), (days_left>days_till_exp_crit)?"WARNING":"CRITICAL", cn, days_left, timestamp); | 282 | printf (_("%s - Certificate '%s' expires in %d day(s) (%s).\n"), (days_left>days_till_exp_crit)?"WARNING":"CRITICAL", cn, days_left, timestamp); |
diff --git a/plugins/t/NPTest.cache.travis b/plugins/t/NPTest.cache.travis index fe8aabd..5d9c5ff 100644 --- a/plugins/t/NPTest.cache.travis +++ b/plugins/t/NPTest.cache.travis | |||
@@ -11,7 +11,7 @@ | |||
11 | 'NP_HOST_NONRESPONSIVE' => '10.0.0.1', | 11 | 'NP_HOST_NONRESPONSIVE' => '10.0.0.1', |
12 | 'NP_HOST_RESPONSIVE' => 'localhost', | 12 | 'NP_HOST_RESPONSIVE' => 'localhost', |
13 | 'NP_HOST_SMB' => '', | 13 | 'NP_HOST_SMB' => '', |
14 | 'NP_HOST_SNMP' => '', | 14 | 'NP_HOST_SNMP' => 'localhost', |
15 | 'NP_HOST_TCP_FTP' => '', | 15 | 'NP_HOST_TCP_FTP' => '', |
16 | 'NP_HOST_TCP_HPJD' => '', | 16 | 'NP_HOST_TCP_HPJD' => '', |
17 | 'NP_HOST_HPJD_PORT_INVALID' => '161', | 17 | 'NP_HOST_HPJD_PORT_INVALID' => '161', |
@@ -39,7 +39,7 @@ | |||
39 | 'NP_SMB_SHARE_SPC' => '', | 39 | 'NP_SMB_SHARE_SPC' => '', |
40 | 'NP_SMB_VALID_USER' => '', | 40 | 'NP_SMB_VALID_USER' => '', |
41 | 'NP_SMB_VALID_USER_PASS' => '', | 41 | 'NP_SMB_VALID_USER_PASS' => '', |
42 | 'NP_SNMP_COMMUNITY' => '', | 42 | 'NP_SNMP_COMMUNITY' => 'public', |
43 | 'NP_SSH_CONFIGFILE' => '~/.ssh/config', | 43 | 'NP_SSH_CONFIGFILE' => '~/.ssh/config', |
44 | 'NP_SSH_HOST' => 'localhost', | 44 | 'NP_SSH_HOST' => 'localhost', |
45 | 'NP_SSH_IDENTITY' => '~/.ssh/id_dsa', | 45 | 'NP_SSH_IDENTITY' => '~/.ssh/id_dsa', |
diff --git a/plugins/t/check_http.t b/plugins/t/check_http.t index c2caec6..5a90f02 100644 --- a/plugins/t/check_http.t +++ b/plugins/t/check_http.t | |||
@@ -9,7 +9,7 @@ use Test::More; | |||
9 | use POSIX qw/mktime strftime/; | 9 | use POSIX qw/mktime strftime/; |
10 | use NPTest; | 10 | use NPTest; |
11 | 11 | ||
12 | plan tests => 42; | 12 | plan tests => 49; |
13 | 13 | ||
14 | my $successOutput = '/OK.*HTTP.*second/'; | 14 | my $successOutput = '/OK.*HTTP.*second/'; |
15 | 15 | ||
@@ -64,6 +64,32 @@ cmp_ok( $res->return_code, '==', 2, "Webserver $hostname_invalid not valid" ); | |||
64 | # Is also possible to get a socket timeout if DNS is not responding fast enough | 64 | # Is also possible to get a socket timeout if DNS is not responding fast enough |
65 | like( $res->output, "/Unable to open TCP socket|Socket timeout after/", "Output OK"); | 65 | like( $res->output, "/Unable to open TCP socket|Socket timeout after/", "Output OK"); |
66 | 66 | ||
67 | # host header checks | ||
68 | $res = NPTest->testCmd("./check_http -v -H $host_tcp_http"); | ||
69 | like( $res->output, '/^Host: '.$host_tcp_http.'\s*$/ms', "Host Header OK" ); | ||
70 | |||
71 | $res = NPTest->testCmd("./check_http -v -H $host_tcp_http -p 80"); | ||
72 | like( $res->output, '/^Host: '.$host_tcp_http.'\s*$/ms', "Host Header OK" ); | ||
73 | |||
74 | $res = NPTest->testCmd("./check_http -v -H $host_tcp_http:8080 -p 80"); | ||
75 | like( $res->output, '/^Host: '.$host_tcp_http.':8080\s*$/ms', "Host Header OK" ); | ||
76 | |||
77 | $res = NPTest->testCmd("./check_http -v -H $host_tcp_http:8080 -p 80"); | ||
78 | like( $res->output, '/^Host: '.$host_tcp_http.':8080\s*$/ms', "Host Header OK" ); | ||
79 | |||
80 | SKIP: { | ||
81 | skip "No internet access", 3 if $internet_access eq "no"; | ||
82 | |||
83 | $res = NPTest->testCmd("./check_http -v -H www.verisign.com -S"); | ||
84 | like( $res->output, '/^Host: www.verisign.com\s*$/ms', "Host Header OK" ); | ||
85 | |||
86 | $res = NPTest->testCmd("./check_http -v -H www.verisign.com:8080 -S -p 443"); | ||
87 | like( $res->output, '/^Host: www.verisign.com:8080\s*$/ms', "Host Header OK" ); | ||
88 | |||
89 | $res = NPTest->testCmd("./check_http -v -H www.verisign.com:443 -S -p 443"); | ||
90 | like( $res->output, '/^Host: www.verisign.com\s*$/ms', "Host Header OK" ); | ||
91 | }; | ||
92 | |||
67 | SKIP: { | 93 | SKIP: { |
68 | skip "No host serving monitoring in index file", 7 unless $host_tcp_http2; | 94 | skip "No host serving monitoring in index file", 7 unless $host_tcp_http2; |
69 | 95 | ||
@@ -121,9 +147,9 @@ SKIP: { | |||
121 | $res = NPTest->testCmd("LC_TIME=C TZ=UTC ./check_http -C 1 www.verisign.com"); | 147 | $res = NPTest->testCmd("LC_TIME=C TZ=UTC ./check_http -C 1 www.verisign.com"); |
122 | like($res->output, qr/OK - Certificate 'www.verisign.com' will expire on/, "Catch cert output"); | 148 | like($res->output, qr/OK - Certificate 'www.verisign.com' will expire on/, "Catch cert output"); |
123 | is( $res->return_code, 0, "Catch cert output exit code" ); | 149 | is( $res->return_code, 0, "Catch cert output exit code" ); |
124 | my($mon,$day,$hour,$min,$sec,$year) = ($res->output =~ /(\w+)\s+(\d+)\s+(\d+):(\d+):(\d+)\s+(\d+)\./); | 150 | my($mon,$day,$hour,$min,$sec,$year) = ($res->output =~ /(\w+)\s+(\d+)\s+(\d+):(\d+):(\d+)\s+(\d+)/); |
125 | if(!defined $year) { | 151 | if(!defined $year) { |
126 | die("parsing date failed from: ".$res); | 152 | die("parsing date failed from: ".$res->output); |
127 | } | 153 | } |
128 | my $months = {'Jan' => 0, 'Feb' => 1, 'Mar' => 2, 'Apr' => 3, 'May' => 4, 'Jun' => 5, 'Jul' => 6, 'Aug' => 7, 'Sep' => 8, 'Oct' => 9, 'Nov' => 10, 'Dec' => 11}; | 154 | my $months = {'Jan' => 0, 'Feb' => 1, 'Mar' => 2, 'Apr' => 3, 'May' => 4, 'Jun' => 5, 'Jul' => 6, 'Aug' => 7, 'Sep' => 8, 'Oct' => 9, 'Nov' => 10, 'Dec' => 11}; |
129 | my $ts = mktime($sec, $min, $hour, $day, $months->{$mon}, $year-1900); | 155 | my $ts = mktime($sec, $min, $hour, $day, $months->{$mon}, $year-1900); |
@@ -154,7 +180,7 @@ SKIP: { | |||
154 | like ( $res->output, '/time_ssl=[\d\.]+/', 'Extended Performance Data SSL Output OK' ); | 180 | like ( $res->output, '/time_ssl=[\d\.]+/', 'Extended Performance Data SSL Output OK' ); |
155 | 181 | ||
156 | $res = NPTest->testCmd( | 182 | $res = NPTest->testCmd( |
157 | "./check_http --ssl www.e-paycobalt.com" | 183 | "./check_http --ssl -H www.e-paycobalt.com" |
158 | ); | 184 | ); |
159 | cmp_ok( $res->return_code, "==", 0, "Can read https for www.e-paycobalt.com (uses AES certificate)" ); | 185 | cmp_ok( $res->return_code, "==", 0, "Can read https for www.e-paycobalt.com (uses AES certificate)" ); |
160 | 186 | ||
diff --git a/plugins/t/check_snmp.t b/plugins/t/check_snmp.t index 2d6c44a..eff46ea 100644 --- a/plugins/t/check_snmp.t +++ b/plugins/t/check_snmp.t | |||
@@ -10,7 +10,7 @@ use NPTest; | |||
10 | 10 | ||
11 | BEGIN { | 11 | BEGIN { |
12 | plan skip_all => 'check_snmp is not compiled' unless -x "./check_snmp"; | 12 | plan skip_all => 'check_snmp is not compiled' unless -x "./check_snmp"; |
13 | plan tests => 61; | 13 | plan tests => 63; |
14 | } | 14 | } |
15 | 15 | ||
16 | my $res; | 16 | my $res; |
@@ -45,7 +45,7 @@ is( $res->return_code, 3, "Invalid protocol" ); | |||
45 | like( $res->output, "/check_snmp: Invalid SNMP version - 3c/" ); | 45 | like( $res->output, "/check_snmp: Invalid SNMP version - 3c/" ); |
46 | 46 | ||
47 | SKIP: { | 47 | SKIP: { |
48 | skip "no snmp host defined", 48 if ( ! $host_snmp ); | 48 | skip "no snmp host defined", 50 if ( ! $host_snmp ); |
49 | 49 | ||
50 | $res = NPTest->testCmd( "./check_snmp -H $host_snmp -C $snmp_community -o system.sysUpTime.0 -w 1: -c 1:"); | 50 | $res = NPTest->testCmd( "./check_snmp -H $host_snmp -C $snmp_community -o system.sysUpTime.0 -w 1: -c 1:"); |
51 | cmp_ok( $res->return_code, '==', 0, "Exit OK when querying uptime" ); | 51 | cmp_ok( $res->return_code, '==', 0, "Exit OK when querying uptime" ); |
@@ -153,6 +153,10 @@ SKIP: { | |||
153 | $res = NPTest->testCmd( "./check_snmp -H $host_snmp -C $snmp_community -o system.sysUpTime.0"); | 153 | $res = NPTest->testCmd( "./check_snmp -H $host_snmp -C $snmp_community -o system.sysUpTime.0"); |
154 | cmp_ok( $res->return_code, '==', 0, "Timetick used as a string"); | 154 | cmp_ok( $res->return_code, '==', 0, "Timetick used as a string"); |
155 | like($res->output, '/^SNMP OK - Timeticks:\s\(\d+\)\s+(?:\d+ days?,\s+)?\d+:\d+:\d+\.\d+\s.*$/', "Timetick used as a string, result printed rather than parsed"); | 155 | like($res->output, '/^SNMP OK - Timeticks:\s\(\d+\)\s+(?:\d+ days?,\s+)?\d+:\d+:\d+\.\d+\s.*$/', "Timetick used as a string, result printed rather than parsed"); |
156 | |||
157 | $res = NPTest->testCmd( "./check_snmp -H $host_snmp -C $snmp_community -o HOST-RESOURCES-MIB::hrSWRunParameters.1"); | ||
158 | cmp_ok( $res->return_code, '==', 0, "Timetick used as a string"); | ||
159 | is( $res->output, 'SNMP OK - "" | ', "snmp response without datatype" ); | ||
156 | } | 160 | } |
157 | 161 | ||
158 | SKIP: { | 162 | SKIP: { |
@@ -166,8 +170,8 @@ SKIP: { | |||
166 | SKIP: { | 170 | SKIP: { |
167 | skip "no non responsive host defined", 2 if ( ! $host_nonresponsive ); | 171 | skip "no non responsive host defined", 2 if ( ! $host_nonresponsive ); |
168 | $res = NPTest->testCmd( "./check_snmp -H $host_nonresponsive -C np_foobar -o system.sysUpTime.0 -w 1: -c 1:"); | 172 | $res = NPTest->testCmd( "./check_snmp -H $host_nonresponsive -C np_foobar -o system.sysUpTime.0 -w 1: -c 1:"); |
169 | cmp_ok( $res->return_code, '==', 3, "Exit UNKNOWN with non responsive host" ); | 173 | cmp_ok( $res->return_code, '==', 2, "Exit CRITICAL with non responsive host" ); |
170 | like($res->output, '/External command error: Timeout: No Response from /', "String matches timeout problem"); | 174 | like($res->output, '/Plugin timed out while executing system call/', "String matches timeout problem"); |
171 | } | 175 | } |
172 | 176 | ||
173 | SKIP: { | 177 | SKIP: { |
diff --git a/plugins/t/check_users.t b/plugins/t/check_users.t index 39044bb..088f3b5 100644 --- a/plugins/t/check_users.t +++ b/plugins/t/check_users.t | |||
@@ -13,7 +13,7 @@ use Test; | |||
13 | use NPTest; | 13 | use NPTest; |
14 | 14 | ||
15 | use vars qw($tests); | 15 | use vars qw($tests); |
16 | BEGIN {$tests = 4; plan tests => $tests} | 16 | BEGIN {$tests = 8; plan tests => $tests} |
17 | 17 | ||
18 | my $successOutput = '/^USERS OK - [0-9]+ users currently logged in/'; | 18 | my $successOutput = '/^USERS OK - [0-9]+ users currently logged in/'; |
19 | my $failureOutput = '/^USERS CRITICAL - [0-9]+ users currently logged in/'; | 19 | my $failureOutput = '/^USERS CRITICAL - [0-9]+ users currently logged in/'; |
@@ -22,6 +22,8 @@ my $t; | |||
22 | 22 | ||
23 | $t += checkCmd( "./check_users 1000 1000", 0, $successOutput ); | 23 | $t += checkCmd( "./check_users 1000 1000", 0, $successOutput ); |
24 | $t += checkCmd( "./check_users 0 0", 2, $failureOutput ); | 24 | $t += checkCmd( "./check_users 0 0", 2, $failureOutput ); |
25 | $t += checkCmd( "./check_users -w 0:1000 -c 0:1000", 0, $successOutput ); | ||
26 | $t += checkCmd( "./check_users -w 0:0 -c 0:0", 2, $failureOutput ); | ||
25 | 27 | ||
26 | exit(0) if defined($Test::Harness::VERSION); | 28 | exit(0) if defined($Test::Harness::VERSION); |
27 | exit($tests - $t); | 29 | exit($tests - $t); |
diff --git a/plugins/tests/check_http.t b/plugins/tests/check_http.t index e72d243..1bc0ecb 100755 --- a/plugins/tests/check_http.t +++ b/plugins/tests/check_http.t | |||
@@ -17,6 +17,8 @@ use Test::More; | |||
17 | use NPTest; | 17 | use NPTest; |
18 | use FindBin qw($Bin); | 18 | use FindBin qw($Bin); |
19 | 19 | ||
20 | $ENV{'LC_TIME'} = "C"; | ||
21 | |||
20 | my $common_tests = 70; | 22 | my $common_tests = 70; |
21 | my $ssl_only_tests = 8; | 23 | my $ssl_only_tests = 8; |
22 | # Check that all dependent modules are available | 24 | # Check that all dependent modules are available |
@@ -186,21 +188,21 @@ SKIP: { | |||
186 | 188 | ||
187 | $result = NPTest->testCmd( "$command -p $port_https -S -C 14" ); | 189 | $result = NPTest->testCmd( "$command -p $port_https -S -C 14" ); |
188 | is( $result->return_code, 0, "$command -p $port_https -S -C 14" ); | 190 | is( $result->return_code, 0, "$command -p $port_https -S -C 14" ); |
189 | is( $result->output, 'OK - Certificate \'Ton Voon\' will expire on Sun Mar 3 21:41:28 2019.', "output ok" ); | 191 | is( $result->output, 'OK - Certificate \'Ton Voon\' will expire on Sun Mar 3 21:41:28 2019 +0000.', "output ok" ); |
190 | 192 | ||
191 | $result = NPTest->testCmd( "$command -p $port_https -S -C 14000" ); | 193 | $result = NPTest->testCmd( "$command -p $port_https -S -C 14000" ); |
192 | is( $result->return_code, 1, "$command -p $port_https -S -C 14000" ); | 194 | is( $result->return_code, 1, "$command -p $port_https -S -C 14000" ); |
193 | like( $result->output, '/WARNING - Certificate \'Ton Voon\' expires in \d+ day\(s\) \(Sun Mar 3 21:41:28 2019\)./', "output ok" ); | 195 | like( $result->output, '/WARNING - Certificate \'Ton Voon\' expires in \d+ day\(s\) \(Sun Mar 3 21:41:28 2019 \+0000\)./', "output ok" ); |
194 | 196 | ||
195 | # Expired cert tests | 197 | # Expired cert tests |
196 | $result = NPTest->testCmd( "$command -p $port_https -S -C 13960,14000" ); | 198 | $result = NPTest->testCmd( "$command -p $port_https -S -C 13960,14000" ); |
197 | is( $result->return_code, 2, "$command -p $port_https -S -C 13960,14000" ); | 199 | is( $result->return_code, 2, "$command -p $port_https -S -C 13960,14000" ); |
198 | like( $result->output, '/CRITICAL - Certificate \'Ton Voon\' expires in \d+ day\(s\) \(Sun Mar 3 21:41:28 2019\)./', "output ok" ); | 200 | like( $result->output, '/CRITICAL - Certificate \'Ton Voon\' expires in \d+ day\(s\) \(Sun Mar 3 21:41:28 2019 \+0000\)./', "output ok" ); |
199 | 201 | ||
200 | $result = NPTest->testCmd( "$command -p $port_https_expired -S -C 7" ); | 202 | $result = NPTest->testCmd( "$command -p $port_https_expired -S -C 7" ); |
201 | is( $result->return_code, 2, "$command -p $port_https_expired -S -C 7" ); | 203 | is( $result->return_code, 2, "$command -p $port_https_expired -S -C 7" ); |
202 | is( $result->output, | 204 | is( $result->output, |
203 | 'CRITICAL - Certificate \'Ton Voon\' expired on Thu Mar 5 00:13:16 2009.', | 205 | 'CRITICAL - Certificate \'Ton Voon\' expired on Thu Mar 5 00:13:16 2009 +0000.', |
204 | "output ok" ); | 206 | "output ok" ); |
205 | 207 | ||
206 | } | 208 | } |
diff --git a/plugins/utils.c b/plugins/utils.c index a864e4a..231af92 100644 --- a/plugins/utils.c +++ b/plugins/utils.c | |||
@@ -668,3 +668,44 @@ char *sperfdata (const char *label, | |||
668 | 668 | ||
669 | return data; | 669 | return data; |
670 | } | 670 | } |
671 | |||
672 | char *sperfdata_int (const char *label, | ||
673 | int val, | ||
674 | const char *uom, | ||
675 | char *warn, | ||
676 | char *crit, | ||
677 | int minp, | ||
678 | int minv, | ||
679 | int maxp, | ||
680 | int maxv) | ||
681 | { | ||
682 | char *data = NULL; | ||
683 | if (strpbrk (label, "'= ")) | ||
684 | xasprintf (&data, "'%s'=", label); | ||
685 | else | ||
686 | xasprintf (&data, "%s=", label); | ||
687 | |||
688 | xasprintf (&data, "%s%d", data, val); | ||
689 | xasprintf (&data, "%s%s;", data, uom); | ||
690 | |||
691 | if (warn!=NULL) | ||
692 | xasprintf (&data, "%s%s", data, warn); | ||
693 | |||
694 | xasprintf (&data, "%s;", data); | ||
695 | |||
696 | if (crit!=NULL) | ||
697 | xasprintf (&data, "%s%s", data, crit); | ||
698 | |||
699 | xasprintf (&data, "%s;", data); | ||
700 | |||
701 | if (minp) | ||
702 | xasprintf (&data, "%s%d", data, minv); | ||
703 | |||
704 | if (maxp) { | ||
705 | xasprintf (&data, "%s;", data); | ||
706 | xasprintf (&data, "%s%d", data, maxv); | ||
707 | } | ||
708 | |||
709 | return data; | ||
710 | } | ||
711 | |||
diff --git a/plugins/utils.h b/plugins/utils.h index 4c4aacc..a436e1c 100644 --- a/plugins/utils.h +++ b/plugins/utils.h | |||
@@ -94,29 +94,17 @@ const char *state_text (int); | |||
94 | #define max(a,b) (((a)>(b))?(a):(b)) | 94 | #define max(a,b) (((a)>(b))?(a):(b)) |
95 | #define min(a,b) (((a)<(b))?(a):(b)) | 95 | #define min(a,b) (((a)<(b))?(a):(b)) |
96 | 96 | ||
97 | char *perfdata (const char *, | 97 | char *perfdata (const char *, long int, const char *, int, long int, |
98 | long int, | 98 | int, long int, int, long int, int, long int); |
99 | const char *, | 99 | |
100 | int, | 100 | char *fperfdata (const char *, double, const char *, int, double, |
101 | long int, | 101 | int, double, int, double, int, double); |
102 | int, | 102 | |
103 | long int, | 103 | char *sperfdata (const char *, double, const char *, char *, char *, |
104 | int, | 104 | int, double, int, double); |
105 | long int, | 105 | |
106 | int, | 106 | char *sperfdata_int (const char *, int, const char *, char *, char *, |
107 | long int); | 107 | int, int, int, int); |
108 | |||
109 | char *fperfdata (const char *, | ||
110 | double, | ||
111 | const char *, | ||
112 | int, | ||
113 | double, | ||
114 | int, | ||
115 | double, | ||
116 | int, | ||
117 | double, | ||
118 | int, | ||
119 | double); | ||
120 | 108 | ||
121 | /* The idea here is that, although not every plugin will use all of these, | 109 | /* The idea here is that, although not every plugin will use all of these, |
122 | most will or should. Therefore, for consistency, these very common | 110 | most will or should. Therefore, for consistency, these very common |