diff options
| -rw-r--r-- | THANKS.in | 2 | ||||
| -rw-r--r-- | lib/utils_base.c | 15 | ||||
| -rw-r--r-- | plugins/check_dig.c | 9 | ||||
| -rw-r--r-- | plugins/check_disk.c | 16 | ||||
| -rwxr-xr-x | tools/generate-change-log | 2 |
5 files changed, 31 insertions, 13 deletions
| @@ -326,4 +326,6 @@ Mikael Falkvidd | |||
| 326 | Patric Wust | 326 | Patric Wust |
| 327 | Julius Kriukas | 327 | Julius Kriukas |
| 328 | Patrick McAndrew | 328 | Patrick McAndrew |
| 329 | Alexander Wittig | ||
| 330 | Jason Benguerel | ||
| 329 | Matthew Kent | 331 | Matthew Kent |
diff --git a/lib/utils_base.c b/lib/utils_base.c index addf26bd..4fb6375d 100644 --- a/lib/utils_base.c +++ b/lib/utils_base.c | |||
| @@ -446,6 +446,7 @@ void np_enable_state(char *keyname, int expected_data_version) { | |||
| 446 | char *temp_filename = NULL; | 446 | char *temp_filename = NULL; |
| 447 | char *temp_keyname = NULL; | 447 | char *temp_keyname = NULL; |
| 448 | char *p=NULL; | 448 | char *p=NULL; |
| 449 | int ret; | ||
| 449 | 450 | ||
| 450 | if(this_monitoring_plugin==NULL) | 451 | if(this_monitoring_plugin==NULL) |
| 451 | die(STATE_UNKNOWN, _("This requires np_init to be called")); | 452 | die(STATE_UNKNOWN, _("This requires np_init to be called")); |
| @@ -476,9 +477,13 @@ void np_enable_state(char *keyname, int expected_data_version) { | |||
| 476 | this_state->state_data=NULL; | 477 | this_state->state_data=NULL; |
| 477 | 478 | ||
| 478 | /* Calculate filename */ | 479 | /* Calculate filename */ |
| 479 | asprintf(&temp_filename, "%s/%lu/%s/%s", | 480 | ret = xasprintf(&temp_filename, "%s/%lu/%s/%s", |
| 480 | _np_state_calculate_location_prefix(), (unsigned long)geteuid(), | 481 | _np_state_calculate_location_prefix(), (unsigned long)geteuid(), |
| 481 | this_monitoring_plugin->plugin_name, this_state->name); | 482 | this_monitoring_plugin->plugin_name, this_state->name); |
| 483 | if (ret < 0) | ||
| 484 | die(STATE_UNKNOWN, _("Cannot allocate memory: %s"), | ||
| 485 | strerror(errno)); | ||
| 486 | |||
| 482 | this_state->_filename=temp_filename; | 487 | this_state->_filename=temp_filename; |
| 483 | 488 | ||
| 484 | this_monitoring_plugin->state = this_state; | 489 | this_monitoring_plugin->state = this_state; |
| @@ -614,8 +619,8 @@ void np_state_write_string(time_t data_time, char *data_string) { | |||
| 614 | 619 | ||
| 615 | /* If file doesn't currently exist, create directories */ | 620 | /* If file doesn't currently exist, create directories */ |
| 616 | if(access(this_monitoring_plugin->state->_filename,F_OK)!=0) { | 621 | if(access(this_monitoring_plugin->state->_filename,F_OK)!=0) { |
| 617 | asprintf(&directories, "%s", this_monitoring_plugin->state->_filename); | 622 | result = xasprintf(&directories, "%s", this_monitoring_plugin->state->_filename); |
| 618 | if(directories==NULL) | 623 | if(result < 0) |
| 619 | die(STATE_UNKNOWN, _("Cannot allocate memory: %s"), | 624 | die(STATE_UNKNOWN, _("Cannot allocate memory: %s"), |
| 620 | strerror(errno)); | 625 | strerror(errno)); |
| 621 | 626 | ||
| @@ -633,8 +638,8 @@ void np_state_write_string(time_t data_time, char *data_string) { | |||
| 633 | np_free(directories); | 638 | np_free(directories); |
| 634 | } | 639 | } |
| 635 | 640 | ||
| 636 | asprintf(&temp_file,"%s.XXXXXX",this_monitoring_plugin->state->_filename); | 641 | result = xasprintf(&temp_file,"%s.XXXXXX",this_monitoring_plugin->state->_filename); |
| 637 | if(temp_file==NULL) | 642 | if(result < 0) |
| 638 | die(STATE_UNKNOWN, _("Cannot allocate memory: %s"), | 643 | die(STATE_UNKNOWN, _("Cannot allocate memory: %s"), |
| 639 | strerror(errno)); | 644 | strerror(errno)); |
| 640 | 645 | ||
diff --git a/plugins/check_dig.c b/plugins/check_dig.c index d9481f2d..d899b119 100644 --- a/plugins/check_dig.c +++ b/plugins/check_dig.c | |||
| @@ -94,8 +94,8 @@ main (int argc, char **argv) | |||
| 94 | timeout_interval_dig = timeout_interval / number_tries + number_tries; | 94 | timeout_interval_dig = timeout_interval / number_tries + number_tries; |
| 95 | 95 | ||
| 96 | /* get the command to run */ | 96 | /* get the command to run */ |
| 97 | xasprintf (&command_line, "%s @%s -p %d %s -t %s %s %s +tries=%d +time=%d", | 97 | xasprintf (&command_line, "%s %s %s -p %d @%s %s %s +tries=%d +time=%d", |
| 98 | PATH_TO_DIG, dns_server, server_port, query_address, record_type, dig_args, query_transport, number_tries, timeout_interval_dig); | 98 | PATH_TO_DIG, dig_args, query_transport, server_port, dns_server, query_address, record_type, number_tries, timeout_interval_dig); |
| 99 | 99 | ||
| 100 | alarm (timeout_interval); | 100 | alarm (timeout_interval); |
| 101 | gettimeofday (&tv, NULL); | 101 | gettimeofday (&tv, NULL); |
| @@ -296,7 +296,10 @@ process_arguments (int argc, char **argv) | |||
| 296 | dns_server = argv[c]; | 296 | dns_server = argv[c]; |
| 297 | } | 297 | } |
| 298 | else { | 298 | else { |
| 299 | dns_server = strdup ("127.0.0.1"); | 299 | if (strcmp(query_transport,"-6") == 0) |
| 300 | dns_server = strdup("::1"); | ||
| 301 | else | ||
| 302 | dns_server = strdup ("127.0.0.1"); | ||
| 300 | } | 303 | } |
| 301 | } | 304 | } |
| 302 | 305 | ||
diff --git a/plugins/check_disk.c b/plugins/check_disk.c index 925dfa82..0d73a4f1 100644 --- a/plugins/check_disk.c +++ b/plugins/check_disk.c | |||
| @@ -171,6 +171,7 @@ main (int argc, char **argv) | |||
| 171 | char *details; | 171 | char *details; |
| 172 | char *perf; | 172 | char *perf; |
| 173 | char *preamble; | 173 | char *preamble; |
| 174 | char *flag_header; | ||
| 174 | double inode_space_pct; | 175 | double inode_space_pct; |
| 175 | double warning_high_tide; | 176 | double warning_high_tide; |
| 176 | double critical_high_tide; | 177 | double critical_high_tide; |
| @@ -353,18 +354,23 @@ main (int argc, char **argv) | |||
| 353 | if (disk_result==STATE_OK && erronly && !verbose) | 354 | if (disk_result==STATE_OK && erronly && !verbose) |
| 354 | continue; | 355 | continue; |
| 355 | 356 | ||
| 356 | xasprintf (&output, "%s %s %.0f %s (%.0f%%", | 357 | if(disk_result && verbose >= 1) { |
| 357 | output, | 358 | xasprintf(&flag_header, " %s [", state_text (disk_result)); |
| 359 | } else { | ||
| 360 | xasprintf(&flag_header, ""); | ||
| 361 | } | ||
| 362 | xasprintf (&output, "%s%s %s %.0f %s (%.0f%%", | ||
| 363 | output, flag_header, | ||
| 358 | (!strcmp(me->me_mountdir, "none") || display_mntp) ? me->me_devname : me->me_mountdir, | 364 | (!strcmp(me->me_mountdir, "none") || display_mntp) ? me->me_devname : me->me_mountdir, |
| 359 | path->dfree_units, | 365 | path->dfree_units, |
| 360 | units, | 366 | units, |
| 361 | path->dfree_pct); | 367 | path->dfree_pct); |
| 362 | if (path->dused_inodes_percent < 0) { | 368 | if (path->dused_inodes_percent < 0) { |
| 363 | xasprintf(&output, "%s inode=-);", output); | 369 | xasprintf(&output, "%s inode=-)%s;", output, (disk_result ? "]" : "")); |
| 364 | } else { | 370 | } else { |
| 365 | xasprintf(&output, "%s inode=%.0f%%);", output, path->dfree_inodes_percent ); | 371 | xasprintf(&output, "%s inode=%.0f%%)%s;", output, path->dfree_inodes_percent, ((disk_result && verbose >= 1) ? "]" : "")); |
| 366 | } | 372 | } |
| 367 | 373 | free(flag_header); | |
| 368 | /* TODO: Need to do a similar debug line | 374 | /* TODO: Need to do a similar debug line |
| 369 | xasprintf (&details, _("%s\n\ | 375 | xasprintf (&details, _("%s\n\ |
| 370 | %.0f of %.0f %s (%.0f%% inode=%.0f%%) free on %s (type %s mounted on %s) warn:%lu crit:%lu warn%%:%.0f%% crit%%:%.0f%%"), | 376 | %.0f of %.0f %s (%.0f%% inode=%.0f%%) free on %s (type %s mounted on %s) warn:%lu crit:%lu warn%%:%.0f%% crit%%:%.0f%%"), |
diff --git a/tools/generate-change-log b/tools/generate-change-log index 3a6b38e7..ad19ce96 100755 --- a/tools/generate-change-log +++ b/tools/generate-change-log | |||
| @@ -19,6 +19,7 @@ use Text::Wrap; | |||
| 19 | 19 | ||
| 20 | # The lines will have a length of no more than $columns - 1. | 20 | # The lines will have a length of no more than $columns - 1. |
| 21 | $Text::Wrap::columns = 81; | 21 | $Text::Wrap::columns = 81; |
| 22 | $Text::Wrap::huge = 'overflow'; | ||
| 22 | 23 | ||
| 23 | if (system('git rev-parse --git-dir >/dev/null 2>&1') != 0) { | 24 | if (system('git rev-parse --git-dir >/dev/null 2>&1') != 0) { |
| 24 | print "Not a Git repository, so I won't update the ChangeLog.\n"; | 25 | print "Not a Git repository, so I won't update the ChangeLog.\n"; |
| @@ -51,6 +52,7 @@ while ($git_log =~ /$regex/gm) { | |||
| 51 | $prev_date = $commit{date}; | 52 | $prev_date = $commit{date}; |
| 52 | $prev_name = $commit{name}; | 53 | $prev_name = $commit{name}; |
| 53 | $prev_email = $commit{email}; | 54 | $prev_email = $commit{email}; |
| 55 | $commit{message} =~ s/\s*Signed\-off\-by.*$//sgmx; | ||
| 54 | 56 | ||
| 55 | my @files = split(/\n/, $commit{files}); | 57 | my @files = split(/\n/, $commit{files}); |
| 56 | my @message = map { s/^ {4}//; $_ } split(/\n/, $commit{message}); | 58 | my @message = map { s/^ {4}//; $_ } split(/\n/, $commit{message}); |
