summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2010-07-09Fix --help output when MAX_OIDS is altered.Thomas Guyot-Sionnest4-235/+277
2010-07-07Fix examples in check_disk, where it implied was possible to suffix unit ↵Ton Voon2-2/+3
values to warn/crit parameters
2010-07-07Allow check_ifstatus to accept version=2cTon Voon3-2/+7
2010-07-02Fix cmd_run overwriting the environmentThomas Guyot-Sionnest2-4/+6
Some commands need the environment to function properly. One such example is check_ssh and check_by_ssh when a SOCKS proxy is required. This patch use setenv and extern char **environ to alter and pass the new environment to the child process Those modules have been added to Gnulib for portability.
2010-07-02Import the environ module from gnulib (86ba51)Thomas Guyot-Sionnest2-2/+3
2010-07-02git-notify: Be careful with "--no-merge"Holger Weiss1-5/+6
The "-X" option (which asks git-notify to not report merge commits) was implemented by setting the "--no-merge" option on each invocation of git-rev-list(1). However, we do not only use git-rev-list(1) to get the list of new commits, but also to check whether the old branch head (or tag) is a parent of the new branch head (or tag). For this latter check, the "--no-merge" option should not be set; otherwise, git-notify would be fooled to believe that the branch has been rewritten if the old head was a merge commit.
2010-06-30Corrected rate_multiplier calculationtonvoon2-2/+2
2010-06-30Removed suffix of "-rate" and let user decide label via --labeltonvoon2-7/+5
2010-06-30Tests for --rate-multiplier optiontonvoon2-1/+14
2010-06-30Merge branch 'master' of ↵Ton Voon1-1/+1
ssh://tonvoon@nagiosplug.git.sourceforge.net/gitroot/nagiosplug/nagiosplug
2010-06-30Fixed rate-multiplier optionTon Voon1-4/+8
2010-06-25Add test file directorytonvoon1-1/+1
2010-06-24Cleanup some warnings displayed from IRIX tinderbox serverTon Voon2-14/+9
2010-06-24Added unsetenv and setenv from gnulibTon Voon12-2/+1039
2010-06-24Added strsep to gnulib, for check_snmp.cTon Voon5-2/+101
2010-06-23Added option to invert search resultstonvoon7-521/+741
2010-06-23Display missing search string and URL when failed (Duncan Ferguson #2999924)tonvoon3-2/+16
2010-06-23Added state retention APIs. Implemented for check_snmp with --rate option.Ton Voon63-1020/+2320
See http://nagiosplugin.org/c-api-private for more details on the API. Also updated check_snmp -l option to change the perfdata label.
2010-06-18NEWS entry for last commitThomas Guyot-Sionnest1-0/+1
2010-06-18Attempt at detecting 64bit compilation flags between gcc, old, and new ↵Thomas Guyot-Sionnest1-3/+62
versions of sun cc Gcc accepts -m64, just as newer version of Suncc. Older Suncc required -xarch=v9 (SPARC) or -xarch=amd64 (x86-64) to generate 64bit code.
2010-05-08Add missing --fqdn help (Jan Wagner)Thomas Guyot-Sionnest1-2/+4
2010-04-28Update extra-opts help text based on ML agreementThomas Guyot-Sionnest4-71/+58
2010-04-28tools/distclean: use git-clean when possibleThomas Guyot-Sionnest2-0/+13
git-clean is much faster and more reliable... Also add confdefs.h in gitignore, although this file is normally removed at the end of the configure script.
2010-04-28Update libtoolThomas Guyot-Sionnest6-3455/+12980
Nagios-plugins wouldn't compile on Ubuntu 10.04 (Lucid) with the old libtool
2010-04-22Add newline after "Usage:" in --helpThomas Guyot-Sionnest41-41/+41
2010-04-22Split long line in check_cluster --helpThomas Guyot-Sionnest1-1/+2
2010-04-22Update French translations with extra-opts changeThomas Guyot-Sionnest3-424/+391
2010-04-22Standardize the extra-opts notesThomas Guyot-Sionnest40-196/+1
2010-04-22Fix tests and update NEWS fileThomas Guyot-Sionnest2-4/+50
2010-04-22Replace the lousy multiline parser with a robust one.Thomas Guyot-Sionnest1-8/+49
This one counts double quotes and backslashes so it should handle any level of escaping.
2010-04-22Attempt at fixing check_snmp multiline output:Thomas Guyot-Sionnest2-9/+32
This patch tries to detect and output nicely multi-line strings. This method is broken by design; only a count of double-quotes and escapes could work in every situation.
2010-04-15Updated Nagios::Plugin librarytonvoon3-0/+1
2010-04-14git-notify: Fix the ordering of commitsHolger Weiss1-1/+1
If notifications for multiple commits are created, sort them chronologically instead of in reverse chronological order.
2010-04-14Fix translations when extra-opts aren't enabledThomas Guyot-Sionnest48-289/+631
Bug #2832884 reported problem with translations outputting pot file headers. This is caused by "" matching the header of the translation files. This patch moves gettext macros inside utils macros and update some french translations.
2010-04-14Update french translation (fix all fuzzy's)Thomas Guyot-Sionnest5-4241/+4534
2010-04-14Fix check_radius returning OK on unexpected resultsThomas Guyot-Sionnest3-2/+14
REJECT_RC is defined on some radiusclient versions and differenciates between auth errors and bad responses. This patch will affect only the behaviour of those clients exporting REJECT_RC. In addition, unexpected return codes are now handled properly and return UNKNOWN.
2010-04-14TypoThomas Guyot-Sionnest1-1/+1
2010-04-14pst3.c must not use nagiosplug/gnulib includesThomas Guyot-Sionnest3-3/+6
2010-04-13Sync with the latest Gnulib code (177f525)Thomas Guyot-Sionnest273-11261/+20118
Signed-off-by: Thomas Guyot-Sionnest <dermoth@aei.ca>
2010-04-12Fix typoHolger Weiss1-1/+1
2010-04-12Fix Debian bug #574612: Return WARNING on rebuildHolger Weiss1-0/+1
Let check_linux_raid return a WARNING instead of an OK state during volume recovery. See: http://bugs.debian.org/574612 (Fixed by Christoph Martin, forwarded by Jan Wagner.)
2010-04-12Fix Debian bug #534604: Checking md10 and aboveHolger Weiss1-1/+1
| check_linux_raid malfunctions if system has software RAID devices with | two or more digits. For example, for system having /dev/md10, | /dev/md11 etc, the plugin returns 'UNKNOWN' in automatic mode (if RAID | devices are manually specified it works). Also, if system has both | one-digit, and two-digit RAID devices, the two-digit devices are | silently ignored in checks, which is even more problematic. [ http://bugs.debian.org/534604 ] (Fixed by Matija Nalis, forwarded by Jan Wagner.)
2010-04-12Fix Debian bug #545940: Failure when run via ePNHolger Weiss2-5/+5
If Perl's "shift" function is called outside of a subroutine and without any argument, it usually shifts @ARGV. However, if a plugin is executed via ePN, such a call will shift @_ instead, so we must explicitly specify @ARGV for this to work as expected. This fixes Debian bug #545940, see: http://bugs.debian.org/545940 Commit de7191e3424e02ba278a39b86e8b1906a25d0362 fixed the same issue for check_disk_smb. (Reported by Hendrik Jaeger, forwarded by Jan Wagner.)
2010-04-11Fix Debian bug #482947: No --nas-ip-address optionHolger Weiss2-13/+29
| check_radius doesn't seem to provide any way to modify the | NAS-IP-Address attribute that it uses in the packets it sends, but it | does so for NAS-Identifier. | | Instead, it hardcodes the IP address that it gets from the | rc_own_ipaddress() library call, and that in turn translates into | calling gethostbyname() on the result of uname(). This call can easily | fail, and its result can easily be unsuitable - for example when the | Nagios instance uses its own virtual host, and you don't want the | original system hostname leaked to the RADIUS servers you monitor with | this. | | Furthermore, this behaviour is inconsistent with RFC 2865, which | defines the two attributes as analogous and never suggests hardcoding | the value of either of them in client software. Therefore, this commit adds the "-N, --nas-ip-address" option which allows for specifying the value of the NAS-IP-Address attribute. | I've also noticed that the original code for NAS-IP-Address hardcoding | is broken in its error handling - it does "return (ERROR_PC)", which | is meaningless in the context of check_radius.c. That actually seems | to be copy&waste from radiusclient-0.3.2/src/radexample.c. :) I fixed | that. | | While debugging, I also took the opportunity to decouple the | nas-identifier rc_avpair_add() instance from the initial three, | because this is just bad practice to lump a fourth optional attribute | into the same block with the required attributes, the error handling | for which is throwing the same daft message "Out of Memory?"... [ http://bugs.debian.org/482947 ] (Contributed by Josip Rodin, forwarded by Jan Wagner.)
2010-04-11Fix Debian bug #479984: Allow empty LDAP baseHolger Weiss2-1/+2
The check_ldap plugin did not allow for specifying an empty LDAP base. See: http://bugs.debian.org/479984 (Fixed by Stephane Chazelas, forwarded by Jan Wagner.)
2010-04-11Fix Debian bug #460097: check_http -M brokenHolger Weiss1-1/+4
See: http://bugs.debian.org/460097 One instance of this bug has already been fixed in commit 888358122004b9571c8fbdfa52ceee1ba5e5f4f2. (Fixed by Hilko Bengen, forwarded by Jan Wagner.)
2010-04-11Fix Debian bug #478942: Fragile argument passingHolger Weiss1-25/+36
Fix some problems regarding the way check_disk_smb passes command line arguments to smbclient(1). | It runs: | | $res = qx/$smbclient "\/\/$host\/$share" $pass -W $workgroup \ | -U $user $smbclientoptions -I $address -c ls/; | | [...] | | The documentation says that if the password is not passed, it | defaults to "". That is not true above, as $pass expands to | nothing which leaves no argument at all (instead of an empty | argument) so is different from providing with an empty password | or with the -N option. | | Also, if the password starts with "-", you're in trouble, that's | why -U $user%$pass may be prefered. | | Also, the doc says that if $user is not provided, then it | defaults to "guest" but the problem is that if it is provided | but empty, it is changed to "guest" as well, which prevents us | from querying hosts that don't do user authentication. [ http://bugs.debian.org/478942 ] (Fixed by Stephane Chazelas, forwarded by Jan Wagner.)
2010-04-11Fix Debian bug #478906: Failure when run via ePNHolger Weiss3-6/+8
| When perl plugin scripts are run with the embedded perl interpreter in | nagios3, the "shift" perl command doesn't shift @ARGV, but @_ (which | happens to contain the same thing as @ARGV at the time the script was | started). | | [...] | | A fix is to replace all the instances of "shift" with "shift @ARGV". [ http://bugs.debian.org/478906 ] (Fixed by Stephane Chazelas, forwarded by Jan Wagner.)
2010-04-11Fix Debian bug #463322: Use deprecated libldap APIHolger Weiss2-0/+2
| Our automated build log filter[1] detected a problem that is likely to | cause your package to segfault on architectures where the size of a | pointer is greater than the size of an integer, such as ia64 and | amd64. | | This is often due to a missing function prototype definition. For | more information, see [2]. | | Function `ldap_init' implicitly converted to pointer at | check_ldap.c:124 | | [1] http://people.debian.org/~dannf/check-implicit-pointer-functions | [2] http://wiki.debian.org/ImplicitPointerConversions | | The libldap API has been updated and many functions used by the ldap | plugin are now deprecated. This package should either update to the | new API or define LDAP_DEPRECATED to continue using the deprecated | interfaces. | | This patch implements the lazy solution. [ http://bugs.debian.org/463322 ] (Contributed by Dann Frazier, forwarded by Jan Wagner.)
2010-04-11Fix Debian bug #425129: SMB guest mode won't workHolger Weiss3-0/+3
| The check_disk_smb plugin purports to support guest users, but it | doesn't work out, because it doesn't specify the -N command line | option to smbclient when no password is specified, making smbclient | stop and ask. [ http://bugs.debian.org/425129 ] (Fixed by Josip Rodin, forwarded by Jan Wagner.)