summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2009-04-22Convert plugins to use the new output functionshw/output/pluginsHolger Weiss10-296/+199
*** THIS COMMIT WILL BE MODIFIED IN THE FUTURE! **** Convert some of the C plugins to use the new "configurable output functions".
2009-04-22Make C plugin output format configurableHolger Weiss5-19/+259
*** THIS COMMIT WILL BE MODIFIED IN THE FUTURE! *** The development guidelines¹ currently state that the plugin output should be in the format "SERVICE STATUS: Information text". However, when a plugin is called via Nagios in order to perform a service check, adding SERVICE and STATUS to the output is redundant. And when a plugin is called on the command line for testing, there is no use in printing out the SERVICE string, either. However, for debugging, it does make sense to print out the STATUS so that the user won't have to check and interpret the exit code manually. But it should suffice to print such debug output only when called with "--verbose", not in production. Space for plugin output is sometimes scarce, so that we should try to keep the output "short and to the point" (as the guide states) and not waste space with redundant information. Therefore, we decided² to make the ("normal" and "verbose") plugin output configurable at compile time. ¹ http://nagiosplug.sf.net/developer-guidelines.html ² http://thread.gmane.org/gmane.network.nagios.plugins.devel/5155
2007-09-15Properly handle SMTP server responses which are split into multipleHolger Weiss2-18/+73
packets (noted by Chris Adams on nagiosplug-help@). TODO: The new recvline()/recvlines() functions should buffer received data instead of reading one byte at a time and they should be moved to netutils.c so that other plugins can use them, too. git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1780 f882894a-f735-0410-b71e-b25c423dba1c
2007-09-15Correct all instances of misaligned memory access. This fixes bus errosHolger Weiss2-43/+37
on platforms which require alignment (such as SPARC and MIPS). git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1779 f882894a-f735-0410-b71e-b25c423dba1c
2007-09-15Remove "-Wtraditional" from our development GCC flags. We use ANSI C.Holger Weiss1-1/+1
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1778 f882894a-f735-0410-b71e-b25c423dba1c
2007-09-13Adding in optional Nagios::Plugin perl module (andTon Voon11-3/+122
dependencies) compilation and installation git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1777 f882894a-f735-0410-b71e-b25c423dba1c
2007-08-28These plugins assumed the "use lib util.pm;" would be substituted like ↵Thomas Guyot-Sionnest4-4/+4
standard Perl plugins (in plugins-scripts) which isn't the case in contrib. I changed the "use lib" line to use the default path. People using custom paths will have to change it manually. git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1771 f882894a-f735-0410-b71e-b25c423dba1c
2007-08-09Don't use C++ style comments (noted by Johannes Kingma onHolger Weiss1-1/+1
nagiosplug-help@) git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1770 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-31Read the response to an SMTP QUIT command before closing the socketHolger Weiss1-3/+28
(noted by Dieter Hendricks on nagiosplug-help@) git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1769 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-29Don't use C++ style comments.Holger Weiss1-1/+1
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1768 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-27If the TMPDIR environment variable is set, use that instead of "/tmp" asHolger Weiss1-2/+3
the installation directory. git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1767 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-26The "--serverip" and "--requestedip" options now accept host names, too.Holger Weiss2-19/+20
This doesn't quite fit the option names and so far I haven't changed the "--help" output which currently only talks about IP addresses. However, I don't see why resolving host names should not be supported. Also note that for the moment, I added a quick'n'dirty resolve_host() function which should really go into netutils.c. I just wanted to think about its interface a bit more before providing such a function globally. git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1766 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-26New "-m, --mac" option which allows for specifying the MAC address toHolger Weiss2-12/+60
use in the DHCP request. git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1765 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-26Make sure strncpy(3)d buffers are nul-terminated.Holger Weiss1-3/+6
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1764 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-26A few minor fixes/improvements which were included with (but unrelatedHolger Weiss1-6/+13
to) the "--unicast" patch (Andreas Ericsson and Heiti Ernits - 1218235) git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1763 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-26New "-u, --unicast" option which gives check_dhcp the ability to mimic aHolger Weiss4-10/+80
DHCP relay server in order to check remote subnets (Heiti Ernits and Andreas Ericsson - 1218235) git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1762 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-24Removing all .cvsignore filesTon Voon14-177/+0
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1761 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-24Updated to use svn instead of cvsTon Voon2-20/+28
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1760 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-21Add "Connection: close" to the HTTP request header, which tells HTTP/1.1Holger Weiss2-0/+5
servers to close the connection after completion of the response. This should be compatible with HTTP/1.0, as HTTP/1.0 allows for custom header fields which should be ignored if not recognized by the server. With some server configurations, the server would keep the connection alive without this header line (despite the plugin requesting HTTP/1.0), resulting in the plugin running into either the server's or it's own timeout (reported by Roman Schliessmeyer and Jesse Morgan via IRC). git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1759 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-15Make ps column count in zombie detection less restrictive. Thanks to Andrew ↵Matthias Eble2-1/+2
Elwell (#1280470) git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1758 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-14Fixed segfault in argument processing. Thanks to Christoph Schell (#1742066)Matthias Eble2-4/+9
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1757 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-14check_ntp: Fixed typo in typo in argument sanity check. Thanks to Aurelien ↵Matthias Eble2-1/+2
Bompard (#1753506) git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1756 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-10Added examples for new features to check_diskMatthias Eble2-0/+6
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1755 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-10Check_disk now calls stat() for all filesystems to check.Matthias Eble3-29/+14
Check_disk prints an strerror() message if the call of stat() fails. git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1754 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-07Added -v/--verbose argument to call ldap_perror() for detailed messages on ↵Matthias Eble1-6/+16
failure. git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1753 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-07Changed output order of print_revisionMatthias Eble1-6/+5
print_revision now uses clean_revstring git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1752 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-07Changed print_revision output order in utils.pmMatthias Eble1-1/+1
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1751 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-07substituted $ID$ through $Revision$ in print_revision callMatthias Eble1-2/+2
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1750 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-07Changed order in -V/--version outputMatthias Eble3-5/+5
Fixed -V output for check_log and check_oracle git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1749 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-06Added hint to avoid using the boolean type in C as discussed on the devel listMatthias Eble1-0/+4
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1748 f882894a-f735-0410-b71e-b25c423dba1c
2007-06-20Fixed default behaviour of check_ldapsMatthias Eble1-1/+3
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1747 f882894a-f735-0410-b71e-b25c423dba1c
2007-06-20Clarified check_ldaps behaviour. New arguments to explicitly select secure ↵Matthias Eble2-36/+64
connect behaviour (--starttls/--ssl). git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1746 f882894a-f735-0410-b71e-b25c423dba1c
2007-06-20added -V/--version to check_clusterMatthias Eble1-1/+7
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1745 f882894a-f735-0410-b71e-b25c423dba1c
2007-06-18Make Linux specific plugin check_ide_smart build if appropriate headers are ↵Matthias Eble3-0/+17
found git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1744 f882894a-f735-0410-b71e-b25c423dba1c
2007-06-17Minor fixes.Holger Weiss1-1/+3
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1743 f882894a-f735-0410-b71e-b25c423dba1c
2007-06-17Fix buffer overflow vulnerabilities when parsing HTTP redirectHolger Weiss2-16/+30
'Location:' strings using sscanf(3) (Nobuhiro Ban - 1687867) git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1742 f882894a-f735-0410-b71e-b25c423dba1c
2007-06-15When following redirects, the plugin supported 'Location:' header fieldsHolger Weiss1-1/+13
which spanned multiple lines. However, it was not checked whether extra lines are preceeded with white space, which could lead to the following header field name being interpreted as the value of the 'Location:' field if the latter was empty for some reason. git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1741 f882894a-f735-0410-b71e-b25c423dba1c
2007-06-15`host_name' is a NULL pointer if the "-I" flag is used instead of "-H",Holger Weiss1-2/+2
so use `server_address' instead. Fixes a possible segfault when following redirects to relative URLs (reported by Ingo Lantschner). git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1740 f882894a-f735-0410-b71e-b25c423dba1c
2007-06-13Fixed some syntax errors to make check_ide_smart buildMatthias Eble1-19/+2
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1739 f882894a-f735-0410-b71e-b25c423dba1c
2007-06-12Add "-v" to help/usage output.Holger Weiss1-1/+2
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1738 f882894a-f735-0410-b71e-b25c423dba1c
2007-06-12Removed debug lineMatthias Eble1-1/+0
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1737 f882894a-f735-0410-b71e-b25c423dba1c
2007-06-11Fixed problem with popen.c not parsing --longopt='foo bar' correctly (Daniel ↵Matthias Eble2-2/+12
Bimschas #1291987) git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1736 f882894a-f735-0410-b71e-b25c423dba1c
2007-06-04Removed duplicate namesTon Voon1-2/+0
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1735 f882894a-f735-0410-b71e-b25c423dba1c
2007-06-04For 1.4.9 releaserelease-1.4.9Ton Voon5-19/+282
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1733 f882894a-f735-0410-b71e-b25c423dba1c
2007-06-03Minor corrections to test_tcp.cMatthias Eble1-12/+8
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1732 f882894a-f735-0410-b71e-b25c423dba1c
2007-06-03Makefile.am changes for test_tcp.cMatthias Eble1-2/+7
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1731 f882894a-f735-0410-b71e-b25c423dba1c
2007-06-03Added test cases for utils_tcpMatthias Eble4-1/+70
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1730 f882894a-f735-0410-b71e-b25c423dba1c
2007-06-03Moved check_tcp's expect string testing into utils_tcp for testing purposes.Matthias Eble5-26/+91
Added -A/--all flag to test for every expect string passed. git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1729 f882894a-f735-0410-b71e-b25c423dba1c
2007-06-01Fix possible check_http segfaults when following HTTP redirects.Holger Weiss2-2/+2
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1728 f882894a-f735-0410-b71e-b25c423dba1c
2007-06-01Fix an off-by-one error where a realloc(3) call doesn't allocate spaceHolger Weiss1-1/+1
for nul-termination (Aravind Gottipati - 1729692) git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1727 f882894a-f735-0410-b71e-b25c423dba1c