Age | Commit message (Collapse) | Author | Files | Lines |
|
Don't return a WARNING state if the number of lost packets is greater
than zero but below the specified warning threshold. This happened
because the check_ping plugin used the exit status of the ping(1)
utility. (#3535140 - Tobias Brox)
|
|
(Debian #654259 - Charles-Henri Larose)
|
|
In the C shell and in the Z shell, the "?" character must be quoted or
backslash-escaped in order to use it verbatim. Therefore, a command
such as
check_by_ssh -H test.example.com -l joe echo huh?
might fail, depending on joe's login shell on test.example.com.
Just to make sure, this commit removes most punctuation characters from
our test strings.
|
|
RFC 2131 (2.) says: "DHCP clarifies the interpretation of the 'siaddr'
field as the address of the server to use in the next step of the
client's bootstrap process." So, we shouldn't interpret this field as
the DHCP server's own address. (#3503921 - Jason Ellison)
|
|
Don't let "pad" options[*] terminate the parsing of DHCP options. This
bug was triggered by using check_dhcp against Windows 2003 DHCP servers
(see #3503921).
[*] Cf. RFC 2132, 3.1.
|
|
The ping6(1) implementation provided by Debian's iputils-ping package
may produce output such as the following:
| 3 packets transmitted, 0 received, +3 errors, 100% packet loss, time 2009ms
There's a corresponding pattern in check_ping.c:458:
| "%*d packets transmitted, %*d received, +%*d errors, %d%% packet loss"
Without this fix, the pattern in check_ping.c:456 matched first (as
sscanf(3) interprets "+3" as a match for "%d"):
| "%*d packets transmitted, %*d received, %d%% loss, time"
(#1894850 - Debian bug report #514588 - Matej Vela)
|
|
Fix indentation and whitespace issues, and correct some capitalization
errors in error messages. The behaviour is unchanged.
|
|
GnuTLS doesn't support SSL version 2.
|
|
|
|
|
|
This patch use the utxent function family to collect the user data. It improve the check speed.
Need a system conforming to POSIX.1-2001.
|
|
Recent versions/builds seem to disable that feature.
|
|
|
|
|
|
The support for specifying the desired SSL protocol version via an
optional -S/--ssl argument broke the -C/--certificate option. This is
fixed now.
|
|
SSL initialization errors are now handled properly by check_http
(#3095106 - Eric Schoeller).
|
|
The check_http -S/--ssl option now takes an optional argument which
specifies the desired SSL/TLS protocol version (#3285367 - Jason Lunn).
|
|
Some versions of OpenSSL fail to negotiate the SSL connection with at
least some versions of Tomcat if stateless SSL session resumption
support (see RFC4507) is enabled:
| CRITICAL - Cannot make SSL connection
| 140099330348712:error:140943F2:SSL routines:SSL3_READ_BYTES:sslv3 alert unexpected message:s3_pkt.c:1195:SSL alert number 10
The problem is reproducible with OpenSSL 1.0.0h, but not with OpenSSL
0.9.8o-4squeeze12 (as shipped with Debian 6.0.4). We work around it by
disabling the RFC4507 functionality when using OpenSSL versions which
support it.
Thanks to Dag Bakke for reporting the issue and for giving me access to
a server I could use to reproduce the problem.
|
|
The nagios-plugins.spec file is created from nagios-plugins.spec.in and
should be ignored by Git.
|
|
ssh://nagiosplug.git.sourceforge.net/gitroot/nagiosplug/nagiosplug
|
|
|
|
|
|
ssh://nagiosplug.git.sourceforge.net/gitroot/nagiosplug/nagiosplug
|
|
|
|
Add a note to the --help output which clarifies that check_http doesn't
perform certificate verification (beyond what the "-C" option does).
(Suggested by Michael Renner in Debian bug report #644627, forwarded by
Jan Wagner.)
|
|
Replace all occurrences of "strstr(s, "c") == s" with "s[0] == 'c'".
|
|
Fix the code which accepts a comma-separated list of labels specified
via the "-l" option.
(Spotted by Oskar Liljeblad in Debian bug report #647020, forwarded by
Jan Wagner.)
|
|
|
|
|
|
|
|
|
|
The Solaris package creation has been updated to newer standards to match those
of the NRPE package. The following changes have been made:
- the plugins now install under /opt/nagios
- the name of package is now NGOSplugin
- the files installed are now owned by the nagios user
- the package includes a pre-installation script that creates a nagios user
and a nagios group if one did not previously exist
|
|
On Solaris, in the case where the mysql libraries were compiled using a
non-gcc compiler, but the plugins are being compiled with gcc, the configure
process would incorrectly determine the MYSQLCFLAGS. This has been corrected
in the m4/np_mysqlclient.m4 file.
|
|
Specify the exit codes by using the constants from utils.sh.
|
|
|
|
Return an UNKNOWN status if a faulty sensor is detected. This can be
suppressed with the new "--ignore-fault" option.
(Fixes Debian bug #615133, patch suggested by Jan Wagner.)
|
|
It won't trust us about msg containing no format string, and fail miserably
when compiled with -Werror=format-security. Reported by spy6 on IRC.
|
|
The undocumented --host has been changed to --hostname which is actually
mentioned in --help. Thanks to lgarrett (#3191388)
|
|
certificate errors (Opsview team)
|
|
Duncan Ferguson)
|
|
When specifying a host-name on the command line, each of its IPs is added to
the host table (and each one is pinged). So, the buffer has to be large enough
to hold all of the respective host objects. (argc - 1) only fits hosts with a
single IP.
Thanks to Max Kosmach <max@tcen.ru> for reporting this in Debian bug #623702.
|
|
|
|
Abort immediately if we don't receive a server greeting or if the
greeting doesn't contain the "--expect"ed string (by default: "220")
instead of blindly sending the EHLO/HELO line.
Spotted by Daniel Piddock, see Debian bug report #611914.
|
|
This patch adds a check for the certificate cn (hostname) to normal
certificate checks. It returns CRITICAL if th cn is missing, otherwise it
prints it in the normal output.
Patch by Stéphane Urbanovski
|
|
parsing of
performance data. Now replaced with ','
|
|
1. Timetick test could fail with uptime > 115 days. Thresholds are
double type, so it's safe to put a large number even for 32bit systems.
2. Add a test based on an invalid bug report, worthy anyway.
|
|
|
|
This enables floating point and ranges, and make the code more standard.
|
|
|
|
My Test::More wouldn't print the total number of tests anymore, moving
the plan at the top appears to fix it.
At the same time I made check-http.t eval the special modules so it can
skip the tests instead of failing.
|