summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-11-11patch to support the concept of virtual portsChristopher Odenbach2-8/+31
2016-11-08update thanks fileSven Nierlein1-0/+1
2016-11-08Merge pull request #1442 from waja/check_dig_use_retry_instead_triesSven Nierlein1-2/+2
check_dig: use +retry instead of +tries
2016-11-08Merge pull request #1441 from waja/check_ide_smart_remove_unused_functionSven Nierlein1-26/+0
check_ide_smart: remove unused function
2016-11-08check_dig: use +retry instead of +triesrefs/pull/1442/headChristian Kujau1-2/+2
After upgrading from an Ubuntu/15.10 to 16.04 installation, I noticed that check_dig is always returning a WARNING: $ /usr/lib/nagios/plugins/check_dig -l localhost -v /usr/bin/dig -p 53 @127.0.0.1 localhost A +tries=3 +time=6 Looking for: 'localhost' DNS WARNING - 0.008 seconds response time (dig returned an error status)|time=0.008274s;;;0.000000 The older Ubuntu installation got its check_dig from the nagios-plugins-standard package[0] which did not include the +tries option. The current Ubuntu version provides its check_dig from the monitoring-plugins-standard package[1], which _does_ use the +tries option that was introduced with df53473[2]. On my system, it so happens that /usr/bin/dig is provided not by the (BIND) dnsutils package but by knot-dnsutils[3] from the Knot DNS project. The Knot dig(1) command doesn't support the +tries option[4] but does support +retry (which is also supported[5] by the BIND dig(1) command). One way to fix that would be for me to install the BIND dnsutils package. But I did not want to do that: it's so much larger in size and pulls in much more dependencies than the knot-dnsutils package. The patch below changes check_dig to use +retry instead of +tries. Both options are similar, but not the same: +retry - Sets the number of times to retry UDP queries to server to T instead of the default, 2. Unlike +tries, this does not include the initial query As number_tries seems to be hard coded to 3, I've lowered DEFAULT_TRIES to 2 so check_dig should behave as before (with +tries=3). Thanks, Christian. [0] http://packages.ubuntu.com/wily/nagios-plugins-standard [1] http://packages.ubuntu.com/xenial/monitoring-plugins-standard [2] https://github.com/monitoring-plugins/monitoring-plugins/commit/df53473 [3] http://packages.ubuntu.com/xenial/knot-dnsutils [4] https://www.knot-dns.cz/docs/2.x/html/man_kdig.html#notes [5] https://ftp.isc.org/isc/bind9/cur/9.10/doc/arm/man.dig.html Signed-off-by: Christian Kujau <lists@nerdbynature.de>
2016-11-08check_ide_smart: remove unused functionrefs/pull/1441/headSebastian Herbszt1-26/+0
Remove function unused since commit b5cc292. Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
2016-11-07tests: enable snmp testsSven Nierlein1-2/+2
Enabled snmp tests against snmpd on localhost. It was installed already in the travis file, we just need to enable the tests by setting the parameters in the answers file. Signed-off-by: Sven Nierlein <sven@nierlein.de>
2016-11-07check_snmp: fix number of tests skipedSven Nierlein1-1/+1
2016-11-07check_snmp: add testcase for no datatypeSven Nierlein1-1/+5
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2016-11-07Revert "check_snmp: fix push request 1173 for SNMP responses without ↵Sven Nierlein1-1/+1
datatype indicator" This reverts commit 3178c8c0ff18822a04fe01c749f3564887473eed.
2016-11-07Revert "update thanks file"Sven Nierlein1-1/+0
This reverts commit 4403c402cba0315c2cb9ebe40639a5fe312d643e.
2016-11-07update thanks fileSven Nierlein1-0/+1
2016-11-07check_snmp: fix push request 1173 for SNMP responses without datatype indicatorThomas Kurschel1-1/+1
2016-11-07fix superfluous argument to printf (#fixes 1308)Sven Nierlein1-1/+1
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2016-11-07Merge pull request #1311 from waja/check_ntp_remove_unused_variablesSven Nierlein1-4/+2
check_ntp: remove unused variables
2016-11-07Merge pull request #1309 from waja/negate_remove_unused_variablesSven Nierlein1-2/+2
negate: remove unused variables
2016-11-07Merge pull request #1312 from waja/check_disk_remove_unused_variablesSven Nierlein1-7/+2
check_disk: remove unused variables
2016-11-07Merge pull request #1313 from waja/check_ntp_time_remove_unused_variablesSven Nierlein1-4/+2
check_ntp_time: remove unused variables
2016-11-07Merge pull request #1307 from waja/check_dns_dead_codeSven Nierlein1-6/+0
check_dns: remove dead code
2016-11-07update news and thanks fileSven Nierlein2-0/+3
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2016-11-07tests: adjust check_http to new output formatSven Nierlein1-2/+2
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2016-11-07GMT expiry displayPeter (pir) Radcliffe2-5/+14
Change solution to display GMT time in the local display format with the offset number of hours from GMT to be clear about what timezone this is if the local display format does not include offset.
2016-11-07Revert "Fix check_http test time output"Peter (pir) Radcliffe1-4/+4
This reverts commit 2d9e61a4382b8366331cde7617dbc4e381a0219a.
2016-11-07Fix check_http test time outputPeter (pir) Radcliffe1-4/+4
Tests need to match new output time and timezone.
2016-11-07Use GMT timezone in SSL certsPeter (pir) Radcliffe1-3/+3
SSL certs are required to use times in GMT per https://www.ietf.org/rfc/rfc5280.txt but the mktime() here assumes the current timezone. Fix the time_t conversion to be done assuming GMT with timegm() and only do it once rather than twice. Display the expiry date and time with ISO format years and give an offset from GMT and a timezone to be very clear about exactly what time is being displayed. Time given is correct and now in the machine’s timezone.
2016-11-07check_snmp.c - Added IPv6 supportabrist3-3/+15
The "-6" optarg now prepends the server_address with "udp6:" for the snmpget external command as per the net-snmp syntax at: http://www.net-snmp.org/wiki/index.php/FAQ:Applications_28 Thanks to DrydenK (Roberto Greiner) for the heads up.
2016-11-07check_users: add new test casesSven Nierlein1-1/+3
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2016-11-07check_users: still allow zero thresholdsSven Nierlein1-2/+2
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2016-11-07check_users not correctly detecting thresholdsJohn C. Frickson4-61/+75
Fix for issue https://github.com/nagios-plugins/nagios-plugins/issues/81 check_users now uses the standard warning and critical ranges parser and a standard perdata output routine.
2016-09-17check_by_ssh: print command output in verbose modeSven Nierlein1-0/+7
right now it is not possible to print the command output of ssh. check_by_ssh only prints the command itself. This patchs adds printing the output too. This makes it possible to use ssh with verbose logging which helps debuging any connection, key or other ssh problems. Note: you must use -E,--skip-stderr=<high number>, otherwise check_by_ssh would always exit with unknown state. Example: ./check_by_ssh -H localhost -o LogLevel=DEBUG3 -C "sleep 1" -E 999 -v Signed-off-by: Sven Nierlein <sven@nierlein.de>
2016-09-16check_dhcp: Make xid a bit more randomHolger Weiss1-3/+2
Don't just use the current time(2) to seed the PRNG that generates the xid. A DHCP server might be checked multiple times per second.
2016-09-14check_dhcp: Don't peek before reading responseHolger Weiss1-7/+1
Omit a recvfrom(3) call which has the MSG_PEEK flag set and should have no effect at all. According to a comment in the code, this call was meant to be a workaround to an opaque issue. If anyone runs into that issue, we should fix it properly instead.
2016-03-24Update AUTHORSOliver Skibbe1-0/+1
Added Oliver Skibbe to Authors
2016-02-22Merge branch 'pr/1386'Holger Weiss1-1/+1
* pr/1386: check_dig: expected answer is now incasesensitive
2016-02-22Let check_http test use HTTP/1.1Holger Weiss1-1/+1
2016-02-22Merge branch 'pr/1404'Holger Weiss1-1/+1
* pr/1404: DNS is case insensitive!
2016-02-22Add Gnulib module "strcasestr"Holger Weiss5-2/+251
2016-02-22DNS is case insensitive!refs/pull/1404/headSven Geggus1-1/+1
Thus recent Versions of bind will no longer change .IN-ADDR.ARPA to lowercase as the uppercase version is also valid. To have check_dns.c consider this fact change strstr to strcasestr
2015-11-03Merge remote-tracking branch 'upstream/pr/1390'Jan Wagner1-1/+1
2015-11-02Typo in check_ldap.c usagerefs/pull/1390/headGerhard Lausser1-1/+1
2015-10-21travis-ci: Adding spwaspace to trusty envJan Wagner1-0/+2
2015-10-21travis-ci: Stop local running ntpdJan Wagner1-0/+2
2015-10-21travis-ci: Detect LDAP configJan Wagner1-0/+2
2015-10-21travis-ci: Add ppa:waja/precise-backports for fixed faketimeJan Wagner1-0/+1
2015-10-20travis-ci: Clearly documentx why we need install mariadbJan Wagner1-0/+1
2015-10-20travis-ci: Work around broken /etc/hosts on trusty envJan Wagner1-0/+4
2015-10-19travis-ci: Adding multiverse repository as long it's not default. ↵Jan Wagner1-0/+1
snmp-mibs-downloader is located there
2015-10-19travis-ci: Install mariadb-client and mariadb-serverJan Wagner1-2/+6
2015-10-19travis-ci: Migrating to Trusty CI envJan Wagner1-1/+2
2015-10-16Prepare for the 2.1.2 releaseHolger Weiss3-2/+8