summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2012-11-03lib/utils_base.c: Stop dumping core on bad args to check_snmpAndreas Ericsson1-8/+8
Since the state patch introduction, we've been freeing uninitialized memory in lib/utils_base.c::np_cleanup(), which caused coredumps with check_snmp when illegal threshold ranges (for example) were passed, or when we called 'die' without having read any state. This patch fixes it by replacing the malloc() calls in there (all of them, since using malloc() is almost always an error) with calloc(). malloc() either doesn't initialize the memory at all, or taints it with a special marker so it can tell us when we're free()'ing memory that hasn't been initialized. calloc() explicitly initializes the allocated memory to nul bytes, which is a zero-cost operation when we get the memory from the kernel (which alread does that) and almost always desirable everywhere else. Signed-off-by: Andreas Ericsson <ae@op5.se>
2012-11-03Make check_snmp backwards compatible in how it parses thresholdsAndreas Ericsson1-0/+23
Once upon a time, check_snmp used to accept inverse ranges in the format of '2:1' to mean "alert if value is inside this range". Since commit 7cb3ae09334796f3b54e4e6438e38c2cc679b360, ranges such as those have instead triggered the error "Range format incorrect" and resulted in an UNKNOWN warning state. This patch attempts to fix the situation so that the old-style ranges continues to mean exactly what the once did and people with lots of snmp checks can avoid a bazillion false positives from their environments. Signed-off-by: Andreas Ericsson <ae@op5.se>
2012-10-09NEWS: Mention the OPENSSL_config(3) supportHolger Weiss1-0/+1
2012-10-09Added additional documentation to the check_range functionMarc Huffnagle1-1/+10
2012-10-09Allow for configuring OpenSSLHolger Weiss1-0/+1
Let OpenSSL load its configuration file. See the OPENSSL_config(3) man page for details. (Suggested by Max Kosmach in Debian bug report #689960, forwarded by Jan Wagner.)
2012-09-25Merge pull request #19 from gvarisco/patch-1Sven Nierlein1-1/+1
Update plugins/check_disk.c
2012-09-25Update plugins/check_disk.crefs/pull/19/headGianluca Varisco1-1/+1
CRITCAL -> CRITICAL typo
2012-09-25Merge pull request #18 from abradley/recoverypctSven Nierlein1-1/+1
Bugfix: Detect array recovery percentages < 10% in check_linux_raid.pl
2012-09-22This patch fixes the regular expression for the array recoveryrefs/pull/18/headAlex Bradley1-1/+1
completion percentage to detect the percentage when there is more than one space between between "recovery =" and the percentage. (When the percentage is less than 10%, /proc/mdstat shows it left-padded with an extra space: "recovery = 7.6%".)
2012-08-10check_http: Update description of -C optionHolger Weiss1-1/+1
Mention that the -C option now accepts two comma-separated values.
2012-08-10check_http: Add missing newline to --help outputHolger Weiss1-3/+3
2012-08-10fixing bug in certificate experiation patch checking for bad warning ↵William Leibzon3-3/+3
threshold data
2012-08-10tests/check_http.t: Fix whitespace issuesHolger Weiss1-10/+8
In tests/check_http.t, tabs are used for indentation. While at it, apply another few cosmetic changes.
2012-08-10tests/check_http.t: Update the number of SSL testsHolger Weiss1-1/+1
2012-08-10tests/check_http.t: Fix test caseHolger Weiss1-1/+1
Fix the test case which is meant to make sure that check_http -C <n>,<m> [...] returns a CRITICAL state if <m> is large enough.
2012-08-06NEWS: Mention fixed compilation without SSLHolger Weiss1-0/+1
2012-08-06check_ntp_peer: Fix --help output for -m and -nHolger Weiss1-1/+1
Fix the threshold specifications in the example for checking the number of truechimers. Reported by Marc Haber on the "nagios-users" mailing list (Message-ID: <20120722142840.GA6931@torres.zugschlus.de>).
2012-08-06check_ntp_peer: Fix --help output for -W and -CHolger Weiss1-2/+2
Mention that the check_ntp_peer plugin checks the stratum of the synchronization peer, not the stratum of the monitored server itself. Thanks to Marc Haber for bringing this up on the "nagios-users" mailing list (Message-ID: <20120722142840.GA6931@torres.zugschlus.de>).
2012-07-18check_http: Fix whitespace issuesHolger Weiss1-10/+10
In check_http.c, tabs aren't used for indentation.
2012-07-18check_http: Fix compilation without SSL supportHolger Weiss1-3/+4
The "ssl_version" variable was undeclared when the plugins were compiled --without-openssl and --without-gnutls. Bug reported by Michael LaCorte on the "nagiosplug-help" mailing list (Message-ID: <CCD30C91-A2A8-463A-82A9-F99B54F741D3@gmail.com>).
2012-07-04NEWS: Mention the new check_dbi pluginHolger Weiss1-0/+3
2012-07-04Merge remote-tracking branch 'github/tokkee/sh/check_dbi'Holger Weiss6-1/+941
2012-07-04Re-added missing variable declarations to check_smtp.cEric Stanley1-0/+2
A recent update removed the declarations for a couple variables in check_smtp.c that are still being used, which caused a failure in the compilation of check_smtp.c. This commit restores those variable declarations so the check_smtp.c will again compile.
2012-06-29check_smtp: Remove a comment regarding MAIL FROMHolger Weiss1-15/+4
Earlier versions of check_smtp generated an (invalid) "MAIL FROM" command without arguments by default. These days, a "MAIL FROM" command is only sent if the --from option is specified. This commit removes a comment which explains the old behaviour, and it updates a variable name accordingly.
2012-06-29check_smtp: Fix help and usage output regarding -RHolger Weiss1-2/+2
2012-06-29NEWS, THANKS: Mention Anders Kaseorg's changesHolger Weiss2-0/+5
2012-06-29check_smtp: Fix strcat overflowsAnders Kaseorg1-4/+2
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2012-06-29Die when asprintf failsAnders Kaseorg38-437/+466
Fixes many instances of warning: ignoring return value of 'asprintf', declared with attribute warn_unused_result [-Wunused-result] Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2012-06-29check_smtp: Strip angle brackets from -f argument, if providedAnders Kaseorg1-1/+2
Apparently some people used -f '<nagios@example.com>' to work around the bug I just fixed in the MAIL FROM: command generation. Although the resulting command wasn't RFC-compliant, it was working with some MTAs, so let's continue to support this syntax now that we generate RFC-compliant commands. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2012-06-29check_smtp: Change MAIL FROM: command to comply with the SMTP standardAnders Kaseorg1-1/+1
Every version of the SMTP standard (from RFC 821 to the current RFC 5321) requires the address following MAIL FROM: to follow the colon immediately (with no space) and to be surrounded by angle brackets. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2012-06-28Remove the package.def fileHolger Weiss1-1/+0
The package.def file is not included in release tarballs, and I'm not aware of anyone (still) using it.
2012-06-27Remove #990948 from the BUGS fileHolger Weiss1-2/+1
Issue #990948 has been fixed by commit 0892c4ac28c4c2e3b6275187f845813b4cd6d320.
2012-06-27Prepare for the 1.4.16 releaserelease-1.4.16Holger Weiss6-5/+455
2012-06-27check_tcp: Print performance data even with -DHolger Weiss1-1/+1
When using the 1.4.15 release of the Nagios Plugins, a command such as check_tcp -H pop.example.com -p 995 -D 14 usually produced two lines of output, e.g.: OK - Certificate will expire on 12/13/2014 23:59. TCP OK - 0.009 second response time on port 995|time=0.008849s;;;0.000000;10.000000 The second line was removed by 4d06603060fc1233861b164870f0d3a2e0d8d2eb. However, as the old two-line output is a valid (though in this case unintended) way to spit out performance data, removing the second line might break current setups. Therefore, we revert to the old behaviour, at least for the moment. The issue was reported by Jochen Bern on the "nagiosplug-devel" mailing list (Message-ID: <4FEAE812.8030309@LINworks.de>).
2012-06-27Update the BUGS fileHolger Weiss1-4/+2
Remove the bug reports that were closed, and add two new items.
2012-06-26check_snmp: use single quotes for perf data labelsSven Nierlein2-4/+8
2012-06-26Fix performance data label containing spaces in check_snmp (Jochen Bern)Sven Nierlein4-4/+48
Add --perf-oids option for check_snmp to retain optional 1.4.14 compatibility
2012-06-26Remove team members from the THANKS fileHolger Weiss1-3/+0
The (current and past) team members are listed in the AUTHORS file.
2012-06-26Add Sven Nierlein to the list of AUTHORSHolger Weiss2-1/+1
2012-06-25added test case for certificate checs with both warning and critical valuesWilliam Leibzon1-0/+4
2012-06-25check_http: added test for warning thresholdsSven Nierlein3-3/+11
fixed typo in sslutils
2012-06-25updated changelogSven Nierlein2-0/+2
2012-06-25applied patch that adds both critical and warning thresholds to certificate ↵William Leibzon5-33/+89
expiration checks of check_tcp, check_http, check_smtp
2012-06-24check_ping: Add missing newline to die() callsHolger Weiss1-11/+11
Our die() function expects the caller to append the trailing newline character.
2012-06-24NEWS: Improve the wording a bitHolger Weiss1-1/+1
2012-06-24Merge remote-tracking branch 'github/waja/master'Holger Weiss2-2/+4
Conflicts: NEWS
2012-06-24check_ping: Ignore ping(1)'s exit statusHolger Weiss2-3/+2
Don't return a WARNING state if the number of lost packets is greater than zero but below the specified warning threshold. This happened because the check_ping plugin used the exit status of the ping(1) utility. (#3535140 - Tobias Brox)
2012-06-23check_disk_smb: Add performance dataHolger Weiss3-12/+34
(Debian #654259 - Charles-Henri Larose)
2012-06-22Fix check_by_ssh test for non-Bash login shellsHolger Weiss1-5/+5
In the C shell and in the Z shell, the "?" character must be quoted or backslash-escaped in order to use it verbatim. Therefore, a command such as check_by_ssh -H test.example.com -l joe echo huh? might fail, depending on joe's login shell on test.example.com. Just to make sure, this commit removes most punctuation characters from our test strings.
2012-06-13check_dhcp: Don't misinterpret the "siaddr" fieldHolger Weiss2-9/+5
RFC 2131 (2.) says: "DHCP clarifies the interpretation of the 'siaddr' field as the address of the server to use in the next step of the client's bootstrap process." So, we shouldn't interpret this field as the DHCP server's own address. (#3503921 - Jason Ellison)