summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2013-07-08check_nt: Fixes NULL pointer dereferenceJan Wagner2-3/+14
Thanks to Vaclav Ovsik for reporting the issue and providing a fix
2013-06-30Add libnpcommon.a file to .gitignoreHolger Weiss1-0/+1
2013-06-30check_ntp_peer: Verify type of response packetsHolger Weiss1-13/+19
The check_ntp_peer plugin now ignores response packets with an unexpected "Operation Code" and/or "Sequence" number (cf. RFC 1305, Appendix B). This fixes an issue where the check_ntp_peer requests got duplicated on their way to the server (due to some network switch bug), and the server therefore sent multiple responses per request. Thanks to Marc Haber for reporting the issue.
2013-06-25NEWS: Mention that check_apt spits out perfdataHolger Weiss1-0/+1
2013-06-25Fixed SF.net bug 1614553, Debian bug #708343, Adding performace dataJan Wagner1-2/+4
2013-05-12NEWS, THANKS: Mention the latest changesHolger Weiss2-0/+3
2013-05-12configure: add --without-ldap, --without-radius and --without-dbi options.Diego Elio Pettenò1-40/+51
When building for distributions such as Gentoo Linux, or FreeBSD ports, it's convenient to be able to disable building certain functionalities even if the dependencies are present, to avoid what are called "automagic dependendencies". Adding these parameters solve the issue.
2013-05-12build: fix building with parallel make.Diego Elio Pettenò1-71/+24
By using a more automake-style handling of dependencies and a single convenience library, it's tremendously easy to build in parallel. Note that since the linking happens with the static archives, the unused objects are discarded and provide no overhead whatsoever.
2013-05-12plugins: rename runcmd's signal handler.Diego Elio Pettenò4-4/+4
The previous name would collide with popen's. Even if the two are never used together, it's still a good idea not to have the same symbol in multiple object files.
2013-03-25NEWS, THANKS: Mention Richard Leitner's changesHolger Weiss2-0/+3
2013-03-25Fixed SF.net bug 3560976, added --include-type/-N optionRichard Leitner1-3/+15
2013-03-25Fixed SF.net bug 3602586, added timeout option for check_nagiosRichard Leitner1-3/+13
2013-03-25Fixed SF.net bug 3539317, typo in --help of check_aptRichard Leitner1-1/+1
2013-03-25NEWS, THANKS: Mention check_oracle --connect flagHolger Weiss2-0/+2
2013-03-25Add option to perform real login in check_oracleBrian De Wolf1-0/+15
The Oracle plugin has no option for testing for a successful login. The closest option to this is --login, which uses a fixed set of credentials and expects to receive the logon failure error code. This patch adds an option called --connect. This option takes a full SID and returns success if it doesn't detect any error codes. With this, we can check that a database is allowing logins from valid credentials (and avoid filling up DB logs with failed authentications).
2013-02-27Update plugins/check_procs.cJoerg Linge1-0/+1
added missing longopt --user
2013-02-10check_tcp: don't ignore trailing optionsSven Nierlein2-11/+18
"./check_tcp -6 -p 80 host" leads to an error: TCP CRITICAL - Invalid hostname, address or socket: 127.0.0.1 because 127.0.0.1 is the fallback host, the tailing hostname was ignored.
2013-01-24Merge pull request #34 from dveeden/masterSven Nierlein2-6/+10
MySQL Requirements and Comments fix
2013-01-24Apply my patch from:refs/pull/34/headDaniël van Eeden2-6/+10
http://sourceforge.net/tracker/index.php?func=detail&aid=3269273&group_id=29880&atid=397597
2013-01-23added latest commits to NEWS fileSven Nierlein2-0/+4
2013-01-23Merge pull request #20 from abradley/aptcriticalSven Nierlein7-21/+276
Fixes for check_apt handling of -i/-e/-c regexps and SECURITY_RE, plus tests
2013-01-23updated check dig testsSven Nierlein1-7/+15
nagios.com seems to have changed their ip address. Also added tests about -4/-6 option.
2013-01-23check_dig: query transport selection supportVille Mattila1-3/+16
Add command line options -4 and -6 (--use-ipv4 and --use-ipv6) to check_dig. Effectively this adds no new functionality, just a shortcut for: check_dig -A "-4" check_dig -A "-6" Needed for using check_dig with the check_v46 wrapper (see e.g. https://gitorious.org/nagios-monitoring-tools/nagios-monitoring-tools/blobs/master/check_v46) which requires -4/-6 command line option support.
2013-01-23updated changelog and thanks file for previous patchSven Nierlein2-0/+5
2013-01-23check_snmp: Don't thrash memory when using multiple label/unit argumentRobin Sonefors1-11/+11
The memory allocation mixed up number of bytes with number of pointers, meaning as soon as we'd reach (on 64 bit systems) the second argument, we'd start writing it outside of our allocated memory. Normally, this isn't too visible, but as soon as you (again, on my 64 bit system) reach argument number 8, you get a segfault. It is easily reproducible with: check_snmp -o '' -l '' -o '' -l '' -o '' -l '' -o '' -l '' \ -o '' -l '' -o '' -l '' -o '' -l '' -o '' -l '' This patch allocates the proper amount of memory, to fix the issue. Signed-off-by: Robin Sonefors <robin.sonefors@op5.com>
2012-12-03Table 4 example 5 updatedpalli1-1/+1
Description did not specify that it condition is critical if "stuff" is less than zero.
2012-12-03Description for table4 example7palli1-2/+2
My original patch was based on the online version which was apparently out of date. In the meantime someone changed the description of example7 instead of the example. I think this is better because otherwise example 6 and 7 are basically the same.
2012-12-03Bugfix, fixed a broken command-line examplePall Sigurdsson1-2/+2
The last example in the table contradicted the previous example. Surely it's purpose was to showcase the @ behaviour to invert threshold, but the @ sign was missing. I also clarified the description to the second last example so it is in same style as the others.
2012-11-28check_ntp(_time): don't die on connect errorsSven Nierlein2-2/+10
connect errors may happen if clients check agains dual stacked ipv4/6 ntp servers.
2012-11-28unified ipv4/6 usage and help textSven Nierlein6-10/+8
2012-11-14NEWS: Mention the check_procs performance dataHolger Weiss1-0/+1
2012-11-14check_procs: Remove superfluous newline characterHolger Weiss1-1/+1
2012-11-14check_procs: Added performance data to plugin output.Sebastian Harl1-0/+7
2012-11-14check_procs: Use the range/threshold support functions from libnagiosplug.Sebastian Harl1-89/+17
This adds support for @<range> and makes stuff a bit simpler by removing code duplications. Note: Previously, the compatibility code for 'check_procs <warn> <max>' accepted something like 'check_procs -w 10:-1 -c 10:-1 20 50' as well (treating it as if '-w 10:20 -c 10:50' was specified). This is no longer the case ... additional arguments are only used as warn/crit thresholds in case -w/-c is not specified at all.
2012-11-07Fix sfwebcron probe fileThomas Guyot-Sionnest3-8/+9
The initial file was created in the user's home and later tested in the doc directory. Instead, just rsync if the file is missing. Also add some temporary files to gitignore/make clean
2012-11-04Update NEWS for bd78299 - check_snmp reverse ranges fixdermoth1-0/+1
2012-11-03Update toolsdermoth2-80/+12
- fix sfwebcron (tool updating sf developer guidelines) - remove obsolete snapshot script
2012-11-03Add scripts that update man pages in drupaldermoth2-0/+45
2012-11-03plugins/check_snmp: Show snmp error when we fail to parse its outputAndreas Ericsson1-2/+2
Dying without a hint of what went wrong is just plain annoying. With this patch we at least get a hint. While at it, we fix the string offset so the output we're interested in doesn't keep the equal sign that snmpget prints. Signed-off-by: Andreas Ericsson <ae@op5.se>
2012-11-03lib/utils_base.c: Stop dumping core on bad args to check_snmpAndreas Ericsson1-8/+8
Since the state patch introduction, we've been freeing uninitialized memory in lib/utils_base.c::np_cleanup(), which caused coredumps with check_snmp when illegal threshold ranges (for example) were passed, or when we called 'die' without having read any state. This patch fixes it by replacing the malloc() calls in there (all of them, since using malloc() is almost always an error) with calloc(). malloc() either doesn't initialize the memory at all, or taints it with a special marker so it can tell us when we're free()'ing memory that hasn't been initialized. calloc() explicitly initializes the allocated memory to nul bytes, which is a zero-cost operation when we get the memory from the kernel (which alread does that) and almost always desirable everywhere else. Signed-off-by: Andreas Ericsson <ae@op5.se>
2012-11-03Make check_snmp backwards compatible in how it parses thresholdsAndreas Ericsson1-0/+23
Once upon a time, check_snmp used to accept inverse ranges in the format of '2:1' to mean "alert if value is inside this range". Since commit 7cb3ae09334796f3b54e4e6438e38c2cc679b360, ranges such as those have instead triggered the error "Range format incorrect" and resulted in an UNKNOWN warning state. This patch attempts to fix the situation so that the old-style ranges continues to mean exactly what the once did and people with lots of snmp checks can avoid a bazillion false positives from their environments. Signed-off-by: Andreas Ericsson <ae@op5.se>
2012-10-09NEWS: Mention the OPENSSL_config(3) supportHolger Weiss1-0/+1
2012-10-09Added additional documentation to the check_range functionMarc Huffnagle1-1/+10
2012-10-09Allow for configuring OpenSSLHolger Weiss1-0/+1
Let OpenSSL load its configuration file. See the OPENSSL_config(3) man page for details. (Suggested by Max Kosmach in Debian bug report #689960, forwarded by Jan Wagner.)
2012-10-03Tests for check_aptrefs/pull/20/headAlex Bradley7-3/+257
Add a hidden "--input-file" option to check_apt (modelled on check_procs) so that it can take files with sample apt output as input. Add tests for my SECURITY_RE fix (debian3) and for the include, exclude and critical options.
2012-10-03Fix SourceForge bug 1904965 - check_apt: SECURITY_RE is not correctAlex Bradley1-1/+1
For the default security upgrade detection regular expression, match "Debian-Security" in package description when it's anywhere after the first parenthesis (not just the second space-delimited word). For example: ... (4.0.1-5.4 Debian:6.0.6/stable, Debian-Security:6.0/stable ...
2012-10-03Don't prepend "^Inst" or append a space to the "include", "exclude", orAlex Bradley1-17/+18
"critical" regular expressions. Instead, check for lines beginning with "Inst" using strncmp and apply the regular expressions only when such lines are found. Fixes Debian bug #522812, along the lines suggested by the bug submitter, Justin T Pryzby.
2012-09-25Merge pull request #19 from gvarisco/patch-1Sven Nierlein1-1/+1
Update plugins/check_disk.c
2012-09-25Update plugins/check_disk.crefs/pull/19/headGianluca Varisco1-1/+1
CRITCAL -> CRITICAL typo
2012-09-25Merge pull request #18 from abradley/recoverypctSven Nierlein1-1/+1
Bugfix: Detect array recovery percentages < 10% in check_linux_raid.pl