summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2024-04-12Adjust check_swap testsNapsty1-1/+1
2024-04-12Adjust check_swap testsNapsty1-0/+12
2024-04-12Allow single thresholdNapsty1-8/+2
2024-04-12Possibility to run check_swap without thresholdsNapsty1-28/+31
2024-04-07check_http/check_curl: added a --regex-state option to change the state of a ↵Andreas Baumann2-6/+32
regex check from the default CRITICAL to something else (#1213)
2024-04-07check_curl/check_http: clarified format of POST data (#1978)Andreas Baumann2-2/+2
2024-04-07check_load: remove unused code (#1998)Lorenz Kästle1-26/+0
adaugherity noticed in issue #1965, that HAVE_PROC_LOADAVG is never defined since the symbol was removed from configure quite some time ago. This commit removes the dead code which would be used when the symbol would have been defined.
2024-03-26check_disk: Fail on missing arguments for --warning and --critical and fix a ↵Lorenz Kästle4-3/+45
test case (#1935) * check_disk: Fail on missing arguments for --warning and --critical * Add new test function for percentage expressions and use it in check_disk * Add error abort in tests if they fail to parse output * Fix typo in test which probably broke the test since forever :-(
2024-03-26check_ssh: patches from op5 (#1738)Lorenz Kästle2-76/+234
* check_ssh: properly parse a delayed version control string This resolves an issue with SSH servers which do not respond with their version control string as the first thing in the SSH protocol version exchange phase after connection establishment. This patch also makes sure that we disregard a potential comment in the version exchange string to avoid nonsense mismatches. In the future, we might want to add the capability to match against a user specified comment. In addition, the patch largely improves the communication towards the server, which adds better protocol adherence. Of course, new test cases are added to support the trigger and guard against regressions of the bugs solved by this patch. This fixes op5#7945 (https://bugs.op5.com/view.php?id=7945) Signed-off-by: Anton Lofgren <alofgren@op5.com> * check_ssh.t: Fix a few typos Signed-off-by: Anton Lofgren <alofgren@op5.com> * check_ssh: Handle non-alpha software versions This patch fixes a bug where we would reject version control strings that do not contain letters, because the assumption is made that they always do. This is not required by the RFC however, and there exist implementations that do not contain letters. I've also added a few references to the RFC to make the process of parsing the control string more apparent. This fixes op5#8716 (https://bugs.op5.com/view.php?id=8716) Signed-off-by: Anton Lofgren <alofgren@op5.com> * check_ssh: Fix a typo in "remote-protocol parameter remote-protcol -> remote-protocol Signed-off-by: Anton Lofgren <alofgren@op5.com> * Remove unused variable * Formating fixes * Update translations * Remove merge conflict artefact from previous merge * Set fixed include paths * Improve code style to be slightly more readable * Update test cases for different netcat behaviour and reduce sleep time --------- Signed-off-by: Anton Lofgren <alofgren@op5.com> Co-authored-by: Anton Lofgren <alofgren@op5.com>
2024-03-23check_swap: replace another fake boolen and small improvements (#1996)Lorenz Kästle1-10/+10
* check_swap: Change another fake boolen to a real one * check_swap: Rename type since *_t is reserved for C standard types * check_swap: Update copyright
2024-03-23check_nwstat: adds percentage used space (#1183)waja2-0/+54
* check_nwstat: adds percentage used space This adds the new VPU parameter to the check_nwstat plugin. This parameter returns the percentage used space on a Netware volume. Now you can monitor your Netware volumes easy. We use it with a warning 85% and critical 90%. eg: check_nwstat -H your.netware.host -v VPUvol1 -c 85 -w 90 returns 324653 MB (95%) used on volume vol1 - total 340212 MB|Used space in percent on vol1=95;90;80;0;100. * check_nwstat: Fixing whitespaces and tabs * Update translation files * check_nwstat: Use C99 booleans also with the patch * Some formatting --------- Co-authored-by: RincewindsHat <12514511+RincewindsHat@users.noreply.github.com>
2024-03-18check_ircd: IPv6 support (#1995)alvar1-35/+26
The prior bindRemote function was restricted to IPv4 by explicitly using address family specific functions as pack_sockaddr_in or unparametrized gethostbyname. Since Perl 5.14, released in early 2013, there is IO::Socket::IP, which supports lookups and connects for a dual stacked network. By switching the connection establishment code, the plugin is now able to establish connections to IPv6-only hosts. Furthermore, additional -4 and -6 flags were introduced to enforce a specific address family. > $ netstat -p tcp -ln | grep 6667 > tcp6 0 0 *.6667 *.* LISTEN > $ ./plugins-scripts/check_ircd -H localhost > IRCD ok - Current Local Users: 4 > $ ./plugins-scripts/check_ircd -H localhost -4 > IRCD UNKNOWN: Could not start socket (Connection refused) > $ ./plugins-scripts/check_ircd -H localhost -6 > IRCD ok - Current Local Users: 4
2024-03-01check_icmp: keep performance data order in case of none-reachable hostsSven Nierlein2-32/+53
For responding hosts nothing changes: ./check_icmp -H 10.0.0.1 OK - 10.0.0.1 rta 0.336ms lost 0%|rta=0.336ms;200.000;500.000;0; rtmax=0.471ms;;;; rtmin=0.000ms;;;; pl=0%;40;80;0;100 In case the host is down, the performance data now contain 'U' according to: https://www.monitoring-plugins.org/doc/guidelines.html#AEN201 Old: ./check_icmp -H 10.0.0.99 CRITICAL - 10.0.0.99: Host unreachable @ 10.0.1.138. rta nan, lost 100%|pl=100%;40;80;0;100 Old: ./check_icmp -H 10.0.0.99 CRITICAL - 10.0.0.99: Host unreachable @ 10.0.1.138. rta nan, lost 100%|rta=U;;;; rtmax=U;;;; rtmin=U;;;; pl=100%;40;80;0;100 This confuses some performance graphing tools, ex.: pnp. Signed-off-by: Sven Nierlein <sven@consol.de>
2024-02-23check_disk increase alert precision (#1989)Sven Nierlein2-23/+7
* check_disk increase alert precision Free disk percentage value was rounded to a full integer meaning it alerted about ~1% percent too early. This is about 10GB on a 1TB disk. The warning and critical thresholds already support float values, so just the percentage calculation needs to be improved. old: ./check_disk -w 35% -c 20% -p / -f -vvv Thresholds(pct) for / warn: 35.000000 crit 20.000000 calling stat on / For /, used_pct=65 free_pct=35 used_units=286451 free_units=156651 total_units=443102 used_inodes_pct=11 free_inodes_pct=89 fsp.fsu_blocksize=4096 mult=1048576 Freespace_units result=0 Freespace% result=1 Usedspace_units result=0 Usedspace_percent result=0 Usedinodes_percent result=0 Freeinodes_percent result=0 DISK WARNING - free space: WARNING [ / 156651MiB (35% inode=89%)];| /=300365643776B;302006979788;371700898201;0;464626122752 new: ./check_disk -w 35% -c 20% -p / -f -vvv Thresholds(pct) for / warn: 35.000000 crit 20.000000 calling stat on / For /, used_pct=64.649722 free_pct=35.350278 used_units=286464 free_units=156637 total_units=443102 used_inodes_pct=10.016183 free_inodes_pct=89.983817 fsp.fsu_blocksize=4096 mult=1048576 Freespace_units result=0 Freespace% result=0 Usedspace_units result=0 Usedspace_percent result=0 Usedinodes_percent result=0 Freeinodes_percent result=0 DISK OK - free space: / 156637MiB (35.4% inode=90%);| /=300379275264B;302006979788;371700898201;0;464626122752 * check_disk: adjust test case to support float precision
2024-02-23CI specfile (#1894)waja5-41/+1105
* Adding spec file and github pipeline for testing * Restructure github pipelines for more clarity * Add build tests for several RPM based distributions --------- Co-authored-by: Lorenz Kästle <12514511+RincewindsHat@users.noreply.github.com>
2024-02-12Merge pull request #1987 from euniceremoquillo/Improve-negate-plugin-helptextLorenz Kästle1-2/+4
Improve negate plugin helptext
2024-02-12Added indentions for readabilityrefs/pull/1987/headEunice Remoquillo1-2/+2
2024-02-12Improve negate plugin helptextEunice Remoquillo1-2/+4
This commit updates the negate plugin's helptext as it is currently ambiguous.
2024-02-07Merge pull request #1982 from RincewindsHat/ini_parser_bugLorenz Kästle1-9/+23
Ini Parser: Avoid freeing symbols from text section
2024-02-07Merge pull request #1985 from emriver/check_curl_haproxy_protocolLorenz Kästle1-2/+15
check_curl: add haproxy protocol option
2024-02-01check_curl: add haproxy protocol optionrefs/pull/1985/headEmmanuel Riviere1-2/+15
2024-01-07Ini Parser: Avoid freeing symbols from text section by remembering where ↵refs/pull/1982/headRincewindsHat1-9/+23
they are from
2023-12-30Merge pull request #1980 from RincewindsHat/compiler_warning_part_7Lorenz Kästle5-10/+5
Compiler warning part 7
2023-12-28check_dhcp: Make implicit conversion explicit to dismiss warningrefs/pull/1980/headRincewindsHat1-1/+1
2023-12-28check_snmp: Remove unused variableRincewindsHat1-4/+0
2023-12-28check_http: Remove self assignment of a variable and add some commentsRincewindsHat1-3/+2
2023-12-28Change iritating NULL assignmentRincewindsHat2-2/+2
2023-12-23Merge pull request #1970 from EricFromCanada/plugins-root-lcryptoLorenz Kästle1-3/+3
plugins-root: prevent -lcrypto from showing up in Makefile dependencies
2023-12-23Merge branch 'master' into plugins-root-lcryptorefs/pull/1970/headLorenz Kästle2-4/+4
2023-12-22Merge pull request #1977 from RincewindsHat/revert_to_debian_stableLorenz Kästle1-2/+2
Use debian stable for main tests again
2023-12-22Use debian stable for main tests againrefs/pull/1977/headRincewindsHat1-2/+2
2023-12-14Merge pull request #1973 from ↵waja1-2/+2
monitoring-plugins/dependabot-github_actions-github-codeql-action-3 build(deps): bump github/codeql-action from 2 to 3
2023-12-14build(deps): bump github/codeql-action from 2 to 3refs/pull/1973/headdependabot[bot]1-2/+2
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/github/codeql-action/compare/v2...v3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
2023-12-06Prevent -lcrypto from showing up in Makefile dependenciesEric Knibbe1-3/+3
2023-12-04Merge pull request #1969 from shartge/document-check_procsLorenz Kästle1-14/+22
check_procs: Improve help text, mentioning excluded processes
2023-12-04check_procs: Generalise wording, remove mentioning of nrperefs/pull/1969/headSven Hartge1-5/+4
2023-12-04check_procs: Improve help text, mentioning excluded processesSven Hartge1-14/+23
Also reindent the code, converting stray tabs to 2 spaces.
2023-12-03Merge pull request #1968 from shartge/improve-check_procsLorenz Kästle1-0/+7
check_procs: ignore our own children
2023-11-28check_procs: ignore our own childrenrefs/pull/1968/headSven Hartge1-0/+7
On systems with higher core counts check_procs will occasionally see its own "ps" child process with a high CPU percentage and raise a false alarm. Ignoring the child processes of check_procs prevents this from happening.
2023-11-27Merge pull request #1967 from sni/fix_check_diskLorenz Kästle2-24/+38
check_disk: fix ignore-missing in combination with includes (fixes #1963)
2023-11-27check_disk: fix ignore-missing in combination with includes (fixes #1963)refs/pull/1967/headSven Nierlein2-18/+33
Using --ignore-missing together with regex matching and ignore option lead to a wrong error message. ./check_disk -n -w 10% -c 5% -W 10% -r /dummy -i /dummy2 DISK UNKNOWN: Paths need to be selected before using -i/-I. Use -A to select all paths explicitly The use case here is a cluster with fail-over mounts. So it is a valid situation that the regex match does not find anything in addtition with a ignore which also does not exist. After this patch: ./check_disk -n -w 10% -c 5% -W 10% -r /dummy -i /dummy2 DISK OK - No disks were found for provided parameters|
2023-11-27check_disk: add -n short option for --ignore-missingSven Nierlein1-6/+5
Signed-off-by: Sven Nierlein <sven@consol.de>
2023-11-23Merge pull request #1964 from RincewindsHat/more_compiler_warningsLorenz Kästle3-6/+23
More compiler warnings
2023-11-22check_dns: Remove unused variablerefs/pull/1964/headRincewindsHat1-1/+0
2023-11-22check_ntp_peer: Fixes for Wmaybe-unitialized and some restructuringRincewindsHat1-2/+11
2023-11-22Fix logic in is_uint64_t to fix type-limit warningRincewindsHat1-3/+12
2023-11-22Merge pull request #1962 from waja/CI_testingLorenz Kästle1-2/+2
CI: Switch back to testing
2023-11-22Merge pull request #1951 from RincewindsHat/compiler_warnings_maybe_unusedLorenz Kästle3-3/+4
Fix compiler warning for uninitialized variable
2023-11-13CI: Switch back to testingrefs/pull/1962/headJan Wagner1-2/+2
2023-11-12Merge pull request #1958 from RincewindsHat/check_users_fix_segfaultLorenz Kästle2-9/+17
check_users: fix segfault