summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2024-10-02add manual workflow triggerSven Nierlein1-0/+1
2024-10-02add new github test workflow for debian:testing and fedora:rawhideSven Nierlein2-1/+77
this workflow runs scheduled once a week, so it does not prevent PRs from being merged but still allows us to notice if anything will go wrong with the next release. Remove rawhide test from the mandatory tests like we did with debian testing already.
2024-09-27Merge pull request #2021 from monitoring-plugins/check_disk_static_fixesLorenz Kästle1-49/+34
Check disk static fixes
2024-09-27check_disk: remove unused variables and functionsLorenz Kästle1-15/+0
2024-09-27check_disk: Declare global variables staticLorenz Kästle1-37/+37
Variables only used in that specific translation unit should be static to actually communicate that fact. Also allows the compiler to detect unused (global) variables.
2024-09-27Merge pull request #2020 from RincewindsHat/check_snmp_fixesLorenz Kästle1-80/+78
Check snmp fixes
2024-09-27check_snmp: Remove unused PP-macrosRincewindsHat1-2/+0
2024-09-27check_snmp: Declare most variables as staticRincewindsHat1-78/+78
2024-09-06Merge pull request #2015 from RincewindsHat/fix/check_mysql_variablesLorenz Kästle1-4/+4
check_mysql: * remove unused variables * convert two practical booleans to real `bool`
2024-08-30Merge pull request #2017 from RincewindsHat/check_curl_no_more_experimentalLorenz Kästle1-2/+0
Remove experimental state from check_curl
2024-08-29Remove experimental state from check_curlLorenz Kästle1-2/+0
2024-08-28check_mysql: Label some booleans correctlyLorenz Kästle1-4/+4
2024-08-28check_mysql: remove unused global variablesLorenz Kästle1-1/+1
2024-08-28Merge pull request #2001 from RincewindsHat/check_snmp_protocoll_documentationLorenz Kästle1-4/+6
Add more documentation to the help page of check_snmp regarding authe…
2024-08-16Merge pull request #2012 from oxzi/check_curl-help-fixesLorenz Kästle1-3/+6
check_curl: Documentation for --certificate, --cookie-jar
2024-08-16check_curl: Documentation for --certificate, --cookie-jarAlvar Penning1-3/+6
From the mere help output for -C / --certificate, I was confused about what its two integer parameters do. Unfortunately, I also missed out on the explaining examples later. Since I like to have basic documentation for each flag, I tried to make the arguments as short as possible. The other fix was one hyphen too many for the --cookie-jar option.
2024-08-11check_curl: raise SSL issue when --continue-after-certificate is usedYannick Martin1-8/+9
This change aims to raise the worst status between the SSL check and the HTTP check. before: check_curl -H www.google.fr -S --continue-after-certificate --certificate 4000,4000 ; echo $? CRITICAL - Certificate '*.google.fr' expires in 74 day(s) (Tue 22 Oct 2024 12:53:52 PM GMT +0000). HTTP OK: HTTP/2 200 - 22807 bytes in 0.076 second response time |time=0.075516s;;;0.000000;10.000000 size=22807B;;;0; 0 after: /usr/lib/nagios/ovh/check_curl -H www.google.fr -S --continue-after-certificate --certificate 4000,4000 ; echo $? CRITICAL - Certificate '*.google.fr' expires in 74 day(s) (Tue 22 Oct 2024 12:53:52 PM GMT +0000). HTTP OK: HTTP/2 200 - 22840 bytes in 0.090 second response time |time=0.090463s;;;0.000000;10.000000 size=22840B;;;0; 2
2024-07-30check_curl: fix relative redirects on non-standard portSven Nierlein3-9/+32
Having a webserver respond with a relative redirect as for ex. in `Location: /path/to.html` check_curl would use the wrong standard http/https port instead of crafting the absolute url using the given scheme/hostname and port. Adding a new test case for this for check_http and check_curl. check_http did it correct already, so no fix necessary there. before: %>./check_curl -H 127.0.0.1 -p 50493 -f follow -u /redirect_rel -s redirected -vvv **** HEADER **** HTTP/1.1 302 Found ... Location: /redirect2 ... * Seen redirect location /redirect2 ** scheme: (null) ** host: (null) ** port: (null) ** path: /redirect2 Redirection to http://127.0.0.1:80/redirect2 fixed: %>./check_curl -H 127.0.0.1 -p 50493 -f follow -u /redirect_rel -s redirected -vvv **** HEADER **** HTTP/1.1 302 Found ... Location: /redirect2 ... * Seen redirect location /redirect2 ** scheme: (null) ** host: (null) ** port: (null) ** path: /redirect2 Redirection to http://127.0.0.1:50493/redirect2 Signed-off-by: Sven Nierlein <sven@nierlein.de>
2024-07-25Merge pull request #2009 from waja/post_releasewaja4-21/+17
Post release changes
2024-07-24Fix double lines in NEWSJan Wagner1-4/+0
2024-07-24Update version in release docuJan Wagner1-15/+15
2024-07-24Update version to new git versionJan Wagner2-2/+2
2024-07-24Merge pull request #2008 from waja/2.4.0waja4-2/+67
2.4.0
2024-07-23Creating NEWSv2.4.0maint-2.4Jan Wagner1-0/+59
2024-07-23Adding new contributors to THANKS.inJan Wagner1-0/+6
2024-07-23Update version for releaseJan Wagner2-2/+2
2024-07-23Merge pull request #2006 from monitoring-plugins/check_curl_featureswaja2-8/+34
Small check_curl fixes
2024-07-23Merge branch 'master' into check_curl_featuresSven Nierlein7-542/+594
2024-07-23tests: always remove ipv6 entry from hosts fileSven Nierlein1-6/+2
2024-07-23check_http: replace www.mozilla.com with monitoring-plugins.orgSven Nierlein2-4/+4
this makes tests more reliable if we test our own sites instead some 3rd party site. Signed-off-by: Sven Nierlein <sven@consol.de>
2024-07-23Merge pull request #2005 from ↵waja1-4/+4
monitoring-plugins/waja-docu_update_release_version Update versions to reflect the actual state, we forgot about this in …
2024-07-23Update versions to reflect the actual state, we forgot about this in our ↵Jan Wagner1-4/+4
last urgent release
2024-07-12check_ups: additional alarm conditions (#1961)Lorenz Kästle1-498/+545
* check_ups: * Update copyright * General refactoring * code formatting * Add ALARM state from ups -> Critical * Set some more states to be warnings
2024-05-21Fix typosRincewindsHat1-2/+2
2024-05-21Add more documentation to the help page of check_snmp regarding ↵RincewindsHat1-4/+6
authentication and privacy options
2024-04-12Adjust check_swap testsNapsty1-1/+1
2024-04-12Adjust check_swap testsNapsty1-1/+1
2024-04-12Adjust check_swap testsNapsty1-0/+12
2024-04-12Allow single thresholdNapsty1-8/+2
2024-04-12Possibility to run check_swap without thresholdsNapsty1-28/+31
2024-04-07check_http/check_curl: added a --regex-state option to change the state of a ↵Andreas Baumann2-6/+32
regex check from the default CRITICAL to something else (#1213)
2024-04-07check_curl/check_http: clarified format of POST data (#1978)Andreas Baumann2-2/+2
2024-04-07check_load: remove unused code (#1998)Lorenz Kästle1-26/+0
adaugherity noticed in issue #1965, that HAVE_PROC_LOADAVG is never defined since the symbol was removed from configure quite some time ago. This commit removes the dead code which would be used when the symbol would have been defined.
2024-03-27check_disk: Fail on missing arguments for --warning and --critical and fix a ↵Lorenz Kästle4-3/+45
test case (#1935) * check_disk: Fail on missing arguments for --warning and --critical * Add new test function for percentage expressions and use it in check_disk * Add error abort in tests if they fail to parse output * Fix typo in test which probably broke the test since forever :-(
2024-03-27check_ssh: patches from op5 (#1738)Lorenz Kästle2-76/+234
* check_ssh: properly parse a delayed version control string This resolves an issue with SSH servers which do not respond with their version control string as the first thing in the SSH protocol version exchange phase after connection establishment. This patch also makes sure that we disregard a potential comment in the version exchange string to avoid nonsense mismatches. In the future, we might want to add the capability to match against a user specified comment. In addition, the patch largely improves the communication towards the server, which adds better protocol adherence. Of course, new test cases are added to support the trigger and guard against regressions of the bugs solved by this patch. This fixes op5#7945 (https://bugs.op5.com/view.php?id=7945) Signed-off-by: Anton Lofgren <alofgren@op5.com> * check_ssh.t: Fix a few typos Signed-off-by: Anton Lofgren <alofgren@op5.com> * check_ssh: Handle non-alpha software versions This patch fixes a bug where we would reject version control strings that do not contain letters, because the assumption is made that they always do. This is not required by the RFC however, and there exist implementations that do not contain letters. I've also added a few references to the RFC to make the process of parsing the control string more apparent. This fixes op5#8716 (https://bugs.op5.com/view.php?id=8716) Signed-off-by: Anton Lofgren <alofgren@op5.com> * check_ssh: Fix a typo in "remote-protocol parameter remote-protcol -> remote-protocol Signed-off-by: Anton Lofgren <alofgren@op5.com> * Remove unused variable * Formating fixes * Update translations * Remove merge conflict artefact from previous merge * Set fixed include paths * Improve code style to be slightly more readable * Update test cases for different netcat behaviour and reduce sleep time --------- Signed-off-by: Anton Lofgren <alofgren@op5.com> Co-authored-by: Anton Lofgren <alofgren@op5.com>
2024-03-23check_swap: replace another fake boolen and small improvements (#1996)Lorenz Kästle1-10/+10
* check_swap: Change another fake boolen to a real one * check_swap: Rename type since *_t is reserved for C standard types * check_swap: Update copyright
2024-03-23check_nwstat: adds percentage used space (#1183)waja2-0/+54
* check_nwstat: adds percentage used space This adds the new VPU parameter to the check_nwstat plugin. This parameter returns the percentage used space on a Netware volume. Now you can monitor your Netware volumes easy. We use it with a warning 85% and critical 90%. eg: check_nwstat -H your.netware.host -v VPUvol1 -c 85 -w 90 returns 324653 MB (95%) used on volume vol1 - total 340212 MB|Used space in percent on vol1=95;90;80;0;100. * check_nwstat: Fixing whitespaces and tabs * Update translation files * check_nwstat: Use C99 booleans also with the patch * Some formatting --------- Co-authored-by: RincewindsHat <12514511+RincewindsHat@users.noreply.github.com>
2024-03-18check_ircd: IPv6 support (#1995)alvar1-35/+26
The prior bindRemote function was restricted to IPv4 by explicitly using address family specific functions as pack_sockaddr_in or unparametrized gethostbyname. Since Perl 5.14, released in early 2013, there is IO::Socket::IP, which supports lookups and connects for a dual stacked network. By switching the connection establishment code, the plugin is now able to establish connections to IPv6-only hosts. Furthermore, additional -4 and -6 flags were introduced to enforce a specific address family. > $ netstat -p tcp -ln | grep 6667 > tcp6 0 0 *.6667 *.* LISTEN > $ ./plugins-scripts/check_ircd -H localhost > IRCD ok - Current Local Users: 4 > $ ./plugins-scripts/check_ircd -H localhost -4 > IRCD UNKNOWN: Could not start socket (Connection refused) > $ ./plugins-scripts/check_ircd -H localhost -6 > IRCD ok - Current Local Users: 4
2024-03-01check_icmp: keep performance data order in case of none-reachable hostsSven Nierlein2-32/+53
For responding hosts nothing changes: ./check_icmp -H 10.0.0.1 OK - 10.0.0.1 rta 0.336ms lost 0%|rta=0.336ms;200.000;500.000;0; rtmax=0.471ms;;;; rtmin=0.000ms;;;; pl=0%;40;80;0;100 In case the host is down, the performance data now contain 'U' according to: https://www.monitoring-plugins.org/doc/guidelines.html#AEN201 Old: ./check_icmp -H 10.0.0.99 CRITICAL - 10.0.0.99: Host unreachable @ 10.0.1.138. rta nan, lost 100%|pl=100%;40;80;0;100 Old: ./check_icmp -H 10.0.0.99 CRITICAL - 10.0.0.99: Host unreachable @ 10.0.1.138. rta nan, lost 100%|rta=U;;;; rtmax=U;;;; rtmin=U;;;; pl=100%;40;80;0;100 This confuses some performance graphing tools, ex.: pnp. Signed-off-by: Sven Nierlein <sven@consol.de>
2024-02-23check_disk increase alert precision (#1989)Sven Nierlein2-23/+7
* check_disk increase alert precision Free disk percentage value was rounded to a full integer meaning it alerted about ~1% percent too early. This is about 10GB on a 1TB disk. The warning and critical thresholds already support float values, so just the percentage calculation needs to be improved. old: ./check_disk -w 35% -c 20% -p / -f -vvv Thresholds(pct) for / warn: 35.000000 crit 20.000000 calling stat on / For /, used_pct=65 free_pct=35 used_units=286451 free_units=156651 total_units=443102 used_inodes_pct=11 free_inodes_pct=89 fsp.fsu_blocksize=4096 mult=1048576 Freespace_units result=0 Freespace% result=1 Usedspace_units result=0 Usedspace_percent result=0 Usedinodes_percent result=0 Freeinodes_percent result=0 DISK WARNING - free space: WARNING [ / 156651MiB (35% inode=89%)];| /=300365643776B;302006979788;371700898201;0;464626122752 new: ./check_disk -w 35% -c 20% -p / -f -vvv Thresholds(pct) for / warn: 35.000000 crit 20.000000 calling stat on / For /, used_pct=64.649722 free_pct=35.350278 used_units=286464 free_units=156637 total_units=443102 used_inodes_pct=10.016183 free_inodes_pct=89.983817 fsp.fsu_blocksize=4096 mult=1048576 Freespace_units result=0 Freespace% result=0 Usedspace_units result=0 Usedspace_percent result=0 Usedinodes_percent result=0 Freeinodes_percent result=0 DISK OK - free space: / 156637MiB (35.4% inode=90%);| /=300379275264B;302006979788;371700898201;0;464626122752 * check_disk: adjust test case to support float precision