summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-11-19Merge pull request #1723 from RincewindsHat/check_swap_smallfix_and_styleRincewindsHat1-20/+23
Small fix to threshold validation and style (indentation) fixes
2021-11-19Merge pull request #1724 from mullumaus/masterRincewindsHat1-1/+4
Allows check_ldap to read password from environment variable
2021-11-19Allows check_ldap to get password from env variablerefs/pull/1724/headLinda Guo1-1/+4
It's not secure to provide LDAP password through command line option because other users on the same host can see the password in 'ps' command output. This change allows check_ldap to get password from environment variable.
2021-11-19Fix option description authpassword -> authpasswdLorenz Kästle1-1/+1
2021-11-19Revert "Fixed option description authpassword -> authpasswd + whitespaces"Lorenz Kästle1-20/+20
This reverts commit b27e639725f680411aaa78dd9aa59cfff84ad0c5.
2021-11-19Fixed option description authpassword -> authpasswd + whitespacesLorenz Kästle1-20/+20
2021-11-18Small fix to threshold validation and style (indentation) fixesrefs/pull/1723/headRincewindsHat1-20/+23
2021-11-18Merge pull request #1697 from RincewindsHat/dont_show_rta_if_uselessRincewindsHat2-6/+14
check_ping: Do not show RTA if no connection was possible
2021-11-17Merge pull request #1654 from wolfgangkarall/masterRincewindsHat2-2/+2
check_procs -- exchange needle and haystack in strstr() for proper st…
2021-11-17Merge pull request #1688 from bazzisoft/masterRincewindsHat2-2/+2
check_curl.c: bugfix: verify certificates option should not force SSL to be used
2021-11-17Add thresholds even if value is missingrefs/pull/1697/headRincewindsHat1-1/+1
2021-11-17homogenize perfdata function and fix small bug with missing semicolonRincewindsHat1-2/+4
2021-11-17Show RTA as unknown if it can not be determinedRincewindsHat1-1/+1
2021-11-17Do not show RTA if no connection was possiblerincewind1-4/+10
2021-11-17check_snmp: fix performance thresholds when using multiple oidsSven Nierlein4-6/+23
when using check_snmp with multiple oids it simply printed the unparsed content from -w/-c into the thresholds for each oid. So each oid contained the hole -w from all oids. ./check_snmp ... -o iso.3.6.1.2.1.25.1.3.0,iso.3.6.1.2.1.25.1.5.0 -w '1,2' -c '3,4' before: SNMP ... | HOST-RESOURCES-MIB::hrSystemInitialLoadDevice.0=393216;1,2;3,4 HOST-RESOURCES-MIB::hrSystemNumUsers.0=24;1,2;3,4 after: SNMP ... | HOST-RESOURCES-MIB::hrSystemInitialLoadDevice.0=393216;1;3 HOST-RESOURCES-MIB::hrSystemNumUsers.0=24;2;4 This also applies to fixed thresholds since check_snmp translates negative infinities from: '~:-1' to '@-1:~'
2021-11-15check_icmp: Fix pkt perfdata in check_host modeAksel Sjögren1-1/+1
Add missing "warn" threshold field in "pkt" perfdata output. Perfdata should be interpreted as; 'label'=value[UOM];[warn];[crit];[min];[max] With one field missing, the hardcoded min value '0' ended up in the "crit" field, making applications interpreting the perfdata thining that critical threshold is always exceeded. Signed-off-by: Aksel Sjögren <asjogren@itrsgroup.com>
2021-11-11Merge pull request #1715 from ghen2/lmtpRincewindsHat1-4/+14
check_smtp: add -L flag to support LMTP (LHLO instead of HELO/EHLO).
2021-11-01check_procs: add test for elapsed timeSven Nierlein2-2/+230
2021-11-01remove unused test fileSven Nierlein1-84/+0
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2021-11-01check_procs: improve ps args autodetectionSven Nierlein2-4/+17
one of the first ps commands in the configure.ac is `axwo 'stat comm vsz rss user uid pid ppid args'` which works on most modern linux systems (checked debian 10/11 and centos 7/8). But this test misses the etime argument. Therefore `check_procs --metric=ELAPSED` does not work. To fix this, we simply do the same test including etime before that one. Signed-off-by: Sven Nierlein <sven@nierlein.de>
2021-11-01check_procs: remove trailing whitespaceSven Nierlein1-25/+25
2021-10-31check_mysql.c: Detect running mysqldumpGerardo Malazdrewicz1-6/+26
When checking a slave, if the IO Thread or the SQL Thread are stopped, check for running mysqldump threads, return STATE_OK if there is any. Requires PROCESS privilege to work (else the mysqldump thread(s) would not be detected). Enlarged SLAVERESULTSIZE to fit "Mysqldump: in progress" at the end of the string. Got a NULL pointer in row[seconds_behind_field] instead of the "NULL" string when a mysqldump is running [mysql 5.7.34 + libmariadb3 10.3.31], so added a check for that.
2021-10-28check_smtp: add -L flag to support LMTP (LHLO instead of HELO/EHLO).refs/pull/1715/headGeert Hendrickx1-4/+14
2021-10-28Merge pull request #1714 from ↵RincewindsHat4-101/+124
RincewindsHat/fix_perfdata_for_big_values_for_check_disk Fix perfdata for big values for check disk. First merge \o/
2021-10-27Replace tabs with spaces and do some formattingrefs/pull/1714/headRincewindsHat1-55/+54
2021-10-27Remove whitespace at the end of linesRincewindsHat1-17/+17
2021-10-26Fix my own errors for real this time and add some comments, so I wont do ↵RincewindsHat1-32/+32
them again
2021-10-26Re-add separation semicolons for perfdata, which I deletedRincewindsHat1-8/+16
2021-10-26Reform some arithmetical operations for more clarityRincewindsHat1-7/+9
2021-10-26hopefully fix warning high tide with percentageRincewindsHat1-1/+1
2021-10-26Fix some testsRincewindsHat1-3/+4
2021-10-26Remove useless lines and fix some formattingRincewindsHat1-12/+8
2021-10-26Switch to uint64_tRincewindsHat2-14/+12
2021-10-26Reformat a little bit for easier readingRincewindsHat1-16/+32
2021-10-26Recognice IEC binary units and format accordingly to base2 (always)RincewindsHat1-12/+15
2021-10-25Update check_load.tHarald Jenny1-2/+2
adjust tests for new plugin output
2021-10-25Create check_load.cHarald Jenny1-1/+1
just a cosmetic fix so the load plugin display a LOAD prefix before check results
2021-10-25actions: map utmp from host to containerSven Nierlein1-0/+1
this fixes the check_users not having any logged in user to check.
2021-10-20Add comment to make the purpose of the nickname fix more obviousLorenz Kästle1-0/+2
2021-10-20Restrict the nickname length of the test user for check_ircdLorenz Kästle1-1/+1
check_ircd was using the string `ircd` plus the PID as a nickname for connecting to a IRC network by default. This caused errors, when the PID was too high and the network restricted the length of the nickname to 9 characters. This patch "fixes" this by just cutting it of, if it gets too big.
2021-10-03Merge remote-tracking branch 'monitoring-plugins/pr/1707'Holger Weiss4-104/+268
* monitoring-plugins/pr/1707: Revert to poor man's logic Change all to comments to old comment style Fix comparing logic Remove spaces from tests check_swap: Fix perfdata und thresholds for big values and simplify code Introduce new perfdata functions and stuff for using (u)int64_t
2021-10-02Revert to poor man's logicrefs/pull/1707/headRincewindsHat3-18/+16
2021-10-02Change all to comments to old comment styleRincewindsHat1-3/+4
2021-09-25Fix comparing logicRincewindsHat1-2/+2
2021-09-25Remove spaces from testsRincewindsHat1-3/+3
2021-09-25check_swap: Fix perfdata und thresholds for big values and simplify coderincewind1-102/+137
The original problem was https://github.com/monitoring-plugins/monitoring-plugins/pull/1705 where the performance data output of check_swap did not conform to the parser logic of a monitoring system (which decided to go for "correct" SI or IEC units. The PR was accompanied by a change to byte values in the performance data which broke the _perfdata_ helper function which could not handle values of this size. The fix for this, was to use _fperfdata_ which could, but would use float values. I didn't like that (since all values here are discreet) and this is my proposal for a fix for the problem. It introduces some helper functions which do now explicitely work with (u)int64_t, including a special version of the _perfdata_ helper. In the process of introducing this to check_swap, I stumbled over several sections of the check_swap code which I found problematic. Therefore I tried to simplify the code and make it more readable and less redundant. I am kinda sorry about this, but sincerely hope my changes can be helpful.
2021-09-25Introduce new perfdata functions and stuff for using (u)int64_trincewind2-0/+130
2021-09-02Improvements suggested by tobiaswieseJonny007-MKD2-3/+3
2021-09-02check_dns: Fix memory leakJonny007-MKD1-1/+1
2021-09-02check_dns: add --expect-nxdomainJonny007-MKD3-18/+56