| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
|
|
check_ircd was using the string `ircd` plus the PID as a nickname
for connecting to a IRC network by default.
This caused errors, when the PID was too high and the network
restricted the length of the nickname to 9 characters.
This patch "fixes" this by just cutting it of, if it gets too big.
|
|
* monitoring-plugins/pr/1707:
Revert to poor man's logic
Change all to comments to old comment style
Fix comparing logic
Remove spaces from tests
check_swap: Fix perfdata und thresholds for big values and simplify code
Introduce new perfdata functions and stuff for using (u)int64_t
|
|
|
|
|
|
|
|
|
|
The original problem was https://github.com/monitoring-plugins/monitoring-plugins/pull/1705
where the performance data output of check_swap did not conform to
the parser logic of a monitoring system (which decided to go for
"correct" SI or IEC units.
The PR was accompanied by a change to byte values in the performance
data which broke the _perfdata_ helper function which could not handle
values of this size.
The fix for this, was to use _fperfdata_ which could, but would
use float values.
I didn't like that (since all values here are discreet) and this
is my proposal for a fix for the problem.
It introduces some helper functions which do now explicitely work
with (u)int64_t, including a special version of the _perfdata_ helper.
In the process of introducing this to check_swap, I stumbled over
several sections of the check_swap code which I found problematic.
Therefore I tried to simplify the code and make it more readable
and less redundant.
I am kinda sorry about this, but sincerely hope my changes can
be helpful.
|
|
|
|
|
|
|
|
|
|
Use netcat-openbsd for debian explicitely
|
|
|
|
check_disk: Fixing the stuff that is broken on btrfs
|
|
Feature check curl
|
|
|
|
|
|
errors)
|
|
Re-attach a comment to where it actually belongs
|
|
|
|
xFuture603/change_state_from_infinite_redirect_loop
check_http: changed 'STATE_CRITICAL' to 'STATE_WARNING' for infinite loop
|
|
|
|
Let ssh decide if a host is valid, enables usage of ssh .config file
|
|
|
|
extended RE
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
fixes check_curl: "CRITICAL - Cannot retrieve certificate subject."
|
|
- added verbose output in verify_callback
- pin refcounting for certs (avoid subject extraction error when checking
certs in is_openssl_callback mode)
|
|
|
|
Migrate to GitHub actions
|
|
check_http closes the connection after checking the certificate with -C. This leads to sigpipe
errors when the ssl daemon wants to send a response and the daemon quits which makes the
subsequent tests fail.
|
|
github action might fail from to time otherwise
|
|
Signed-off-by: Sven Nierlein <sven@nierlein.de>
|
|
Rather than manully removing the tmpfs volume.
Signed-off-by: Jacob Hansen <jhansen@op5.com>
|
|
* Set correct amount of tests based on conditionals.
* When running the test as non-root, we would previously check is the
setuid bit is set. This doesn't seem to be needed, so just check if the
binary is executable for the user running the test.
* Use cmp_ok to check if tests succeeds rather than couting.
Signed-off-by: Jacob Hansen <jhansen@op5.com>
|
|
Docker doesn't seem to have a working IPv6 stack by default. For now
disable IPv6 tests.
Signed-off-by: Jacob Hansen <jhansen@op5.com>
|
|
It appears that `-f follow` doesn't work correctly in `check_curl` at
the moment. Test adjusted to use `-f curl` instead.
Issue for the above created: https://github.com/monitoring-plugins/monitoring-plugins/issues/1685
Signed-off-by: Jacob Hansen <jhansen@op5.com>
|
|
The SSL certificate generate using make-ssl-cert seems to not work well
with a our plugins. Causing a "CN could not be found" error to be shown.
Using an OpenSSL generated certifiticate, seems to work better.
Signed-off-by: Jacob Hansen <jhansen@op5.com>
|
|
* try to use "/usr/sbin/ip" before "ifconfig" since the latter is
obsolete on Linux to figure out interface to listen for DHCP messages.
But keeping ifconfig method just in case.
Without this, tests fail on boxes without ifconfig AND the correct
interface named ethX.
* amend possible failure responses, as check_dhcp might get a DHCPOFFER,
but from an unexpected address - which happens if the box running
tests are on a network with a DHCP server.
|
|
Fixes "No rule to make target 'test-debug'" when running "make
test-debug" in root dir.
|
|
Set correct number of tests in skip- blocks to avoid the error "Bad
plan. You planned 50 tests but ran 55" when run with/without
/usr/bin/faketime and NP_INTERNET_ACCESS=yes/no.
|
|
Signed-off-by: Jacob Hansen <jhansen@op5.com>
|
|
|
