summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-12-10check_icmp: Do not overwrite -4,-6 on lookuprefs/pull/1563/headJacob Hansen1-2/+10
In case we needed to do a lookup, we previously overwrote the address_family to IPv6, even if we supplied -4 as a cmd line argument. This commit should ensure the cmd line argument is always followed. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2018-12-10check_icmp: emit error if multiple protocol versionJacob Hansen1-0/+4
As we do not support checking both IPv4 and IPv6 hosts in one execution we emit an error if multiple protocol versions are defined in the cmd line args. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2018-12-10check_icmp: move opts string into a variableJacob Hansen1-2/+3
This commit moves the opts string into a variable as it is now used twice. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2018-12-07check_icmp: Correctly set address_family on lookupJacob Hansen1-1/+2
If a hostname is supplied instead of an IP address, the automatic address family detection would fail to correctly set the IP protocol version (it would always be IPv6). We now supply AF_UNSPEC to getaddrinfo, which should then return the correct address family in the result. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2018-12-07check_icmp: removed outcommented codeJacob Hansen1-7/+0
Signed-off-by: Jacob Hansen <jhansen@op5.com>
2018-12-07check_icmp: process protocol version args firstJacob Hansen1-10/+22
Detection of protocol version is in the previous patch implemented in the add_target() function, which is called when adding the -H command line argument. That means that if a protocal version argument (-4, -6) is added after the -H then the protocol version might be incorrectly set. This patch ensures that we first process the protocol version arguments, and then we process the rest of the arguments. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2018-12-07check_icmp: Automatically detect IP protocolJacob Hansen1-26/+45
This patch automatically detects whether the protocol version is IPv4 or IPv6 All credits to: https://github.com/ghciv6 Signed-off-by: Jacob Hansen <jhansen@op5.com>
2018-12-07Fixed parameter handling after 01efbb2183d49c5082598d4799788fc385342f28Lars Michelsen1-38/+38
2018-12-07check_icmp: Add IPv6 supportLars Michelsen1-161/+330
This commit adds IPv6 capabilities to check_icmp. It is now possible to specify the address family using the arguments -4 (default) or -6. To make the change possible we had to move the argument parsing previous to creating the socket to be able to create it with the correct address family. This commit also fixes some gcc 4.9.2 compiler warnings. It has been tested with several current linux distributions (debian, ubuntu, rh, sles). This commit fixes monitoring-plugins/monitoring-plugins#1291
2018-12-07Merge pull request #1565 from sni/travis_run_plugin_root_testsSven Nierlein18-438/+212
Travis run plugin root tests
2018-12-04tests: rework test parametersrefs/pull/1565/headSven Nierlein16-303/+107
there were 2 variants of calling getTestParameter: - parameter, description, default value - parameter, env value, default value, description, scope While scope was never actually used and having 2 names for the same value led to having 2 different entries in the cache file for the same configuration. This commit removes the variants and simplifies tests parameters by only using the first 3 parameter variant.
2018-12-04NPTest: unify whitespaceSven Nierlein1-73/+73
2018-12-04tests: skip some tests if Monitoring::Plugin::Range isn't availableSven Nierlein1-67/+36
The check_file_age uses Monitoring::Plugin::Range internally. Skip thoses tests if the module isn't available.
2018-12-04tests: enable plugins-root testsSven Nierlein1-0/+1
2018-11-10Merge remote-tracking branch 'monitoring-plugins/pr/1560'Holger Weiss1-1/+11
* monitoring-plugins/pr/1560: Add new flag --show-body/-B to print body
2018-11-09Add new flag --show-body/-B to print bodyrefs/pull/1560/headTobias Wolf1-1/+11
This should help with figuring out ia problem at a glance when enabled for healthz endpoints on web APIs, for example. The content of the body can point to what the problem is and help with diagnostics. Fixes #1559
2018-11-06Merge remote-tracking branch 'monitoring-plugins/pr/1476'Holger Weiss5-5/+8023
* monitoring-plugins/pr/1476: test: Add proxy tests via proxy Allow user to specify HTTP method after proxy CONNECT
2018-11-06test: Add proxy tests via proxyrefs/pull/1476/headMarkus Frosch4-2/+8009
On Travis with a local squid
2018-11-06Allow user to specify HTTP method after proxy CONNECTMarkus Frosch1-3/+14
Simple format, avoids refactoring the CONNECT feature.
2018-10-22Merge pull request #1552 from madpilot78/Avoid_passing_NULL_to_vprintfSven Nierlein1-4/+7
Avoid passing NULL to vprintf().
2018-10-22Merge pull request #1522 from Sp1l/fix-MariaDB10.2Sven Nierlein1-0/+5
Fix build issue with MariaDB 10.2
2018-10-13Merge pull request #1556 from TeamOfMonkeysNet/masterSven Nierlein1-0/+1
Added a compiled plugin script that was missing from gitignore
2018-10-13Added a compiled plugin script that was missing from gitignorerefs/pull/1556/headLucas Bussey1-0/+1
2018-09-29Avoid passing NULL to vprintf().refs/pull/1552/headGuido Falsi1-4/+7
2018-07-26Merge pull request #1538 from wopfel/uptime-pluginSven Nierlein3-0/+446
Uptime plugin
2018-06-17Fixed error message, added commentrefs/pull/1538/headBernd Arnold1-1/+2
2018-06-17Drop uptime binary callBernd Arnold1-1/+1
No need to call /bin/uptime, since the string can be generated with strftime(...).
2018-06-17Added help text for range supportBernd Arnold1-0/+6
2018-06-17Remove useless (empty) printBernd Arnold1-1/+0
2018-06-13fix typo in check_uptimeSven Nierlein1-1/+1
2018-06-13add check_uptime to makefileSven Nierlein1-0/+2
2018-06-13RefactoringBernd Arnold1-7/+7
Better alignment. Avoid duplications ("Exceeds ... threshold").
2018-06-13Added tests for range valuesBernd Arnold1-1/+57
2018-06-13Introducing ranges for warning and criticalBernd Arnold2-42/+95
Works as before: -w 1w -c 2w New (as before, but also warn if uptime < 5m, and crit if uptime < 2m): -w 5m:1w -c 2m:2w (idea by @sni) Also refactored the time calculation, if a suffix is present: New sub calc_as_seconds($)
2018-06-13Modified alignmentBernd Arnold1-2/+2
2018-06-13Fix: Use macro for perl binaryBernd Arnold1-1/+1
I've messed that up in the previous commit 554b702f9d65fdfe640f20633543e00cd79d64ac.
2018-06-09Fix: Initialize valuesBernd Arnold1-0/+1
Otherwise, there's a warning about unitialized values: Use of uninitialized value $hours in numeric gt (>) at ... Use of uninitialized value $days in numeric gt (>) at ...
2018-06-03Fix: uptime_file variable was declared too lateBernd Arnold1-3/+3
When called with --help, the following error was shown: Use of uninitialized value $uptime_file in concatenation (.) or string at
2018-06-03Added test fileBernd Arnold1-0/+73
2018-06-03Added suffix "s" for seconds in perfdata outputBernd Arnold1-1/+1
2018-06-03Rename to .plBernd Arnold1-0/+0
All other check script also have the .pl ending
2018-05-30Replaced my values with macrosBernd Arnold1-5/+4
2018-05-30My version of check_uptimeBernd Arnold1-0/+256
Derived from check_mailq
2017-11-06Fix build issue with MariaDB 10.2refs/pull/1522/headBernard Spil1-0/+5
As of 10.2 MariaDB no longer defines MYSQL_PORT.
2017-09-04Merge pull request #1505 from m-kraus/patch-1Sven Nierlein1-3/+1
Output plugin's stderr to stderr
2017-09-04Output plugin's stderr to stderrrefs/pull/1505/headMichael Kraus1-3/+1
Output plugin's stderr to stderr and do not exit with WARNING in that case
2017-05-04Merge pull request #1474 from odenbach/vportSven Nierlein1-2/+39
Added tests for virtual port behaviour. Separated from all other test…
2017-04-21Merge pull request #1485 from kbabioch/fix/spellingSven Nierlein1-1/+1
plugins: check_dig: Fix spelling
2017-04-20plugins: check_dig: Fix spellingrefs/pull/1485/headKarol Babioch1-1/+1
2017-04-20Merge pull request #1461 from philipowen/file-size-lessthanSven Nierlein3-15/+93
Enable check_file_age to test for maximum file size