Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
lines so this new test fails on the current head.
Note: check_snmp v1.4.13 with multi-line strings return somewhat v3 output;
it's not exactly what the specs say but it doesn't appears to break them
either. The fix could eventually supports both v2 and v3 output formats.
|
|
#2832451)
|
|
|
|
|
|
Only multi-line string test for now (regression test), counter rollover
tests planed with my snmp_counters_new branch.
NB: 64bit counters are broken in NetSNMP::agent from NetSNMP version 5.4.1
and lower, but might come in handy one day
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This is intended to make error fixing based on tinderbox output
easier.
|
|
Time differences are now set to 0 in case of backward timejumps so there are no wrap-around problems any more.
The RTA calculation hopefully gets a more accurate value in these cases also.
|
|
no snmp community is specified
The checks for invalid/unavailable hosts need a complete command line.
They failed on hosts where no community was specified. Now, an invalid community is used so
the tests can run on hosts w/o snmp host/community in NPTest.cache. Execution will fail anyway.
|
|
getTestparam changes for check_ifstatus.t and ifoperstatus.t
Added snmp_interface and snmp_ifxtable test parameters to check_ifoperstatus.t.
Also getTestParameter calls for both plugins were converted to use three arguments
instead of undocumented >3 arg behaviour which led to redundant data in NPTest.cache.
|
|
|
|
check_ifstatus already used -x so both plugins can use same short option, now.
to specify privacy protocol.
|
|
(#2343438 - Robin Schroeder)
check_ifstatus didn't function correctly with SNMPv3. This is fixed now.
Created argument-hash for SNMP session creation. This removes redundant code.
Session creation was moved out of process_arguments() and now takes place
after setting the timeout handler.
Additionally the -P argument was added to specify the privprotocol.
|
|
Added testcases for check_ifoperstatus. No SNMPv3 testing
included for now.
|
|
Minor output fixes for check_ifoperstatus.
Fixed typo so that -n now implies -I as documented.
|
|
|
|
Added proper usage messages in case of missing arguments.
Removed accidently committed Data::Dumper call.
Minor whitespace fixes.
|
|
|
|
privprotocol (#2343438 - Robin Schroeder)
check_ifoperstatus didn't function correctly with SNMPv3. This is fixed now.
Created argument-hash for SNMP session creation. This removes redundant code.
Session creation was moved out of process_arguments() and now takes place
after setting the timeout handler.
Additionally the -x argument was added to specify the privprotocol.
|
|
Allocate the appropriate amount of memory for storing the thresholds
data. Before, we allocated the amount of memory required for storing a
_pointer_ to the thresholds data. This crashed (at least) check_mysql
when using its "-S" option on FreeBSD/amd64 (as reported and analyzed by
Nikita Kalabukhov - 2797757).
Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
|
|
Buffers which are used for holding arbitrary data should be referenced
using pointers to void and accessed using pointers to unsigned char.
Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
|
|
|
|
Self defined DBL_MAX caused compiler warnings. Now float.h
which defines DBL_MAX is included.
|
|
debian #530553)
check_icmp wrongly calculated the current thresholds in --help output.
|
|
check_pgsql displayed the -v flag in help output, but didn't
accept the verbosity argument. Added -v and basic verbose output.
|
|
(#2347686 - Martin Foster)
Added support for passing timeout and interval length to check_fping.
To protect compatibility, both options use fping's defaults if they
are not specified on the command line.
|
|
This patch makes use of standard threshold functions. This allows using
doubles as thresholds.
Since SNMP supports only integers, double precision numbers are only
printed when parsed from a STRING type.
In addition, support for printing properly Timeticks type has been added,
and the code has been thoroughly cleaned.
|
|
|
|
|
|
check_mrtgtraf used the label "in" for both input and output traffic.
This fixed, now.
|
|
Check_smtp's help showed the -n/--nocommand options to not send an
SMTP command. This usage is covered by check_tcp and is thus not needed
in check_smtp.
|
|
|
|
Presbrey)
|
|
|
|
|
|
Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
|
|
Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
|
|
Update the Developer Guidelines to reflect the fact that our development
is done using Git instead of CVS these days (as noted by Chris Pepper on
the "nagiosplug-devel" list).
While at it, apply another few minor cleanups.
Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
|
|
Don't explain why Libtool and Gettext are no longer needed. Libtool
actually is a requirement, as (at least) the M4 macros provided by
Libtool are needed for our Autotools setup. And the fact that Gettext
is no longer needed probably isn't that interesting for new developers.
Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
|
|
|
|
(sf.net #2731755, debian #521097)
|