summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2014-01-31Add tests for negative thresholds in check_snmpThomas Guyot-Sionnest2-8/+36
Next commit will work on fixing these!
2014-01-31Add tests for negative thresholds in test_utilsThomas Guyot-Sionnest1-2/+17
2014-01-30check_dig: Declare variable at the topHolger Weiss1-1/+2
C89 doesn't allow variable declarations to be intermingled with code.
2014-01-30check_dig: stick with integer devisionJan Wagner1-1/+1
This change saves us from having to link check_dig against "libm"
2014-01-30check_dig: timeout_interval is a global variableJan Wagner1-2/+0
which is already set to 10 seconds
2014-01-30check_dig: patch to make dig honor -t optionJan Wagner2-2/+10
When a timeout value is specified with the -t option, dig will sometimes timeout before the timer is actually reached. The problem occurs because the check_dig plugin does not pass the specified timeout value to dig, leaving dig to timeout with it's default value which seems to be around 10-15seconds. To reproduce: time ./check_dig -H 127.0.0.2 -l www.google.com -t 30 It will not run for 30secs, which is the expected behaviour. The following will work, because the timeout is less than the default dig timeout, so the plugin cancels the dig command: time ./check_dig -H 127.0.0.2 -l www.google.com -t 2 This fix passes the timeout value to dig, and sets the number of retries which tends to vary from system to system by default. Closes #1168
2014-01-30Add tests for mp_translate_state()Thomas Guyot-Sionnest1-5/+50
2014-01-29check_mailq: adding nullmailer supportJan Wagner2-2/+40
Adding nullmailer support to check_mailq submitted by Luca Corti Closes: #740 Closes: #1189
2014-01-29Just fixing small typo in commentJan Wagner1-1/+1
2014-01-29Update check_swap usageThomas Guyot-Sionnest1-3/+4
2014-01-29AUpdate .gitignore for new gnulib moduleThomas Guyot-Sionnest1-0/+1
2014-01-29check_swap: add supports for a configurable state when there is no swapThomas Guyot-Sionnest2-2/+16
Check_swap used to allow no swap when thresholds were only specified in percent. This is no longer the case and the state now must be specified explicitly. The default is to always return CRITICAL when the swap is absent regardless of thresholds.
2014-01-29Move negate' translate_state() to utils_base.h mp_translate_state()Thomas Guyot-Sionnest3-28/+31
Also use strcasecmp imported from gnulib for simplicity
2014-01-29Add strcase gnulib moduleThomas Guyot-Sionnest8-2/+403
2014-01-29TypoThomas Guyot-Sionnest1-1/+1
2014-01-29Fix check_swap returning OK on & thresholds and no swapThomas Guyot-Sionnest1-1/+1
Return 0% free instead of 100% free when total swap is 0
2014-01-28check_disk: precise the help outputJan Wagner1-1/+1
Clarifying in the help output that we need either a device or mount point listed by the mount(8) command. (Closes: #1118) (Closes: #1170)
2014-01-28Clarify check_mysql test promptsThomas Guyot-Sionnest1-15/+17
Also default to "-u test -ptest" which are default MySQL accounts only missing the prescribed privileges. The database is no longer specified as it is not used. If wanted is should be its own parameter/tests.
2014-01-28Merge pull request #1200 from awiddersheim/add_file_options_mysql_queryThomas Guyot-Sionnest1-3/+23
Add ability to read from options file to check_mysql_query.c
2014-01-28check_dig: fix wrong IPv6 arguments orderThomas Guyot-Sionnest3-2/+4
2014-01-27Rename MP_STATE_DIRECTORY to MP_STATE_PATHThomas Guyot-Sionnest3-7/+7
2014-01-27And release notes for previous change (MP_STATE_DIRECTORY)Thomas Guyot-Sionnest2-1/+2
The change has also been updated in https://www.monitoring-plugins.org/doc/state-retention.html
2014-01-26Fix tests with an empty NPTest.cache fileThomas Guyot-Sionnest1-1/+1
The NPTest.cache cannot be loaded when empty, and this prevents getting the data and populating the file. This patch skips the file when empty as if it didn't exist.
2014-01-25Ignore MP_STATE_DIRECTORY in suid pluginsThomas Guyot-Sionnest3-9/+21
If a plugin still has suid privileges at the time np_enable_state() is called, the MP_STATE_DIRECTORY environment will be ignored. There is no need for a NEWS entry as no suid plugins use np_enable_state yet.
2014-01-25Clean up parse_ini error messages, add missing newlinesThomas Guyot-Sionnest1-5/+5
2014-01-25Rename ENV variable, keep backward compatibilityThomas Guyot-Sionnest3-5/+11
Rename NAGIOS_PLUGIN_STATE_DIRECTORY to MP_STATE_DIRECTORY
2014-01-24check_file_age: support for --ignore-missingJan Wagner2-5/+19
Patch to provide for a -i | --ignore-missing option. This allows files that don't exist to be monitored for without causing an error. The use case is: * one process periodically pushes files to an "input" queue for a second process * the second process, when running cleanly will "consume" (process and remove) these files So the conditions to meet are: 1. If the file doesn't exist, that's fine (OK) 2. If the file exists, but is less than X seconds, that's fine (OK) 3. If the file exists, but greater than X seconds, no good (CRITICAL) Since now check_file_age doesn't permit this behavior, as a non-existent file is considered CRITICAL. Test case was contributed by our lovely Holger. Closes #1181, Closes #989, Closes #862, Closes #1187, Closes #845 Closes Debian Bug #496307
2014-01-24check_ping: Fixing "time of day goes back"Jan Wagner2-1/+6
by Geoff Oakham <goakham at oanda.com> Patch of check_ping that allows it to gracefully handle when ping outputs to stderr "Warning: time of day goes back (-XXXXus), taking countermeasures." Closes: #809 and #1195
2014-01-24Fixing bug in average calculation (Submitted by Lars)Jan Wagner2-2/+2
The more important change: A fix for a bug which caused the check_ntp_time and check_ntp_time check to always take the first response from ntp and not the avarage since "j" is not increased anywhere. "i" should be used there instead. Partly Closes #956 and Closes #1166 Closes: #1089
2014-01-24Making AVG_NUM configurable by compiler define (Submitted by Lars)Jan Wagner2-0/+4
A minor change which makes the AVG_NUM configurable by compiler define. Partly Closed #956 and Closes #1166
2014-01-24Use access() instead of stat() in parse_ini.cThomas Guyot-Sionnest1-3/+2
2014-01-24Update commentsThomas Guyot-Sionnest10-10/+10
1. libtab is now bundled, so suggest to enable it rather than install it 2. "parse-ini" feature has been called "extra-opts"
2014-01-23Remove obsolete check_ntp.plThomas Guyot-Sionnest2-472/+1
2014-01-23fix smart attribute comparisonTilmann Bubeck1-3/+3
Each S.M.A.R.T. attribute is compared against a threshold. If it is LESSTHAN that threshold an error is reported. This patch fixes the problem, that attribute values EQUAL to the threshold are reported as error, which is wrong. Only LESSTHAN the threshold is an error. For more information see: http://www.hdsentinel.com/smart/index.php My SSD has some attributes which value and threshold are "0". Without the patch this is reported as errornous. ID# ATTRIBUTE_NAME FLAG VALUE WORST THRESH TYPE UPDATED WHEN_FAILED RAW_VALUE ... 172 Unknown_Attribute 0x0032 000 000 000 Old_age Always - 0 174 Unknown_Attribute 0x0030 000 000 000 Old_age Offline - 13 177 Wear_Leveling_Count 0x0000 000 000 000 Old_age Offline - 0 ... See also: * http://sourceforge.net/p/nagiosplug/patches/365/ * https://bugzilla.redhat.com/913085
2014-01-23Enable extra-opts by defaultThomas Guyot-Sionnest2-1/+2
2014-01-23Fix misleading option textThomas Guyot-Sionnest1-1/+2
As soon as a device is specified without using -d, anything else on the command line is ignored.
2014-01-23Disable SMART test commands in check_ide_smartThomas Guyot-Sionnest2-37/+26
check_ide_smart could disable offline auto tests but could not re-enable them. For this reason all SMART command modes have been disabled The disabled commands are -0/--auto-off, -1/--auto-on and -i/--immediate
2014-01-23Remove accidental tabs inserted in macroThomas Guyot-Sionnest1-1/+1
2014-01-23Make check_ide_smart default to nagios outputThomas Guyot-Sionnest2-28/+38
check_ide_smart was originally a smard control utility later converted to a monitoring plugin. the -n option (Nagios check) should therefore be the default. This patch deprecates the -n and -q switches, and make the other switches return nagios-compatible output (they are most likely used in eventhandlers, but returning nagios-compatible output makes it clear and easy to handle the return status)
2014-01-22plugins/utils.h: avoiding warnings on empty printf statementsRicardo Maraschini1-1/+1
while compiling i keep receiving an warning statement as follow: warning: zero-length gnu_printf format string using an unorthodox method to remove them Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com>
2014-01-22fix outdated Free Software Foundation addressLars Vogdt4-5/+6
2014-01-21README: Minor fixes regarding new project nameHolger Weiss1-10/+10
Talk about "monitoring systems", not just about "Nagios". Also, the default installation prefix has changed to /usr/local. (While at it, wrap lines consistently at 76 characters.)
2014-01-21Capitalize "Monitoring Plugins"Holger Weiss11-12/+12
"Monitoring Plugins" is a name.
2014-01-21Merge branch 'maint'Holger Weiss13-55/+79
* maint: check_ssh: Get rid of sshd: Read from socket failed: Connection reset by peer fixed tests when there is no direct internet connection NEWS: Mention fix for check_http's -S option Fix for SSL Versioning when multiple options are used. Fix #1217 spec file fails to build due to duplicate files and unused files check_http: Don't let "-N" expect an argument README: Change GitHub URL README: Clarify license notice Update URLs and mailing list addresses Just using the posix conform extended regular expression grep check_oracle: --db +ASM bad string matching check_oracle doesn't correctly check for pmon +ASM instance from at least Oracle 11 as the pmon proces was renamed from ora_pmon_.* to asm_pmon_.*. -- Just turning attached patch of github issue #1207 into a push request. (Closes #1207) Update web site URLs Conflicts: FAQ NEWS README SUPPORT configure.in monitoring-plugins.spec.in pkg/solaris/pkginfo.in plugins-root/check_dhcp.c plugins-root/check_icmp.c plugins-scripts/check_ifoperstatus.pl plugins-scripts/check_mssql.pl plugins/check_apt.c plugins/check_by_ssh.c plugins/check_cluster.c plugins/check_dbi.c plugins/check_dig.c plugins/check_disk.c plugins/check_dns.c plugins/check_dummy.c plugins/check_fping.c plugins/check_game.c plugins/check_hpjd.c plugins/check_http.c plugins/check_ide_smart.c plugins/check_ldap.c plugins/check_load.c plugins/check_mrtg.c plugins/check_mrtgtraf.c plugins/check_mysql.c plugins/check_mysql_query.c plugins/check_nagios.c plugins/check_nt.c plugins/check_ntp.c plugins/check_ntp_peer.c plugins/check_ntp_time.c plugins/check_nwstat.c plugins/check_overcr.c plugins/check_pgsql.c plugins/check_ping.c plugins/check_procs.c plugins/check_radius.c plugins/check_real.c plugins/check_smtp.c plugins/check_snmp.c plugins/check_ssh.c plugins/check_swap.c plugins/check_tcp.c plugins/check_time.c plugins/check_ups.c plugins/check_users.c plugins/negate.c plugins/urlize.c plugins/utils.h po/Makevars po/de.po po/fr.po po/monitoring-plugins.pot
2014-01-21Merge branch 'rename'Thomas Guyot-Sionnest117-3315/+4271
2014-01-21New default installation prefix: /usr/localHolger Weiss2-3/+1
Install into /usr/local instead of /usr/local/nagios by default, in order to comply with the Filesystem Hierarchy Standard (FHS) and presumably the expectations of most users.
2014-01-21plugins/*.c: Non-network timeout changesSpenser Reinhardt4-4/+4
Changes to non-network checks for clarity on timeout value. Adapted from pull request #1209 tracker from user awiddersheim. (Closes: #1209) Files: check_apt.c, check_disk.c, check_procs.c, negate.c
2014-01-21plugins/utils.h: Addition of plugin timeout msg.Spenser Reinhardt1-1/+5
Addition of timeout message for non-network plugins(UT_PLUG_TIMEOUT), and alteration of UT_TIMEOUT to UT_CONN_TIMEOUT for networked checks. Alteration of pull request #1209 tracker by user awiddersheim.
2014-01-21plugins/*.c: Alterations for timeout messages.Spenser Reinhardt26-26/+26
.c file changes for misleading timeout messages in help functions. Solution to pull request #1209 tracker by awiddersheim. Files: plugins/check_apt.c, plugins/check_by_ssh.c, plugins/check_dbi.c, plugins/check_dig.c, plugins/check_disk.c, plugins/check_dns.c, plugins/check_game.c, plugins/check_http.c, plugins/check_ldap.c, plugins/check_ntp.c, plugins/check_ntp_peer.c, plugins/check_ntp_time.c, plugins/check_nwstat.c, plugins/check_overcr.c, plugins/check_pgsql.c, plugins/check_ping.c, plugins/check_procs.c, plugins/check_radius.c, plugins/check_real.c, plugins/check_smtp.c, plugins/check_snmp.c, plugins/check_ssh.c, plugins/check_tcp.c, plugins/check_time.c, plugins/check_ups.c, plugins/negate.c
2014-01-21Revert renaming valueJan Wagner1-5/+5
As suggested by sreinhardt in 045d38a6 over there in nagios-plugins