summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2014-06-21Add UID to state retention file pathHolger Weiss3-3/+11
Add the UID of the invoking user to the state retention file path. This helps solving permission issues when different users run the same plugin.
2014-06-20NEWS: s/MP_STATE_DIRECTORY/MP_STATE_PATH/Holger Weiss1-1/+1
NAGIOS_PLUGIN_STATE_DIRECTORY was renamed to MP_STATE_PATH, not to MP_STATE_DIRECTORY.
2014-06-18lib/parse_ini.c: Print proper read error messageHolger Weiss1-1/+2
Print a useful error message if opening the configuration file fails.
2014-06-18lib/parse_ini.c: Drop privileges for reading fileHolger Weiss1-0/+10
Read the configuration file with privileges temporarily dropped if the code is used by a setuid plugin.
2014-06-18lib/parse_ini.c: Add newline to die() callsHolger Weiss1-2/+2
Our die() function doesn't append a newline character to the message.
2014-06-18lib/parse_ini.c: Cosmetic changeHolger Weiss1-4/+1
Replace an "if" with the ternary operator.
2014-06-18Add Gnulib module "idpriv-droptemp"Holger Weiss6-4/+352
2014-06-18Use FindBin consistently across Perl pluginsHolger Weiss2-2/+4
Use Perl's FindBin module to locate the path to utils.pm in check_file_age.pl and check_mssql.pl, just as we do in other Perl plugins.
2014-06-18plugins/runcmd.c: Remove superfluous newlineHolger Weiss1-1/+1
The puts(3) function already appends a newline character to the string.
2014-06-18lib/parse_ini.c: Search for INI file in subdirsHolger Weiss1-0/+2
Add two path names to the list of default INI file locations, as some users/distributions prefer to put configuration files into subdirectories.
2014-06-18lib/parse_ini.c: Add comment on NAGIOS_CONFIG_PATHHolger Weiss1-15/+17
We might want to spit out a warning when NAGIOS_CONFIG_PATH is used. While at it, move the function that handles this environment variable to the bottom.
2014-06-18lib/parse_ini.c: Cosmetic changes to commentsHolger Weiss1-16/+20
2014-06-18lib/parse_ini.c: Fix Clang warningsHolger Weiss1-8/+7
2014-06-18lib/parse_ini.[ch]: Change code formattingHolger Weiss2-156/+192
Change the indentation and formatting of the code in lib/parse_ini.c. This breaks patches against that file and makes it harder to track its history, but it (hopefully) improves readability a lot.
2014-06-18lib/parse_ini.c: Don't cast malloc(3) resultHolger Weiss1-2/+2
There's no need to cast malloc(3)'s return value.
2014-06-18lib/parse_ini.c: Remove outdated comment and codeHolger Weiss1-15/+10
The lib/parse_ini.c:np_get_defaults() function now dies if no configuration file is found.
2014-06-18lib/parse_ini.c: Read $MP_CONFIG_FILEHolger Weiss1-1/+2
Read $MP_CONFIG_FILE if that variable is set in the environment.
2014-06-18lib/parse_ini.c: Read "monitoring-plugins.ini"Holger Weiss1-0/+4
Read "monitoring-plugins.ini" if that file exists, but fall back to reading "plugins.ini" or "nagios-plugins.ini" for backward compatibility.
2014-06-18lib/parse_ini.[ch]: Simplify codeHolger Weiss2-110/+49
Rewrite the code that looks up the INI configuration file path (used by the Extra-Opts feature) in order to improve readability. The behaviour should not have changed.
2014-06-13tests: freebsds snmpd does not use quotesSven Nierlein1-1/+1
when returning syscontact. So make them optional since we want to test check_snmp and not the snmpd. Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-06-13tests: check_proc tests fail if uid -2 does not map to nobodySven Nierlein1-0/+1
so make sure our tests only run if -2 maps to nobody Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-06-13tests: fping checks require being root or setuid rootSven Nierlein2-9/+34
on the fping binary. Check this before running the test. Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-06-13require at least HTTP::Daemon 6.01Sven Nierlein1-1/+2
since the test uses send_header from HTTP::Daemon::ClientConn which has been introduced in HTTP::Daemon 6.01
2014-06-12tests: testCmd has own timeout which overwrites local oneSven Nierlein2-17/+12
so add configurable/optional timeout to testCmd. Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-06-12tests: parts of the check_procs test only work when uid -2 existsSven Nierlein1-12/+16
skip those tests if the uid does not exist Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-06-12configure.ac: Remove unused codeHolger Weiss1-2/+0
We no longer set LIBGNUTLS_CONFIG, as GnuTLS no longer ships a "libgnutls-config" tool.
2014-06-12Fix compilation with GnuTLSHolger Weiss1-0/+2
GnuTLS doesn't provide a SSL_CTX_check_private_key() function. Closes #1254.
2014-04-27Make check_disk work on Windows.Gunnar Beutner1-1/+20
2014-04-27Make check_users work on Windows.Gunnar Beutner3-5/+51
2014-04-27Make check_ping work on Windows.Gunnar Beutner2-4/+19
2014-04-27Add missing file extensions for some of the plugins.Gunnar Beutner1-21/+21
2014-04-24check_snmp: Handle SNMPv3 noAuthNoPriv properlyAnton Lofgren2-6/+15
The SNMPv3 noAuthNoPriv security level, somewhat unintuitively, requires a security name to be passed along together with the request. Check_snmp previously did not do this, causing snmpget to throw an error: "External command error: No log handling enabled - turning on stderr logging snmpget: No securityName specified" This patch fixes the issue by always providing the security name when noAuthNoPriv is specified. See also: https:://bugs.op5.com/view.php?id=8385. Signed-off-by: Anton Lofgren <alofgren@op5.com>
2014-04-04Remove the suggestion to run check_apt with --verbose since it doesn't do ↵Sam Kottler1-1/+1
anything
2014-04-04Add Sam Kottler to the list of AUTHORSHolger Weiss1-0/+1
2014-04-04check_nt: add UPTIME to perfdata [sf#3434647]Jan Wagner2-1/+2
2014-04-03Fix check_mysql.c client options from fileawiddersheim1-6/+0
If you don't specify a group or a file to read data from the plugin tries to read from several files that don't exist and no groups.
2014-03-20Update the last remaining instance of the old FSF addressSam Kottler1-1/+1
2014-03-13check_pgsql: Add missing newline to --help outputHolger Weiss1-1/+1
2014-03-09build - avoid deprecated INCLUDESDavide Madrisan3-11/+10
Signed-off-by: Davide Madrisan <davide.madrisan@gmail.com>
2014-02-28Disable Perl's "taint" checksHolger Weiss3-3/+3
Perl's "taint" checks don't like `use lib "$FindBin::Bin"'. Cf. http://www.perlmonks.org/?node_id=585299
2014-02-28travis-ci: remove mawk build-depsJan Wagner1-1/+1
2014-02-28configure.ac: Remove unused AC_PATH_PROG() callsHolger Weiss1-3/+0
2014-02-28Replace "plugins-scripts/subst.in" fooHolger Weiss20-103/+53
Remove the buggy and complex awk(1) magic in "plugins-scripts/subst.in" in favor of simple sed(1) substitutions. The plugins in the "plugins-scripts" directory now always use the PATH specified via "./configure --trusted-path", or the default PATH hard-coded in "configure.ac". Fixes #1242.
2014-02-28Merge remote-tracking branch 'awiddersheim/fix_trusted_path'Holger Weiss18-28/+508
* awiddersheim/fix_trusted_path: Fix trusted path Conflicts: plugins-scripts/check_ntp.pl plugins-scripts/subst.in Closes #1212.
2014-02-27travis-ci: Remove gawk to build against mawkJan Wagner1-0/+1
2014-02-27subst.in: remove the led() functionEvgeni Golov1-17/+0
It was only used to replace the 'use lib utils.pm' with the proper libexec dir, which is now solved by using Perl's FinBin. Closes #1241
2014-02-27utils.pm: use FindBin instead of awk to find the path toEvgeni Golov10-10/+20
'use lib utils.pm' is not valid Perl syntax: Bareword "utils" not allowed while "strict subs" in use at plugins-scripts/check_ircd.pl line 52. Bareword "pm" not allowed while "strict subs" in use at plugins-scripts/check_ircd.pl line 52. This makes it impossible to use the plugins directly from the git tree, e.g. while hacking on them. Using FindBin::Bin as the library path allows that, while preserving the original behaviour of adding the libexec path when the plugin is properly installed.
2014-02-27NEWS: Adding check_mailq auto detectionJan Wagner2-0/+3
2014-02-27check_mailq: add $mailq to check output, so it is easily visible what was ↵Evgeni Golov1-17/+17
autodetected Closes: #1242
2014-02-27check_mailq: document autodetection in the usage outputEvgeni Golov1-1/+3