summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-10-25actions: map utmp from host to containerSven Nierlein1-0/+1
this fixes the check_users not having any logged in user to check.
2021-10-20Add comment to make the purpose of the nickname fix more obviousLorenz Kästle1-0/+2
2021-10-20Restrict the nickname length of the test user for check_ircdLorenz Kästle1-1/+1
check_ircd was using the string `ircd` plus the PID as a nickname for connecting to a IRC network by default. This caused errors, when the PID was too high and the network restricted the length of the nickname to 9 characters. This patch "fixes" this by just cutting it of, if it gets too big.
2021-10-03Merge remote-tracking branch 'monitoring-plugins/pr/1707'Holger Weiss4-104/+268
* monitoring-plugins/pr/1707: Revert to poor man's logic Change all to comments to old comment style Fix comparing logic Remove spaces from tests check_swap: Fix perfdata und thresholds for big values and simplify code Introduce new perfdata functions and stuff for using (u)int64_t
2021-10-02Revert to poor man's logicRincewindsHat3-18/+16
2021-10-02Change all to comments to old comment styleRincewindsHat1-3/+4
2021-09-26Fix comparing logicRincewindsHat1-2/+2
2021-09-26Remove spaces from testsRincewindsHat1-3/+3
2021-09-25check_swap: Fix perfdata und thresholds for big values and simplify coderincewind1-102/+137
The original problem was https://github.com/monitoring-plugins/monitoring-plugins/pull/1705 where the performance data output of check_swap did not conform to the parser logic of a monitoring system (which decided to go for "correct" SI or IEC units. The PR was accompanied by a change to byte values in the performance data which broke the _perfdata_ helper function which could not handle values of this size. The fix for this, was to use _fperfdata_ which could, but would use float values. I didn't like that (since all values here are discreet) and this is my proposal for a fix for the problem. It introduces some helper functions which do now explicitely work with (u)int64_t, including a special version of the _perfdata_ helper. In the process of introducing this to check_swap, I stumbled over several sections of the check_swap code which I found problematic. Therefore I tried to simplify the code and make it more readable and less redundant. I am kinda sorry about this, but sincerely hope my changes can be helpful.
2021-09-25Introduce new perfdata functions and stuff for using (u)int64_trincewind2-0/+130
2021-09-02Improvements suggested by tobiaswieseJonny007-MKD2-3/+3
2021-09-02check_dns: Fix memory leakJonny007-MKD1-1/+1
2021-09-02check_dns: add --expect-nxdomainJonny007-MKD3-18/+56
2021-09-01Merge pull request #1704 from RincewindsHat/use_openbsd_netcat_for_debian_testsSven Nierlein1-1/+1
Use netcat-openbsd for debian explicitely
2021-09-01Use netcat-openbsd for debian explicitelyrincewind1-1/+1
2021-08-24Merge pull request #1388 from waja/check_proc_consumption_1357Sven Nierlein1-4/+1
check_disk: Fixing the stuff that is broken on btrfs
2021-08-10Merge pull request #1700 from monitoring-plugins/feature_check_curlSven Nierlein1-8/+77
Feature check curl
2021-07-28Merge branch 'master' into feature_check_curlAndreas Baumann3-5/+3
2021-07-25check_curl: fixed a potential buffer overflow in retir/uri_stringAndreas Baumann1-2/+2
2021-07-25check_curl: fixed DNS caching for SSL hostnames (avoid CURLOPT_RESOLVE entry ↵Andreas Baumann1-3/+51
errors)
2021-07-22Merge pull request #1699 from peternewman/patch-1Sven Nierlein1-1/+1
Re-attach a comment to where it actually belongs
2021-07-22Re-attach a comment to where it actually belongsPeter Newman1-1/+1
2021-07-08Merge pull request #1690 from ↵Sven Nierlein1-2/+2
xFuture603/change_state_from_infinite_redirect_loop check_http: changed 'STATE_CRITICAL' to 'STATE_WARNING' for infinite loop
2021-07-05Add quoting for the remaining variablesrincewind1-3/+3
2021-07-05Merge pull request #1691 from RincewindsHat/no-host-check-for-check_by_sshSven Nierlein1-2/+0
Let ssh decide if a host is valid, enables usage of ssh .config file
2021-07-04check_curl: changed to STATE_CRITICAL for infinite loops (-ffollow)Andreas Baumann1-2/+2
2021-07-02Add -a option to print all matching lines and -p and -e options for perl and ↵rincewind1-14/+37
extended RE
2021-07-02Add extended and perl regexrincewind1-2/+32
2021-07-02Apply shellcheckrincewind1-29/+29
2021-07-02Remove modified note, since this is a git repositoryrincewind1-2/+1
2021-06-25Let ssh decide if a host is valid, enables usage of ssh .config fileLorenz Kästle1-2/+0
2021-06-24fix for missing X509_up_ref on old systems with only OpenSSL 1.0Andreas Baumann1-0/+6
2021-06-24changed 'STATE_CRITICAL' to 'STATE_WARNING' for infinite loopDaniel Uhlmann1-2/+2
2021-06-24added option --enable-automatic-decompressionAndreas Baumann1-1/+16
2021-05-27Merge pull request #1689 from monitoring-plugins/feature_check_curlSven Nierlein1-0/+12
fixes check_curl: "CRITICAL - Cannot retrieve certificate subject."
2021-05-27check_curl:Andreas Baumann1-0/+12
- added verbose output in verify_callback - pin refcounting for certs (avoid subject extraction error when checking certs in is_openssl_callback mode)
2021-05-24check_curl.c: bugfix: verify certificates option should not force SSL to be usedBarak Shohat2-2/+2
2021-05-21Merge pull request #1686 from monitoring-plugins/feature_github_actionsSven Nierlein11-136/+194
Migrate to GitHub actions
2021-05-20tests: ignore sigpipes in https test daemonSven Nierlein1-4/+8
check_http closes the connection after checking the certificate with -C. This leads to sigpipe errors when the ssl daemon wants to send a response and the daemon quits which makes the subsequent tests fail.
2021-05-20tests: increase startup sleepSven Nierlein2-4/+6
github action might fail from to time otherwise
2021-05-20remove useless commentsSven Nierlein2-39/+3
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2021-05-19Prune container and volumesJacob Hansen1-1/+2
Rather than manully removing the tmpfs volume. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2021-05-19Refactor check_fpingJacob Hansen1-15/+14
* Set correct amount of tests based on conditionals. * When running the test as non-root, we would previously check is the setuid bit is set. This doesn't seem to be needed, so just check if the binary is executable for the user running the test. * Use cmp_ok to check if tests succeeds rather than couting. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2021-05-19Disable IPv6 in testsJacob Hansen1-1/+1
Docker doesn't seem to have a working IPv6 stack by default. For now disable IPv6 tests. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2021-05-18check_curl.t: Adjust test to use -f curlJacob Hansen1-2/+1
It appears that `-f follow` doesn't work correctly in `check_curl` at the moment. Test adjusted to use `-f curl` instead. Issue for the above created: https://github.com/monitoring-plugins/monitoring-plugins/issues/1685 Signed-off-by: Jacob Hansen <jhansen@op5.com>
2021-05-18Use openssl generated certJacob Hansen1-2/+6
The SSL certificate generate using make-ssl-cert seems to not work well with a our plugins. Causing a "CN could not be found" error to be shown. Using an OpenSSL generated certifiticate, seems to work better. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2021-04-30Fix check_dhcp testsAksel Sjögren1-2/+7
* try to use "/usr/sbin/ip" before "ifconfig" since the latter is obsolete on Linux to figure out interface to listen for DHCP messages. But keeping ifconfig method just in case. Without this, tests fail on boxes without ifconfig AND the correct interface named ethX. * amend possible failure responses, as check_dhcp might get a DHCPOFFER, but from an unexpected address - which happens if the box running tests are on a network with a DHCP server.
2021-04-30Add test-debug for plugins-rootAksel Sjögren1-0/+3
Fixes "No rule to make target 'test-debug'" when running "make test-debug" in root dir.
2021-04-30Fix conditional tests for check_http, check_curlAksel Sjögren2-4/+4
Set correct number of tests in skip- blocks to avoid the error "Bad plan. You planned 50 tests but ran 55" when run with/without /usr/bin/faketime and NP_INTERNET_ACCESS=yes/no.
2021-04-30Attempt to fix check_usersJacob Hansen1-4/+6
Signed-off-by: Jacob Hansen <jhansen@op5.com>