Age | Commit message (Collapse) | Author | Files | Lines |
|
As suggested by sreinhardt in 045d38a6 over there in nagios-plugins
|
|
|
|
It appeats STDERR isn't a tty anymore during tests, but since we type
from tty to STDIN it should be bound to our tty (and works for me).
|
|
Signed-off-by: Sven Nierlein <sven@nierlein.de>
|
|
|
|
|
|
|
|
|
|
This is an initial take at renaming the project to Monitoring Plugins.
It's not expected to be fully complete, and it is expected to break
things (The perl module for instance). More testing will be required
before this goes mainline.
|
|
In utils.sh, $ECHO was set to printf(1) or echo(1), depending on whether
printf(1) is available in /usr/bin. This resulted in various bugs, as
printf(1) cannot be used in the same way as echo(1).
Thanks to Trevor Hemsley for reporting one of those bugs: If $ECHO was
set to printf(1), check_log stumbled when reporting a log line with a
"%" character.
|
|
This fix was grabbed from FreeBSD downstream and provided by Dmitry Sivachenko.
Fixes Debian Bug #734811
|
|
AM_CONFIG_HEADER is deprecated.
|
|
- check http had wrong number of skipped tests
- check tcp did not use the 'no internet' flag at all
|
|
Closes #1220.
|
|
If you specify -S1 -C 30... The -C option will reset the ssl_version to 0. This is not a good thing.
Instead we set the default to 0 and retain the version when later args are passed.
|
|
|
|
Fix the problem that check_http's "-N" option expects an argument
although it shouldn't. The corresponding long option ("--no-body")
wasn't affected.
This error was introduced in ee3c4014d511e105489b081390636cacd4c53e3f.
Thanks to Kerry Hughes for reporting it on the devel@ list.
|
|
also grandparents make this test fail but is not a problem in real live.
NPTest->testCmd uses "sh -c" already, so there is no need to do that twice.
|
|
Closes #1205.
|
|
This fixes an issue that appears when running check_procs over NRPE,
where the default shell is configured to (for example) dash, as is the
case on Debian.
dash (and tcsh, and mksh, and probably others), when invoked with -c forks an additional process
to execute the argument string. Contrast this with bash, which does not
do this, provided that the argument string simply can be exec()'d as-is.
To demonstrate:
$ bash -c pstree
init─┬ ..
...
├─sshd─-─sshd───pstree
versus
$ dash -c pstree
init─┬ ..
...
├─sshd─-─sshd───dash───pstree
The consequence of this fork is that the following invocation:
/opt/plugins/check_procs -a init
will result in this output:
PROCS OK: 2 processes with args 'init' | processes=2;;;0;
because the check_procs, in addition to finding the actual init process,
finds its parent shell as well.
This example is a bit contrived, but I think it illustrates the
point.
This wouldn't really be a problem, and normally isn't, if it weren't
for the fact that NRPE uses a call to popen() which does exactly the
above (executes '/bin/sh -c ...'), causing inconsistent behaviour
between distributions and much confusion for end users.
The argument may be made that the dash process spawned by NRPE is just a
process like any other, and should therefore be included in the process
count just like any other. However, this is not very intuitive, because
of the previously mentioned inconsistencies.
The argument might also well be made that we're _never_ interested in the
immediate ancestor of the plugin, and while it is unknown how many
installations have already made the necessary modifications to their
setups to make up for the fact that the plugin behaves the way it does,
it is not deemed worthwhile to entertain such workarounds.
Thus, this patch ignores the parent process.
See also these bug reports:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=626913
http://sourceforge.net/p/nagiosplug/bugs/512/
https://github.com/nagios-plugins/nagios-plugins/issues/999
https://bugs.op5.com/view.php?id=4398
|
|
Link to our main project home page on GitHub instead of referencing only
the "nagios-plugins.git" repository. (And put the URL on its own line.)
|
|
Note that we permit redistribution and modification under the terms of
future GPL versions, and state the exclusion of warranty. This is in
accordance with the license notices at the top of our source files.
|
|
Now that we moved our infrastructure away from SourceForge, update the
URLs and mailing list addresses accordingly.
|
|
Fix the Test::Simple tutorial URL.
|
|
We don't run a Tinderbox instance anymore. (Noted by "zathras" on IRC.)
|
|
When configuring the plugins you have the option to specify a trusted path with --with-trusted-path. This option seems to have been deprecated at some point for unknown reasons and had typically had no affect. This commit makes this option work again for those who have a desire to use it. There should be no affect on those who have not chosen to specify a trusted path.
|
|
github1207
|
|
|
|
check_oracle doesn't correctly check for pmon +ASM instance from at least Oracle 11 as the pmon proces was renamed from ora_pmon_.* to asm_pmon_.*.
--
Just turning attached patch of github issue #1207 into a push request.
(Closes #1207)
|
|
The Nagios Plugin Development Guidelines and the Extra-Opts
documentation were moved to our new project server.
|
|
|
|
This is the same code that was added to check_mysql.c in 5ed7194.
|
|
Add a note regarding the removal of the "contrib" directory to the NEWS
file. This note is missing from the NEWS file shipped with the 1.5
release, though.
|
|
|
|
We moved from CVS to Git.
|
|
We moved our stuff from CVS/SourceForge to Git/GitHub.
|
|
We moved our stuff from CVS/SourceForge to Git/GitHub.
|
|
We moved the Nagios Plugins site from SourceForge to our project server.
|
|
We moved our stuff from CVS/SourceForge to Git/GitHub.
|
|
It would be useful to be able to detect the protocols supported by the remote
ssh server to locate any using the insecure ssh v1 protocol. This patch
attempts to match against the protocol string in the ssh response.
Example:
check_ssh -H my.host.com -P 2.0
--
Just turning attached patch of github issue #780 into a push request.
(Closes #780)
|
|
Add all new Git commit authors to the THANKS.in file.
|
|
|
|
|
|
|
|
Testing "nagiosplugins.org" will currently not work.
|
|
Add the tools/generate-change-log script for auto-generating the
ChangeLog file from the Git history when running "make dist".
|
|
We moved our web site away from Drupal and the snapshots/guidelines away
from SourceForge. The new infrastructure scripts will be maintained in
a separate repository together with the Markdown source of the new web
site.
|
|
We no longer mirror out Git repositories into Subversion.
|
|
Fixes issue where if an SSL initialization error occurs on a redirect
using -f follow the plugin still returns an OK state.
Closes #1159.
|
|
- Write "plugin" instead of "plug-in".
- Write "development guidelines" instead of "developer guidelines"
- Capitalize "Nagios Plugin Development Guidelines".
|