summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2012-06-29check_smtp: Strip angle brackets from -f argument, if providedAnders Kaseorg1-1/+2
Apparently some people used -f '<nagios@example.com>' to work around the bug I just fixed in the MAIL FROM: command generation. Although the resulting command wasn't RFC-compliant, it was working with some MTAs, so let's continue to support this syntax now that we generate RFC-compliant commands. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2012-06-29check_smtp: Change MAIL FROM: command to comply with the SMTP standardAnders Kaseorg1-1/+1
Every version of the SMTP standard (from RFC 821 to the current RFC 5321) requires the address following MAIL FROM: to follow the colon immediately (with no space) and to be surrounded by angle brackets. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2012-06-28Remove the package.def fileHolger Weiss1-1/+0
The package.def file is not included in release tarballs, and I'm not aware of anyone (still) using it.
2012-06-27Remove #990948 from the BUGS fileHolger Weiss1-2/+1
Issue #990948 has been fixed by commit 0892c4ac28c4c2e3b6275187f845813b4cd6d320.
2012-06-27Prepare for the 1.4.16 releaserelease-1.4.16Holger Weiss6-5/+455
2012-06-27check_tcp: Print performance data even with -DHolger Weiss1-1/+1
When using the 1.4.15 release of the Nagios Plugins, a command such as check_tcp -H pop.example.com -p 995 -D 14 usually produced two lines of output, e.g.: OK - Certificate will expire on 12/13/2014 23:59. TCP OK - 0.009 second response time on port 995|time=0.008849s;;;0.000000;10.000000 The second line was removed by 4d06603060fc1233861b164870f0d3a2e0d8d2eb. However, as the old two-line output is a valid (though in this case unintended) way to spit out performance data, removing the second line might break current setups. Therefore, we revert to the old behaviour, at least for the moment. The issue was reported by Jochen Bern on the "nagiosplug-devel" mailing list (Message-ID: <4FEAE812.8030309@LINworks.de>).
2012-06-27Update the BUGS fileHolger Weiss1-4/+2
Remove the bug reports that were closed, and add two new items.
2012-06-26check_snmp: use single quotes for perf data labelsSven Nierlein2-4/+8
2012-06-26Fix performance data label containing spaces in check_snmp (Jochen Bern)Sven Nierlein4-4/+48
Add --perf-oids option for check_snmp to retain optional 1.4.14 compatibility
2012-06-26Remove team members from the THANKS fileHolger Weiss1-3/+0
The (current and past) team members are listed in the AUTHORS file.
2012-06-26Add Sven Nierlein to the list of AUTHORSHolger Weiss2-1/+1
2012-06-25added test case for certificate checs with both warning and critical valuesWilliam Leibzon1-0/+4
2012-06-25check_http: added test for warning thresholdsSven Nierlein3-3/+11
fixed typo in sslutils
2012-06-25updated changelogSven Nierlein2-0/+2
2012-06-25applied patch that adds both critical and warning thresholds to certificate ↵William Leibzon5-33/+89
expiration checks of check_tcp, check_http, check_smtp
2012-06-24check_ping: Add missing newline to die() callsHolger Weiss1-11/+11
Our die() function expects the caller to append the trailing newline character.
2012-06-24NEWS: Improve the wording a bitHolger Weiss1-1/+1
2012-06-24Merge remote-tracking branch 'github/waja/master'Holger Weiss2-2/+4
Conflicts: NEWS
2012-06-24check_ping: Ignore ping(1)'s exit statusHolger Weiss2-3/+2
Don't return a WARNING state if the number of lost packets is greater than zero but below the specified warning threshold. This happened because the check_ping plugin used the exit status of the ping(1) utility. (#3535140 - Tobias Brox)
2012-06-23check_disk_smb: Add performance dataHolger Weiss3-12/+34
(Debian #654259 - Charles-Henri Larose)
2012-06-22Fix check_by_ssh test for non-Bash login shellsHolger Weiss1-5/+5
In the C shell and in the Z shell, the "?" character must be quoted or backslash-escaped in order to use it verbatim. Therefore, a command such as check_by_ssh -H test.example.com -l joe echo huh? might fail, depending on joe's login shell on test.example.com. Just to make sure, this commit removes most punctuation characters from our test strings.
2012-06-13check_dhcp: Don't misinterpret the "siaddr" fieldHolger Weiss2-9/+5
RFC 2131 (2.) says: "DHCP clarifies the interpretation of the 'siaddr' field as the address of the server to use in the next step of the client's bootstrap process." So, we shouldn't interpret this field as the DHCP server's own address. (#3503921 - Jason Ellison)
2012-06-13check_dhcp: Fix handling of "pad" optionsHolger Weiss2-3/+5
Don't let "pad" options[*] terminate the parsing of DHCP options. This bug was triggered by using check_dhcp against Windows 2003 DHCP servers (see #3503921). [*] Cf. RFC 2132, 3.1.
2012-06-11Improve parsing of ping6(1) outputHolger Weiss3-17/+21
The ping6(1) implementation provided by Debian's iputils-ping package may produce output such as the following: | 3 packets transmitted, 0 received, +3 errors, 100% packet loss, time 2009ms There's a corresponding pattern in check_ping.c:458: | "%*d packets transmitted, %*d received, +%*d errors, %d%% packet loss" Without this fix, the pattern in check_ping.c:456 matched first (as sscanf(3) interprets "+3" as a match for "%d"): | "%*d packets transmitted, %*d received, %d%% loss, time" (#1894850 - Debian bug report #514588 - Matej Vela)
2012-06-11Fix whitespace and capitalization issuesHolger Weiss1-80/+80
Fix indentation and whitespace issues, and correct some capitalization errors in error messages. The behaviour is unchanged.
2012-06-11Don't use SSLv2 when compiling against GnuTLSHolger Weiss1-2/+2
GnuTLS doesn't support SSL version 2.
2012-06-08t/check_dbi.t: Don't use 'INSERT … VALUES (a,b), (c,d)' with SQLite3.refs/pull/8/headSebastian Harl1-1/+2
Older versions of SQLite3 don't seem to support that.
2012-06-08Added a few test cases for the check_dbi plugin.Sebastian Harl1-0/+102
All tests use sqlite3. A temporary database is created for the purpose of the tests.
2012-06-07check_users: Whitespace fixes, etc.Holger Weiss1-24/+14
2012-06-07Update NEWS and THANKS w.r.t. check_users changeHolger Weiss2-0/+2
2012-06-07check_users: improve performanceM. Remy2-31/+9
This patch use the utxent function family to collect the user data. It improve the check speed. Need a system conforming to POSIX.1-2001.
2012-06-06check_dbi: Hint the user about cause when dbi init fails.Sebastian Harl1-1/+1
2012-06-06check_dbi: Added simple regex example to help output.Sebastian Harl1-0/+6
2012-06-06check_dbi: Added SERVER_VERSION metric.Sebastian Harl1-4/+25
This metric compares the database engine server version with the specified ranges. The version string [[[[A.]B.]C.]D.]E[.] is returned as E + D*100 + C*10000 + B*1000000 + A*100000000 (see libdbi's dbi_conn_get_engine_version() documentation).
2012-06-06check_dbi: Added -r and -R options.Sebastian Harl1-12/+89
These options may be used to specify an extended POSIX regular expression that is applied to the query result. When using -R, a case-insensitive match is done. The options may not be mixed with -w/-c/-e.
2012-06-06check_dbi: Added -e option.Sebastian Harl1-19/+76
This option may be used to specify a string that is expected as the query return value. The string is compared to the query result using strcmp(). The option may not be mixed with -w/-c.
2012-06-06check_dbi: Added some examples to the help output.Sebastian Harl1-1/+16
2012-06-06check_dbi: Added QUERY_TIME metric.Sebastian Harl1-37/+90
This metric checks the execution time of the specified query. In case the query does not return any (parsable) data, this is not treated as an error when using this metric.
2012-06-06check_dbi: Replaced -W/-C with -m.Sebastian Harl1-61/+70
The -m option may be used to specify a metric to check the thresholds against. This is more flexible than --conntime-warning/--conntime-critical (-W/-C) as it may be extended to support further metrics without introducing tons of arguments. Also, it does not make much sense to check the conntime and query result at the same time. Currently, the metrics CONN_TIME and QUERY_RESULT are available. A query is no longer required unless QUERY_RESULT (the default) is used.
2012-06-06check_dbi: Fixed/improved perfdata output.Sebastian Harl1-1/+1
- do not use zero as 'min' value for the query result perfdata - added all semicolons
2012-06-06check_dbi: Check and report the time used by the query.Sebastian Harl1-17/+37
2012-06-06check_dbi: Added threshold ranges for the connection time.Sebastian Harl1-7/+45
The -W and -C options are used for that. The plugin return value is determined by the worst check result.
2012-06-06check_dbi: Include extra opts in help output.Sebastian Harl1-0/+5
2012-06-06Initial version of the 'check_dbi' plugin.Sebastian Harl5-1/+537
This plugin connects to an SQL database using libdbi, thus supporting all database backends supported by libdbi. It will then issue the specified SQL query and check the result (the numeric value of the first column of the first row to be precise) against the specified warning/critical ranges. The performance data includes the connection time (µs-resolution as provided by gettimeofday()) and the query result.
2012-06-06sslutils: Check if OpenSSL supports SSLv2.refs/pull/6/headSebastian Harl1-0/+5
Recent versions/builds seem to disable that feature.
2012-05-29Mention the check_range function in NEWS, etc.Holger Weiss3-3/+5
2012-05-29Added check_range shell function to utils.sh.inAlex Griffin1-0/+85
2012-05-29check_http: Fix -C/--certificate option handlingHolger Weiss1-1/+1
The support for specifying the desired SSL protocol version via an optional -S/--ssl argument broke the -C/--certificate option. This is fixed now.
2012-05-28check_http: Don't ignore SSL initialization errorsHolger Weiss1-1/+3
SSL initialization errors are now handled properly by check_http (#3095106 - Eric Schoeller).
2012-05-28Add support for specifying SSL protocol versionHolger Weiss4-8/+42
The check_http -S/--ssl option now takes an optional argument which specifies the desired SSL/TLS protocol version (#3285367 - Jason Lunn).