summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2014-07-21plugins/t/check_dns.t: Fix Perl warningHolger Weiss1-1/+1
Perl said: "Unrecognized escape \d passed through at ./t/check_dns.t line 57."
2014-07-21sslutils: expire time in local timezone formatJan Wagner2-5/+5
sshutils prints the expiry time of certificates in US format this patch uses the strftime %c, I don't know how portable that is Thanks to Neil Prockter. Closes #1188 Closes #1161 Closes #977 Closes #976 Closes #975 Closes #840 Closes #382
2014-07-20check_ifstatus: perfdata bugJan Wagner2-1/+2
The perfdata output violates the current Nagios Plugin Development Guidelines (http://nagiosplug.sourceforge.net/developer-guidelines.html#AEN202 : "space separated list of label/value pairs"). Thus the Addon PNP did not read the perdata correctly. The patch replaces the commas with spaces in the perfdata output. Many thanks to Patric Wust. --- Closes #1169 and #721.
2014-07-20travis-ci: Adding ports for check_hpjdJan Wagner1-0/+2
2014-07-20added tests for check_hpjd port optionsabrist1-7/+28
--- Closes #1160 and #973
2014-07-20Added check_hpjd port option to news and clarified the port usage error.abrist2-1/+5
2014-07-20check_hpjd - Added a switch for port specification. Defaults to 161.abrist1-6/+24
2014-07-20check_ntp.t - fixed tests for new status outputabrist1-2/+2
closes #1236 and #1239
2014-07-20check_ntp_peer - Added specific state output for each metric. It now should ↵abrist1-12/+37
be easy to see which check caused the alert.
2014-07-11NEWS: Fix typov2.0Holger Weiss1-1/+1
2014-07-11Prepare for the 2.0 releaseHolger Weiss3-3/+3
2014-07-11NEWS: Wrap overly long lineHolger Weiss1-1/+2
2014-07-10Update THANKS.in file with latest authorHolger Weiss1-0/+1
2014-07-10Merge pull request #1272 from mfalkvidd/masterSam Kottler1-1/+1
check_procs: Add delay after forking in test
2014-07-10check_procs: Add delay after forking in testrefs/pull/1272/headMikael Falkvidd1-1/+1
Forking raises a race condition, where the parent might run the test before the child has had time to fork. If that happens, an error similar to this is produced: Failed test 'Output correct' at ./t/check_procs.t line 32. 'PROCS OK: 0 processes with args 'sleep 7' | processes=0;;;0;' doesn't match '/^PROCS OK: 1 process?/' Sleeping a bit should avoid the problem. It might be enough to sleep less than a second, but perl's built-in sleep function only supports integer seconds. In our build environment, the build failed 3 of 4 times before this patch. After the patch it failed 0 of 7 times. Signed-off-by: Mikael Falkvidd <mfalkvidd@op5.com>
2014-07-07NEWS: Add a warning regarding check_snmpHolger Weiss1-1/+3
Tell users that check_snmp might now return CRITICAL in cases where it used to return OK, and how to deal with that.
2014-07-07NEWS: Update version numberHolger Weiss1-1/+1
We're going to release version 2.0, not 1.6.
2014-07-07plugins/netutils.h: Adjust UNIX_PATH_MAX for BSDHolger Weiss1-2/+2
On at least FreeBSD, NetBSD, OpenBSD, DragonFly, and OS X, this is hard-coded at 104 bytes. Closes #1267.
2014-07-06Don't rely on FindBin module to locate utils.pmHolger Weiss13-1/+14
As the FindBin module doesn't work with ePN, set the path to utils.pm explicitly at build time. Keep using FindBin additionally, so that the plugins can also be executed from the build directory. Closes #1271.
2014-07-06check_icmp/check_dhcp: disable check, if we are rootJan Wagner4-22/+0
As it is possible to use capabilities(7) on linux or solaris privileges for example, it is not necessary in all cases to have those binaries making use of setuid.
2014-07-06NEWS: Add missing entriesHolger Weiss1-0/+2
2014-07-06THANKS.in: Add new authorsHolger Weiss1-0/+3
Update the THANKS.in file with the new Git commit authors.
2014-06-30Merge PR #1265 from waja/check_tcp_server_addrJan Wagner2-5/+10
2014-06-30check_jabber.t - fixed tests for new status output including hostnamerefs/pull/1265/headabrist1-3/+3
2014-06-30Merge pull request #1190 from waja/github780Sven Nierlein1-4/+20
check_ssh: check protocol
2014-06-28Merge pull request #1262 from waja/fix_aixSven Nierlein2-4/+3
Include common.h before any system headers.
2014-06-28Merge pull request #1264 from waja/check_nt_unitsSven Nierlein1-2/+2
check_nt.c - Changed 'Mb' to 'MB' in MEMUSE.
2014-06-28Merge pull request #1263 from waja/coverity_fixesSven Nierlein7-11/+28
Serveral coverity fixes from nagios-plugins
2014-06-28tests: added check_dns performance data testSven Nierlein1-1/+2
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2014-06-28check_dns.c Added a bit more logic to thresholdsabrist1-4/+13
Added two if elses to cover when only one threshold is set.
2014-06-28check_dns: add warning and critical thresholds to perfdataJean-Claude Computing1-1/+8
2014-06-28Cleaned up status output of check_tcp changesabrist1-1/+1
2014-06-28check_tcp: also display the server addr when host_specified is set. This ↵Davide Madrisan1-2/+7
will help the admins when multiple checks are configured Signed-off-by: Davide Madrisan <davide.madrisan@gmail.com>
2014-06-28check_nt.c - Changed 'Mb' to 'MB' in MEMUSE.refs/pull/1264/headabrist1-2/+2
2014-06-28lib/utils_cmd.c - Free file descriptorrefs/pull/1263/headSpenser Reinhardt1-0/+3
Coverity 66502 - File descriptor fd in cmd_file_read is never closed, and thus file is left open after usage throughout runtime. - SR
2014-06-28plugins/negate.c - Function should not return.Spenser Reinhardt1-2/+2
Coverity 66479 - validate_arguments has no need to return anything, as it dies on error, yet was set to return an int. Set to void to resolve warning.
2014-06-28plugins/negate.c - Reorder if statement, aiobSpenser Reinhardt1-2/+1
Coverity 66480 - Potential array index out of bounds, since result was not verified to be positive prior to using as an index for state[]. Simply reording the if statement should resolve the issue. - SR
2014-06-28plugins-root/check_dhcp.c - array out of boundsSpenser Reinhardt1-1/+1
Coverity 66488 - offer_packet->options has a max size of 312. It was being used in a loop verifying less than 311, but increasing by 2 per loop, causing a possible array index out of bounds. Changed to checking less than max length - 1. - SR
2014-06-28plugins/check_http.c - leakage fixSpenser Reinhardt1-4/+6
Coverity 66514 - Possible leakage and overflow with addr in redirect functionality. Not confirmed as null terminated, and externally gathered. Restrict string comparisons and duplications by size. - SR
2014-06-28plugins/check_ntp.c - Verify struct from responseSpenser Reinhardt1-2/+11
Coverity 66524 - req.data is not neccessarily null terminated but still feed to printf statements. This both does that, and verifies the struct more so than before. - SR
2014-06-28plugins/check_real.c - recv string null terminateSpenser Reinhardt1-0/+1
Recv into buffer is not properly null terminated prior to strstr and possible other string functions expecting a null termination. Simply take bytes received and use as an index to append \0 after. We are creating buffer[] with size of MAX_INPUT_BUFFER and recv with MAX_INPUT_BUFFER-1 so this should never overflow.
2014-06-28plugins/check_apt.c - Print uninitialized eregSpenser Reinhardt1-0/+3
Coverity 66531 - ereg.buffer can be printed without being initialized if do_include and do_exclude are null and critical is an invalid regex. While minor this may leak memory and cause undefined behavior.
2014-06-28Include common.h before any system headers.refs/pull/1262/headEric J. Mislivec2-4/+3
This should fix some problems building on AIX.
2014-06-24Merge pull request #1261 from sni/masterSven Nierlein5-8/+72
tests: always build and test on travis
2014-06-24tests: always build and test on travisrefs/pull/1261/headSven Nierlein5-8/+72
also make test is now working on travis-ci Signed-off-by: Sven Nierlein <sven@nierlein.de>
2014-06-23check_ide_smart: Fixing spelling bugJan Wagner4-4/+4
2014-06-23check_mrtg: Fixing spelling bugJan Wagner4-4/+4
2014-06-23check_ups/check_dbi: Fixing spelling bugJan Wagner2-6/+6
2014-06-22NEWS: Add missing entries for the upcoming releaseHolger Weiss1-2/+16
2014-06-22THANKS.in: Add new authorsHolger Weiss1-0/+11
Add the new Git commit authors to the THANKS.in file.