summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2022-01-29Formating fixesRincewindsHat1-15/+15
2022-01-29Remove unused variableRincewindsHat1-1/+1
2022-01-14check_ssh: Fix a typo in "remote-protocol parameterAnton Lofgren1-1/+1
remote-protcol -> remote-protocol Signed-off-by: Anton Lofgren <alofgren@op5.com>
2022-01-14check_ssh: Handle non-alpha software versionsAnton Lofgren2-32/+70
This patch fixes a bug where we would reject version control strings that do not contain letters, because the assumption is made that they always do. This is not required by the RFC however, and there exist implementations that do not contain letters. I've also added a few references to the RFC to make the process of parsing the control string more apparent. This fixes op5#8716 (https://bugs.op5.com/view.php?id=8716) Signed-off-by: Anton Lofgren <alofgren@op5.com>
2022-01-14check_ssh.t: Fix a few typosAnton Lofgren1-5/+2
Signed-off-by: Anton Lofgren <alofgren@op5.com>
2022-01-14check_ssh: properly parse a delayed version control stringAnton Lofgren2-57/+174
This resolves an issue with SSH servers which do not respond with their version control string as the first thing in the SSH protocol version exchange phase after connection establishment. This patch also makes sure that we disregard a potential comment in the version exchange string to avoid nonsense mismatches. In the future, we might want to add the capability to match against a user specified comment. In addition, the patch largely improves the communication towards the server, which adds better protocol adherence. Of course, new test cases are added to support the trigger and guard against regressions of the bugs solved by this patch. This fixes op5#7945 (https://bugs.op5.com/view.php?id=7945) Signed-off-by: Anton Lofgren <alofgren@op5.com>
2022-01-03Merge pull request #1642 from mdavranche/masterLorenz1-2/+6
check_swap: Handle cached swap
2022-01-03Rename tmp variable to get even with masterLorenz Kästle1-4/+4
2022-01-03Merge branch 'master' into masterLorenz56-786/+1662
2021-12-21Merge pull request #1679 from RincewindsHat/shell_check_check_sensors.shLorenz1-1/+1
check_sensors.sh: Make shellcheck happier
2021-12-21check_sensors.sh: Make shellcheck happierrincewind1-1/+1
2021-12-20Merge pull request #1732 from RincewindsHat/check_log_missing_oldlog_abortLorenz1-1/+10
Missing oldlog now aborts check_log
2021-12-20Apparently Dash is not Bash, so -v does not workRincewindsHat1-1/+1
2021-12-19Merge pull request #1725 from monitoring-plugins/check_game_update_urlLorenz1-1/+1
Update Url to qstat
2021-12-02Missing oldlog now aborts check_logRincewindsHat1-1/+10
2021-12-02Merge pull request #1459 from waja/fix/shellcheckRincewindsHat3-136/+138
Several fixes shellcheck complaining about
2021-12-02Merge branch 'master' into fix/shellcheckRincewindsHat115-1546/+15533
2021-12-02Merge pull request #1490 from leeclemens/mailq-add-config-dirRincewindsHat1-8/+16
check_mailq: Add mailq -C option for config dir or config file
2021-12-02Fix syntax error resulting from mergingRincewindsHat1-1/+1
2021-12-02Merge branch 'master' into mailq-add-config-dirRincewindsHat103-1534/+15309
2021-11-29Merge pull request #1730 from RincewindsHat/check_file_age_more_explicit_helpRincewindsHat1-1/+1
Make size parameter a little bit more intelligible
2021-11-29Make size parameter a little bit more intelligibleRincewindsHat1-1/+1
2021-11-29Merge pull request #1493 from darksoul42/masterRincewindsHat1-1/+1
Fix regexp for nullmailer "mailq" output. Looks good. Thank you very much.
2021-11-28Merge pull request #1692 from RincewindsHat/modernize_check_logRincewindsHat1-42/+94
Modernize check log
2021-11-25Merge pull request #1729 from RincewindsHat/fix_QL_problemsRincewindsHat4-18/+23
Fix some QL problems
2021-11-25Merge pull request #1727 from phibos/fix_check_ups_1030RincewindsHat1-1/+4
Fix possible overflow in check_ups. Looks good to me too, thank you very much
2021-11-24More wrong printf formattingRincewindsHat3-5/+5
2021-11-24check_hpjd: Fixing port optionRincewindsHat1-8/+9
2021-11-24Fix CodeQL checksRincewindsHat4-10/+14
2021-11-24Merge pull request #1682 from phibos/codeqlRincewindsHat1-0/+71
Add CodeQL checks
2021-11-24Fix possible overflow in check_ups (Fixes: #1030)PhiBo1-1/+4
2021-11-21Update Url to qstatRincewindsHat1-1/+1
2021-11-19Merge pull request #1723 from RincewindsHat/check_swap_smallfix_and_styleRincewindsHat1-20/+23
Small fix to threshold validation and style (indentation) fixes
2021-11-19Merge pull request #1724 from mullumaus/masterRincewindsHat1-1/+4
Allows check_ldap to read password from environment variable
2021-11-19Allows check_ldap to get password from env variableLinda Guo1-1/+4
It's not secure to provide LDAP password through command line option because other users on the same host can see the password in 'ps' command output. This change allows check_ldap to get password from environment variable.
2021-11-19Fix option description authpassword -> authpasswdLorenz Kästle1-1/+1
2021-11-19Revert "Fixed option description authpassword -> authpasswd + whitespaces"Lorenz Kästle1-20/+20
This reverts commit b27e639725f680411aaa78dd9aa59cfff84ad0c5.
2021-11-19Fixed option description authpassword -> authpasswd + whitespacesLorenz Kästle1-20/+20
2021-11-19Small fix to threshold validation and style (indentation) fixesRincewindsHat1-20/+23
2021-11-18Merge pull request #1697 from RincewindsHat/dont_show_rta_if_uselessRincewindsHat2-6/+14
check_ping: Do not show RTA if no connection was possible
2021-11-17Merge pull request #1654 from wolfgangkarall/masterRincewindsHat2-2/+2
check_procs -- exchange needle and haystack in strstr() for proper st…
2021-11-17Merge pull request #1688 from bazzisoft/masterRincewindsHat2-2/+2
check_curl.c: bugfix: verify certificates option should not force SSL to be used
2021-11-17Add thresholds even if value is missingRincewindsHat1-1/+1
2021-11-17homogenize perfdata function and fix small bug with missing semicolonRincewindsHat1-2/+4
2021-11-17Show RTA as unknown if it can not be determinedRincewindsHat1-1/+1
2021-11-17Do not show RTA if no connection was possiblerincewind1-4/+10
2021-11-17check_snmp: fix performance thresholds when using multiple oidsSven Nierlein4-6/+23
when using check_snmp with multiple oids it simply printed the unparsed content from -w/-c into the thresholds for each oid. So each oid contained the hole -w from all oids. ./check_snmp ... -o iso.3.6.1.2.1.25.1.3.0,iso.3.6.1.2.1.25.1.5.0 -w '1,2' -c '3,4' before: SNMP ... | HOST-RESOURCES-MIB::hrSystemInitialLoadDevice.0=393216;1,2;3,4 HOST-RESOURCES-MIB::hrSystemNumUsers.0=24;1,2;3,4 after: SNMP ... | HOST-RESOURCES-MIB::hrSystemInitialLoadDevice.0=393216;1;3 HOST-RESOURCES-MIB::hrSystemNumUsers.0=24;2;4 This also applies to fixed thresholds since check_snmp translates negative infinities from: '~:-1' to '@-1:~'
2021-11-15check_icmp: Fix pkt perfdata in check_host modeAksel Sjögren1-1/+1
Add missing "warn" threshold field in "pkt" perfdata output. Perfdata should be interpreted as; 'label'=value[UOM];[warn];[crit];[min];[max] With one field missing, the hardcoded min value '0' ended up in the "crit" field, making applications interpreting the perfdata thining that critical threshold is always exceeded. Signed-off-by: Aksel Sjögren <asjogren@itrsgroup.com>
2021-11-11Merge pull request #1715 from ghen2/lmtpRincewindsHat1-4/+14
check_smtp: add -L flag to support LMTP (LHLO instead of HELO/EHLO).
2021-11-01check_procs: add test for elapsed timeSven Nierlein2-2/+230