summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-05-24fix maxfd being zeroSven Nierlein4-57/+23
If _SC_OPEN_MAX is available then maxfd was zero initialized and never set to the value from sysconf. This leads to segfaults with free(): invalid size introduced by commit 7cafb0e84550035fe671662c293122be975065ca. Signed-off-by: Sven Nierlein <sven@nierlein.de>
2019-04-09Merge pull request #1591 from odenbach/check_disk_helpSven Nierlein1-0/+2
include -P switch in help
2019-04-09include -P switch in helpChristopher Odenbach1-0/+2
2019-03-28Merge pull request #1491 from odenbach/no_swapSven Nierlein1-8/+8
check_swap: repaired "-n" behaviour
2019-03-21Merge pull request #1586 from computersalat/masterSven Nierlein1-0/+5
improve command examples for 'at least' processes
2019-03-21Merge pull request #1587 from jacobbaungard/check_mysql_allow_socket-HSven Nierlein1-0/+3
check_mysql: Allow sockets to be specified to -H
2019-03-21improve command examples for 'at least' processesChrisWi1-0/+5
2019-03-21check_mysql: Allow sockets to be specified to -HRobin Sonefors1-0/+3
The help text says that -H accepts a "unix socket (must be an absolute path)". Now that actually corresponds to reality. Signed-off-by: Robin Sonefors <robin.sonefors@op5.com>
2019-02-19Merge pull request #1506 from sanchezfauste/check_apt_parametersSven Nierlein1-4/+13
Adding packages-warning option to check_apt plugin
2019-02-19Merge pull request #1507 from sanchezfauste/check_load_print_top_procsSven Nierlein2-2/+63
Adding print top consuming processes option to check_load
2019-02-19Merge pull request #1527 from m-kraus/masterSven Nierlein1-1/+2
check_snmp: make calcualtion of timeout value in help output more clear
2019-02-19Merge pull request #1567 from vdanjean/masterSven Nierlein5-5/+58
[check_disk] add support to display inodes usage in perfdata
2019-02-19Merge pull request #1583 from sni/fix_check_by_ssh_timeout_child_leakSven Nierlein11-107/+70
check_by_ssh: fix child process leak on timeouts
2019-02-19Merge pull request #1585 from sni/update_test_certsSven Nierlein3-42/+58
renew test certificates
2019-02-19renew test certificatesSven Nierlein3-42/+58
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2019-02-19Merge pull request #1563 from jacobbaungard/ipv6_check_icmpSven Nierlein1-129/+336
check_icmp: Add IPv6 support
2019-02-15Merge pull request #1584 from DerDakon/typoSven Nierlein1-1/+1
check_dns: fix typo in parameter description
2019-02-15check_dns: fix typo in parameter descriptionRolf Eike Beer1-1/+1
2019-02-15check_by_ssh: fix child process leak on timeoutsSven Nierlein11-107/+70
When check_by_ssh runs into a timeout it simply exits keeping all child processes running. Simply adopting the kill loop from runcmd_timeout_alarm_handler() fixes this. Signed-off-by: Sven Nierlein <sven@nierlein.de>
2019-02-15Merge pull request #1582 from towolf/show_body_for_http_expect_caseSven Nierlein1-0/+2
Also support the --show-body/-B flag when --expect is used
2019-02-15Merge pull request #1545 from DerDakon/dns_orderSven Nierlein3-9/+30
check_dns: improve support for checking multiple addresses
2019-02-12Also support the --show-body/-B flag when --expect is usedTobias Wolf1-0/+2
2019-02-06Merge branch 'travis-ci-xenial'Jan Wagner2-8/+8
2019-02-04travis-ci: Use RSA keys for SSH testsJan Wagner2-3/+3
2019-02-02travis-ci: Restart mysqlJan Wagner1-0/+1
2019-02-02travis-ci: The package name is now 'squid'Jan Wagner1-3/+3
2019-02-02travis-ci: Remove backports ppaJan Wagner1-1/+0
2019-02-02travis-ci: Switch over to xenialJan Wagner1-1/+1
2019-02-01Merge pull request #1578 from sni/tests_fix_snmp_testSven Nierlein1-52/+58
tests: make check_snmp test more reliable
2019-01-21tests: make check_snmp test more reliableSven Nierlein1-52/+58
The check_snmp rate tests depend on the exact amount of time spend between the plugin runs and will fail on busy machines, ex. the ci servers. Using faketime mitigates this issue and also removes all the sleeps. Signed-off-by: Sven Nierlein <sven@nierlein.de>
2019-01-20Merge pull request #1574 from waja/check_smtp_custom_command_sslJan Wagner1-0/+1
Simply initializes n before it is used
2019-01-18Simply initializes n before it is usedIustin Pop1-0/+1
When SSL is enabled, n is assigned the size of the server's second EHLO response (I think in bytes), which will usually be significantly higher than the command passed. As such, no commands are executed and no responses are checked, which - silently - defeats the desired checks and results in a success value.
2019-01-04Merge pull request #1569 from jacobbaungard/check_hpjd_disable_paper_outSven Nierlein1-3/+9
check_hpjd: Added -D option to disable warning on 'out of paper'
2019-01-04check_hpjd: Added -D option to disable warning on 'out of paper'Kostyantyn Hushchyn1-3/+9
Signed-off-by: Kostyantyn Hushchyn <kgushtin@op5.com>
2018-12-10check_icmp: Do not overwrite -4,-6 on lookupJacob Hansen1-2/+10
In case we needed to do a lookup, we previously overwrote the address_family to IPv6, even if we supplied -4 as a cmd line argument. This commit should ensure the cmd line argument is always followed. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2018-12-10check_icmp: emit error if multiple protocol versionJacob Hansen1-0/+4
As we do not support checking both IPv4 and IPv6 hosts in one execution we emit an error if multiple protocol versions are defined in the cmd line args. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2018-12-10check_icmp: move opts string into a variableJacob Hansen1-2/+3
This commit moves the opts string into a variable as it is now used twice. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2018-12-08[check_disk] add support to display inodes usage in perfdataVincent Danjean5-5/+58
This is not enabled by default It can be enabled with the -P (--iperfdata) option
2018-12-07Merge pull request #1564 from jacobbaungard/check_cluster_arg_validationSven Nierlein1-0/+10
check_cluster.c: Added data argument validation.
2018-12-07check_icmp: Correctly set address_family on lookupJacob Hansen1-1/+2
If a hostname is supplied instead of an IP address, the automatic address family detection would fail to correctly set the IP protocol version (it would always be IPv6). We now supply AF_UNSPEC to getaddrinfo, which should then return the correct address family in the result. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2018-12-07check_icmp: removed outcommented codeJacob Hansen1-7/+0
Signed-off-by: Jacob Hansen <jhansen@op5.com>
2018-12-07check_icmp: process protocol version args firstJacob Hansen1-10/+22
Detection of protocol version is in the previous patch implemented in the add_target() function, which is called when adding the -H command line argument. That means that if a protocal version argument (-4, -6) is added after the -H then the protocol version might be incorrectly set. This patch ensures that we first process the protocol version arguments, and then we process the rest of the arguments. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2018-12-07check_icmp: Automatically detect IP protocolJacob Hansen1-26/+45
This patch automatically detects whether the protocol version is IPv4 or IPv6 All credits to: https://github.com/ghciv6 Signed-off-by: Jacob Hansen <jhansen@op5.com>
2018-12-07Fixed parameter handling after 01efbb2183d49c5082598d4799788fc385342f28Lars Michelsen1-38/+38
2018-12-07check_icmp: Add IPv6 supportLars Michelsen1-161/+330
This commit adds IPv6 capabilities to check_icmp. It is now possible to specify the address family using the arguments -4 (default) or -6. To make the change possible we had to move the argument parsing previous to creating the socket to be able to create it with the correct address family. This commit also fixes some gcc 4.9.2 compiler warnings. It has been tested with several current linux distributions (debian, ubuntu, rh, sles). This commit fixes monitoring-plugins/monitoring-plugins#1291
2018-12-07Merge pull request #1565 from sni/travis_run_plugin_root_testsSven Nierlein18-438/+212
Travis run plugin root tests
2018-12-04tests: rework test parametersSven Nierlein16-303/+107
there were 2 variants of calling getTestParameter: - parameter, description, default value - parameter, env value, default value, description, scope While scope was never actually used and having 2 names for the same value led to having 2 different entries in the cache file for the same configuration. This commit removes the variants and simplifies tests parameters by only using the first 3 parameter variant.
2018-12-04NPTest: unify whitespaceSven Nierlein1-73/+73
2018-12-04tests: skip some tests if Monitoring::Plugin::Range isn't availableSven Nierlein1-67/+36
The check_file_age uses Monitoring::Plugin::Range internally. Skip thoses tests if the module isn't available.
2018-12-04tests: enable plugins-root testsSven Nierlein1-0/+1