summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2013-12-17Fix #1217 spec file fails to build due to duplicate files and unused filesDamian Myerscough1-2/+4
2013-12-05check_http: Don't let "-N" expect an argumentHolger Weiss1-1/+1
Fix the problem that check_http's "-N" option expects an argument although it shouldn't. The corresponding long option ("--no-body") wasn't affected. This error was introduced in ee3c4014d511e105489b081390636cacd4c53e3f. Thanks to Kerry Hughes for reporting it on the devel@ list.
2013-11-20make testing check_proc not rely on bashSven Nierlein1-6/+4
also grandparents make this test fail but is not a problem in real live. NPTest->testCmd uses "sh -c" already, so there is no need to do that twice.
2013-11-20NEWS: Add WARNING regarding the check_procs changeHolger Weiss1-0/+4
Closes #1205.
2013-11-19check_procs: ignore plugin parent processAnton Lofgren2-1/+16
This fixes an issue that appears when running check_procs over NRPE, where the default shell is configured to (for example) dash, as is the case on Debian. dash (and tcsh, and mksh, and probably others), when invoked with -c forks an additional process to execute the argument string. Contrast this with bash, which does not do this, provided that the argument string simply can be exec()'d as-is. To demonstrate: $ bash -c pstree init─┬ .. ... ├─sshd─-─sshd───pstree versus $ dash -c pstree init─┬ .. ... ├─sshd─-─sshd───dash───pstree The consequence of this fork is that the following invocation: /opt/plugins/check_procs -a init will result in this output: PROCS OK: 2 processes with args 'init' | processes=2;;;0; because the check_procs, in addition to finding the actual init process, finds its parent shell as well. This example is a bit contrived, but I think it illustrates the point. This wouldn't really be a problem, and normally isn't, if it weren't for the fact that NRPE uses a call to popen() which does exactly the above (executes '/bin/sh -c ...'), causing inconsistent behaviour between distributions and much confusion for end users. The argument may be made that the dash process spawned by NRPE is just a process like any other, and should therefore be included in the process count just like any other. However, this is not very intuitive, because of the previously mentioned inconsistencies. The argument might also well be made that we're _never_ interested in the immediate ancestor of the plugin, and while it is unknown how many installations have already made the necessary modifications to their setups to make up for the fact that the plugin behaves the way it does, it is not deemed worthwhile to entertain such workarounds. Thus, this patch ignores the parent process. See also these bug reports: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=626913 http://sourceforge.net/p/nagiosplug/bugs/512/ https://github.com/nagios-plugins/nagios-plugins/issues/999 https://bugs.op5.com/view.php?id=4398
2013-11-05README: Change GitHub URLHolger Weiss1-1/+3
Link to our main project home page on GitHub instead of referencing only the "nagios-plugins.git" repository. (And put the URL on its own line.)
2013-11-05README: Clarify license noticeHolger Weiss1-6/+13
Note that we permit redistribution and modification under the terms of future GPL versions, and state the exclusion of warranty. This is in accordance with the license notices at the top of our source files.
2013-10-28Update URLs and mailing list addressesHolger Weiss56-84/+83
Now that we moved our infrastructure away from SourceForge, update the URLs and mailing list addresses accordingly.
2013-10-28developer-guidelines.sgml: Fix URLHolger Weiss1-1/+1
Fix the Test::Simple tutorial URL.
2013-10-28developer-guidelines.sgml: Remove Tinderbox linkHolger Weiss1-5/+0
We don't run a Tinderbox instance anymore. (Noted by "zathras" on IRC.)
2013-10-22Merge branch 'github1207' of https://github.com/waja/nagios-plugins into ↵Jan Wagner1-1/+1
github1207
2013-10-22Just using the posix conform extended regular expression grepJan Wagner1-2/+1
2013-10-22check_oracle: --db +ASM bad string matchingJan Wagner1-0/+1
check_oracle doesn't correctly check for pmon +ASM instance from at least Oracle 11 as the pmon proces was renamed from ora_pmon_.* to asm_pmon_.*. -- Just turning attached patch of github issue #1207 into a push request. (Closes #1207)
2013-10-08Update web site URLsHolger Weiss1-2/+3
The Nagios Plugin Development Guidelines and the Extra-Opts documentation were moved to our new project server.
2013-10-05Add additional usage data for new options in check_mysql_query.cawiddersheim1-1/+1
2013-10-05Add ability to read from options file to check_mysql_query.cawiddersheim1-2/+22
This is the same code that was added to check_mysql.c in 5ed7194.
2013-10-03NEWS: Mention "contrib" removalHolger Weiss1-0/+1
Add a note regarding the removal of the "contrib" directory to the NEWS file. This note is missing from the NEWS file shipped with the 1.5 release, though.
2013-10-02Prepare for the 1.5 releaserelease-1.5Holger Weiß3-3/+3
2013-10-02FAQ: Update CVS referencesHolger Weiss1-5/+3
We moved from CVS to Git.
2013-10-02tools: Update CVS referencesJan Wagner3-5/+5
We moved our stuff from CVS/SourceForge to Git/GitHub.
2013-10-02doc: Updated CVS referencesJan Wagner2-8/+6
We moved our stuff from CVS/SourceForge to Git/GitHub.
2013-10-02README: Update URLsHolger Weiss1-2/+2
We moved the Nagios Plugins site from SourceForge to our project server.
2013-10-02SUPPORT: Update CVS/SourceForge referencesHolger Weiss1-7/+8
We moved our stuff from CVS/SourceForge to Git/GitHub.
2013-09-30Update THANKS fileHolger Weiss1-0/+16
Add all new Git commit authors to the THANKS.in file.
2013-09-30AUTHORS: Tiny cosmetic changeHolger Weiss1-1/+1
2013-09-30Add Jan Wagner to the list of AUTHORSHolger Weiss1-0/+1
2013-09-30Add Eric Stanley to the list of AUTHORSHolger Weiss1-0/+1
2013-09-29Change default host names for some testsHolger Weiss2-5/+5
Testing "nagiosplugins.org" will currently not work.
2013-09-28Add tools/generate-change-logHolger Weiss4-16157/+76
Add the tools/generate-change-log script for auto-generating the ChangeLog file from the Git history when running "make dist".
2013-09-27tools: Remove Drupal/SourceForge scriptsHolger Weiss9-497/+0
We moved our web site away from Drupal and the snapshots/guidelines away from SourceForge. The new infrastructure scripts will be maintained in a separate repository together with the Markdown source of the new web site.
2013-09-27Remove tools/git2svn.plHolger Weiss1-129/+0
We no longer mirror out Git repositories into Subversion.
2013-09-26Die on SSL initialization errorsawiddersheim1-1/+1
Fixes issue where if an SSL initialization error occurs on a redirect using -f follow the plugin still returns an OK state. Closes #1159.
2013-09-25developer-guidelines.sgml: Normalize spellingHolger Weiss1-10/+10
- Write "plugin" instead of "plug-in". - Write "development guidelines" instead of "developer guidelines" - Capitalize "Nagios Plugin Development Guidelines".
2013-09-22README: Minor cosmetic changeHolger Weiss1-1/+1
2013-09-20README: Apply another few cosmetic changesHolger Weiss1-10/+6
2013-09-20Add symlink: README.md -> READMEHolger Weiss1-0/+1
Add a symlink so that GitHub renders the README file as Markdown.
2013-09-20README: Use code blocks for commandsHolger Weiss1-5/+5
2013-09-20Remove the BUGS fileHolger Weiss3-35/+1
The BUGS file wasn't maintained properly anymore. And doing so makes no sense. That's what the bug tracker is for.
2013-09-20README: Convert to Markdown and apply cleanupsHolger Weiss1-54/+52
Use the Markdown format for the README file and apply various minor cosmetic changes.
2013-09-20README: Remove outdated informationHolger Weiss1-19/+7
2013-09-19check_pgsql: Don't exit UNKNOWN instead of OKHolger Weiss1-1/+1
Since commit 912df3ef9b188c82893dace1e9b56c42a558fdba, check_pgsql exited UNKNOWN instead of OK if the new --query option was *not* specified. This bug is fixed now.
2013-09-18tests: only write cache file if it changedSven Nierlein1-17/+19
Tests sometimes fila when running multiple parallel tests using the same cache file because it is written everytime a test parameter is read. Since there is no locking, this might fail from time to time.
2013-09-17check_disk: die with a reasonable error message if one mount point hits ↵Sven Nierlein1-0/+6
average value
2013-09-17check_dhcp: fix mac address and interface number detection on solarisSven Nierlein1-4/+9
newer (or x86) solaris implementations have interface names like e1000g0 which includes numbers. So we reverse the interface number detection to get the last number, instead of the first number.
2013-09-17check_dhcp: fix tests interface detectionSven Nierlein1-1/+1
2013-09-17check_ssh: added test caseSven Nierlein1-0/+49
2013-09-17check_by_ssh: tests expand key and config pathSven Nierlein1-0/+4
some systems do not expand the path automatically.
2013-09-17check_udp: skip tests which rely on udp listenSven Nierlein1-0/+1
solaris netcat does not listen in udp mode due to http://sourceforge.net/p/netcat/bugs/27/
2013-09-17check_disk_smb: fixed number of tests to skipSven Nierlein1-5/+5
2013-09-16check_disk: get_fs_usage hasn't been run if using groupsSven Nierlein1-3/+3
the reason why it still worked sometimes was fsu_blocks beeing uninitialized which resulted in a true test sometimes.