summaryrefslogtreecommitdiffstats
path: root/plugins-root/check_icmp.c
AgeCommit message (Collapse)AuthorFilesLines
2023-10-07Fix typoRincewindsHat1-1/+1
2023-10-07Refactor new threshold parserRincewindsHat1-37/+45
2023-10-07Do some actual error checking on the threshold parserRincewindsHat1-6/+32
2023-10-06Remove useless return after crashRincewindsHat1-1/+0
2023-10-06Change function type of get_thresholds to better reflect the options and ↵RincewindsHat1-7/+14
describe it in general
2023-10-06Update commentRincewindsHat1-2/+2
2023-10-06Refactor get_threshold2 to be barely understandableRincewindsHat1-35/+65
2023-10-06check mallocDanijel Tasov1-0/+4
2023-10-06do not introduce new ints as boolsDanijel Tasov1-14/+16
2023-10-04unnecessary spaceDanijel Tasov1-1/+1
Signed-off-by: Danijel Tasov <m@rbfh.de>
2023-10-04readability improvementsDanijel Tasov1-3/+21
Signed-off-by: Danijel Tasov <m@rbfh.de>
2023-10-04remove sun ifdefDanijel Tasov1-5/+0
my be readded later with proper comments Signed-off-by: Danijel Tasov <m@rbfh.de>
2023-10-04fix host count on when checking multiple hostsDanijel Tasov1-21/+24
2023-10-04adjust check_icmp testsDanijel Tasov1-1/+1
2023-09-28update-poDanijel Tasov1-1/+1
Signed-off-by: Danijel Tasov <m@rbfh.de>
2023-09-27cleanup more merge debrisDanijel Tasov1-8/+3
Signed-off-by: Danijel Tasov <m@rbfh.de>
2023-09-26Add some spaces to the outputDanijel Tasov1-19/+19
needed if multiple modes are used at once Signed-off-by: Danijel Tasov <m@rbfh.de>
2023-09-26fixed commentDanijel Tasov1-1/+1
Signed-off-by: Danijel Tasov <m@rbfh.de>
2023-09-25Fix spelingDanijel Tasov1-1/+1
Signed-off-by: Danijel Tasov <m@rbfh.de>
2023-09-25Fix compile errorsDanijel Tasov1-8/+6
Signed-off-by: Danijel Tasov <m@rbfh.de>
2023-09-25exit UNKNOWN on -VDanijel Tasov1-1/+1
Signed-off-by: Danijel Tasov <m@rbfh.de>
2023-09-23fix merge errorDanijel Tasov1-1/+0
Signed-off-by: Danijel Tasov <m@rbfh.de>
2023-09-23Merge branch 'jitter-orig' into merge-jitterDanijel Tasov1-31/+377
2023-09-23remove root checkDanijel Tasov1-3/+0
We can perfectly do icmp without root by using capabalities. So, instead of doing unsufficient checks beforehand, we just try and fail if it doesn't work. Signed-off-by: Danijel Tasov <m@rbfh.de>
2023-04-17Refix spelling issuesRincewindsHat1-1/+1
2023-04-17Fixes for -WuninitializedRincewindsHat1-0/+1
2023-04-17Fixes for -Wunused-parametersRincewindsHat1-0/+4
2023-04-14Fix a lot of typos reported by codespellrefs/pull/1864/headJan Wagner1-1/+1
2023-02-19Merge branch 'master' into check_icmp_cleanuprefs/pull/1807/headRincewindsHat1-8/+8
2023-02-19check_icmp: Fix compiler warningRincewindsHat1-1/+1
This fixes a compiler warning which complains about an uninitialized value for a variable which is then returned. This had no real world impact, since the program would crash in the branch where result is not set. The variable is initialized to "-1" which would be the error for inet_pton.
2023-02-19check_icmp: Fix compiler warningRincewindsHat1-2/+3
This fixes a compiler warning with no real world impact. The compiler complains about a missing return, which is correct, but in that scenario the program would crash anyways, so this has no impact.
2022-11-29check_icmp: fix parsing help/version long optionsAksel Sjögren1-8/+8
Fix parsing of the long options --help and --version. The special handling must be done before calling getopt(). This fixes erroneous output like: ./check_icmp --version ./check_icmp: invalid option -- '-' ./check_icmp: invalid option -- 'e' ./check_icmp: invalid option -- 'r' ./check_icmp: invalid option -- '-' ./check_icmp: invalid option -- 'e' ./check_icmp: invalid option -- 'r' Signed-off-by: Aksel Sjögren <asjogren@itrsgroup.com>
2022-11-04Replace DBL_MAX with INFITY to check if value was setRincewindsHat1-2/+3
2022-11-04Remove hardcoded DBL_MAX definitionRincewindsHat1-4/+0
2022-11-04Remove trailing whitespacesRincewindsHat1-12/+12
2022-07-14Set msg_namelen to the size of the sockaddr struct for the appropriate ↵eriksejr1-4/+8
address family and not sockaddr_storage (#1771) Co-authored-by: Erik Sejr <eriks@ssimicro.com> Co-authored-by: Lorenz <12514511+RincewindsHat@users.noreply.github.com>
2022-03-15check_icmp: buffer offerflow (#1733)Lorenz1-29/+37
* Fix different overflows * Less includes * Add testcases * Remove unused variable * Remove unused and commented includes
2022-01-29- delay set_source_ip() until address_family is detectedghciv61-1/+4
- add a test to check '-s'
2021-11-24More wrong printf formattingrefs/pull/1729/headRincewindsHat1-2/+2
2021-11-24Fix CodeQL checksRincewindsHat1-2/+2
2021-11-15check_icmp: Fix pkt perfdata in check_host modeAksel Sjögren1-1/+1
Add missing "warn" threshold field in "pkt" perfdata output. Perfdata should be interpreted as; 'label'=value[UOM];[warn];[crit];[min];[max] With one field missing, the hardcoded min value '0' ended up in the "crit" field, making applications interpreting the perfdata thining that critical threshold is always exceeded. Signed-off-by: Aksel Sjögren <asjogren@itrsgroup.com>
2020-12-19docs: fix simple typo, conspicuosly -> conspicuouslyrefs/pull/1652/headTim Gates1-1/+1
There is a small typo in plugins-root/check_icmp.c. Should read `conspicuously` rather than `conspicuosly`.
2018-12-10check_icmp: Do not overwrite -4,-6 on lookuprefs/pull/1563/headJacob Hansen1-2/+10
In case we needed to do a lookup, we previously overwrote the address_family to IPv6, even if we supplied -4 as a cmd line argument. This commit should ensure the cmd line argument is always followed. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2018-12-10check_icmp: emit error if multiple protocol versionJacob Hansen1-0/+4
As we do not support checking both IPv4 and IPv6 hosts in one execution we emit an error if multiple protocol versions are defined in the cmd line args. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2018-12-10check_icmp: move opts string into a variableJacob Hansen1-2/+3
This commit moves the opts string into a variable as it is now used twice. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2018-12-07check_icmp: Correctly set address_family on lookupJacob Hansen1-1/+2
If a hostname is supplied instead of an IP address, the automatic address family detection would fail to correctly set the IP protocol version (it would always be IPv6). We now supply AF_UNSPEC to getaddrinfo, which should then return the correct address family in the result. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2018-12-07check_icmp: removed outcommented codeJacob Hansen1-7/+0
Signed-off-by: Jacob Hansen <jhansen@op5.com>
2018-12-07check_icmp: process protocol version args firstJacob Hansen1-10/+22
Detection of protocol version is in the previous patch implemented in the add_target() function, which is called when adding the -H command line argument. That means that if a protocal version argument (-4, -6) is added after the -H then the protocol version might be incorrectly set. This patch ensures that we first process the protocol version arguments, and then we process the rest of the arguments. Signed-off-by: Jacob Hansen <jhansen@op5.com>
2018-12-07check_icmp: Automatically detect IP protocolJacob Hansen1-26/+45
This patch automatically detects whether the protocol version is IPv4 or IPv6 All credits to: https://github.com/ghciv6 Signed-off-by: Jacob Hansen <jhansen@op5.com>
2018-12-07Fixed parameter handling after 01efbb2183d49c5082598d4799788fc385342f28Lars Michelsen1-38/+38