summaryrefslogtreecommitdiffstats
path: root/plugins/t
AgeCommit message (Collapse)AuthorFilesLines
2013-11-19check_procs: ignore plugin parent processAnton Lofgren1-1/+8
This fixes an issue that appears when running check_procs over NRPE, where the default shell is configured to (for example) dash, as is the case on Debian. dash (and tcsh, and mksh, and probably others), when invoked with -c forks an additional process to execute the argument string. Contrast this with bash, which does not do this, provided that the argument string simply can be exec()'d as-is. To demonstrate: $ bash -c pstree init─┬ .. ... ├─sshd─-─sshd───pstree versus $ dash -c pstree init─┬ .. ... ├─sshd─-─sshd───dash───pstree The consequence of this fork is that the following invocation: /opt/plugins/check_procs -a init will result in this output: PROCS OK: 2 processes with args 'init' | processes=2;;;0; because the check_procs, in addition to finding the actual init process, finds its parent shell as well. This example is a bit contrived, but I think it illustrates the point. This wouldn't really be a problem, and normally isn't, if it weren't for the fact that NRPE uses a call to popen() which does exactly the above (executes '/bin/sh -c ...'), causing inconsistent behaviour between distributions and much confusion for end users. The argument may be made that the dash process spawned by NRPE is just a process like any other, and should therefore be included in the process count just like any other. However, this is not very intuitive, because of the previously mentioned inconsistencies. The argument might also well be made that we're _never_ interested in the immediate ancestor of the plugin, and while it is unknown how many installations have already made the necessary modifications to their setups to make up for the fact that the plugin behaves the way it does, it is not deemed worthwhile to entertain such workarounds. Thus, this patch ignores the parent process. See also these bug reports: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=626913 http://sourceforge.net/p/nagiosplug/bugs/512/ https://github.com/nagios-plugins/nagios-plugins/issues/999 https://bugs.op5.com/view.php?id=4398
2013-09-28Change default host names for some testsHolger Weiss2-5/+5
Testing "nagiosplugins.org" will currently not work.
2013-09-17check_disk: die with a reasonable error message if one mount point hits ↵Sven Nierlein1-0/+6
average value
2013-09-17check_ssh: added test caseSven Nierlein1-0/+49
2013-09-17check_by_ssh: tests expand key and config pathSven Nierlein1-0/+4
some systems do not expand the path automatically.
2013-09-17check_udp: skip tests which rely on udp listenSven Nierlein1-0/+1
solaris netcat does not listen in udp mode due to http://sourceforge.net/p/netcat/bugs/27/
2013-09-16check_procs: fix test with sleeping processesSven Nierlein1-1/+1
at least on freebsd, there are a processes with state 'S', they always use two character status.
2013-09-16check_http: tests use supplied value if possibleSven Nierlein1-9/+3
2013-09-14check_ping: increase test timeoutSven Nierlein1-1/+1
freebsds ping takes a few seconds till it returns, so a 1 second timeout does not work for the test.
2013-09-14check_udp: try nc.traditional tooSven Nierlein1-1/+4
nc.traditional is available on (at least) ubuntu systems and uses traditional nc syntax
2013-09-14tests: move ipv6 detection into NPTest moduleSven Nierlein2-18/+18
2013-09-13unified nc syntaxSven Nierlein1-3/+15
older netcats do not understand -p, they expect host and port as additional argument. This is backwards compatibel to newer clients. Also support netcat instead of nc.
2013-09-12check_tcp: only test ipv6 if ping6 worksSven Nierlein1-3/+18
2013-08-21fixed check_tcp testSven Nierlein1-1/+1
A check with thresholds 9000,1 must exit with warning if the certificate expires in less than 9000 but more than one day.
2013-08-21check_snmp: added threshold testsSven Nierlein1-137/+156
2013-08-17plugins/t/check_procs.t: Expect performance dataHolger Weiss1-3/+3
The check_procs plugin now emits performance data, fix the test(s) accordingly.
2013-08-17plugins/t/check_apt.t: Expect performance dataHolger Weiss1-2/+2
The check_apt plugin now emits performance data, fix the test(s) accordingly.
2013-08-15cleanup after check_http patch (fixes #50)Sven Nierlein1-8/+15
- cleanup whitespace - added test cases - print time_ssl only if ssl is in use - updated news and thanks file
2013-08-15corrected http testSven Nierlein1-8/+3
multiple headers have to be set by multiple -k switches. Seperating them by semicolons is not longer supported as semicolons are valid characters in http headers.
2013-02-10check_tcp: don't ignore trailing optionsSven Nierlein1-1/+3
"./check_tcp -6 -p 80 host" leads to an error: TCP CRITICAL - Invalid hostname, address or socket: 127.0.0.1 because 127.0.0.1 is the fallback host, the tailing hostname was ignored.
2013-01-23Merge pull request #20 from abradley/aptcriticalSven Nierlein6-0/+241
Fixes for check_apt handling of -i/-e/-c regexps and SECURITY_RE, plus tests
2013-01-23updated check dig testsSven Nierlein1-7/+15
nagios.com seems to have changed their ip address. Also added tests about -4/-6 option.
2012-10-03Tests for check_aptrefs/pull/20/headAlex Bradley6-0/+241
Add a hidden "--input-file" option to check_apt (modelled on check_procs) so that it can take files with sample apt output as input. Add tests for my SECURITY_RE fix (debian3) and for the include, exclude and critical options.
2012-07-04Merge remote-tracking branch 'github/tokkee/sh/check_dbi'Holger Weiss1-0/+103
2012-06-25check_http: added test for warning thresholdsSven Nierlein2-1/+9
fixed typo in sslutils
2012-06-22Fix check_by_ssh test for non-Bash login shellsHolger Weiss1-5/+5
In the C shell and in the Z shell, the "?" character must be quoted or backslash-escaped in order to use it verbatim. Therefore, a command such as check_by_ssh -H test.example.com -l joe echo huh? might fail, depending on joe's login shell on test.example.com. Just to make sure, this commit removes most punctuation characters from our test strings.
2012-06-08t/check_dbi.t: Don't use 'INSERT … VALUES (a,b), (c,d)' with SQLite3.refs/pull/8/headSebastian Harl1-1/+2
Older versions of SQLite3 don't seem to support that.
2012-06-08Added a few test cases for the check_dbi plugin.Sebastian Harl1-0/+102
All tests use sqlite3. A temporary database is created for the purpose of the tests.
2012-04-09check_by_ssh: added -F config file to specify alternative ssh configSven Nierlein1-1/+12
2011-02-04check_http: check for and print the certificate cnThomas Guyot-Sionnest1-1/+1
This patch adds a check for the certificate cn (hostname) to normal certificate checks. It returns CRITICAL if th cn is missing, otherwise it prints it in the normal output. Patch by Stéphane Urbanovski
2011-01-06Test updates...Thomas Guyot-Sionnest1-1/+1
1. Timetick test could fail with uptime > 115 days. Thresholds are double type, so it's safe to put a large number even for 32bit systems. 2. Add a test based on an invalid bug report, worthy anyway.
2010-12-01check_snmp: Remove that is_numeric madnessThomas Guyot-Sionnest1-1/+8
Original patch to make Timeticks works as in check_snmp v1.4.14, it turns out is_numeric isn't so useful and treating all types as numeric works best for backwards-compatibility. This is how it used to work in 1.4.14. As a special case, I also make calculate_rate look up for numeric values as it would otherwise return the last value instead.
2010-03-17Let check_ntp_peer check the number of truechimersHolger Weiss1-12/+12
Add support for checking the number of usable time sources (i.e., the number of peers which are classified as so-called "truechimers" by NTP's intersection algorithm). The new "-m" and "-n" options allow for specifying the according WARNING and CRITICAL thresholds (and thereby activating the truechimers check), respectively.
2009-10-22Fix usage of repeated -o options in check_snmpThomas Guyot-Sionnest1-9/+17
2009-09-11Fix skip numberTon Voon1-1/+1
2009-07-31check_snmp: Add some verbose output and testsThomas Guyot-Sionnest1-1/+5
2009-07-31Fix check_snmp Timetick test with <1 day uptimeThomas Guyot-Sionnest1-2/+2
2009-06-13Fixed testcases for check_snmp, check_ifstatus and check_ifoperstatus when ↵Matthias Eble1-3/+5
no snmp community is specified The checks for invalid/unavailable hosts need a complete command line. They failed on hosts where no community was specified. Now, an invalid community is used so the tests can run on hosts w/o snmp host/community in NPTest.cache. Execution will fail anyway.
2009-05-28check_snmp: Make use of standard threshold functionsThomas Guyot-Sionnest1-2/+29
This patch makes use of standard threshold functions. This allows using doubles as thresholds. Since SNMP supports only integers, double precision numbers are only printed when parsed from a STRING type. In addition, support for printing properly Timeticks type has been added, and the code has been thoroughly cleaned.
2009-03-20negate: make timeouts configurableThomas Guyot-Sionnest1-6/+25
2009-03-18Add suggested multi-oid test (John A. Barbuto)Thomas Guyot-Sionnest1-1/+5
2009-03-17Check for existence of pre-instaleld pst3 for Solaris tests in t/check_procs.tThomas Guyot-Sionnest1-1/+1
2009-03-16Fix check_snmp test on solarisThomas Guyot-Sionnest1-1/+1
2009-03-16check_snmp fixes:Thomas Guyot-Sionnest1-1/+1
- Fix broken compilation caused by typo in command ending - Remove extra whitespaces at EOL - Fix invalid host test on Ubuntu Hardy (and possibly others)
2009-03-14Fixed passing of quotes in OID for check_snmp (#1985230 - Jan Wagner, patch ↵Ton Voon1-9/+40
by John Barbuto)
2009-01-21Trick for check_users test without users logged-inThomas Guyot-Sionnest1-0/+4
2008-11-23Removing CVS/SVN tags and replacing with git-based versioningThomas Guyot-Sionnest28-29/+0
For contrib/, full tags have been imported from subversion git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2091 f882894a-f735-0410-b71e-b25c423dba1c
2008-11-05Fix check_http test (altinity.com redirects now).Thomas Guyot-Sionnest1-2/+2
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2067 f882894a-f735-0410-b71e-b25c423dba1c
2008-08-16TypoThomas Guyot-Sionnest1-1/+1
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2032 f882894a-f735-0410-b71e-b25c423dba1c
2008-07-09rewrote check_snmp.t to use Test::MoreMatthias Eble1-31/+44
added perfdata checking for string values git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2022 f882894a-f735-0410-b71e-b25c423dba1c