summaryrefslogtreecommitdiffstats
path: root/plugins
AgeCommit message (Collapse)AuthorFilesLines
2011-09-07Make GCC happyThomas Guyot-Sionnest1-1/+1
It won't trust us about msg containing no format string, and fail miserably when compiled with -Werror=format-security. Reported by spy6 on IRC.
2011-08-13Fix: check_ldap now correctly handles the long option --hostname for -HMatthias Eble1-1/+1
The undocumented --host has been changed to --hostname which is actually mentioned in --help. Thanks to lgarrett (#3191388)
2011-07-15Fix check_smtp and check_tcp where duplicate messages were displayed for ↵Ton Voon2-7/+1
certificate errors (Opsview team)
2011-07-15New option to check_smtp to ignore failures when sending QUIT (#3358348 - ↵Ton Voon1-4/+26
Duncan Ferguson)
2011-03-26Add perfdata to check_ssh (#3244097 - Marco Beck)Thomas Guyot-Sionnest1-2/+9
2011-02-08check_smtp: Abort on missing/unexpected greetingHolger Weiss1-2/+2
Abort immediately if we don't receive a server greeting or if the greeting doesn't contain the "--expect"ed string (by default: "220") instead of blindly sending the EHLO/HELO line. Spotted by Daniel Piddock, see Debian bug report #611914.
2011-02-04check_http: check for and print the certificate cnThomas Guyot-Sionnest3-14/+32
This patch adds a check for the certificate cn (hostname) to normal certificate checks. It returns CRITICAL if th cn is missing, otherwise it prints it in the normal output. Patch by Stéphane Urbanovski
2011-01-21Fix for regex input of '|', being output causing problems with Nagios' ↵Ton Voon2-2/+15
parsing of performance data. Now replaced with ','
2011-01-06Test updates...Thomas Guyot-Sionnest3-5/+9
1. Timetick test could fail with uptime > 115 days. Thresholds are double type, so it's safe to put a large number even for 32bit systems. 2. Add a test based on an invalid bug report, worthy anyway.
2011-01-01Make check_http use standard threshold functionsThomas Guyot-Sionnest1-30/+18
This enables floating point and ranges, and make the code more standard.
2010-12-23Fix check_ldap overriding the port when --ssl was specified after -pThomas Guyot-Sionnest1-2/+6
2010-12-01Fix minor test issuesThomas Guyot-Sionnest2-21/+28
My Test::More wouldn't print the total number of tests anymore, moving the plan at the top appears to fix it. At the same time I made check-http.t eval the special modules so it can skip the tests instead of failing.
2010-12-01Revert "check_snmp now considers strings returned by SNMP that contain just"Thomas Guyot-Sionnest2-19/+1
This reverts commit 896962a1ad1b7d7c75d42c565b06cc799feb0a7c. Conflicts: NEWS plugins/tests/check_snmp.t Notes: Reverting because I rebased a patch that was doing the same thing, plus fixing more related regressions, and both didn't work together. I kept the tests intact except for one that wouldn't pass on 1.4.14 either
2010-12-01State-based tests enhancementsThomas Guyot-Sionnest1-1/+4
- Use /var/tmp for state if no state dir environment variable is set, this avoid the need for a writable localstatedir during tests. - Use "rm -f", mostly to avoid printing out garbage of the directory doesn't exists
2010-12-01check_snmp: Remove that is_numeric madnessThomas Guyot-Sionnest2-9/+12
Original patch to make Timeticks works as in check_snmp v1.4.14, it turns out is_numeric isn't so useful and treating all types as numeric works best for backwards-compatibility. This is how it used to work in 1.4.14. As a special case, I also make calculate_rate look up for numeric values as it would otherwise return the last value instead.
2010-11-15Fix check_disk free space calculation if blocksizes differ within a disk ↵Matthias Eble1-81/+94
group (Bekar - #2973603) Various values (dused_pct, dfree_pct, inodes_free, inodes_total, ...) are now carried in the parameter_list structure. Assignments have been moved to a subroutine preventing code redundancies. Group metrics are now calculated based on units rather than blocks. This fixes freespace calculation when blocksizes differ within a group.
2010-11-15check_snmp now considers strings returned by SNMP that contain justnagios3-4/+33
numbers (according to strtod) to be a numeric value for threshold and performance data
2010-10-15check_nt: make UPTIME accept warning/critical levelsThomas Guyot-Sionnest1-1/+6
Patch originally by Ryan Kelly
2010-08-31Fix typos in -f help textTon Voon1-1/+1
2010-07-09Fix --help output when MAX_OIDS is altered.Thomas Guyot-Sionnest1-2/+2
2010-07-07Fix examples in check_disk, where it implied was possible to suffix unit ↵Ton Voon1-2/+2
values to warn/crit parameters
2010-06-30Corrected rate_multiplier calculationtonvoon2-2/+2
2010-06-30Removed suffix of "-rate" and let user decide label via --labeltonvoon2-7/+5
2010-06-30Tests for --rate-multiplier optiontonvoon2-1/+14
2010-06-30Fixed rate-multiplier optionTon Voon1-4/+8
2010-06-23Added option to invert search resultstonvoon3-10/+34
2010-06-23Display missing search string and URL when failed (Duncan Ferguson #2999924)tonvoon2-2/+15
2010-06-23Added state retention APIs. Implemented for check_snmp with --rate option.Ton Voon4-21/+199
See http://nagiosplugin.org/c-api-private for more details on the API. Also updated check_snmp -l option to change the perfdata label.
2010-05-08Add missing --fqdn help (Jan Wagner)Thomas Guyot-Sionnest1-2/+4
2010-04-28Update extra-opts help text based on ML agreementThomas Guyot-Sionnest1-1/+2
2010-04-22Add newline after "Usage:" in --helpThomas Guyot-Sionnest39-39/+39
2010-04-22Split long line in check_cluster --helpThomas Guyot-Sionnest1-1/+2
2010-04-22Standardize the extra-opts notesThomas Guyot-Sionnest38-186/+1
2010-04-22Fix tests and update NEWS fileThomas Guyot-Sionnest1-4/+49
2010-04-22Replace the lousy multiline parser with a robust one.Thomas Guyot-Sionnest1-8/+49
This one counts double quotes and backslashes so it should handle any level of escaping.
2010-04-22Attempt at fixing check_snmp multiline output:Thomas Guyot-Sionnest2-9/+32
This patch tries to detect and output nicely multi-line strings. This method is broken by design; only a count of double-quotes and escapes could work in every situation.
2010-04-14Fix translations when extra-opts aren't enabledThomas Guyot-Sionnest41-266/+266
Bug #2832884 reported problem with translations outputting pot file headers. This is caused by "" matching the header of the translation files. This patch moves gettext macros inside utils macros and update some french translations.
2010-04-14Update french translation (fix all fuzzy's)Thomas Guyot-Sionnest2-3/+3
2010-04-14Fix check_radius returning OK on unexpected resultsThomas Guyot-Sionnest1-2/+12
REJECT_RC is defined on some radiusclient versions and differenciates between auth errors and bad responses. This patch will affect only the behaviour of those clients exporting REJECT_RC. In addition, unexpected return codes are now handled properly and return UNKNOWN.
2010-04-12Fix typoHolger Weiss1-1/+1
2010-04-11Fix Debian bug #482947: No --nas-ip-address optionHolger Weiss1-13/+28
| check_radius doesn't seem to provide any way to modify the | NAS-IP-Address attribute that it uses in the packets it sends, but it | does so for NAS-Identifier. | | Instead, it hardcodes the IP address that it gets from the | rc_own_ipaddress() library call, and that in turn translates into | calling gethostbyname() on the result of uname(). This call can easily | fail, and its result can easily be unsuitable - for example when the | Nagios instance uses its own virtual host, and you don't want the | original system hostname leaked to the RADIUS servers you monitor with | this. | | Furthermore, this behaviour is inconsistent with RFC 2865, which | defines the two attributes as analogous and never suggests hardcoding | the value of either of them in client software. Therefore, this commit adds the "-N, --nas-ip-address" option which allows for specifying the value of the NAS-IP-Address attribute. | I've also noticed that the original code for NAS-IP-Address hardcoding | is broken in its error handling - it does "return (ERROR_PC)", which | is meaningless in the context of check_radius.c. That actually seems | to be copy&waste from radiusclient-0.3.2/src/radexample.c. :) I fixed | that. | | While debugging, I also took the opportunity to decouple the | nas-identifier rc_avpair_add() instance from the initial three, | because this is just bad practice to lump a fourth optional attribute | into the same block with the required attributes, the error handling | for which is throwing the same daft message "Out of Memory?"... [ http://bugs.debian.org/482947 ] (Contributed by Josip Rodin, forwarded by Jan Wagner.)
2010-04-11Fix Debian bug #479984: Allow empty LDAP baseHolger Weiss1-1/+1
The check_ldap plugin did not allow for specifying an empty LDAP base. See: http://bugs.debian.org/479984 (Fixed by Stephane Chazelas, forwarded by Jan Wagner.)
2010-04-11Fix Debian bug #460097: check_http -M brokenHolger Weiss1-1/+4
See: http://bugs.debian.org/460097 One instance of this bug has already been fixed in commit 888358122004b9571c8fbdfa52ceee1ba5e5f4f2. (Fixed by Hilko Bengen, forwarded by Jan Wagner.)
2010-04-11Fix Debian bug #463322: Use deprecated libldap APIHolger Weiss1-0/+1
| Our automated build log filter[1] detected a problem that is likely to | cause your package to segfault on architectures where the size of a | pointer is greater than the size of an integer, such as ia64 and | amd64. | | This is often due to a missing function prototype definition. For | more information, see [2]. | | Function `ldap_init' implicitly converted to pointer at | check_ldap.c:124 | | [1] http://people.debian.org/~dannf/check-implicit-pointer-functions | [2] http://wiki.debian.org/ImplicitPointerConversions | | The libldap API has been updated and many functions used by the ldap | plugin are now deprecated. This package should either update to the | new API or define LDAP_DEPRECATED to continue using the deprecated | interfaces. | | This patch implements the lazy solution. [ http://bugs.debian.org/463322 ] (Contributed by Dann Frazier, forwarded by Jan Wagner.)
2010-04-11Fix Debian bug #307905: Incorrect usage outputHolger Weiss1-1/+1
The usage output of check_game was wrong, see: http://bugs.debian.org/307905 (Fixed by Sean Finney, forwarded by Jan Wagner.)
2010-04-06Fix regression in check_http ssl checks on some serversThomas Guyot-Sionnest1-3/+12
The fix is making SNI an option.
2010-03-31check_snmp: Update last patch to copy value verbatimThomas Guyot-Sionnest1-10/+6
Rework last patch, copying the converted portion of the string rather than re-converting it. This is safer for backwards-compatibility as the value is never modified.
2010-03-31check_snmp: Fix regression introduced in #1867716Thomas Guyot-Sionnest1-2/+10
Bug #1867716 fixed what it meant to fix: broken perfdata strings. Unfortunately some users relied on half-broken perfdata string where at least the first token was OK. This patch do a two-way conversion (string to double then back to string) instead and use the conversion result for the performance data. A possible caveat is that the string may change where it normally shouldn't but the result should be somewhat similar.
2010-03-27Fix compilation with GCC 2.96 (Konstantin Khomoutov - #2977105)Thomas Guyot-Sionnest1-3/+3
2010-03-17Let check_ntp_peer check the number of truechimersHolger Weiss2-27/+69
Add support for checking the number of usable time sources (i.e., the number of peers which are classified as so-called "truechimers" by NTP's intersection algorithm). The new "-m" and "-n" options allow for specifying the according WARNING and CRITICAL thresholds (and thereby activating the truechimers check), respectively.