Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
since 6623a1 check_snmp prints the thresholds along the performance data.
This adjust our test cases accordingly.
Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
|
|
* handle-hanging-nfs:
NEWS: Mention check_disk enhancement
Cosmetic change: s/THRLIBS/THREADLIBS/
configure.ac: Don't let pthread check depend on OS
check_disk: Seperate declarations from code
check_disk: Remove unused status variable
check_disk: Fix pthread start routine type
Don't let check_disk hang on hanging file systems
|
|
Use a more intuitive variable name.
|
|
* maint:
NEWS: Modify list of changes for 2.1.1 release
Prepare release
THANKS.in: Add new authors
NEWS: Updating all the fixes
check_tcp: fix help description regarding escape option
check_ntp: Nul-terminate jitter data
Revert "plugins/check_ntp.c - Verify struct from response"
check_real: fix null termination
check_ntp: fix null termination
check_apt: fix memset
Conflicts:
NEWS
|
|
The help description should print '\\' for backslash not just '\'.
Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
|
|
Make sure the jitter response is nul-terminated before parsing the data
using string functions.
|
|
This reverts commit a04df3e1b67dc5eab3adc202cc89901f801cdeaa. The "fix"
was bogus in many ways and broke jitter checking.
Conflicts:
plugins/check_ntp.c
|
|
|
|
We didn't actually use the exit status provided by pthread_join(3) for
anything.
|
|
The function pointer passed as third argument to pthread_create(3) must
be of type void *(*)(void *).
|
|
|
|
|
|
It makes more sense to exit critical if a explicit version/protocol is requested. This
would also be more consistent with other plugins. Other string matching plugins like
check_snmp or check_http exit critical if the result does not match.
Signed-off-by: Sven Nierlein <sven@nierlein.de>
Closes #1268
|
|
|
|
snmpget already supports using SNMPv3 contexts using the option "-n".
Thus all we need to do is introduce a new argument to check_snmp and
pass the argument on to snmpget using snmpget's option "-n".
Since "-n" is already in use for check_snmp for a different purpose,
we use "-N" instead.
|
|
|
|
Fix null termination introduced by commit b61f51a ("plugins/check_real.c - recv string null terminate").
Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
|
|
Fix null termination introduced by commit a04df3e ("plugins/check_ntp.c - Verify struct from response").
Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
|
|
Fix memset introduced by commit 9ce7369 ("plugins/check_apt.c - Print uninitialized ereg").
Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
|
|
|
|
|
|
Signed-off-by: Davide Madrisan <davide.madrisan@gmail.com>
|
|
Conflicts:
NEWS
THANKS.in
|
|
The plugin expected:
<?xml version='1.0'?>
But Openfire sends:
<?xml version='1.0' encoding='UTF-8'?>
|
|
just like the guidelines and the help already suggests.
Signed-off-by: Sven Nierlein <sven@nierlein.de>
|
|
solaris snmpd has no perl support by default, so this test will fail.
Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
|
|
Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
|
|
instead of hoping to have it in the environment. This at
least broke tests on solaris.
Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
|
|
this also allows us to make tests against "critical" in the output.
Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
|
|
s/t/jresult are not initialized if there is no corresponding threshold
supplied. So we shouldn't use them for calculating our result.
Signed-off-by: Sven Nierlein <sven@nierlein.de>
|
|
|
|
|
|
|
|
Fix automatic DNS server name detection to honor -4 and -6 switches
(default to 127.0.0.1 or ::1 respectively, i.e. if -6 is given ::1
is used instead of 127.0.0.1)
|
|
FreeBSD starting with version 10 is shipped with ldns instead of bind as
resolver. Consequently the dig tool in base is replaced by drill. While dig can
still be installed as a third party application, it would be nice to make do
with the tools available in the system already.
This patch rearranges the command line used to invoke dig slightly so that it
can be used with both dig and drill (tested with dig 9.8.3-P1 and 9.9.4 as well
as drill 1.6.16). It would be really neat if the configure script could be
changed to automatically pick up drill when dig is not available (or the other
way around), but my autotools-foo is not good enough for that.
This part of the patch is an extended version of the locally maintained patch
currently deployed in the FreeBSD ports tree by Dmitry Sivachenko.
|
|
This patch verifies if the response is returned by the dns server we
are trying to check
---
Closes #981
Closes #982
Closes #1164
|
|
Signed-off-by: Sven Nierlein <sven@nierlein.de>
|
|
I'm submitting a small patch to check_disk that will show which partitions are
actually causing the error state. This helps the human operator to quickly
identify the exact issue. I made it so a single -v flag is required so it
doesn't harm legacy code that may be parsing the original style of output.
Thanks to Jason Benguerel.
---
Closes #984
Closes #1182
|
|
Closes #907
Closes #1184
|
|
Not sure if this is of use or not - we have a strange requirement to run
certain servers 5 minutes fast. I've added a switch to the check_ntp_time
to allow for this offset.
Thanks to Patrick McAndrew.
|
|
Changed bool to short.
Removed first instance of is_socket to avoid
redeclaration error.
Changed 'socket' to 'file socket' for verbosity.
|
|
thus simplify the problem debugging: no need to check for this information in
the Nagios configuration.
This function is only used by 'check_tcp.c'.
Without the patch:
$ ./plugins/check_tcp -H 127.0.0.1 -p 21
Connection refused
$ ./plugins/check_tcp -H /var/spool/nagios/cmd/nagios.cmd
Permission denied
With the patch:
$ ./plugins/check_tcp -H 127.0.0.1 -p 21
connect to address 127.0.0.1 and port 21: Connection refused
$ ./plugins/check_tcp -H /var/spool/nagios/cmd/nagios.cmd
connect to socket /var/spool/nagios/cmd/nagios.cmd: Permission denied
Thanks to Davide Madrisan.
---
Closes #1277
|
|
This patch allows checking if MySQL server is running without providing valid
username and password. Similar to check_ssh plugin it returns MySQL server
version string and protocol number.
Example:
check_mysql -n -H aaa.bbb.ccc.ddd
MySQL OK - Version: 5.0.51a-24+lenny5 (protocol 10)
This is useful for monitoring servers where one does not have administrator
privileges or does not want to grant any privileges for the monitoring station.
To enable this functionality new option --ignore-auth (-n) is added to
check_mysql plugin.
Thanks to Julius Kriukas
Closes #1020
Closes #1178
|
|
Adjust the expected date strings to the now-localized output produced by
plugins/sslutils.c.
Closes #1275.
|
|
Perl said: "Unrecognized escape \d passed through at ./t/check_dns.t
line 57."
|
|
sshutils prints the expiry time of certificates in US format
this patch uses the strftime %c, I don't know how portable that is
Thanks to Neil Prockter.
Closes #1188
Closes #1161
Closes #977
Closes #976
Closes #975
Closes #840
Closes #382
|
|
|
|
---
Closes #1160 and #973
|
|
|