summaryrefslogtreecommitdiffstats
path: root/plugins
AgeCommit message (Collapse)AuthorFilesLines
2013-08-06Fixed SF.net bug 2555775, threshold can be double for check_smtpJan Wagner1-14/+12
Thanks to Roman Fiedler for reporting the issue and providing a fix
2013-07-08check_nt: Fixes NULL pointer dereferenceJan Wagner1-3/+13
Thanks to Vaclav Ovsik for reporting the issue and providing a fix
2013-06-30check_ntp_peer: Verify type of response packetsHolger Weiss1-13/+19
The check_ntp_peer plugin now ignores response packets with an unexpected "Operation Code" and/or "Sequence" number (cf. RFC 1305, Appendix B). This fixes an issue where the check_ntp_peer requests got duplicated on their way to the server (due to some network switch bug), and the server therefore sent multiple responses per request. Thanks to Marc Haber for reporting the issue.
2013-06-25Fixed SF.net bug 1614553, Debian bug #708343, Adding performace dataJan Wagner1-2/+4
2013-05-12build: fix building with parallel make.Diego Elio Pettenò1-71/+24
By using a more automake-style handling of dependencies and a single convenience library, it's tremendously easy to build in parallel. Note that since the linking happens with the static archives, the unused objects are discarded and provide no overhead whatsoever.
2013-05-12plugins: rename runcmd's signal handler.Diego Elio Pettenò4-4/+4
The previous name would collide with popen's. Even if the two are never used together, it's still a good idea not to have the same symbol in multiple object files.
2013-03-25Fixed SF.net bug 3560976, added --include-type/-N optionRichard Leitner1-3/+15
2013-03-25Fixed SF.net bug 3602586, added timeout option for check_nagiosRichard Leitner1-3/+13
2013-03-25Fixed SF.net bug 3539317, typo in --help of check_aptRichard Leitner1-1/+1
2013-02-27Update plugins/check_procs.cJoerg Linge1-0/+1
added missing longopt --user
2013-02-10check_tcp: don't ignore trailing optionsSven Nierlein2-11/+18
"./check_tcp -6 -p 80 host" leads to an error: TCP CRITICAL - Invalid hostname, address or socket: 127.0.0.1 because 127.0.0.1 is the fallback host, the tailing hostname was ignored.
2013-01-24Apply my patch from:refs/pull/34/headDaniël van Eeden1-3/+8
http://sourceforge.net/tracker/index.php?func=detail&aid=3269273&group_id=29880&atid=397597
2013-01-23Merge pull request #20 from abradley/aptcriticalSven Nierlein7-21/+276
Fixes for check_apt handling of -i/-e/-c regexps and SECURITY_RE, plus tests
2013-01-23updated check dig testsSven Nierlein1-7/+15
nagios.com seems to have changed their ip address. Also added tests about -4/-6 option.
2013-01-23check_dig: query transport selection supportVille Mattila1-3/+16
Add command line options -4 and -6 (--use-ipv4 and --use-ipv6) to check_dig. Effectively this adds no new functionality, just a shortcut for: check_dig -A "-4" check_dig -A "-6" Needed for using check_dig with the check_v46 wrapper (see e.g. https://gitorious.org/nagios-monitoring-tools/nagios-monitoring-tools/blobs/master/check_v46) which requires -4/-6 command line option support.
2013-01-23check_snmp: Don't thrash memory when using multiple label/unit argumentRobin Sonefors1-11/+11
The memory allocation mixed up number of bytes with number of pointers, meaning as soon as we'd reach (on 64 bit systems) the second argument, we'd start writing it outside of our allocated memory. Normally, this isn't too visible, but as soon as you (again, on my 64 bit system) reach argument number 8, you get a segfault. It is easily reproducible with: check_snmp -o '' -l '' -o '' -l '' -o '' -l '' -o '' -l '' \ -o '' -l '' -o '' -l '' -o '' -l '' -o '' -l '' This patch allocates the proper amount of memory, to fix the issue. Signed-off-by: Robin Sonefors <robin.sonefors@op5.com>
2012-11-28check_ntp(_time): don't die on connect errorsSven Nierlein2-2/+10
connect errors may happen if clients check agains dual stacked ipv4/6 ntp servers.
2012-11-28unified ipv4/6 usage and help textSven Nierlein6-10/+8
2012-11-14check_procs: Remove superfluous newline characterHolger Weiss1-1/+1
2012-11-14check_procs: Added performance data to plugin output.Sebastian Harl1-0/+7
2012-11-14check_procs: Use the range/threshold support functions from libnagiosplug.Sebastian Harl1-89/+17
This adds support for @<range> and makes stuff a bit simpler by removing code duplications. Note: Previously, the compatibility code for 'check_procs <warn> <max>' accepted something like 'check_procs -w 10:-1 -c 10:-1 20 50' as well (treating it as if '-w 10:20 -c 10:50' was specified). This is no longer the case ... additional arguments are only used as warn/crit thresholds in case -w/-c is not specified at all.
2012-11-03plugins/check_snmp: Show snmp error when we fail to parse its outputAndreas Ericsson1-2/+2
Dying without a hint of what went wrong is just plain annoying. With this patch we at least get a hint. While at it, we fix the string offset so the output we're interested in doesn't keep the equal sign that snmpget prints. Signed-off-by: Andreas Ericsson <ae@op5.se>
2012-11-03Make check_snmp backwards compatible in how it parses thresholdsAndreas Ericsson1-0/+23
Once upon a time, check_snmp used to accept inverse ranges in the format of '2:1' to mean "alert if value is inside this range". Since commit 7cb3ae09334796f3b54e4e6438e38c2cc679b360, ranges such as those have instead triggered the error "Range format incorrect" and resulted in an UNKNOWN warning state. This patch attempts to fix the situation so that the old-style ranges continues to mean exactly what the once did and people with lots of snmp checks can avoid a bazillion false positives from their environments. Signed-off-by: Andreas Ericsson <ae@op5.se>
2012-10-09Allow for configuring OpenSSLHolger Weiss1-0/+1
Let OpenSSL load its configuration file. See the OPENSSL_config(3) man page for details. (Suggested by Max Kosmach in Debian bug report #689960, forwarded by Jan Wagner.)
2012-10-03Tests for check_aptrefs/pull/20/headAlex Bradley7-3/+257
Add a hidden "--input-file" option to check_apt (modelled on check_procs) so that it can take files with sample apt output as input. Add tests for my SECURITY_RE fix (debian3) and for the include, exclude and critical options.
2012-10-03Fix SourceForge bug 1904965 - check_apt: SECURITY_RE is not correctAlex Bradley1-1/+1
For the default security upgrade detection regular expression, match "Debian-Security" in package description when it's anywhere after the first parenthesis (not just the second space-delimited word). For example: ... (4.0.1-5.4 Debian:6.0.6/stable, Debian-Security:6.0/stable ...
2012-10-03Don't prepend "^Inst" or append a space to the "include", "exclude", orAlex Bradley1-17/+18
"critical" regular expressions. Instead, check for lines beginning with "Inst" using strncmp and apply the regular expressions only when such lines are found. Fixes Debian bug #522812, along the lines suggested by the bug submitter, Justin T Pryzby.
2012-09-25Update plugins/check_disk.crefs/pull/19/headGianluca Varisco1-1/+1
CRITCAL -> CRITICAL typo
2012-08-10check_http: Update description of -C optionHolger Weiss1-1/+1
Mention that the -C option now accepts two comma-separated values.
2012-08-10check_http: Add missing newline to --help outputHolger Weiss1-3/+3
2012-08-10fixing bug in certificate experiation patch checking for bad warning ↵William Leibzon3-3/+3
threshold data
2012-08-10tests/check_http.t: Fix whitespace issuesHolger Weiss1-10/+8
In tests/check_http.t, tabs are used for indentation. While at it, apply another few cosmetic changes.
2012-08-10tests/check_http.t: Update the number of SSL testsHolger Weiss1-1/+1
2012-08-10tests/check_http.t: Fix test caseHolger Weiss1-1/+1
Fix the test case which is meant to make sure that check_http -C <n>,<m> [...] returns a CRITICAL state if <m> is large enough.
2012-08-06check_ntp_peer: Fix --help output for -m and -nHolger Weiss1-1/+1
Fix the threshold specifications in the example for checking the number of truechimers. Reported by Marc Haber on the "nagios-users" mailing list (Message-ID: <20120722142840.GA6931@torres.zugschlus.de>).
2012-08-06check_ntp_peer: Fix --help output for -W and -CHolger Weiss1-2/+2
Mention that the check_ntp_peer plugin checks the stratum of the synchronization peer, not the stratum of the monitored server itself. Thanks to Marc Haber for bringing this up on the "nagios-users" mailing list (Message-ID: <20120722142840.GA6931@torres.zugschlus.de>).
2012-07-18check_http: Fix whitespace issuesHolger Weiss1-10/+10
In check_http.c, tabs aren't used for indentation.
2012-07-18check_http: Fix compilation without SSL supportHolger Weiss1-3/+4
The "ssl_version" variable was undeclared when the plugins were compiled --without-openssl and --without-gnutls. Bug reported by Michael LaCorte on the "nagiosplug-help" mailing list (Message-ID: <CCD30C91-A2A8-463A-82A9-F99B54F741D3@gmail.com>).
2012-07-04Merge remote-tracking branch 'github/tokkee/sh/check_dbi'Holger Weiss3-1/+923
2012-07-04Re-added missing variable declarations to check_smtp.cEric Stanley1-0/+2
A recent update removed the declarations for a couple variables in check_smtp.c that are still being used, which caused a failure in the compilation of check_smtp.c. This commit restores those variable declarations so the check_smtp.c will again compile.
2012-06-29check_smtp: Remove a comment regarding MAIL FROMHolger Weiss1-15/+4
Earlier versions of check_smtp generated an (invalid) "MAIL FROM" command without arguments by default. These days, a "MAIL FROM" command is only sent if the --from option is specified. This commit removes a comment which explains the old behaviour, and it updates a variable name accordingly.
2012-06-29check_smtp: Fix help and usage output regarding -RHolger Weiss1-2/+2
2012-06-29check_smtp: Fix strcat overflowsAnders Kaseorg1-4/+2
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2012-06-29Die when asprintf failsAnders Kaseorg37-366/+395
Fixes many instances of warning: ignoring return value of 'asprintf', declared with attribute warn_unused_result [-Wunused-result] Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2012-06-29check_smtp: Strip angle brackets from -f argument, if providedAnders Kaseorg1-1/+2
Apparently some people used -f '<nagios@example.com>' to work around the bug I just fixed in the MAIL FROM: command generation. Although the resulting command wasn't RFC-compliant, it was working with some MTAs, so let's continue to support this syntax now that we generate RFC-compliant commands. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2012-06-29check_smtp: Change MAIL FROM: command to comply with the SMTP standardAnders Kaseorg1-1/+1
Every version of the SMTP standard (from RFC 821 to the current RFC 5321) requires the address following MAIL FROM: to follow the colon immediately (with no space) and to be surrounded by angle brackets. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2012-06-27check_tcp: Print performance data even with -DHolger Weiss1-1/+1
When using the 1.4.15 release of the Nagios Plugins, a command such as check_tcp -H pop.example.com -p 995 -D 14 usually produced two lines of output, e.g.: OK - Certificate will expire on 12/13/2014 23:59. TCP OK - 0.009 second response time on port 995|time=0.008849s;;;0.000000;10.000000 The second line was removed by 4d06603060fc1233861b164870f0d3a2e0d8d2eb. However, as the old two-line output is a valid (though in this case unintended) way to spit out performance data, removing the second line might break current setups. Therefore, we revert to the old behaviour, at least for the moment. The issue was reported by Jochen Bern on the "nagiosplug-devel" mailing list (Message-ID: <4FEAE812.8030309@LINworks.de>).
2012-06-26check_snmp: use single quotes for perf data labelsSven Nierlein2-4/+8
2012-06-26Fix performance data label containing spaces in check_snmp (Jochen Bern)Sven Nierlein2-4/+45
Add --perf-oids option for check_snmp to retain optional 1.4.14 compatibility
2012-06-25added test case for certificate checs with both warning and critical valuesWilliam Leibzon1-0/+4