summaryrefslogtreecommitdiffstats
path: root/plugins
AgeCommit message (Collapse)AuthorFilesLines
2016-11-08Merge pull request #1442 from waja/check_dig_use_retry_instead_triesSven Nierlein1-2/+2
check_dig: use +retry instead of +tries
2016-11-08check_dig: use +retry instead of +triesrefs/pull/1442/headChristian Kujau1-2/+2
After upgrading from an Ubuntu/15.10 to 16.04 installation, I noticed that check_dig is always returning a WARNING: $ /usr/lib/nagios/plugins/check_dig -l localhost -v /usr/bin/dig -p 53 @127.0.0.1 localhost A +tries=3 +time=6 Looking for: 'localhost' DNS WARNING - 0.008 seconds response time (dig returned an error status)|time=0.008274s;;;0.000000 The older Ubuntu installation got its check_dig from the nagios-plugins-standard package[0] which did not include the +tries option. The current Ubuntu version provides its check_dig from the monitoring-plugins-standard package[1], which _does_ use the +tries option that was introduced with df53473[2]. On my system, it so happens that /usr/bin/dig is provided not by the (BIND) dnsutils package but by knot-dnsutils[3] from the Knot DNS project. The Knot dig(1) command doesn't support the +tries option[4] but does support +retry (which is also supported[5] by the BIND dig(1) command). One way to fix that would be for me to install the BIND dnsutils package. But I did not want to do that: it's so much larger in size and pulls in much more dependencies than the knot-dnsutils package. The patch below changes check_dig to use +retry instead of +tries. Both options are similar, but not the same: +retry - Sets the number of times to retry UDP queries to server to T instead of the default, 2. Unlike +tries, this does not include the initial query As number_tries seems to be hard coded to 3, I've lowered DEFAULT_TRIES to 2 so check_dig should behave as before (with +tries=3). Thanks, Christian. [0] http://packages.ubuntu.com/wily/nagios-plugins-standard [1] http://packages.ubuntu.com/xenial/monitoring-plugins-standard [2] https://github.com/monitoring-plugins/monitoring-plugins/commit/df53473 [3] http://packages.ubuntu.com/xenial/knot-dnsutils [4] https://www.knot-dns.cz/docs/2.x/html/man_kdig.html#notes [5] https://ftp.isc.org/isc/bind9/cur/9.10/doc/arm/man.dig.html Signed-off-by: Christian Kujau <lists@nerdbynature.de>
2016-11-08check_ide_smart: remove unused functionrefs/pull/1441/headSebastian Herbszt1-26/+0
Remove function unused since commit b5cc292. Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
2016-11-07tests: enable snmp testsSven Nierlein1-2/+2
Enabled snmp tests against snmpd on localhost. It was installed already in the travis file, we just need to enable the tests by setting the parameters in the answers file. Signed-off-by: Sven Nierlein <sven@nierlein.de>
2016-11-07check_snmp: fix number of tests skipedSven Nierlein1-1/+1
2016-11-07check_snmp: add testcase for no datatypeSven Nierlein1-1/+5
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2016-11-07Revert "check_snmp: fix push request 1173 for SNMP responses without ↵Sven Nierlein1-1/+1
datatype indicator" This reverts commit 3178c8c0ff18822a04fe01c749f3564887473eed.
2016-11-07check_snmp: fix push request 1173 for SNMP responses without datatype indicatorThomas Kurschel1-1/+1
2016-11-07fix superfluous argument to printf (#fixes 1308)Sven Nierlein1-1/+1
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2016-11-07Merge pull request #1311 from waja/check_ntp_remove_unused_variablesSven Nierlein1-4/+2
check_ntp: remove unused variables
2016-11-07Merge pull request #1309 from waja/negate_remove_unused_variablesSven Nierlein1-2/+2
negate: remove unused variables
2016-11-07Merge pull request #1312 from waja/check_disk_remove_unused_variablesSven Nierlein1-7/+2
check_disk: remove unused variables
2016-11-07Merge pull request #1313 from waja/check_ntp_time_remove_unused_variablesSven Nierlein1-4/+2
check_ntp_time: remove unused variables
2016-11-07Merge pull request #1307 from waja/check_dns_dead_codeSven Nierlein1-6/+0
check_dns: remove dead code
2016-11-07tests: adjust check_http to new output formatSven Nierlein1-2/+2
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2016-11-07GMT expiry displayPeter (pir) Radcliffe2-5/+14
Change solution to display GMT time in the local display format with the offset number of hours from GMT to be clear about what timezone this is if the local display format does not include offset.
2016-11-07Revert "Fix check_http test time output"Peter (pir) Radcliffe1-4/+4
This reverts commit 2d9e61a4382b8366331cde7617dbc4e381a0219a.
2016-11-07Fix check_http test time outputPeter (pir) Radcliffe1-4/+4
Tests need to match new output time and timezone.
2016-11-07Use GMT timezone in SSL certsPeter (pir) Radcliffe1-3/+3
SSL certs are required to use times in GMT per https://www.ietf.org/rfc/rfc5280.txt but the mktime() here assumes the current timezone. Fix the time_t conversion to be done assuming GMT with timegm() and only do it once rather than twice. Display the expiry date and time with ISO format years and give an offset from GMT and a timezone to be very clear about exactly what time is being displayed. Time given is correct and now in the machine’s timezone.
2016-11-07check_snmp.c - Added IPv6 supportabrist1-3/+13
The "-6" optarg now prepends the server_address with "udp6:" for the snmpget external command as per the net-snmp syntax at: http://www.net-snmp.org/wiki/index.php/FAQ:Applications_28 Thanks to DrydenK (Roberto Greiner) for the heads up.
2016-11-07check_users: add new test casesSven Nierlein1-1/+3
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2016-11-07check_users: still allow zero thresholdsSven Nierlein1-2/+2
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2016-11-07check_users not correctly detecting thresholdsJohn C. Frickson3-61/+74
Fix for issue https://github.com/nagios-plugins/nagios-plugins/issues/81 check_users now uses the standard warning and critical ranges parser and a standard perdata output routine.
2016-09-17check_by_ssh: print command output in verbose modeSven Nierlein1-0/+7
right now it is not possible to print the command output of ssh. check_by_ssh only prints the command itself. This patchs adds printing the output too. This makes it possible to use ssh with verbose logging which helps debuging any connection, key or other ssh problems. Note: you must use -E,--skip-stderr=<high number>, otherwise check_by_ssh would always exit with unknown state. Example: ./check_by_ssh -H localhost -o LogLevel=DEBUG3 -C "sleep 1" -E 999 -v Signed-off-by: Sven Nierlein <sven@nierlein.de>
2016-02-22Merge branch 'pr/1386'Holger Weiss1-1/+1
* pr/1386: check_dig: expected answer is now incasesensitive
2016-02-22Let check_http test use HTTP/1.1Holger Weiss1-1/+1
2016-02-22DNS is case insensitive!refs/pull/1404/headSven Geggus1-1/+1
Thus recent Versions of bind will no longer change .IN-ADDR.ARPA to lowercase as the uppercase version is also valid. To have check_dns.c consider this fact change strstr to strcasestr
2015-11-02Typo in check_ldap.c usagerefs/pull/1390/headGerhard Lausser1-1/+1
2015-10-15check_dig: expected answer is now incasesensitiverefs/pull/1386/headDaniel Stirnimann1-1/+1
check_dig was casesensitive if an expected answer is given. Switching strstr with strcasestr fixes this issue While testing i noticed a bug where expected is not an exact match New issue for that is opened #1385 This fix closes #1233
2015-10-12Revert "Don't let check_disk hang on hanging file systems"Holger Weiss2-44/+1
This reverts commit 6986aa1d0a352d8d02eed4896034631fffd25a27. That commit leads to issues on non-Linux systems, and it seems to not (always) work as expected on Linux, either. Conflicts: plugins/Makefile.am plugins/check_disk.c Closes #1377 and closes #1329.
2015-10-08Merge branch 'maint'Holger Weiss3-10/+9
* maint: sslutils: Remove superfluous parenthesis for sslv3 function too sslutils: remove superfluous parenthesis check_snmp: modified tests check_snmp.c: switched DEFAULT_TIMEOUT to DEFAULT_SOCKET_TIMEOUT (provided by utils.h), already used by help description, see issue #1318 install snmpd on travis tests enable libtab on travis builds add perl snmp to travis dependencies NEWS: Mention check_ups performance data fix Fix incorrect performance data thresholds check_dhcp: Fix option parsing Fixes segfaults when running via monitoring worker (off-by-one) travis: fix http test host sslutils: Check if OpenSSL supports SSLv3. Conflicts: NEWS plugins/sslutils.c
2015-10-08check_smtp.c: modified SSL check for use with -erefs/pull/1379/headOliver Skibbe1-1/+1
- currently STARTTLS check does not work with -e if there's text like '220 hostname ESMTP*'. This is caused by SMTP answer from host. Postfix answer: 220 2.0.0 Ready to start TLS, Exchange 2010: 220 2.0.0 SMTP server ready. This fix checks against 220 closes #1093
2015-10-06check_smtp: Let "-D" option imply "-S"Holger Weiss1-5/+4
2015-10-06check_smtp: QUIT SMTP connection when "-D" is usedHolger Weiss1-0/+2
Don't forget to issue an SMTP QUIT command when the -D/--certificate option is specified. This avoids undesired MTA log messages.
2015-10-06Merge branch 'pr/1373'Holger Weiss3-20/+93
* pr/1373: check_http: Allow for requesting TLSv1.1/TLSv1.2
2015-10-04check_http: Allow for requesting TLSv1.1/TLSv1.2refs/pull/1373/headHolger Weiss3-20/+93
check_http's -S/--ssl option now allows for requesting the TLSv1.1 and TLSv1.2 protocols. Apart from that, a '+' suffix can be appended in oder to also accept newer protocols than the specified version. Closes #1338, and closes #1354, and closes #1359.
2015-10-04use unknown exit code for help/version in pluginsSven Nierlein39-78/+78
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2015-10-04sslutils: Remove superfluous parenthesis for sslv3 function toorefs/pull/1362/headrefs/pull/1314/headJan Wagner1-1/+1
2015-10-04sslutils: remove superfluous parenthesisSebastian Herbszt1-1/+1
Remove superfluous parenthesis. Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
2015-10-04check_snmp: modified testsOliver Skibbe1-2/+2
(Closes #1325)
2015-10-04check_snmp.c: switched DEFAULT_TIMEOUT to DEFAULT_SOCKET_TIMEOUT (provided ↵Oliver Skibbe1-2/+1
by utils.h), already used by help description, see issue #1318
2015-10-02plugins/check_http.c - fix regression introduced in commit 388ea928 (Host ↵Laurent Licour1-1/+1
header)
2015-10-02plugins/check_http.c - fix Host header if explicitly set with -kLAURENT LICOUR1-12/+29
2015-10-02Merge pull request #1257 from gcoxmoz/masterSven Nierlein2-6/+8
check_tcp: Fixing to return desired exit code
2015-10-02fix tests for certificates expire date with secondsSven Nierlein1-4/+4
2015-10-02Merge pull request #1315 from waja/utils_remove_unused_variableSven Nierlein1-2/+0
utils: remove unused variable
2015-10-02Merge pull request #1349 from waja/check_http_ssl_via_proxySven Nierlein1-4/+41
check_http: Adding support for checking SSL-Websites through Proxies
2015-10-02add faketime based tests for check_httpSven Nierlein1-3/+40
2015-10-02fix typo from #1336Sven Nierlein1-2/+3
if exactly one hour before the expire date, we would mixup minutes and hours. Signed-off-by: Sven Nierlein <sven@nierlein.de>
2015-10-02Update sslutils.cMatthias Hähnel1-14/+23
Fixed Output if the expiration time is below one hour and code cleanup