summaryrefslogtreecommitdiffstats
path: root/plugins
AgeCommit message (Collapse)AuthorFilesLines
2013-08-17check_pgsql: Remove -4/-6 flags from help outputHolger Weiss1-1/+1
The -4/-6 options are currently not supported.
2013-08-17Merge remote-tracking branch 'github/tokkee/sh/check_pgsql'Holger Weiss1-32/+202
* github/tokkee/sh/check_pgsql: check_pgsql: Determine connection time in µs-resolution. check_pgsql: Leave 'min' value in query perfdata empty. check_pgsql: Updated copyright. check_pgsql: Added support for the -o command line option. check_pgsql: Removed -4/-6 flags from help output. check_pgsql: Allow UNIX socket directories as hostname as well. check_pgsql: Use PQconnectdb() rather than PQsetdbLogin(). check_pgsql: Fixed query perfdata output for empty warn/crit ranges. check_pgsql: Added support for executing queries. Conflicts: plugins/check_pgsql.c
2013-08-17plugins/t/check_procs.t: Expect performance dataHolger Weiss1-3/+3
The check_procs plugin now emits performance data, fix the test(s) accordingly.
2013-08-17plugins/t/check_apt.t: Expect performance dataHolger Weiss1-2/+2
The check_apt plugin now emits performance data, fix the test(s) accordingly.
2013-08-15cleanup after check_http patch (fixes #50)Sven Nierlein2-36/+43
- cleanup whitespace - added test cases - print time_ssl only if ssl is in use - updated news and thanks file
2013-08-15log more perfdata in check_httpSebastian Nohn1-9/+83
2013-08-15Merge pull request #54 from g0hl1n/check_apt_-_run_update_upgrade_return_fixSven Nierlein1-2/+2
check_apt now correctly exits when apt-get return != 0
2013-08-15corrected http testSven Nierlein1-8/+3
multiple headers have to be set by multiple -k switches. Seperating them by semicolons is not longer supported as semicolons are valid characters in http headers.
2013-08-15Merge pull request #52 from ↵Sven Nierlein1-3/+1
g0hl1n/sf_3571331_check_http_-_removed_semicolon_delimiter_in_-k Fixed SF.net bug #3571331, check_http converts semicolon to newline in -k
2013-08-06Fixed SF.net bug 2555775, threshold can be double for check_smtpJan Wagner1-14/+12
Thanks to Roman Fiedler for reporting the issue and providing a fix
2013-07-08check_nt: Fixes NULL pointer dereferenceJan Wagner1-3/+13
Thanks to Vaclav Ovsik for reporting the issue and providing a fix
2013-06-30check_ntp_peer: Verify type of response packetsHolger Weiss1-13/+19
The check_ntp_peer plugin now ignores response packets with an unexpected "Operation Code" and/or "Sequence" number (cf. RFC 1305, Appendix B). This fixes an issue where the check_ntp_peer requests got duplicated on their way to the server (due to some network switch bug), and the server therefore sent multiple responses per request. Thanks to Marc Haber for reporting the issue.
2013-06-25Fixed SF.net bug 1614553, Debian bug #708343, Adding performace dataJan Wagner1-2/+4
2013-05-29check_apt now correctly exits when apt-get return != 0refs/pull/54/headRichard Leitner1-2/+2
This commit fixes an issue with check_apt where check_apt doesn't exit with the appropriate return code when apt-get returned a non-zero value.
2013-05-29Fixed SF.net bug #3571331, check_http converts semicolon to newline in -krefs/pull/52/headRichard Leitner1-3/+1
This commit fixes sourceforge.net bug id 3571331. The semicolon was defined as input delimiter for multiple values in the -k arguments. Due to the fact the semicolon is a valid character for HTTP header fields this input delimiter function was removed. It is still possible to pass multiple header fields via multiple -k (like described in helptext).
2013-05-17added support for client authentication via SSLrefs/pull/48/headLionel Cons3-5/+54
2013-05-12build: fix building with parallel make.Diego Elio Pettenò1-71/+24
By using a more automake-style handling of dependencies and a single convenience library, it's tremendously easy to build in parallel. Note that since the linking happens with the static archives, the unused objects are discarded and provide no overhead whatsoever.
2013-05-12plugins: rename runcmd's signal handler.Diego Elio Pettenò4-4/+4
The previous name would collide with popen's. Even if the two are never used together, it's still a good idea not to have the same symbol in multiple object files.
2013-03-25Fixed SF.net bug 3560976, added --include-type/-N optionRichard Leitner1-3/+15
2013-03-25Fixed SF.net bug 3602586, added timeout option for check_nagiosRichard Leitner1-3/+13
2013-03-25Fixed SF.net bug 3539317, typo in --help of check_aptRichard Leitner1-1/+1
2013-02-27Update plugins/check_procs.cJoerg Linge1-0/+1
added missing longopt --user
2013-02-10check_tcp: don't ignore trailing optionsSven Nierlein2-11/+18
"./check_tcp -6 -p 80 host" leads to an error: TCP CRITICAL - Invalid hostname, address or socket: 127.0.0.1 because 127.0.0.1 is the fallback host, the tailing hostname was ignored.
2013-01-29check_snmp: Close potential for using uninitialized memoryrefs/pull/37/headRobin Sonefors2-4/+5
This was reported by clang, and in order for it to understand attributes properly, I had to modify the macro that checks for non-gcc compilers. Signed-off-by: Robin Sonefors <robin.sonefors@op5.com>
2013-01-29check_snmp: Dynamically grow all data structuresRobin Sonefors1-20/+59
Before this patch, there was a constant, MAX_OIDS, that determined the amount of slots most (but not all - see labels) array data structures would have. It was set to 8. Some users would like to use more than that, but rather than bumping the constant, let's use the same type of logic we already use for labels - grow the space 8 slots at a time. This will allow us to potentially support an infinite amount of oids - or at least as many as the packetsize on the SNMP server allows, which is usually significantly smaller than infinity, yet often larger than 8. Signed-off-by: Robin Sonefors <robin.sonefors@op5.com>
2013-01-24Apply my patch from:refs/pull/34/headDaniël van Eeden1-3/+8
http://sourceforge.net/tracker/index.php?func=detail&aid=3269273&group_id=29880&atid=397597
2013-01-23Merge pull request #20 from abradley/aptcriticalSven Nierlein7-21/+276
Fixes for check_apt handling of -i/-e/-c regexps and SECURITY_RE, plus tests
2013-01-23updated check dig testsSven Nierlein1-7/+15
nagios.com seems to have changed their ip address. Also added tests about -4/-6 option.
2013-01-23check_dig: query transport selection supportVille Mattila1-3/+16
Add command line options -4 and -6 (--use-ipv4 and --use-ipv6) to check_dig. Effectively this adds no new functionality, just a shortcut for: check_dig -A "-4" check_dig -A "-6" Needed for using check_dig with the check_v46 wrapper (see e.g. https://gitorious.org/nagios-monitoring-tools/nagios-monitoring-tools/blobs/master/check_v46) which requires -4/-6 command line option support.
2013-01-23check_snmp: Don't thrash memory when using multiple label/unit argumentRobin Sonefors1-11/+11
The memory allocation mixed up number of bytes with number of pointers, meaning as soon as we'd reach (on 64 bit systems) the second argument, we'd start writing it outside of our allocated memory. Normally, this isn't too visible, but as soon as you (again, on my 64 bit system) reach argument number 8, you get a segfault. It is easily reproducible with: check_snmp -o '' -l '' -o '' -l '' -o '' -l '' -o '' -l '' \ -o '' -l '' -o '' -l '' -o '' -l '' -o '' -l '' This patch allocates the proper amount of memory, to fix the issue. Signed-off-by: Robin Sonefors <robin.sonefors@op5.com>
2012-12-28Updated check_mysql.c to take client options file and group parametersrefs/pull/32/headJonathan Milby1-4/+35
2012-12-28check_fping: IPv6 supportrefs/pull/30/headVille Mattila1-2/+29
Add command line options -4 and -6 (--use-ipv4 and --use-ipv6) to check_fping. IPv4 is used by default, maintaining backwards compatibility with older check_fping versions. IPv6 support requires the fping6 program. The implementation is really just an imitation of check_ping IPv6 support: Plugin command line option -4/-6 designates whether to run fping/fping6. Please note that especially the changes to configure.in might be all wrong - I don't know what's the proper autoconf way, patching configure.in just seemed to work for me.
2012-11-28check_ntp(_time): don't die on connect errorsSven Nierlein2-2/+10
connect errors may happen if clients check agains dual stacked ipv4/6 ntp servers.
2012-11-28unified ipv4/6 usage and help textSven Nierlein6-10/+8
2012-11-14check_procs: Remove superfluous newline characterHolger Weiss1-1/+1
2012-11-14check_procs: Added performance data to plugin output.Sebastian Harl1-0/+7
2012-11-14check_procs: Use the range/threshold support functions from libnagiosplug.Sebastian Harl1-89/+17
This adds support for @<range> and makes stuff a bit simpler by removing code duplications. Note: Previously, the compatibility code for 'check_procs <warn> <max>' accepted something like 'check_procs -w 10:-1 -c 10:-1 20 50' as well (treating it as if '-w 10:20 -c 10:50' was specified). This is no longer the case ... additional arguments are only used as warn/crit thresholds in case -w/-c is not specified at all.
2012-11-03plugins/check_snmp: Show snmp error when we fail to parse its outputAndreas Ericsson1-2/+2
Dying without a hint of what went wrong is just plain annoying. With this patch we at least get a hint. While at it, we fix the string offset so the output we're interested in doesn't keep the equal sign that snmpget prints. Signed-off-by: Andreas Ericsson <ae@op5.se>
2012-11-03Make check_snmp backwards compatible in how it parses thresholdsAndreas Ericsson1-0/+23
Once upon a time, check_snmp used to accept inverse ranges in the format of '2:1' to mean "alert if value is inside this range". Since commit 7cb3ae09334796f3b54e4e6438e38c2cc679b360, ranges such as those have instead triggered the error "Range format incorrect" and resulted in an UNKNOWN warning state. This patch attempts to fix the situation so that the old-style ranges continues to mean exactly what the once did and people with lots of snmp checks can avoid a bazillion false positives from their environments. Signed-off-by: Andreas Ericsson <ae@op5.se>
2012-10-12check_disk: option to ignore reserved spacerefs/pull/22/headchl1-4/+17
This commit add a runtime option to ignore the root-reserved space when calculating perfdata. Before / after: ./check_disk -w 2% -c 1% /home ./check_disk -w 2% -c 1% -f /home DISK CRITICAL - free space: /home 272 MB (1% inode=83%);| /home=17551MB;18401;18589;0;18777 DISK CRITICAL - free space: /home 272 MB (1% inode=83%);| /home=17551MB;17466;17644;0;17823 Well, it doesn't really give me more space :) but the perfdata are a little bit more coherent. Note that there are still a rounding issue on the percent calculation (cf calculate_percent() comments, taken from coreutils 'df' command). 272/17823 -> 1.526% Since the warning/critical/min/max data are usually not saved in RRD DB, you can activate the option without seeing landslides in the graphs.
2012-10-09Allow for configuring OpenSSLHolger Weiss1-0/+1
Let OpenSSL load its configuration file. See the OPENSSL_config(3) man page for details. (Suggested by Max Kosmach in Debian bug report #689960, forwarded by Jan Wagner.)
2012-10-03Tests for check_aptrefs/pull/20/headAlex Bradley7-3/+257
Add a hidden "--input-file" option to check_apt (modelled on check_procs) so that it can take files with sample apt output as input. Add tests for my SECURITY_RE fix (debian3) and for the include, exclude and critical options.
2012-10-03Fix SourceForge bug 1904965 - check_apt: SECURITY_RE is not correctAlex Bradley1-1/+1
For the default security upgrade detection regular expression, match "Debian-Security" in package description when it's anywhere after the first parenthesis (not just the second space-delimited word). For example: ... (4.0.1-5.4 Debian:6.0.6/stable, Debian-Security:6.0/stable ...
2012-10-03Don't prepend "^Inst" or append a space to the "include", "exclude", orAlex Bradley1-17/+18
"critical" regular expressions. Instead, check for lines beginning with "Inst" using strncmp and apply the regular expressions only when such lines are found. Fixes Debian bug #522812, along the lines suggested by the bug submitter, Justin T Pryzby.
2012-09-25Update plugins/check_disk.crefs/pull/19/headGianluca Varisco1-1/+1
CRITCAL -> CRITICAL typo
2012-08-10check_http: Update description of -C optionHolger Weiss1-1/+1
Mention that the -C option now accepts two comma-separated values.
2012-08-10check_http: Add missing newline to --help outputHolger Weiss1-3/+3
2012-08-10fixing bug in certificate experiation patch checking for bad warning ↵William Leibzon3-3/+3
threshold data
2012-08-10tests/check_http.t: Fix whitespace issuesHolger Weiss1-10/+8
In tests/check_http.t, tabs are used for indentation. While at it, apply another few cosmetic changes.
2012-08-10tests/check_http.t: Update the number of SSL testsHolger Weiss1-1/+1