summaryrefslogtreecommitdiffstats
path: root/plugins
AgeCommit message (Collapse)AuthorFilesLines
2010-04-11Fix Debian bug #482947: No --nas-ip-address optionHolger Weiss1-13/+28
| check_radius doesn't seem to provide any way to modify the | NAS-IP-Address attribute that it uses in the packets it sends, but it | does so for NAS-Identifier. | | Instead, it hardcodes the IP address that it gets from the | rc_own_ipaddress() library call, and that in turn translates into | calling gethostbyname() on the result of uname(). This call can easily | fail, and its result can easily be unsuitable - for example when the | Nagios instance uses its own virtual host, and you don't want the | original system hostname leaked to the RADIUS servers you monitor with | this. | | Furthermore, this behaviour is inconsistent with RFC 2865, which | defines the two attributes as analogous and never suggests hardcoding | the value of either of them in client software. Therefore, this commit adds the "-N, --nas-ip-address" option which allows for specifying the value of the NAS-IP-Address attribute. | I've also noticed that the original code for NAS-IP-Address hardcoding | is broken in its error handling - it does "return (ERROR_PC)", which | is meaningless in the context of check_radius.c. That actually seems | to be copy&waste from radiusclient-0.3.2/src/radexample.c. :) I fixed | that. | | While debugging, I also took the opportunity to decouple the | nas-identifier rc_avpair_add() instance from the initial three, | because this is just bad practice to lump a fourth optional attribute | into the same block with the required attributes, the error handling | for which is throwing the same daft message "Out of Memory?"... [ http://bugs.debian.org/482947 ] (Contributed by Josip Rodin, forwarded by Jan Wagner.)
2010-04-11Fix Debian bug #479984: Allow empty LDAP baseHolger Weiss1-1/+1
The check_ldap plugin did not allow for specifying an empty LDAP base. See: http://bugs.debian.org/479984 (Fixed by Stephane Chazelas, forwarded by Jan Wagner.)
2010-04-11Fix Debian bug #460097: check_http -M brokenHolger Weiss1-1/+4
See: http://bugs.debian.org/460097 One instance of this bug has already been fixed in commit 888358122004b9571c8fbdfa52ceee1ba5e5f4f2. (Fixed by Hilko Bengen, forwarded by Jan Wagner.)
2010-04-11Fix Debian bug #463322: Use deprecated libldap APIHolger Weiss1-0/+1
| Our automated build log filter[1] detected a problem that is likely to | cause your package to segfault on architectures where the size of a | pointer is greater than the size of an integer, such as ia64 and | amd64. | | This is often due to a missing function prototype definition. For | more information, see [2]. | | Function `ldap_init' implicitly converted to pointer at | check_ldap.c:124 | | [1] http://people.debian.org/~dannf/check-implicit-pointer-functions | [2] http://wiki.debian.org/ImplicitPointerConversions | | The libldap API has been updated and many functions used by the ldap | plugin are now deprecated. This package should either update to the | new API or define LDAP_DEPRECATED to continue using the deprecated | interfaces. | | This patch implements the lazy solution. [ http://bugs.debian.org/463322 ] (Contributed by Dann Frazier, forwarded by Jan Wagner.)
2010-04-11Fix Debian bug #307905: Incorrect usage outputHolger Weiss1-1/+1
The usage output of check_game was wrong, see: http://bugs.debian.org/307905 (Fixed by Sean Finney, forwarded by Jan Wagner.)
2010-04-06Fix regression in check_http ssl checks on some serversThomas Guyot-Sionnest1-3/+12
The fix is making SNI an option.
2010-03-31check_snmp: Update last patch to copy value verbatimThomas Guyot-Sionnest1-10/+6
Rework last patch, copying the converted portion of the string rather than re-converting it. This is safer for backwards-compatibility as the value is never modified.
2010-03-31check_snmp: Fix regression introduced in #1867716Thomas Guyot-Sionnest1-2/+10
Bug #1867716 fixed what it meant to fix: broken perfdata strings. Unfortunately some users relied on half-broken perfdata string where at least the first token was OK. This patch do a two-way conversion (string to double then back to string) instead and use the conversion result for the performance data. A possible caveat is that the string may change where it normally shouldn't but the result should be somewhat similar.
2010-03-27Fix compilation with GCC 2.96 (Konstantin Khomoutov - #2977105)Thomas Guyot-Sionnest1-3/+3
2010-03-17Let check_ntp_peer check the number of truechimersHolger Weiss2-27/+69
Add support for checking the number of usable time sources (i.e., the number of peers which are classified as so-called "truechimers" by NTP's intersection algorithm). The new "-m" and "-n" options allow for specifying the according WARNING and CRITICAL thresholds (and thereby activating the truechimers check), respectively.
2010-02-26Fix memory leak in check_http for large pages (Jimmy Bergman - #2957455)Ton Voon1-1/+4
2009-12-03Fix short help using "warn" for the -f option instead of "warning" (onredirect).Thomas Guyot-Sionnest1-2/+2
2009-10-22Fix usage of repeated -o options in check_snmpThomas Guyot-Sionnest2-10/+18
2009-09-25Allow custom versions with the release file...nagiosplugins1-1/+1
2009-09-22Add proxy-authorization option to check_http (Peter Doherty - #2863772, ↵Thomas Guyot-Sionnest1-2/+16
Bryan Irvine - #2863925)
2009-09-11Fix skip numberTon Voon1-1/+1
2009-09-05Add a test that succeeds on check_snmp v1.4.13. Newer versions skip additionalThomas Guyot-Sionnest1-1/+8
lines so this new test fails on the current head. Note: check_snmp v1.4.13 with multi-line strings return somewhat v3 output; it's not exactly what the specs say but it doesn't appears to break them either. The fix could eventually supports both v2 and v3 output formats.
2009-08-05Fix segfault in check_snmp (definitive fix is still in the works - see bug ↵Thomas Guyot-Sionnest1-3/+5
#2832451)
2009-08-01Fix check_snmp passing single-quotes as -m argument when it should be emptyThomas Guyot-Sionnest1-3/+3
2009-07-31check_snmp: Add some verbose output and testsThomas Guyot-Sionnest2-3/+10
2009-07-31Add tests using custom snmp agentThomas Guyot-Sionnest3-0/+180
Only multi-line string test for now (regression test), counter rollover tests planed with my snmp_counters_new branch. NB: 64bit counters are broken in NetSNMP::agent from NetSNMP version 5.4.1 and lower, but might come in handy one day
2009-07-31Fix check_snmp Timetick test with <1 day uptimeThomas Guyot-Sionnest1-2/+2
2009-06-22Added example for check_cluster to alert if more than X non-OK statesTon Voon1-0/+5
2009-06-13Fixed testcases for check_snmp, check_ifstatus and check_ifoperstatus when ↵Matthias Eble1-3/+5
no snmp community is specified The checks for invalid/unavailable hosts need a complete command line. They failed on hosts where no community was specified. Now, an invalid community is used so the tests can run on hosts w/o snmp host/community in NPTest.cache. Execution will fail anyway.
2009-06-01Whitespace indent fixes for check_pgsqlMatthias Eble1-22/+22
2009-06-01Added verbose output to check_pgsql (#2799281 - Jun Kuriyama)Matthias Eble1-1/+20
check_pgsql displayed the -v flag in help output, but didn't accept the verbosity argument. Added -v and basic verbose output.
2009-06-01check_fping now supports passing target timeout and interval to fping ↵Matthias Eble1-4/+30
(#2347686 - Martin Foster) Added support for passing timeout and interval length to check_fping. To protect compatibility, both options use fping's defaults if they are not specified on the command line.
2009-05-28check_snmp: Make use of standard threshold functionsThomas Guyot-Sionnest2-199/+82
This patch makes use of standard threshold functions. This allows using doubles as thresholds. Since SNMP supports only integers, double precision numbers are only printed when parsed from a STRING type. In addition, support for printing properly Timeticks type has been added, and the code has been thoroughly cleaned.
2009-05-27Fix whitespaces in check_snmpThomas Guyot-Sionnest1-73/+73
2009-05-26Fix check_by_ssh interpretation of quotes in -C parameter (#1985246, #2268675)Thomas Guyot-Sionnest2-18/+58
2009-05-22Fixed wrong perfdata label for output traffic in check_mrtgtrafMatthias Eble1-1/+1
check_mrtgtraf used the label "in" for both input and output traffic. This fixed, now.
2009-05-22Removed -n option in check_smtp's help and usage output (#2782784)Matthias Eble1-5/+1
Check_smtp's help showed the -n/--nocommand options to not send an SMTP command. This usage is covered by check_tcp and is thus not needed in check_smtp.
2009-05-20Whitespace changes onlyThomas Guyot-Sionnest1-2/+2
2009-05-20check_http: Add SSL/TLS hostname extension support (SNI) - (#1939022 - Joe ↵Thomas Guyot-Sionnest3-2/+14
Presbrey)
2009-05-20Fix check_mysql* not using password set in my.cnf (#2531905 - Ben Timby)Thomas Guyot-Sionnest2-8/+8
2009-05-19Fix a few minor typosChris Pepper2-9/+9
Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
2009-05-07Fixed typo in check_diskTon Voon1-5/+5
2009-05-01Fixed crash from check_nt when -H unspecified or given multiple times ↵Matthias Eble2-2/+6
(sf.net #2731755, debian #521097)
2009-03-25check_nt: allow returning UNKNOWN on timeouts (-u)Thomas Guyot-Sionnest1-2/+8
2009-03-25Make socket alarm handler customisable (like c459ca07)Thomas Guyot-Sionnest2-6/+12
2009-03-24check_mysql: Fix segfault with old slaves (#2696823 - Oskar Ahner)Thomas Guyot-Sionnest1-1/+2
2009-03-24Whitespace and intend cleanupThomas Guyot-Sionnest1-210/+210
2009-03-21Update check_http short help with new stycky and stickyport options.Thomas Guyot-Sionnest1-4/+4
2009-03-21check_http: die when an invalid --onredirect option is specifiedThomas Guyot-Sionnest1-6/+7
2009-03-21check_http: add --onredirect=stickyport - also follow the same portThomas Guyot-Sionnest2-19/+51
2009-03-20negate: make timeouts configurableThomas Guyot-Sionnest2-8/+37
2009-03-20Make alarm handler customisableThomas Guyot-Sionnest2-3/+5
2009-03-20negate: Fix not printing the real timeout in ALRM handler when timeout is ↵Thomas Guyot-Sionnest1-1/+3
left to default
2009-03-20tests/check_http.t: Add various timeout-related testsThomas Guyot-Sionnest1-3/+51
2009-03-19Fixed check_http not timing-out on redirectsThomas Guyot-Sionnest thomas@aei.ca1-3/+3