Age | Commit message (Collapse) | Author | Files | Lines |
|
There are different declarations for timeout_interval:
lib/utils_base.c has the definition:
unsigned int timeout_interval = DEFAULT_SOCKET_TIMEOUT;
lib/utils_base.h has the appropiate declaration:
extern unsigned int timeout_interval;
plugins/popen.h has an extra declaration:
extern unsigned int timeout_interval;
This doesn't hurt, but it's a dupe. The one in utils_base.h
should be enough, so remove this one.
plugins/popen.c has a WRONG one:
extern int timeout_interval;
Remove it!
Use #include "utils.h" to get the right one.
This makes the local defines for max/min unnecassary, so
remove them also.
|
|
If _SC_OPEN_MAX is available then maxfd was zero initialized and never set to the value from sysconf.
This leads to segfaults with free(): invalid size introduced by commit 7cafb0e84550035fe671662c293122be975065ca.
Signed-off-by: Sven Nierlein <sven@nierlein.de>
|
|
|
|
check_swap: repaired "-n" behaviour
|
|
improve command examples for 'at least' processes
|
|
|
|
The help text says that -H accepts a "unix socket (must be an absolute
path)". Now that actually corresponds to reality.
Signed-off-by: Robin Sonefors <robin.sonefors@op5.com>
|
|
Adding packages-warning option to check_apt plugin
|
|
Adding print top consuming processes option to check_load
|
|
check_snmp: make calcualtion of timeout value in help output more clear
|
|
[check_disk] add support to display inodes usage in perfdata
|
|
check_by_ssh: fix child process leak on timeouts
|
|
Signed-off-by: Sven Nierlein <sven@nierlein.de>
|
|
|
|
When check_by_ssh runs into a timeout it simply exits keeping all child processes running.
Simply adopting the kill loop from runcmd_timeout_alarm_handler() fixes this.
Signed-off-by: Sven Nierlein <sven@nierlein.de>
|
|
Also support the --show-body/-B flag when --expect is used
|
|
check_dns: improve support for checking multiple addresses
|
|
|
|
|
|
The check_snmp rate tests depend on the exact amount of time spend between the
plugin runs and will fail on busy machines, ex. the ci servers. Using faketime
mitigates this issue and also removes all the sleeps.
Signed-off-by: Sven Nierlein <sven@nierlein.de>
|
|
When SSL is enabled, n is assigned the size of the server's second EHLO
response (I think in bytes), which will usually be significantly higher
than the command passed. As such, no commands are executed and no responses
are checked, which - silently - defeats the desired checks and results in a
success value.
|
|
Signed-off-by: Kostyantyn Hushchyn <kgushtin@op5.com>
|
|
This is not enabled by default
It can be enabled with the -P (--iperfdata) option
|
|
check_cluster.c: Added data argument validation.
|
|
there were 2 variants of calling getTestParameter:
- parameter, description, default value
- parameter, env value, default value, description, scope
While scope was never actually used and having 2 names for the same value led
to having 2 different entries in the cache file for the same configuration.
This commit removes the variants and simplifies tests parameters by only using
the first 3 parameter variant.
|
|
Signed-off-by: Kostyantyn Hushchyn <kgushtin@op5.com>
|
|
This should help with figuring out ia problem at a glance when enabled for
healthz endpoints on web APIs, for example.
The content of the body can point to what the problem is and help with
diagnostics.
Fixes #1559
|
|
On Travis with a local squid
|
|
Simple format, avoids refactoring the CONNECT feature.
|
|
|
|
|
|
|
|
remove unnecessary brackets in help text
|
|
|
|
As of 10.2 MariaDB no longer defines MYSQL_PORT.
|
|
Disable sorting of procs by CPU usage on check_load if procpcpu is not present on PS_VARLIST
|
|
|
|
|
|
-W, --print-top-warning
Print top consuming processes on WARNING status
-C, --print-top-critical
Print top consuming processes on CRITICAL status
-n, --procs-to-show=NUMBER_OF_PROCS
Number of processes to show when printing top consuming
processes. Not useful without -W or -C. Default value is 5
|
|
This option specifies the minumum number of packages available for upgrade to return WARNING status. Default is 1 package.
|
|
Output plugin's stderr to stderr and do not exit with WARNING in that case
|
|
completely out of swap space would return "ok" which is
not desired. It should only return "ok" if there is no
swap space configured at all.
|
|
Added tests for virtual port behaviour. Separated from all other test…
|
|
|
|
time.
|
|
sles 12 systems have netcat symlinked to nc and so expect nc syntax for netcat.
Signed-off-by: Sven Nierlein <sven@nierlein.de>
|
|
The check_disk fails if the build system has more than 100GB of free disk
space. Lets make this 100TB and we are safe for a couple more years.
Signed-off-by: Sven Nierlein <sven@nierlein.de>
|
|
and make it configurable
Signed-off-by: Sven Nierlein <sven@nierlein.de>
|
|
snmp tests fail if the snmp daemon runs systemd, then the process with 1 has arguments. Convert
the test into a regex which works for sysv and systemd.
Signed-off-by: Sven Nierlein <sven@nierlein.de>
|
|
on sles (ex. 11sp1) systems the nslookup output for not found was not parsed correctly
and interpreted as ok when it should be critical:
./check_dns -H nosuchhost.nodomain -t 1 -vvv
/usr/bin/nslookup -sil nosuchhost.nodomain Server: 10.0.2.3
Address: 10.0.2.3#53
Non-authoritative answer:
*** Can't find nosuchhost.nodomain: No answer
DNS OK: 0.011 seconds response time. nosuchhost.nodomain returns |time=0.010892s;;;0.000000
Signed-off-by: Sven Nierlein <sven@nierlein.de>
|