summaryrefslogtreecommitdiffstats
path: root/plugins
AgeCommit message (Collapse)AuthorFilesLines
2012-08-10tests/check_http.t: Fix whitespace issuesHolger Weiss1-10/+8
In tests/check_http.t, tabs are used for indentation. While at it, apply another few cosmetic changes.
2012-08-10tests/check_http.t: Update the number of SSL testsHolger Weiss1-1/+1
2012-08-10tests/check_http.t: Fix test caseHolger Weiss1-1/+1
Fix the test case which is meant to make sure that check_http -C <n>,<m> [...] returns a CRITICAL state if <m> is large enough.
2012-08-06check_ntp_peer: Fix --help output for -m and -nHolger Weiss1-1/+1
Fix the threshold specifications in the example for checking the number of truechimers. Reported by Marc Haber on the "nagios-users" mailing list (Message-ID: <20120722142840.GA6931@torres.zugschlus.de>).
2012-08-06check_ntp_peer: Fix --help output for -W and -CHolger Weiss1-2/+2
Mention that the check_ntp_peer plugin checks the stratum of the synchronization peer, not the stratum of the monitored server itself. Thanks to Marc Haber for bringing this up on the "nagios-users" mailing list (Message-ID: <20120722142840.GA6931@torres.zugschlus.de>).
2012-07-18check_http: Fix whitespace issuesHolger Weiss1-10/+10
In check_http.c, tabs aren't used for indentation.
2012-07-18check_http: Fix compilation without SSL supportHolger Weiss1-3/+4
The "ssl_version" variable was undeclared when the plugins were compiled --without-openssl and --without-gnutls. Bug reported by Michael LaCorte on the "nagiosplug-help" mailing list (Message-ID: <CCD30C91-A2A8-463A-82A9-F99B54F741D3@gmail.com>).
2012-07-05check_pgsql: Determine connection time in µs-resolution.refs/pull/16/headSebastian Harl1-7/+15
… thus, treat "elapsed time" and the thresholds as floating point values.
2012-07-05check_pgsql: Leave 'min' value in query perfdata empty.Sebastian Harl1-1/+1
There is no reasonable default value for that.
2012-07-05check_pgsql: Updated copyright.Sebastian Harl1-2/+2
2012-07-05check_pgsql: Added support for the -o command line option.Sebastian Harl1-5/+22
This option may be used to specify further connection parameters to be passed to PQconnectdb(). For example, this may be used to specify a service name in pg_service.conf to be used for additional connection parameters: -o 'service=<name>' or to specify the SSL mode: -o 'sslmode=require'. See the chapter "libpq - C Library" in the PostgreSQL manual for details.
2012-07-05check_pgsql: Removed -4/-6 flags from help output.Sebastian Harl1-2/+0
These options are not currently supported.
2012-07-05check_pgsql: Allow UNIX socket directories as hostname as well.Sebastian Harl1-1/+1
PostgreSQL accepts the directory name of its UNIX socket as hostname as well, e.g. /var/run/postgresql/.
2012-07-05check_pgsql: Use PQconnectdb() rather than PQsetdbLogin().Sebastian Harl1-7/+48
This is more flexible and the recommended way to connect to a PostgreSQL database. Also, the verbose output now includes detailed information about the connection.
2012-07-05check_pgsql: Fixed query perfdata output for empty warn/crit ranges.Sebastian Harl1-1/+3
Previously, "(null)" was printed (when using GNU's libc). This has been changed to print the empty string instead.
2012-07-05check_pgsql: Added support for executing queries.Sebastian Harl1-11/+115
The query result (the double value of the first column in the first row, to be precise) will be checked against threshold ranges specified using the -C and -W options. Note that this also allows to query PostgreSQL internal values using the information available from the database daemon's "statistics collector" -- see the chapter "Monitoring Database Activity" in the PostgreSQL manual for details.
2012-07-04Merge remote-tracking branch 'github/tokkee/sh/check_dbi'Holger Weiss3-1/+923
2012-07-04Re-added missing variable declarations to check_smtp.cEric Stanley1-0/+2
A recent update removed the declarations for a couple variables in check_smtp.c that are still being used, which caused a failure in the compilation of check_smtp.c. This commit restores those variable declarations so the check_smtp.c will again compile.
2012-06-29check_smtp: Remove a comment regarding MAIL FROMHolger Weiss1-15/+4
Earlier versions of check_smtp generated an (invalid) "MAIL FROM" command without arguments by default. These days, a "MAIL FROM" command is only sent if the --from option is specified. This commit removes a comment which explains the old behaviour, and it updates a variable name accordingly.
2012-06-29check_smtp: Fix help and usage output regarding -RHolger Weiss1-2/+2
2012-06-29check_smtp: Fix strcat overflowsAnders Kaseorg1-4/+2
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2012-06-29Die when asprintf failsAnders Kaseorg37-366/+395
Fixes many instances of warning: ignoring return value of 'asprintf', declared with attribute warn_unused_result [-Wunused-result] Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2012-06-29check_smtp: Strip angle brackets from -f argument, if providedAnders Kaseorg1-1/+2
Apparently some people used -f '<nagios@example.com>' to work around the bug I just fixed in the MAIL FROM: command generation. Although the resulting command wasn't RFC-compliant, it was working with some MTAs, so let's continue to support this syntax now that we generate RFC-compliant commands. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2012-06-29check_smtp: Change MAIL FROM: command to comply with the SMTP standardAnders Kaseorg1-1/+1
Every version of the SMTP standard (from RFC 821 to the current RFC 5321) requires the address following MAIL FROM: to follow the colon immediately (with no space) and to be surrounded by angle brackets. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2012-06-27check_tcp: Print performance data even with -DHolger Weiss1-1/+1
When using the 1.4.15 release of the Nagios Plugins, a command such as check_tcp -H pop.example.com -p 995 -D 14 usually produced two lines of output, e.g.: OK - Certificate will expire on 12/13/2014 23:59. TCP OK - 0.009 second response time on port 995|time=0.008849s;;;0.000000;10.000000 The second line was removed by 4d06603060fc1233861b164870f0d3a2e0d8d2eb. However, as the old two-line output is a valid (though in this case unintended) way to spit out performance data, removing the second line might break current setups. Therefore, we revert to the old behaviour, at least for the moment. The issue was reported by Jochen Bern on the "nagiosplug-devel" mailing list (Message-ID: <4FEAE812.8030309@LINworks.de>).
2012-06-26check_snmp: use single quotes for perf data labelsSven Nierlein2-4/+8
2012-06-26Fix performance data label containing spaces in check_snmp (Jochen Bern)Sven Nierlein2-4/+45
Add --perf-oids option for check_snmp to retain optional 1.4.14 compatibility
2012-06-25added test case for certificate checs with both warning and critical valuesWilliam Leibzon1-0/+4
2012-06-25check_http: added test for warning thresholdsSven Nierlein3-3/+11
fixed typo in sslutils
2012-06-25applied patch that adds both critical and warning thresholds to certificate ↵William Leibzon5-33/+89
expiration checks of check_tcp, check_http, check_smtp
2012-06-24check_ping: Add missing newline to die() callsHolger Weiss1-11/+11
Our die() function expects the caller to append the trailing newline character.
2012-06-24Merge remote-tracking branch 'github/waja/master'Holger Weiss1-0/+2
Conflicts: NEWS
2012-06-24check_ping: Ignore ping(1)'s exit statusHolger Weiss1-3/+1
Don't return a WARNING state if the number of lost packets is greater than zero but below the specified warning threshold. This happened because the check_ping plugin used the exit status of the ping(1) utility. (#3535140 - Tobias Brox)
2012-06-22Fix check_by_ssh test for non-Bash login shellsHolger Weiss1-5/+5
In the C shell and in the Z shell, the "?" character must be quoted or backslash-escaped in order to use it verbatim. Therefore, a command such as check_by_ssh -H test.example.com -l joe echo huh? might fail, depending on joe's login shell on test.example.com. Just to make sure, this commit removes most punctuation characters from our test strings.
2012-06-11Improve parsing of ping6(1) outputHolger Weiss1-17/+19
The ping6(1) implementation provided by Debian's iputils-ping package may produce output such as the following: | 3 packets transmitted, 0 received, +3 errors, 100% packet loss, time 2009ms There's a corresponding pattern in check_ping.c:458: | "%*d packets transmitted, %*d received, +%*d errors, %d%% packet loss" Without this fix, the pattern in check_ping.c:456 matched first (as sscanf(3) interprets "+3" as a match for "%d"): | "%*d packets transmitted, %*d received, %d%% loss, time" (#1894850 - Debian bug report #514588 - Matej Vela)
2012-06-11Fix whitespace and capitalization issuesHolger Weiss1-80/+80
Fix indentation and whitespace issues, and correct some capitalization errors in error messages. The behaviour is unchanged.
2012-06-11Don't use SSLv2 when compiling against GnuTLSHolger Weiss1-2/+2
GnuTLS doesn't support SSL version 2.
2012-06-08t/check_dbi.t: Don't use 'INSERT … VALUES (a,b), (c,d)' with SQLite3.refs/pull/8/headSebastian Harl1-1/+2
Older versions of SQLite3 don't seem to support that.
2012-06-08Added a few test cases for the check_dbi plugin.Sebastian Harl1-0/+102
All tests use sqlite3. A temporary database is created for the purpose of the tests.
2012-06-07check_users: Whitespace fixes, etc.Holger Weiss1-24/+14
2012-06-07check_users: improve performanceM. Remy2-31/+9
This patch use the utxent function family to collect the user data. It improve the check speed. Need a system conforming to POSIX.1-2001.
2012-06-06check_dbi: Hint the user about cause when dbi init fails.Sebastian Harl1-1/+1
2012-06-06check_dbi: Added simple regex example to help output.Sebastian Harl1-0/+6
2012-06-06check_dbi: Added SERVER_VERSION metric.Sebastian Harl1-4/+25
This metric compares the database engine server version with the specified ranges. The version string [[[[A.]B.]C.]D.]E[.] is returned as E + D*100 + C*10000 + B*1000000 + A*100000000 (see libdbi's dbi_conn_get_engine_version() documentation).
2012-06-06check_dbi: Added -r and -R options.Sebastian Harl1-12/+89
These options may be used to specify an extended POSIX regular expression that is applied to the query result. When using -R, a case-insensitive match is done. The options may not be mixed with -w/-c/-e.
2012-06-06check_dbi: Added -e option.Sebastian Harl1-19/+76
This option may be used to specify a string that is expected as the query return value. The string is compared to the query result using strcmp(). The option may not be mixed with -w/-c.
2012-06-06check_dbi: Added some examples to the help output.Sebastian Harl1-1/+16
2012-06-06check_dbi: Added QUERY_TIME metric.Sebastian Harl1-37/+90
This metric checks the execution time of the specified query. In case the query does not return any (parsable) data, this is not treated as an error when using this metric.
2012-06-06check_dbi: Replaced -W/-C with -m.Sebastian Harl1-61/+70
The -m option may be used to specify a metric to check the thresholds against. This is more flexible than --conntime-warning/--conntime-critical (-W/-C) as it may be extended to support further metrics without introducing tons of arguments. Also, it does not make much sense to check the conntime and query result at the same time. Currently, the metrics CONN_TIME and QUERY_RESULT are available. A query is no longer required unless QUERY_RESULT (the default) is used.
2012-06-06check_dbi: Fixed/improved perfdata output.Sebastian Harl1-1/+1
- do not use zero as 'min' value for the query result perfdata - added all semicolons