summaryrefslogtreecommitdiffstats
path: root/plugins
AgeCommit message (Collapse)AuthorFilesLines
2022-01-29Remove unused variableRincewindsHat1-1/+1
2022-01-14check_ssh: Fix a typo in "remote-protocol parameterAnton Lofgren1-1/+1
remote-protcol -> remote-protocol Signed-off-by: Anton Lofgren <alofgren@op5.com>
2022-01-14check_ssh: Handle non-alpha software versionsAnton Lofgren2-32/+70
This patch fixes a bug where we would reject version control strings that do not contain letters, because the assumption is made that they always do. This is not required by the RFC however, and there exist implementations that do not contain letters. I've also added a few references to the RFC to make the process of parsing the control string more apparent. This fixes op5#8716 (https://bugs.op5.com/view.php?id=8716) Signed-off-by: Anton Lofgren <alofgren@op5.com>
2022-01-14check_ssh.t: Fix a few typosAnton Lofgren1-5/+2
Signed-off-by: Anton Lofgren <alofgren@op5.com>
2022-01-14check_ssh: properly parse a delayed version control stringAnton Lofgren2-57/+174
This resolves an issue with SSH servers which do not respond with their version control string as the first thing in the SSH protocol version exchange phase after connection establishment. This patch also makes sure that we disregard a potential comment in the version exchange string to avoid nonsense mismatches. In the future, we might want to add the capability to match against a user specified comment. In addition, the patch largely improves the communication towards the server, which adds better protocol adherence. Of course, new test cases are added to support the trigger and guard against regressions of the bugs solved by this patch. This fixes op5#7945 (https://bugs.op5.com/view.php?id=7945) Signed-off-by: Anton Lofgren <alofgren@op5.com>
2022-01-03Rename tmp variable to get even with masterrefs/pull/1642/headLorenz Kästle1-4/+4
2022-01-03Merge branch 'master' into masterLorenz33-516/+1059
2021-12-19Merge pull request #1725 from monitoring-plugins/check_game_update_urlLorenz1-1/+1
Update Url to qstat
2021-11-25Merge pull request #1729 from RincewindsHat/fix_QL_problemsRincewindsHat3-16/+21
Fix some QL problems
2021-11-24More wrong printf formattingrefs/pull/1729/headRincewindsHat2-3/+3
2021-11-24check_hpjd: Fixing port optionRincewindsHat1-8/+9
2021-11-24Fix CodeQL checksRincewindsHat3-8/+12
2021-11-24Fix possible overflow in check_ups (Fixes: #1030)refs/pull/1727/headPhiBo1-1/+4
2021-11-21Update Url to qstatrefs/pull/1725/headRincewindsHat1-1/+1
2021-11-19Merge pull request #1723 from RincewindsHat/check_swap_smallfix_and_styleRincewindsHat1-20/+23
Small fix to threshold validation and style (indentation) fixes
2021-11-19Merge pull request #1724 from mullumaus/masterRincewindsHat1-1/+4
Allows check_ldap to read password from environment variable
2021-11-19Allows check_ldap to get password from env variablerefs/pull/1724/headLinda Guo1-1/+4
It's not secure to provide LDAP password through command line option because other users on the same host can see the password in 'ps' command output. This change allows check_ldap to get password from environment variable.
2021-11-19Fix option description authpassword -> authpasswdLorenz Kästle1-1/+1
2021-11-19Revert "Fixed option description authpassword -> authpasswd + whitespaces"Lorenz Kästle1-20/+20
This reverts commit b27e639725f680411aaa78dd9aa59cfff84ad0c5.
2021-11-19Fixed option description authpassword -> authpasswd + whitespacesLorenz Kästle1-20/+20
2021-11-18Small fix to threshold validation and style (indentation) fixesrefs/pull/1723/headRincewindsHat1-20/+23
2021-11-18Merge pull request #1697 from RincewindsHat/dont_show_rta_if_uselessRincewindsHat2-6/+14
check_ping: Do not show RTA if no connection was possible
2021-11-17Merge pull request #1654 from wolfgangkarall/masterRincewindsHat2-2/+2
check_procs -- exchange needle and haystack in strstr() for proper st…
2021-11-17Merge pull request #1688 from bazzisoft/masterRincewindsHat2-2/+2
check_curl.c: bugfix: verify certificates option should not force SSL to be used
2021-11-17Add thresholds even if value is missingrefs/pull/1697/headRincewindsHat1-1/+1
2021-11-17homogenize perfdata function and fix small bug with missing semicolonRincewindsHat1-2/+4
2021-11-17Show RTA as unknown if it can not be determinedRincewindsHat1-1/+1
2021-11-17Do not show RTA if no connection was possiblerincewind1-4/+10
2021-11-17check_snmp: fix performance thresholds when using multiple oidsSven Nierlein2-5/+21
when using check_snmp with multiple oids it simply printed the unparsed content from -w/-c into the thresholds for each oid. So each oid contained the hole -w from all oids. ./check_snmp ... -o iso.3.6.1.2.1.25.1.3.0,iso.3.6.1.2.1.25.1.5.0 -w '1,2' -c '3,4' before: SNMP ... | HOST-RESOURCES-MIB::hrSystemInitialLoadDevice.0=393216;1,2;3,4 HOST-RESOURCES-MIB::hrSystemNumUsers.0=24;1,2;3,4 after: SNMP ... | HOST-RESOURCES-MIB::hrSystemInitialLoadDevice.0=393216;1;3 HOST-RESOURCES-MIB::hrSystemNumUsers.0=24;2;4 This also applies to fixed thresholds since check_snmp translates negative infinities from: '~:-1' to '@-1:~'
2021-11-11Merge pull request #1715 from ghen2/lmtpRincewindsHat1-4/+14
check_smtp: add -L flag to support LMTP (LHLO instead of HELO/EHLO).
2021-11-01check_procs: add test for elapsed timeSven Nierlein2-2/+230
2021-11-01remove unused test fileSven Nierlein1-84/+0
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2021-11-01check_procs: improve ps args autodetectionSven Nierlein1-4/+7
one of the first ps commands in the configure.ac is `axwo 'stat comm vsz rss user uid pid ppid args'` which works on most modern linux systems (checked debian 10/11 and centos 7/8). But this test misses the etime argument. Therefore `check_procs --metric=ELAPSED` does not work. To fix this, we simply do the same test including etime before that one. Signed-off-by: Sven Nierlein <sven@nierlein.de>
2021-11-01check_procs: remove trailing whitespaceSven Nierlein1-25/+25
2021-10-28check_smtp: add -L flag to support LMTP (LHLO instead of HELO/EHLO).refs/pull/1715/headGeert Hendrickx1-4/+14
2021-10-27Replace tabs with spaces and do some formattingrefs/pull/1714/headRincewindsHat1-55/+54
2021-10-27Remove whitespace at the end of linesRincewindsHat1-17/+17
2021-10-26Fix my own errors for real this time and add some comments, so I wont do ↵RincewindsHat1-32/+32
them again
2021-10-26Re-add separation semicolons for perfdata, which I deletedRincewindsHat1-8/+16
2021-10-26Reform some arithmetical operations for more clarityRincewindsHat1-7/+9
2021-10-26hopefully fix warning high tide with percentageRincewindsHat1-1/+1
2021-10-26Fix some testsRincewindsHat1-3/+4
2021-10-26Remove useless lines and fix some formattingRincewindsHat1-12/+8
2021-10-26Switch to uint64_tRincewindsHat1-13/+11
2021-10-26Reformat a little bit for easier readingRincewindsHat1-16/+32
2021-10-26Recognice IEC binary units and format accordingly to base2 (always)RincewindsHat1-12/+15
2021-10-25Update check_load.tHarald Jenny1-2/+2
adjust tests for new plugin output
2021-10-25Create check_load.cHarald Jenny1-1/+1
just a cosmetic fix so the load plugin display a LOAD prefix before check results
2021-10-02Revert to poor man's logicrefs/pull/1707/headRincewindsHat3-18/+16
2021-10-02Change all to comments to old comment styleRincewindsHat1-3/+4