summaryrefslogtreecommitdiffstats
path: root/plugins
AgeCommit message (Collapse)AuthorFilesLines
2022-12-22check_curl: fix checking large bodys (#1823)Sven Nierlein1-2/+5
check_curl fails on large pages: HTTP CRITICAL - Invalid HTTP response received from host on port 5080: cURL returned 23 - Failure writing output to destination for example trying to run check_curl on the test from #1822 I guess the idea is to double the buffer size each time it is to small. But the code exponentially grows the buffer size which works well 2-3 times, but then fails.
2022-12-22make check_http faster with larger filesDanijel Tasov1-2/+7
The current implementation becomes exponentially slower with growing response size. See also: https://github.com/nagios-plugins/nagios-plugins/blob/release-2.4.2/plugins/check_http.c#L1199-L1204 Test: $ mkdir web $ nohup python3 -m http.server -d web 5080 & $ perl -E 'say "0123456789" for (1..2_000_000)' >| web/file.txt $ ./check_http.orig -t 200 -v -I localhost -p 5080 -u /file.txt > test1.txt real 0m26.893s user 0m12.661s sys 0m14.221s $ time ./check_http -t 200 -v -I localhost -p 5080 -u /file.txt > test2.txt real 0m0.038s user 0m0.011s sys 0m0.027s $ diff -u test[12].txt --- test1.txt 2022-12-21 14:58:28.720260811 +0100 +++ test2.txt 2022-12-21 14:58:42.640008604 +0100 @@ -7,7 +7,7 @@ STATUS: HTTP/1.0 200 OK **** HEADER **** Server: SimpleHTTP/0.6 Python/3.9.2 -Date: Wed, 21 Dec 2022 13:58:01 GMT +Date: Wed, 21 Dec 2022 13:58:42 GMT Content-type: text/plain Content-Length: 22000000 Last-Modified: Wed, 21 Dec 2022 13:57:58 GMT @@ -2000013,4 +2000013,4 @@ 0123456789 0123456789 -HTTP OK: HTTP/1.0 200 OK - 22000191 bytes in 26.860 second response time |time=26.860182s;;;0.000000;200.000000 size=22000191B;;;0; +HTTP OK: HTTP/1.0 200 OK - 22000191 bytes in 0.016 second response time |time=0.016412s;;;0.000000;200.000000 size=22000191B;;;0;
2022-12-20Remove trailing whitespacesRincewindsHat1-14/+14
2022-12-20Fix unknown escape sequence error outputRincewindsHat1-1/+1
2022-11-29check_http: fix test planAksel Sjögren1-1/+1
Fix test plan when run with NP_INTERNET_ACCESS=no, where the correct number of steps must be skipped. Caused by a removed test in 65fc7064295ac70d1388fa4db4d4d2cddd531e24. Signed-off-by: Aksel Sjögren <asjogren@itrsgroup.com>
2022-11-07Check curl detect ipv6 (#1809)Lorenz2-15/+46
* If server_address is an IPv6 address surround it with brackets * If the message is too short, we should not have an underflow * Add simple conditional test case available if IPv6 is
2022-11-05Remove superflous CRLF in HTTP-Requests in check_http (#1798)Lorenz1-3/+2
* Remove superflous CRLF in HTTP-Requests in check_http
2022-11-04Removing is_pg_dbname alltogether,using postgres API. (Closes: #1660) (#1803)waja1-44/+4
The problem is that check_pgsql validates the Database name and has different assumptions that postgres itself. I fail to see a reason to validate the database name here. Postgres'es API should do this - So i would suggest a fix like this by removing is_pg_dbname alltogether. Co-authored-by: Florian Lohoff <f@zz.de>
2022-10-27fixed two PRId64 to PRIu64 in perfdata_uint64 (#1802)Andreas Baumann1-2/+2
2022-10-21using PRId64 and PRIu64 instead of %ld directly (#1800)Andreas Baumann1-12/+12
2022-09-19Display total and scaled load values if check_load scales the values by ↵Lorenz2-20/+51
number of CPUs (#1778) * Renew copyright * Display more verbose output, if scaled load values are used * Actually use scaled value for determining status and print the fitting perfdata depending on input parameters * Add test cases for scaled mode
2022-09-18check_http: Fix HD6 definitionJan Wagner1-1/+1
2022-09-18I had to make a couple of small changes.John C. Frickson1-5/+5
2022-09-18Remove unused codeEric Wunderlin1-4/+0
2022-09-18Added ability to correctly check redirects with reference format ↵Eric Wunderlin1-0/+18
//test.server.com/folder Referenced redirect of the format //www.server.com/folder would result in check_http trying to contact http://hostname:80//www.server.com/folder instead of http://www.server.com/folder. Referenced redirect of this format is listed in rfc3986 ( https://tools.ietf.org/html/rfc3986 ). It should work as expected now.
2022-09-14Check ntp remove unused variables (#1781)Lorenz1-4/+4
* Remove unused argument * Fix typo in comment
2022-09-11Check disk compiler warnings (#1758)Lorenz1-59/+8
* Use unused variable * Proper format strings for printf * Use proper functions for absolute values * Remove and add comments at some places
2022-09-11Check load compiler warnings (#1759)Lorenz1-33/+33
* Fix compiler warnings due to implizit conversion and formats * Make includes more specific and complement them * Formatting fixes
2022-09-11Check swap compiler warnings (#1756)Lorenz1-6/+3
* Fix compiler warnings * Fix superfluous whitespaces
2022-07-25check_swap: Fix unit for total in perfdata (#1779)Lorenz1-11/+11
* check_swap: Fix unit for total in perfdata * Remove trailing whitespaces
2022-07-25fix parsing swap values (#1780)Sven Nierlein1-1/+1
tmp_KB changed from float to uint64, so change the sscanf format accordingly.
2022-07-24check_snmp: Segfault if number of processed lines is greater than number of ↵adrb1-1/+1
thresholds Segfault at line 489 if number of processed lines is greater than number (#1589) of thresholds Co-authored-by: Lorenz <12514511+RincewindsHat@users.noreply.github.com>
2022-07-20Remove check_http and check_curl test which are somehow always failing (#1777)Lorenz2-13/+2
* Remove failing checks for check_http * Remove failing checks for check_curl
2022-07-14check_by_ssh: Add "-U" flag (#1123). (#1774)Archie L. Cobbs1-2/+16
This causes a 255 exit value from ssh(1), which indicates a connection failure, to return UNKNOWN instead of CRITICAL; similar to check_nrpe's "-u" flag.
2022-04-10check_curl: added option --continue-after-certificate (#1761)Andreas Baumann1-4/+22
2022-04-10check_http: added option --continue-after-certificate (#1761)Andreas Baumann1-5/+19
2022-01-30Description for -M was the wrong way around (#1746)Lorenz1-1/+1
Using -M should show the mountpoint instead of the device the file system originated from. Seems like this was not the case for a long time and now the default is to show the mount point. Using `-M` reverts to showing the (block) device instead. The usage Description was adjusted with this commit.
2022-01-30Fix double percentage sign in usage (#1743)Lorenz1-1/+1
2022-01-30sslutils: use chain from client certificatesTobias Wiese18-204/+538
sslutils used to load only the first certificate when it was given a client certificate file. Added tests for check_http to connect to a http server that expects a client certificate (simple and with chain). Signed-off-by: Tobias Wiese <tobias@tobiaswiese.com>
2022-01-29fixed -ffollow for HTTP/2.0 (Fixes #1685): added major_version parsing to ↵Andreas Baumann3-17/+23
PicoHTTPParser
2022-01-29check_http and check_curl: added --max-redirs=N option (feature #1684)Andreas Baumann2-6/+30
2022-01-25add --queryname parameter to check_pgsql (#1741)datamuc1-1/+16
This is used in the long output instead of the actual query. So instead of OK - 'select stuff from various, tables where some_stuff is null and other_stuff is not null' returned 42 one can use --queryname=check_greatest_basket and it will print OK - check_greatest_basket returned 42 That's nicer for alerting purposes, at least in our use case.
2022-01-22Fixes the positioning of the code and some other changesRincewindsHat1-27/+26
2022-01-22Implements 'host-alive' mode (Closes. #1027)Jan Wagner1-1/+21
To reduce the check-duration, it addes a host-alive flag which stops testing after the first successful reply.
2022-01-22Trivial printf fix and a little bit of code style (#1695)Lorenz1-2/+4
* Fix several warnings (and some downright bugs probably) with formating in check_disk Update to master * Fix merge error, I forgot the last time * Fix indentation Co-authored-by: rincewind <rincewind@vulgrim.de>
2022-01-22Trivial source code formatting only: Use tabs consistently for source code ↵Mark A. Ziesemer1-22/+22
indentation (whitespace), as per https://github.com/monitoring-plugins/monitoring-plugins/blob/master/CODING . (#1424) Looks good, thank you very much.
2022-01-14Merge pull request #1412 from glensc/pld/nagios-plugins-ping.patchLorenz1-5/+6
[check_ping] understang ping6 output from iputils package
2022-01-14Merge pull request #1496 from FracKenA/Add-NullOID-ExitLorenz1-3/+27
Added option for null zero length string exit codes
2022-01-14Updated int state to human readableKen D1-1/+1
2022-01-14Added option for null zero length string exit codesKen D1-3/+27
When using a large distributed network with the same group of checks used against a large number of devices, occationally there are missing cards in a few devices that are present in other devices. Rather than having a large number of unknown results, disable active checking on those large number of result or having to create a unique check configuration for those devices. This option allows you to select an OK, WARNING, CRITICAL or UNKNOWN status while still retaining the default behavior when not present. This also allows a for the check to immediately start checks as intended should the hardware be added that the check is looking for.
2022-01-14Merge pull request #1301 from nafets/exit_on_stderrLorenz1-2/+12
check_by_ssh: added option to exit with an warning, if there is output on STDERR
2022-01-03Rename tmp variable to get even with masterLorenz Kästle1-4/+4
2022-01-03Merge branch 'master' into masterLorenz33-516/+1059
2021-12-19Merge pull request #1725 from monitoring-plugins/check_game_update_urlLorenz1-1/+1
Update Url to qstat
2021-11-25Merge pull request #1729 from RincewindsHat/fix_QL_problemsRincewindsHat3-16/+21
Fix some QL problems
2021-11-24More wrong printf formattingRincewindsHat2-3/+3
2021-11-24check_hpjd: Fixing port optionRincewindsHat1-8/+9
2021-11-24Fix CodeQL checksRincewindsHat3-8/+12
2021-11-24Fix possible overflow in check_ups (Fixes: #1030)PhiBo1-1/+4
2021-11-21Update Url to qstatRincewindsHat1-1/+1