summaryrefslogtreecommitdiffstats
path: root/plugins
AgeCommit message (Collapse)AuthorFilesLines
2014-01-25Rename ENV variable, keep backward compatibilityThomas Guyot-Sionnest1-2/+2
Rename NAGIOS_PLUGIN_STATE_DIRECTORY to MP_STATE_DIRECTORY
2014-01-24check_ping: Fixing "time of day goes back"Jan Wagner1-1/+5
by Geoff Oakham <goakham at oanda.com> Patch of check_ping that allows it to gracefully handle when ping outputs to stderr "Warning: time of day goes back (-XXXXus), taking countermeasures." Closes: #809 and #1195
2014-01-24Fixing bug in average calculation (Submitted by Lars)Jan Wagner2-2/+2
The more important change: A fix for a bug which caused the check_ntp_time and check_ntp_time check to always take the first response from ntp and not the avarage since "j" is not increased anywhere. "i" should be used there instead. Partly Closes #956 and Closes #1166 Closes: #1089
2014-01-24Making AVG_NUM configurable by compiler define (Submitted by Lars)Jan Wagner2-0/+4
A minor change which makes the AVG_NUM configurable by compiler define. Partly Closed #956 and Closes #1166
2014-01-23fix smart attribute comparisonTilmann Bubeck1-3/+3
Each S.M.A.R.T. attribute is compared against a threshold. If it is LESSTHAN that threshold an error is reported. This patch fixes the problem, that attribute values EQUAL to the threshold are reported as error, which is wrong. Only LESSTHAN the threshold is an error. For more information see: http://www.hdsentinel.com/smart/index.php My SSD has some attributes which value and threshold are "0". Without the patch this is reported as errornous. ID# ATTRIBUTE_NAME FLAG VALUE WORST THRESH TYPE UPDATED WHEN_FAILED RAW_VALUE ... 172 Unknown_Attribute 0x0032 000 000 000 Old_age Always - 0 174 Unknown_Attribute 0x0030 000 000 000 Old_age Offline - 13 177 Wear_Leveling_Count 0x0000 000 000 000 Old_age Offline - 0 ... See also: * http://sourceforge.net/p/nagiosplug/patches/365/ * https://bugzilla.redhat.com/913085
2014-01-23Fix misleading option textThomas Guyot-Sionnest1-1/+2
As soon as a device is specified without using -d, anything else on the command line is ignored.
2014-01-23Disable SMART test commands in check_ide_smartThomas Guyot-Sionnest1-35/+20
check_ide_smart could disable offline auto tests but could not re-enable them. For this reason all SMART command modes have been disabled The disabled commands are -0/--auto-off, -1/--auto-on and -i/--immediate
2014-01-23Remove accidental tabs inserted in macroThomas Guyot-Sionnest1-1/+1
2014-01-23Make check_ide_smart default to nagios outputThomas Guyot-Sionnest1-28/+33
check_ide_smart was originally a smard control utility later converted to a monitoring plugin. the -n option (Nagios check) should therefore be the default. This patch deprecates the -n and -q switches, and make the other switches return nagios-compatible output (they are most likely used in eventhandlers, but returning nagios-compatible output makes it clear and easy to handle the return status)
2014-01-22plugins/utils.h: avoiding warnings on empty printf statementsRicardo Maraschini1-1/+1
while compiling i keep receiving an warning statement as follow: warning: zero-length gnu_printf format string using an unorthodox method to remove them Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com>
2014-01-21Capitalize "Monitoring Plugins"Holger Weiss1-2/+2
"Monitoring Plugins" is a name.
2014-01-21Merge branch 'maint'Holger Weiss5-16/+27
* maint: check_ssh: Get rid of sshd: Read from socket failed: Connection reset by peer fixed tests when there is no direct internet connection NEWS: Mention fix for check_http's -S option Fix for SSL Versioning when multiple options are used. Fix #1217 spec file fails to build due to duplicate files and unused files check_http: Don't let "-N" expect an argument README: Change GitHub URL README: Clarify license notice Update URLs and mailing list addresses Just using the posix conform extended regular expression grep check_oracle: --db +ASM bad string matching check_oracle doesn't correctly check for pmon +ASM instance from at least Oracle 11 as the pmon proces was renamed from ora_pmon_.* to asm_pmon_.*. -- Just turning attached patch of github issue #1207 into a push request. (Closes #1207) Update web site URLs Conflicts: FAQ NEWS README SUPPORT configure.in monitoring-plugins.spec.in pkg/solaris/pkginfo.in plugins-root/check_dhcp.c plugins-root/check_icmp.c plugins-scripts/check_ifoperstatus.pl plugins-scripts/check_mssql.pl plugins/check_apt.c plugins/check_by_ssh.c plugins/check_cluster.c plugins/check_dbi.c plugins/check_dig.c plugins/check_disk.c plugins/check_dns.c plugins/check_dummy.c plugins/check_fping.c plugins/check_game.c plugins/check_hpjd.c plugins/check_http.c plugins/check_ide_smart.c plugins/check_ldap.c plugins/check_load.c plugins/check_mrtg.c plugins/check_mrtgtraf.c plugins/check_mysql.c plugins/check_mysql_query.c plugins/check_nagios.c plugins/check_nt.c plugins/check_ntp.c plugins/check_ntp_peer.c plugins/check_ntp_time.c plugins/check_nwstat.c plugins/check_overcr.c plugins/check_pgsql.c plugins/check_ping.c plugins/check_procs.c plugins/check_radius.c plugins/check_real.c plugins/check_smtp.c plugins/check_snmp.c plugins/check_ssh.c plugins/check_swap.c plugins/check_tcp.c plugins/check_time.c plugins/check_ups.c plugins/check_users.c plugins/negate.c plugins/urlize.c plugins/utils.h po/Makevars po/de.po po/fr.po po/monitoring-plugins.pot
2014-01-21Merge branch 'rename'Thomas Guyot-Sionnest56-183/+183
2014-01-21New default installation prefix: /usr/localHolger Weiss1-1/+1
Install into /usr/local instead of /usr/local/nagios by default, in order to comply with the Filesystem Hierarchy Standard (FHS) and presumably the expectations of most users.
2014-01-21plugins/*.c: Non-network timeout changesSpenser Reinhardt4-4/+4
Changes to non-network checks for clarity on timeout value. Adapted from pull request #1209 tracker from user awiddersheim. (Closes: #1209) Files: check_apt.c, check_disk.c, check_procs.c, negate.c
2014-01-21plugins/utils.h: Addition of plugin timeout msg.Spenser Reinhardt1-1/+5
Addition of timeout message for non-network plugins(UT_PLUG_TIMEOUT), and alteration of UT_TIMEOUT to UT_CONN_TIMEOUT for networked checks. Alteration of pull request #1209 tracker by user awiddersheim.
2014-01-21plugins/*.c: Alterations for timeout messages.Spenser Reinhardt26-26/+26
.c file changes for misleading timeout messages in help functions. Solution to pull request #1209 tracker by awiddersheim. Files: plugins/check_apt.c, plugins/check_by_ssh.c, plugins/check_dbi.c, plugins/check_dig.c, plugins/check_disk.c, plugins/check_dns.c, plugins/check_game.c, plugins/check_http.c, plugins/check_ldap.c, plugins/check_ntp.c, plugins/check_ntp_peer.c, plugins/check_ntp_time.c, plugins/check_nwstat.c, plugins/check_overcr.c, plugins/check_pgsql.c, plugins/check_ping.c, plugins/check_procs.c, plugins/check_radius.c, plugins/check_real.c, plugins/check_smtp.c, plugins/check_snmp.c, plugins/check_ssh.c, plugins/check_tcp.c, plugins/check_time.c, plugins/check_ups.c, plugins/negate.c
2014-01-21Revert renaming valueJan Wagner1-5/+5
As suggested by sreinhardt in 045d38a6 over there in nagios-plugins
2014-01-21Add performance data to check_mysql_query.c (Closes: #1202)awiddersheim1-4/+10
2014-01-20Capitalize "Monitoring" when it's the first wordHolger Weiss39-39/+39
2014-01-20Minor fixes to be amended into "rename" commitHolger Weiss3-5/+4
2014-01-19Project rename initial commit.Monitoring Plugins Development Team56-182/+183
This is an initial take at renaming the project to Monitoring Plugins. It's not expected to be fully complete, and it is expected to break things (The perl module for instance). More testing will be required before this goes mainline.
2014-01-10check_ssh: Get rid of sshd: Read from socket failed: Connection reset by peerJan Wagner1-0/+2
This fix was grabbed from FreeBSD downstream and provided by Dmitry Sivachenko. Fixes Debian Bug #734811
2013-12-27fixed tests when there is no direct internet connectionSven Nierlein2-6/+14
- check http had wrong number of skipped tests - check tcp did not use the 'no internet' flag at all
2013-12-20Fix for SSL Versioning when multiple options are used.Joseph Gooch1-4/+4
If you specify -S1 -C 30... The -C option will reset the ssl_version to 0. This is not a good thing. Instead we set the default to 0 and retain the version when later args are passed.
2013-12-05check_http: Don't let "-N" expect an argumentHolger Weiss1-1/+1
Fix the problem that check_http's "-N" option expects an argument although it shouldn't. The corresponding long option ("--no-body") wasn't affected. This error was introduced in ee3c4014d511e105489b081390636cacd4c53e3f. Thanks to Kerry Hughes for reporting it on the devel@ list.
2013-11-20make testing check_proc not rely on bashSven Nierlein1-6/+4
also grandparents make this test fail but is not a problem in real live. NPTest->testCmd uses "sh -c" already, so there is no need to do that twice.
2013-11-19check_procs: ignore plugin parent processAnton Lofgren2-1/+16
This fixes an issue that appears when running check_procs over NRPE, where the default shell is configured to (for example) dash, as is the case on Debian. dash (and tcsh, and mksh, and probably others), when invoked with -c forks an additional process to execute the argument string. Contrast this with bash, which does not do this, provided that the argument string simply can be exec()'d as-is. To demonstrate: $ bash -c pstree init─┬ .. ... ├─sshd─-─sshd───pstree versus $ dash -c pstree init─┬ .. ... ├─sshd─-─sshd───dash───pstree The consequence of this fork is that the following invocation: /opt/plugins/check_procs -a init will result in this output: PROCS OK: 2 processes with args 'init' | processes=2;;;0; because the check_procs, in addition to finding the actual init process, finds its parent shell as well. This example is a bit contrived, but I think it illustrates the point. This wouldn't really be a problem, and normally isn't, if it weren't for the fact that NRPE uses a call to popen() which does exactly the above (executes '/bin/sh -c ...'), causing inconsistent behaviour between distributions and much confusion for end users. The argument may be made that the dash process spawned by NRPE is just a process like any other, and should therefore be included in the process count just like any other. However, this is not very intuitive, because of the previously mentioned inconsistencies. The argument might also well be made that we're _never_ interested in the immediate ancestor of the plugin, and while it is unknown how many installations have already made the necessary modifications to their setups to make up for the fact that the plugin behaves the way it does, it is not deemed worthwhile to entertain such workarounds. Thus, this patch ignores the parent process. See also these bug reports: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=626913 http://sourceforge.net/p/nagiosplug/bugs/512/ https://github.com/nagios-plugins/nagios-plugins/issues/999 https://bugs.op5.com/view.php?id=4398
2013-10-28Update URLs and mailing list addressesHolger Weiss42-44/+44
Now that we moved our infrastructure away from SourceForge, update the URLs and mailing list addresses accordingly.
2013-10-08Update web site URLsHolger Weiss1-2/+3
The Nagios Plugin Development Guidelines and the Extra-Opts documentation were moved to our new project server.
2013-10-05Add additional usage data for new options in check_mysql_query.crefs/pull/1200/headawiddersheim1-1/+1
2013-10-05Add ability to read from options file to check_mysql_query.cawiddersheim1-2/+22
This is the same code that was added to check_mysql.c in 5ed7194.
2013-09-28Change default host names for some testsHolger Weiss2-5/+5
Testing "nagiosplugins.org" will currently not work.
2013-09-26Die on SSL initialization errorsawiddersheim1-1/+1
Fixes issue where if an SSL initialization error occurs on a redirect using -f follow the plugin still returns an OK state. Closes #1159.
2013-09-19check_pgsql: Don't exit UNKNOWN instead of OKHolger Weiss1-1/+1
Since commit 912df3ef9b188c82893dace1e9b56c42a558fdba, check_pgsql exited UNKNOWN instead of OK if the new --query option was *not* specified. This bug is fixed now.
2013-09-17check_disk: die with a reasonable error message if one mount point hits ↵Sven Nierlein1-0/+6
average value
2013-09-17check_ssh: added test caseSven Nierlein1-0/+49
2013-09-17check_by_ssh: tests expand key and config pathSven Nierlein1-0/+4
some systems do not expand the path automatically.
2013-09-17check_udp: skip tests which rely on udp listenSven Nierlein1-0/+1
solaris netcat does not listen in udp mode due to http://sourceforge.net/p/netcat/bugs/27/
2013-09-16check_disk: get_fs_usage hasn't been run if using groupsSven Nierlein1-3/+3
the reason why it still worked sometimes was fsu_blocks beeing uninitialized which resulted in a true test sometimes.
2013-09-16check_procs: fix test with sleeping processesSven Nierlein1-1/+1
at least on freebsd, there are a processes with state 'S', they always use two character status.
2013-09-16check_http: tests use supplied value if possibleSven Nierlein1-9/+3
2013-09-15check_tcp: use receive timeout for checks that expect responseSven Nierlein1-0/+14
if check_imap expects a string that never occurs, it currently waits forever because thats how the imap protocoll works. Use a receive timeout in that case so we can exit early with a proper error message.
2013-09-14check_ping: increase test timeoutSven Nierlein1-1/+1
freebsds ping takes a few seconds till it returns, so a 1 second timeout does not work for the test.
2013-09-14check_load: add alternative uptime syntaxSven Nierlein1-1/+10
check_load parses load from the uptime command if no proc filesystem is available. Seems like there are at least 2 different uptime outputs. linux: 20:44:34 up 25 days, 2:07, 13 users, load average: 0.13, 0.17, 0.22 freebsd 8: 8:44PM up 4:29, 1 user, load averages: 0.00, 0.00, 0.00
2013-09-14check_udp: try nc.traditional tooSven Nierlein1-1/+4
nc.traditional is available on (at least) ubuntu systems and uses traditional nc syntax
2013-09-14tests: move ipv6 detection into NPTest moduleSven Nierlein2-18/+18
2013-09-13unified nc syntaxSven Nierlein1-3/+15
older netcats do not understand -p, they expect host and port as additional argument. This is backwards compatibel to newer clients. Also support netcat instead of nc.
2013-09-13fping: some fping versions set loss to 0% by mistakeSven Nierlein1-0/+7
fping v2.4b2 returns 10.99.0.1 : xmt/rcv/%loss = 0/0/0% for a failed host, so we assume the host is down if xmt is zero
2013-09-12check_snmp: add timeout handler befor running snmpgetSven Nierlein1-0/+10